Re: [Amsn-devel] remember me bugfix

2007-05-25 Thread Mirko Hansen

no problem. actually a CreateProfile creates the new profile, writes the new
config and reactivates the last profile. i think this behavior is still from
the time before you introduced the new login window, but that isn't really
useful when you try to login with the new profile after that because the
last one is reactivated. what i did is creating the new profile and let this
profile active. so the newHOME isn't needed anymore, because you won't load
the last profile again, so i used HOME to save memory by not using another
useless temporary variable. the password and the remember me flag are the
only temporary variables i need to save, because they are reset by the call
of configDefaults. after creating the new, empty profile, i write them back
to the config, save config and free the memory of the two unused variables.
alright? everything clear? i hope i explained it understandable ...

Greetings,
Mirko

2007/5/25, Youness Alaoui [EMAIL PROTECTED]:


Hi Mirko, thanks for the patch, but could you explain exactly what happens
in the patch? why each line of the
diff is there, why rename newHOME into HOME, why move the 'set
oldpassword' a few lines before, etc...
otherwise, we can't understand this...
Thanks!

KKRT

On Fri, May 25, 2007 at 06:54:20AM +0200, square87 wrote:
 Hello all.
 Maybe Mirko are talking about this reported problem:
 http://www.amsn-project.net/forums/viewtopic.php?t=3267highlight=

 Square87


-
 This SF.net email is sponsored by DB2 Express
 Download DB2 Express C - the FREE version of DB2 express and take
 control of your XML. No limits. Just data. Click to get it now.
 http://sourceforge.net/powerbar/db2/
 ___
 Amsn-devel mailing list
 Amsn-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/amsn-devel


-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel

-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/___
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel


Re: [Amsn-devel] remember me bugfix

2007-05-25 Thread Philippe Valembois - Phil
Commited in r8762 on trunk
Branch will be synced later
Phil

Mirko Hansen a écrit :
 no problem. actually a CreateProfile creates the new profile, writes the
 new config and reactivates the last profile. i think this behavior is
 still from the time before you introduced the new login window, but that
 isn't really useful when you try to login with the new profile after
 that because the last one is reactivated. what i did is creating the new
 profile and let this profile active. so the newHOME isn't needed
 anymore, because you won't load the last profile again, so i used HOME
 to save memory by not using another useless temporary variable. the
 password and the remember me flag are the only temporary variables i
 need to save, because they are reset by the call of configDefaults.
 after creating the new, empty profile, i write them back to the config,
 save config and free the memory of the two unused variables.
 alright? everything clear? i hope i explained it understandable ...
 
 Greetings,
 Mirko
 
 2007/5/25, Youness Alaoui [EMAIL PROTECTED]
 mailto:[EMAIL PROTECTED]:
 
 Hi Mirko, thanks for the patch, but could you explain exactly what
 happens in the patch? why each line of the
 diff is there, why rename newHOME into HOME, why move the 'set
 oldpassword' a few lines before, etc...
 otherwise, we can't understand this...
 Thanks!
 
 KKRT
 
 On Fri, May 25, 2007 at 06:54:20AM +0200, square87 wrote:
  Hello all.
  Maybe Mirko are talking about this reported problem:
  http://www.amsn-project.net/forums/viewtopic.php?t=3267highlight=
 http://www.amsn-project.net/forums/viewtopic.php?t=3267highlight=
 
  Square87
 
 
 -
  This SF.net email is sponsored by DB2 Express
  Download DB2 Express C - the FREE version of DB2 express and take
  control of your XML. No limits. Just data. Click to get it now.
  http://sourceforge.net/powerbar/db2/
  ___
  Amsn-devel mailing list
  Amsn-devel@lists.sourceforge.net
 mailto:Amsn-devel@lists.sourceforge.net
  https://lists.sourceforge.net/lists/listinfo/amsn-devel
 https://lists.sourceforge.net/lists/listinfo/amsn-devel
 
 
 -
 This SF.net email is sponsored by DB2 Express
 Download DB2 Express C - the FREE version of DB2 express and take
 control of your XML. No limits. Just data. Click to get it now.
 http://sourceforge.net/powerbar/db2/
 ___
 Amsn-devel mailing list
 Amsn-devel@lists.sourceforge.net
 mailto:Amsn-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/amsn-devel
 
 
 
 
 
 -
 This SF.net email is sponsored by DB2 Express
 Download DB2 Express C - the FREE version of DB2 express and take
 control of your XML. No limits. Just data. Click to get it now.
 http://sourceforge.net/powerbar/db2/
 
 
 
 
 ___
 Amsn-devel mailing list
 Amsn-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/amsn-devel


-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel


Re: [Amsn-devel] remember me bugfix

2007-05-24 Thread square87

Hello all.
Maybe Mirko are talking about this reported problem:
http://www.amsn-project.net/forums/viewtopic.php?t=3267highlight=

Square87
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/___
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel


Re: [Amsn-devel] remember me bugfix

2007-05-24 Thread Youness Alaoui
Hi Mirko, thanks for the patch, but could you explain exactly what happens in 
the patch? why each line of the 
diff is there, why rename newHOME into HOME, why move the 'set oldpassword' a 
few lines before, etc...
otherwise, we can't understand this...
Thanks!

KKRT

On Fri, May 25, 2007 at 06:54:20AM +0200, square87 wrote:
 Hello all.
 Maybe Mirko are talking about this reported problem:
 http://www.amsn-project.net/forums/viewtopic.php?t=3267highlight=
 
 Square87

 -
 This SF.net email is sponsored by DB2 Express
 Download DB2 Express C - the FREE version of DB2 express and take
 control of your XML. No limits. Just data. Click to get it now.
 http://sourceforge.net/powerbar/db2/
 ___
 Amsn-devel mailing list
 Amsn-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/amsn-devel


-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel


[Amsn-devel] remember me bugfix

2007-05-23 Thread Mirko Hansen

another patch from me: after creating a new profile with checking remember
me, amsn only made the login screen invisible but didn't login. restarting
amsn, and logging in again then worked fine. it seems like the code for
creating a profile wasn't adapted to the new login window. it should be
fixed with this patch.
deleting a profile also didn't remove the email from the combo box. i moved
the fireing of the event right behind the saving of the list, because the
new login window has an event reloading the list before saving it to disk
and so a removed profile will always reappear. i think this should be ok, at
least i didn't find a reason why not.

Greetings,
Mirko


rememberme-patch.diff
Description: Binary data
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/___
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel