Re: [android-building] Re: SOONG - cc_prebuilt_library_shared

2017-09-13 Thread Colin Cross 
Oh, missed that, we don't currently have a way to vary the prebuilt based
on TARGET_BUILD_VARIANT.  What's the use case for it?

Try adding strip: none to turn off stripping.

On Wed, Sep 13, 2017 at 1:29 AM, Michael Lekman 
wrote:

> What is the requirements on prebuilt libraries?
>
> Symbols are missing and it breaks the build:
>
>  target Strip (mini debug info): libmytest (out/target/product/mytest/
> obj/lib/libmytest.so)
> 
> prebuilts/gcc/linux-x86/aarch64/aarch64-linux-android-
> 4.9/bin/aarch64-linux-android-nm: out/target/product/mytest/
> symbols/system/lib64/libmytest.so: no symbols
>
>
> Are debug symbols mandatory for prebuilt libs?
>
>
> On Tuesday, 12 September 2017 23:09:15 UTC+2, Michael Lekman wrote:
>>
>> What is the recommended way to set src file path to prebuilt libs? There
>> are different libs for target variants.
>>
>> Android.mk file:
>> LOCAL_PATH := $(call my-dir)
>>
>> PREBUILT_PATH := prebuilts/$(TARGET_BUILD_VARIANT)
>> PREBUILT_SYSTEM_PATH := $(PREBUILT_PATH)/system
>> PREBUILT_SYSTEM_BIN_PATH := = $(PREBUILT_SYSTEM_PATH)/lib
>> PREBUILT_SYSTEM_LIB64_PATH := $(PREBUILT_SYSTEM_PATH)/lib64
>>
>> include $(CLEAR_VARS)
>> LOCAL_MODULE := libmytest
>> LOCAL_MODULE_TAGS   := optional
>> LOCAL_MODULE_CLASS  := SHARED_LIBRARIES
>> LOCAL_MODULE_SUFFIX := .so
>> LOCAL_MULTILIB  := both
>> LOCAL_SRC_FILES_32 := $(PREBUILT_SYSTEM_LIB32_PATH)/
>> $(LOCAL_MODULE)$(LOCAL_MODULE_SUFFIX)
>> LOCAL_SRC_FILES_64 := $(PREBUILT_SYSTEM_LIB64_PATH)/
>> $(LOCAL_MODULE)$(LOCAL_MODULE_SUFFIX)
>> LOCAL_SHARED_LIBRARIES := liblog libutils libcutils libbase libpcrecpp
>> include $(BUILD_PREBUILT)
>>
>>
> --
> --
> You received this message because you are subscribed to the "Android
> Building" mailing list.
> To post to this group, send email to android-building@googlegroups.com
> To unsubscribe from this group, send email to
> android-building+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/android-building?hl=en
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Android Building" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to android-building+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
You received this message because you are subscribed to the "Android Building" 
mailing list.
To post to this group, send email to android-building@googlegroups.com
To unsubscribe from this group, send email to
android-building+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to android-building+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [android-building] Re: SOONG - cc_prebuilt_library_shared

2017-09-13 Thread Colin Cross 
Correction:
strip: {
none: true,
}

On Wed, Sep 13, 2017 at 10:14 AM, Colin Cross  wrote:

> Oh, missed that, we don't currently have a way to vary the prebuilt based
> on TARGET_BUILD_VARIANT.  What's the use case for it?
>
> Try adding strip: none to turn off stripping.
>
> On Wed, Sep 13, 2017 at 1:29 AM, Michael Lekman 
> wrote:
>
>> What is the requirements on prebuilt libraries?
>>
>> Symbols are missing and it breaks the build:
>>
>>  target Strip (mini debug info): libmytest (out/target/product/mytest/obj
>> /lib/libmytest.so)
>> 
>> prebuilts/gcc/linux-x86/aarch64/aarch64-linux-android-4.9/bin/aarch64-linux-android-nm:
>> out/target/product/mytest/symbols/system/lib64/libmytest.so: no symbols
>>
>>
>> Are debug symbols mandatory for prebuilt libs?
>>
>>
>> On Tuesday, 12 September 2017 23:09:15 UTC+2, Michael Lekman wrote:
>>>
>>> What is the recommended way to set src file path to prebuilt libs? There
>>> are different libs for target variants.
>>>
>>> Android.mk file:
>>> LOCAL_PATH := $(call my-dir)
>>>
>>> PREBUILT_PATH := prebuilts/$(TARGET_BUILD_VARIANT)
>>> PREBUILT_SYSTEM_PATH := $(PREBUILT_PATH)/system
>>> PREBUILT_SYSTEM_BIN_PATH := = $(PREBUILT_SYSTEM_PATH)/lib
>>> PREBUILT_SYSTEM_LIB64_PATH := $(PREBUILT_SYSTEM_PATH)/lib64
>>>
>>> include $(CLEAR_VARS)
>>> LOCAL_MODULE := libmytest
>>> LOCAL_MODULE_TAGS   := optional
>>> LOCAL_MODULE_CLASS  := SHARED_LIBRARIES
>>> LOCAL_MODULE_SUFFIX := .so
>>> LOCAL_MULTILIB  := both
>>> LOCAL_SRC_FILES_32 := $(PREBUILT_SYSTEM_LIB32_PATH)/
>>> $(LOCAL_MODULE)$(LOCAL_MODULE_SUFFIX)
>>> LOCAL_SRC_FILES_64 := $(PREBUILT_SYSTEM_LIB64_PATH)/
>>> $(LOCAL_MODULE)$(LOCAL_MODULE_SUFFIX)
>>> LOCAL_SHARED_LIBRARIES := liblog libutils libcutils libbase libpcrecpp
>>> include $(BUILD_PREBUILT)
>>>
>>>
>> --
>> --
>> You received this message because you are subscribed to the "Android
>> Building" mailing list.
>> To post to this group, send email to android-building@googlegroups.com
>> To unsubscribe from this group, send email to
>> android-building+unsubscr...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/android-building?hl=en
>>
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Android Building" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to android-building+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
-- 
You received this message because you are subscribed to the "Android Building" 
mailing list.
To post to this group, send email to android-building@googlegroups.com
To unsubscribe from this group, send email to
android-building+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to android-building+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.