Re: [android-building] Information about prebuilt ckati

['Dan Willemsen' via Android Building]

There's a manifest.xml in that project that should have all of the exact
revisions:
https://android.googlesource.com/platform/prebuilts/build-tools/+/refs/heads/master/manifest.xml.
It's a snapshot of the platform/manifest build-tools manifest
.

It's built using the prebuilts/build-tools/build-prebuilts.sh

script, and you can get the full artifacts from the aosp-build-tools branch
on ci.android.com
. The commit
message updating the prebuilts should reference a build number that can be
found on ci.android.com.

- Dan

*From: *Rounak Agarwal 
*Date: *Sun, May 12, 2019, 11:01 PM
*To: *Android Building

Is there a way to find out the exact commit and the build command used to
> build the prebuilt ckati executable available in AOSP project
> prebuilts/build-tools ?
>
> --
> --
> You received this message because you are subscribed to the "Android
> Building" mailing list.
> To post to this group, send email to android-building@googlegroups.com
> To unsubscribe from this group, send email to
> android-building+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/android-building?hl=en
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Android Building" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to android-building+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/android-building/3f2f33e5-e805-4194-9595-4cd9f3c4798f%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
You received this message because you are subscribed to the "Android Building" 
mailing list.
To post to this group, send email to android-building@googlegroups.com
To unsubscribe from this group, send email to
android-building+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to android-building+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/android-building/CALQgHd%3DJ_9K7nK12AL%3D-9NJMd5xS7D3VQLkBT7%2Bcm0zQ-yBSVA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[android-building] Information about prebuilt ckati

[Rounak Agarwal]

Is there a way to find out the exact commit and the build command used to 
build the prebuilt ckati executable available in AOSP project 
prebuilts/build-tools ?

-- 
-- 
You received this message because you are subscribed to the "Android Building" 
mailing list.
To post to this group, send email to android-building@googlegroups.com
To unsubscribe from this group, send email to
android-building+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to android-building+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/android-building/3f2f33e5-e805-4194-9595-4cd9f3c4798f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[android-building] Re: Trouble adding vendor AIDs

['Tom Cherry' via Android Building]

It should be installed to /vendor/etc/passwd and /vendor/etc/group.

I'd also be careful that TARGET_FS_CONFIG_GEN isn't overwritten anywhere.  
The BoardConfig.mk's for most of the google products specify this with a 
string similar to "TARGET_FS_CONFIG_GEN := device/google/wahoo/config.fs" 
so the := may overwrite what you've used.

On Monday, May 13, 2019 at 12:25:58 PM UTC-7, Eric Crahen wrote:
>
> I've been attempting to add some custom user for an application in my AOSP 
> build, 
>
> Following the notes here, I tried to add a custom vendor AID to my AOSP 
> build
>   * https://source.android.com/devices/tech/config/filesystem
>
> I thought I'd find an /etc/passwd entry somewhere with a mapping of the 
> uid  -> vendor_foobar (or maybe to just a user named foobar). Maybe I'm 
> missing something from the notes linked above, but that's not happening. It 
> seems like the new user isn't getting added to either the system.img or 
> vendor.img
>
>
> config.fs:
>   [AID_VENDOR_FOOBAR]
>   value: 
>
> additions to BoardConfig.mk:
>   TARGET_FS_CONFIG_GEN += device/google/muskie/walleye/config.fs
>   TARGET_ANDROID_FILESYSTEM_CONFIG_H :=
>
>
> Does anyone know how to correctly add a custom vendor AID? Thanks!
>
>

-- 
-- 
You received this message because you are subscribed to the "Android Building" 
mailing list.
To post to this group, send email to android-building@googlegroups.com
To unsubscribe from this group, send email to
android-building+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to android-building+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/android-building/48d7f54d-8954-4593-86a3-db040f120449%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [android-building] Please help me!Thanks!

['Dan Willemsen' via Android Building]

As I posted before: "Please don't do that, your build will fail in some
other way, since that check is there to ensure that the two build systems
agree about options that they both need to use."

- Dan

On Mon, May 13, 2019 at 12:36 PM Old3nglish 800 <0ld3nglish...@gmail.com>
wrote:

> Thank you, was helpful.
>
> On Saturday, December 9, 2017 at 11:51:46 PM UTC-8, quake73 wrote:
>>
>> In the file build/soong/android/makevars.go, there are these 3 lines:
>>
>> ifneq ($(my_check_failed),false)
>>   $(error Soong variable check failed)
>> endif
>>
>> Either remove them or just comment out the 2nd line ( # $(error Soong
>> variable check failed) )
>>
>> On Fri, Dec 8, 2017 at 12:46 PM,  wrote:
>>
>>> When I builing the AOSP for my device ,I have a problem that I can't
>>> slove
>>>
>>>
>>> home/jack/Mokee/O/out/soong/make_vars-mk_N939St.mk:362: warning:
>>> TARGET_GLOBAL_CFLAGS does not match between Make and Soong:
>>> /home/jack/Mokee/O/out/soong/make_vars-mk_N939St.mk:362: warning: Make :
>>> -DNO_SECURE_DISCARD
>>> /home/jack/Mokee/O/out/soong/make_vars-mk_N939St.mk:362: warning: Soong:
>>> -fno-exceptions -Wno-multichar -fno-strict-aliasing
>>> -fstack-protector-strong -ffunction-sections -fdata-sections
>>> -funwind-tables -Wa,--noexecstack -Werror=format-security
>>> -D_FORTIFY_SOURCE=2 -fno-short-enums -no-canonical-prefixes
>>> -fno-canonical-system-headers -Werror=pointer-to-int-cast
>>> -Werror=int-to-pointer-cast -Werror=implicit-function-declaration
>>> -fno-strict-volatile-bitfields -DNDEBUG -O2 -g -Wstrict-aliasing=2
>>> -fgcse-after-reload -frerun-cse-after-loop -frename-registers -DANDROID
>>> -fmessage-length=0 -W -Wall -Wno-unused -Winit-self -Wpointer-arith
>>> -DNDEBUG -UDEBUG -fdebug-prefix-map=/proc/self/cwd= -fdiagnostics-color
>>> -Werror=return-type -Werror=non-virtual-dtor -Werror=address
>>> -Werror=sequence-point -Werror=date-time -mcpu=cortex-a53
>>> /home/jack/Mokee/O/out/soong/make_vars-mk_N939St.mk:810: error: Soong
>>> variable check failed.
>>> 18:19:38 ckati failed with: exit status 1
>>> build/core/main.mk:21: recipe for target 'run_soong_ui' failed
>>> make: *** [run_soong_ui] Error 1
>>>
>>> --
>>> --
>>> You received this message because you are subscribed to the "Android
>>> Building" mailing list.
>>> To post to this group, send email to android-...@googlegroups.com
>>> To unsubscribe from this group, send email to
>>> android-...@googlegroups.com
>>> For more options, visit this group at
>>> http://groups.google.com/group/android-building?hl=en
>>>
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "Android Building" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to android-...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>> --
> --
> You received this message because you are subscribed to the "Android
> Building" mailing list.
> To post to this group, send email to android-building@googlegroups.com
> To unsubscribe from this group, send email to
> android-building+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/android-building?hl=en
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Android Building" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to android-building+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/android-building/c50b27cd-7392-46c3-a9d0-d6d8dc8e380c%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
You received this message because you are subscribed to the "Android Building" 
mailing list.
To post to this group, send email to android-building@googlegroups.com
To unsubscribe from this group, send email to
android-building+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to android-building+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/android-building/CALQgHdmhYuNwRktwCd7mm%3D%2B4igOQWBkG6fnSGE9KJU_3uSqB%3Dg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[android-building] Trouble adding vendor AIDs

[Eric Crahen]

I've been attempting to add some custom user for an application in my AOSP 
build, 

Following the notes here, I tried to add a custom vendor AID to my AOSP 
build
  * https://source.android.com/devices/tech/config/filesystem

I thought I'd find an /etc/passwd entry somewhere with a mapping of the uid 
 -> vendor_foobar (or maybe to just a user named foobar). Maybe I'm 
missing something from the notes linked above, but that's not happening. It 
seems like the new user isn't getting added to either the system.img or 
vendor.img


config.fs:
  [AID_VENDOR_FOOBAR]
  value: 

additions to BoardConfig.mk:
  TARGET_FS_CONFIG_GEN += device/google/muskie/walleye/config.fs
  TARGET_ANDROID_FILESYSTEM_CONFIG_H :=


Does anyone know how to correctly add a custom vendor AID? Thanks!

-- 
-- 
You received this message because you are subscribed to the "Android Building" 
mailing list.
To post to this group, send email to android-building@googlegroups.com
To unsubscribe from this group, send email to
android-building+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to android-building+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/android-building/77e9b3d2-9c7d-4f57-944b-2e175943c713%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [android-building] Information about prebuilt ckati

['Dan Willemsen' via Android Building]

Strange. Are you able to do regular builds of AOSP master on your machine?
(If not, don't worry, it's just a data point if you have)

What does the end of out/soong.log look like? That'll narrow down the
problem.

If you have a slow disk, the first time you run this, it may take a while
as it builds up a database of the files in the source tree, but it
shouldn't take that long (on a sufficiently fast machine that should only
take a few seconds). If you happen to have mounts / hard links / etc that
expose more files or a network mount inside the source tree, we've seen
hangs when we generate this db.

- Dan

*From: *Rounak Agarwal 
*Date: *Mon, May 13, 2019 at 9:10 AM
*To: *Android Building

Thanks for the information Dan.
>
> I wanted to try and build the binaries myself. I did the following :
>
> repo init -u https://android.googlesource.com/platform/manifest -b build-tools
> repo sync -c
> export OUT_DIR=$PWD/out
> ./prebuilts/build-tools/build-prebuilts.sh
>
>
> It got stuck at the following command :
>
> build/soong/soong_ui.bash --make-mode --skip-make 
>
> Do you know what might be the reason for this ?
>
>
> On Monday, May 13, 2019 at 11:38:42 AM UTC+5:30, Dan Willemsen wrote:
>>
>> There's a manifest.xml in that project that should have all of the exact
>> revisions:
>> https://android.googlesource.com/platform/prebuilts/build-tools/+/refs/heads/master/manifest.xml.
>> It's a snapshot of the platform/manifest build-tools manifest
>> .
>>
>> It's built using the prebuilts/build-tools/build-prebuilts.sh
>> 
>> script, and you can get the full artifacts from the aosp-build-tools
>> branch on ci.android.com
>> . The
>> commit message updating the prebuilts should reference a build number that
>> can be found on ci.android.com.
>>
>> - Dan
>>
>> *From: *Rounak Agarwal 
>> *Date: *Sun, May 12, 2019, 11:01 PM
>> *To: *Android Building
>>
>> Is there a way to find out the exact commit and the build command used to
>>> build the prebuilt ckati executable available in AOSP project
>>> prebuilts/build-tools ?
>>>
>>> --
>>> --
>>> You received this message because you are subscribed to the "Android
>>> Building" mailing list.
>>> To post to this group, send email to android-...@googlegroups.com
>>> To unsubscribe from this group, send email to
>>> android-...@googlegroups.com
>>> For more options, visit this group at
>>> http://groups.google.com/group/android-building?hl=en
>>>
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "Android Building" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to android-...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/android-building/3f2f33e5-e805-4194-9595-4cd9f3c4798f%40googlegroups.com
>>> 
>>> .
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> --
> --
> You received this message because you are subscribed to the "Android
> Building" mailing list.
> To post to this group, send email to android-building@googlegroups.com
> To unsubscribe from this group, send email to
> android-building+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/android-building?hl=en
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Android Building" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to android-building+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/android-building/6b01612c-d7f0-4388-ad71-0e274cea912f%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
You received this message because you are subscribed to the "Android Building" 
mailing list.
To post to this group, send email to android-building@googlegroups.com
To unsubscribe from this group, send email to
android-building+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to android-building+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/android-building/CALQgHd%3DHKX0LtaxaWf2Ja26a8pcEcLp6tX-JNHTLy680swMOVw%40mail.gmail.com.
For 

[android-building] Re: Android 9.0.0 Pie Bonito/Sargo Released

['Xin Li' via Android Building]

We have merged Bonito/Sargo support into AOSP master.

-- 
-- 
You received this message because you are subscribed to the "Android Building" 
mailing list.
To post to this group, send email to android-building@googlegroups.com
To unsubscribe from this group, send email to
android-building+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to android-building+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/android-building/86b16080-e445-4673-aff5-1b26dd2e8406%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[android-building] Re: Trouble adding vendor AIDs

[Eric Crahen]

Thanks, 

With that, I've been able to see my /system/etc/passwd file contains the 
generated AID now. That's great.

$ cat /system/etc/passwd
...
*vendor_foobar*:::::/:/system/bin/sh

Now, I'm trying to use this user. Is there a mapping from this 
vendor_foobar unix user-name to an android:sharedUserId attribute in an 
app/services AndroidManifest.xml? I was hoping to use something like:



or 



to connect an application to this user. Those examples above didn't work, 
the application ran as one of the generated users (e.g. u0_a167) which 
seems to be the default behavior if you set android:sharedUserId to some 
unrecognized value. 

Is there an additional configuration needed to establish a binding to 
android:sharedUserId?


On Monday, May 13, 2019 at 12:44:53 PM UTC-7, Tom Cherry wrote:
>
> It should be installed to /vendor/etc/passwd and /vendor/etc/group.
>
> I'd also be careful that TARGET_FS_CONFIG_GEN isn't overwritten anywhere.  
> The BoardConfig.mk's for most of the google products specify this with a 
> string similar to "TARGET_FS_CONFIG_GEN := device/google/wahoo/config.fs" 
> so the := may overwrite what you've used.
>
> On Monday, May 13, 2019 at 12:25:58 PM UTC-7, Eric Crahen wrote:
>>
>> I've been attempting to add some custom user for an application in my 
>> AOSP build, 
>>
>> Following the notes here, I tried to add a custom vendor AID to my AOSP 
>> build
>>   * https://source.android.com/devices/tech/config/filesystem
>>
>> I thought I'd find an /etc/passwd entry somewhere with a mapping of the 
>> uid  -> vendor_foobar (or maybe to just a user named foobar). Maybe I'm 
>> missing something from the notes linked above, but that's not happening. It 
>> seems like the new user isn't getting added to either the system.img or 
>> vendor.img
>>
>>
>> config.fs:
>>   [AID_VENDOR_FOOBAR]
>>   value: 
>>
>> additions to BoardConfig.mk:
>>   TARGET_FS_CONFIG_GEN += device/google/muskie/walleye/config.fs
>>   TARGET_ANDROID_FILESYSTEM_CONFIG_H :=
>>
>>
>> Does anyone know how to correctly add a custom vendor AID? Thanks!
>>
>>

-- 
-- 
You received this message because you are subscribed to the "Android Building" 
mailing list.
To post to this group, send email to android-building@googlegroups.com
To unsubscribe from this group, send email to
android-building+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to android-building+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/android-building/352d6455-9c6c-4375-ba6a-c0c3d3365197%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [android-building] Add prebuilt jar to system image - android 9.0

[Vinayak Soni]

Classes.

On Tuesday, May 7, 2019 at 1:22:15 PM UTC-7, Colin Cross wrote:
>
> What is in the jar, class files or dex files?
>
> On Tue, May 7, 2019 at 12:42 PM Vinayak Soni  > wrote:
>
>> Hi Colin,
>>
>> How to write an Android.bp for a prebuilt jar that needs to be added to 
>> PRODUCT_BOOT_JARS?
>>
>> Thanks,
>> Vinayak
>>
>> On Monday, March 18, 2019 at 3:36:17 PM UTC-7, Colin Cross wrote:
>>>
>>> The basics on Android.bp files are documented at 
>>> https://android.googlesource.com/platform/build/soong/+/master/README.md, 
>>> and the documentation on the module types and their properties is at 
>>> https://ci.android.com/builds/latest/branches/aosp-build-tools/targets/linux/view/soong_build.html
>>> .
>>>
>>> On Mon, Mar 18, 2019 at 2:52 PM KarenL  wrote:
>>>
 I actually have everything in vendor and I'd prefer to keep it there. 
 I'm not sure how to include whats in vendor in framework.jar.
 This is the structure of the stuff I have in vendor that I would like 
 to include.
 vendor/xxx/lib -> the prebuilt jars are here
 vendor/xxx/src/com/aaa/bbb/ccc => the source files are here

 Question: Should I add an Android.bp to vendor/xxx/
 It sounds like that should contain the java_import section you already 
 mentioned.
 How do I include the source files in the new Android.bp?

 Question: How do I reference this not module from Android.bk in 
 frameworks/base/Android.bp?

 Is there any documentation on how to set up Android.bp files. I've been 
 looking around and I cant find anything.

 I need the extra classes because I'm adding a new system service to the 
 build that I'm making.

 Thank you again for your help.



 On Monday, March 18, 2019 at 2:33:13 PM UTC-7, Colin Cross wrote:
>
> All of that is up to you.  All Android.bp files found in the tree are 
> parsed, so you can create a directory anywhere (maybe under vendor/ so 
> you 
> can minimize changes to AOSP files).  Put the prebuilt jars in that 
> directory too.
>
> static_libs takes a list of module names.  
> android.hardware.radio-V1.0-java is a module created 
> by hardware/interfaces/radio/1.0/Android.bp.  The modules can be defined 
> anywhere in the tree.
>
> Taking a step back, what are you trying to accomplish?  Why do you 
> need extra classes in framework.jar?  Maybe it would be better to keep 
> them 
> outside framework.jar but add them to the default classpath using 
> PRODUCT_BOOT_JARS?  Or ship them as a separate shared library that apps 
> can 
> opt into loading?
>
> On Mon, Mar 18, 2019 at 1:34 PM KarenL  wrote:
>
>> What directory should my prebuilt jars go into? Where are the pother 
>> static_libs, like android.hardware.radio-V1.0-java, picked up from?
>> Where do I add this new Android.bp with the below content?
>>
>> All I want to add to framework.jar are 2 prebuilt jars and 2 source 
>> files. Do I need to create a new folder structure under frameworks/base 
>> for 
>> these? If so - what does that structure look like.
>>
>> Thank you for your help.
>>
>>
>>
>> On Monday, March 18, 2019 at 1:06:45 PM UTC-7, Colin Cross wrote:
>>>
>>> You need to use java_import modules to create a module for the 
>>> jars.  Something like:
>>>
>>> java_import {
>>> name: "my_prebuilt_jars",
>>> jars: [
>>> "my_prebuilt_jar1.jar",
>>> "my_prebuilt_jar2.jar",
>>> ],
>>> }
>>>
>>> Then you can add to static_libs:
>>> "my_prebuilt_jars"
>>>
>>> On Mon, Mar 18, 2019 at 12:35 PM KarenL  wrote:
>>>
 Hi

 I would like to add a couple of prebuilt jars and some source files 
 to the Android 9 aosp image that I"m building.
 With lower versions of Android I've added these easily to 
 frameworks.jar. This was straight forward to do when framework.jar was 
 built using a make file. Its a lot less clear how to do this using 
 blueprint files and soong.

 This is what I've tried and its not enough. 

 Add a new folder to frameworks/base for my source files:
 frameworks/base/myfolder/java/com/xxx

 Edit the Android.bp file in frameworks/base and add source files to 
 the "srcs" list
 "myfolder/java/com/xxx/source1.java"
 "myfolder/java/com/xxx/source2.java"

 Edit the "static_libs" list and add my prebuilt jars
 "prebuilt_jar1",
 "prebuilt_jar2",

 I'm not sure where to put these prebuilt jars. 
 Do they go somewhere inside myfolder? Where are the other static 
 libs in this list picked up from? 
 Do I need to create .bp files inside myfolder to build this new 
 part?