Re: [android-developers] Re: ActionBar/Mode Style Regressions with SDK 12r2 and 13r1

2011-07-29 Thread Dianne Hackborn
Yes, that is terrible, and pretty much guaranteed to break.

On Mon, Jul 18, 2011 at 6:54 AM, dmitry.lukas...@gmail.com 
dmitry.lukas...@gmail.com wrote:

 I've found only one way to change default search view icon:-) But this is
 terrible solution

 SearchView sv = new SearchView(mActivity);
 sv.setOnQueryTextListener(mOnSearchQueryTextListener);
 menuItemSearch.setActionView(sv);
 searchViewChangeHack(sv);

 private static int sViewIndex = 0;

 private void searchViewChangeHack(ViewGroup sv) {
 for (int i = 0; i  sv.getChildCount(); i++) {
 View v = sv.getChildAt(i);
 if (v instanceof ViewGroup) {
 searchViewChangeHack((ViewGroup)v);
 } else if (v instanceof ImageView) {
 if (sViewIndex == 0 || sViewIndex == 1) {
 ((ImageView)
 v).setImageResource(R.drawable.common_bar_search);
 }
 sViewIndex++;

 }
 }
 }

 --
 You received this message because you are subscribed to the Google
 Groups Android Developers group.
 To post to this group, send email to android-developers@googlegroups.com
 To unsubscribe from this group, send email to
 android-developers+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/android-developers?hl=en




-- 
Dianne Hackborn
Android framework engineer
hack...@android.com

Note: please don't send private questions to me, as I don't have time to
provide private support, and so won't reply to such e-mails.  All such
questions should be posted on public forums, where I and others can see and
answer them.

-- 
You received this message because you are subscribed to the Google
Groups Android Developers group.
To post to this group, send email to android-developers@googlegroups.com
To unsubscribe from this group, send email to
android-developers+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-developers?hl=en

Re: [android-developers] Re: ActionBar/Mode Style Regressions with SDK 12r2 and 13r1

2011-07-29 Thread dmitry . lukashev
My concern is why I can easily change android:actionOverflowButtonStyle... 
and cannot do the same with search icon. Gray search icon is not acceptable 
for our brand style... so default action bar became useless for us, and we 
should create custom bar for tablet that is ridiculous:)

-- 
You received this message because you are subscribed to the Google
Groups Android Developers group.
To post to this group, send email to android-developers@googlegroups.com
To unsubscribe from this group, send email to
android-developers+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-developers?hl=en

Re: [android-developers] Re: ActionBar/Mode Style Regressions with SDK 12r2 and 13r1

2011-07-29 Thread Dianne Hackborn
Sorry at this point you can't customize it like that.  If you seriously
can't live with the standard style, you'll need to make your own.

On Thu, Jul 28, 2011 at 11:42 PM, dmitry.lukas...@gmail.com wrote:

 My concern is why I can easily change android:actionOverflowButtonStyle...
 and cannot do the same with search icon. Gray search icon is not acceptable
 for our brand style... so default action bar became useless for us, and we
 should create custom bar for tablet that is ridiculous:)

 --
 You received this message because you are subscribed to the Google
 Groups Android Developers group.
 To post to this group, send email to android-developers@googlegroups.com
 To unsubscribe from this group, send email to
 android-developers+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/android-developers?hl=en




-- 
Dianne Hackborn
Android framework engineer
hack...@android.com

Note: please don't send private questions to me, as I don't have time to
provide private support, and so won't reply to such e-mails.  All such
questions should be posted on public forums, where I and others can see and
answer them.

-- 
You received this message because you are subscribed to the Google
Groups Android Developers group.
To post to this group, send email to android-developers@googlegroups.com
To unsubscribe from this group, send email to
android-developers+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-developers?hl=en

Re: [android-developers] Re: ActionBar/Mode Style Regressions with SDK 12r2 and 13r1

2011-07-28 Thread Xavier Ducrohet
These were always private but aapt didn't correctly enforce not being
able to reference private styles/attributes.

Note that this would not have done what you wanted as private resource
integers change from build to build.

see bug http://code.google.com/p/android/issues/detail?id=18659 for more detail.

On Sat, Jul 16, 2011 at 2:18 PM, Jake Wharton jakewhar...@gmail.com wrote:
 I managed to fix these up fairly easily. I can only assume the removed
 styles were not meant to be public yet and that the styling of action modes
 is being limited to provide a more consistent experience.
 The missing attributes definitely need to be on the API differences report
 at the very least.

 --
 You received this message because you are subscribed to the Google
 Groups Android Developers group.
 To post to this group, send email to android-developers@googlegroups.com
 To unsubscribe from this group, send email to
 android-developers+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/android-developers?hl=en



-- 
Xavier Ducrohet
Android SDK Tech Lead
Google Inc.
http://developer.android.com | http://tools.android.com

Please do not send me questions directly. Thanks!

-- 
You received this message because you are subscribed to the Google
Groups Android Developers group.
To post to this group, send email to android-developers@googlegroups.com
To unsubscribe from this group, send email to
android-developers+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-developers?hl=en


[android-developers] Re: ActionBar/Mode Style Regressions with SDK 12r2 and 13r1

2011-07-18 Thread clemp6r
How did you fixed this?

On Jul 16, 11:18 pm, Jake Wharton jakewhar...@gmail.com wrote:
 I managed to fix these up fairly easily. I can only assume the removed
 styles were not meant to be public yet and that the styling of action modes
 is being limited to provide a more consistent experience.

 The missing attributes definitely need to be on the API differences report
 at the very least.

-- 
You received this message because you are subscribed to the Google
Groups Android Developers group.
To post to this group, send email to android-developers@googlegroups.com
To unsubscribe from this group, send email to
android-developers+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-developers?hl=en


Re: [android-developers] Re: ActionBar/Mode Style Regressions with SDK 12r2 and 13r1

2011-07-18 Thread Jake Wharton
Removed references to actionModeStyle and actionModePopupWindowStyle. It
would seem the only customization options for action modes going
forward is their
background 
imagehttp://developer.android.com/reference/android/R.attr.html#actionModeBackground.
This is the only true regression in functionality, not that many people (if
any) used it.

For the list navigation I changed the parent style to just be
Widget.Holo.Spinner and Widget.Holo.Light.Spinner. There were no customized
attributes in the Widget.Holo.Spinner.DropDown.ActionBar style anyway.

In my values/ folder I changed all of the tab-related styles to use
Widgetas their parent. The three individual styles previously used for
tab styling
did not have any customized attributes and inherited from Widget themselves.
I also added a values-v13/ folder which contains only these three tab styles
for that instead inherit from the new Widget.Holo.ActionBar.Tab___ for
future compatibility.

---
Jake Wharton
http://about.me/jakewharton


On Mon, Jul 18, 2011 at 7:59 AM, clemp6r clemplant...@gmail.com wrote:

 How did you fixed this?

 On Jul 16, 11:18 pm, Jake Wharton jakewhar...@gmail.com wrote:
  I managed to fix these up fairly easily. I can only assume the removed
  styles were not meant to be public yet and that the styling of action
 modes
  is being limited to provide a more consistent experience.
 
  The missing attributes definitely need to be on the API differences
 report
  at the very least.

 --
 You received this message because you are subscribed to the Google
 Groups Android Developers group.
 To post to this group, send email to android-developers@googlegroups.com
 To unsubscribe from this group, send email to
 android-developers+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/android-developers?hl=en


-- 
You received this message because you are subscribed to the Google
Groups Android Developers group.
To post to this group, send email to android-developers@googlegroups.com
To unsubscribe from this group, send email to
android-developers+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-developers?hl=en

Re: [android-developers] Re: ActionBar/Mode Style Regressions with SDK 12r2 and 13r1

2011-07-18 Thread dmitry.lukas...@gmail.com
How to change android:searchViewSearchIcon now?

-- 
You received this message because you are subscribed to the Google
Groups Android Developers group.
To post to this group, send email to android-developers@googlegroups.com
To unsubscribe from this group, send email to
android-developers+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-developers?hl=en

Re: [android-developers] Re: ActionBar/Mode Style Regressions with SDK 12r2 and 13r1

2011-07-18 Thread dmitry.lukas...@gmail.com
I've found only one way to change default search view icon:-) But this is 
terrible solution

SearchView sv = new SearchView(mActivity);
sv.setOnQueryTextListener(mOnSearchQueryTextListener);
menuItemSearch.setActionView(sv);
searchViewChangeHack(sv);

private static int sViewIndex = 0;

private void searchViewChangeHack(ViewGroup sv) {
for (int i = 0; i  sv.getChildCount(); i++) {
View v = sv.getChildAt(i);
if (v instanceof ViewGroup) {
searchViewChangeHack((ViewGroup)v);
} else if (v instanceof ImageView) {
if (sViewIndex == 0 || sViewIndex == 1) {
((ImageView) 
v).setImageResource(R.drawable.common_bar_search);
}
sViewIndex++;
}
}
}

-- 
You received this message because you are subscribed to the Google
Groups Android Developers group.
To post to this group, send email to android-developers@googlegroups.com
To unsubscribe from this group, send email to
android-developers+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-developers?hl=en

[android-developers] Re: ActionBar/Mode Style Regressions with SDK 12r2 and 13r1

2011-07-16 Thread Jake Wharton
I managed to fix these up fairly easily. I can only assume the removed 
styles were not meant to be public yet and that the styling of action modes 
is being limited to provide a more consistent experience.

The missing attributes definitely need to be on the API differences report 
at the very least.

-- 
You received this message because you are subscribed to the Google
Groups Android Developers group.
To post to this group, send email to android-developers@googlegroups.com
To unsubscribe from this group, send email to
android-developers+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-developers?hl=en