Re: interpreting COD of bluetooth devices

2009-06-24 Thread Nick Pelly
A rather belated response,

This sounds like a bug on our side, and we are tracking.

Thanks for the report,
Nick

On Mon, Apr 27, 2009 at 4:36 PM, tajpro  wrote:

>
> Hello,
> In cupcake version, the discovered BT devices are listed with its type
> icon.
> I found that some laptops (with windows XP) are shown with headphone
> icon.
>
> My debugging result is that
> (1) their COD (class of device) is 0x1c010B, which  indicates that its
> major service is "rendering" and its major class is "computer".
> (2)
> android.bluetooth.BluetoothA2dp.java's doesClassMachSink method return
> true if COD's 18th bit ("rendering" is set.
> (3) Setting package's LocalBluetoothProfileManager.java's fill method
> adds A2DP profile once (2) is satisfied.
> (4) Setting package's LocalBluetoothDevice.java's getBtClassDrawable
> method checks the device's profile first and then major class. If the
> device contains A2DP profile, a "headphone" icon is displayed.
>
> My question is that
> - why "rendering" bit of major service is considered as A2DP profile?
> - why getBtClassDrawable method can check the device's major device
> class first rather than checking major service class. If so, the
> laptops announcing 0x1c010B can display a laptop icon properly.
>
> Thanks a lot,
>
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"android-framework" group.
To post to this group, send email to android-framework@googlegroups.com
To unsubscribe from this group, send email to 
android-framework+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/android-framework?hl=en
-~--~~~~--~~--~--~---



Re: SBC integration license issue in BlueZ/Android

2009-04-21 Thread Nick Pelly
On Tue, Apr 21, 2009 at 7:06 PM, Andy Quan  wrote:

> Dave/Nick et al,
> Many thanks for your informative answers!
>
> I have very limited understanding about the "infection nature" of GPL. In
> my understanding, as long as one of the source files or linked dynamic
> libs used to build certain lib is infected by GPL, the rest part, no matter
> it is inside that lib or only used as dynamic linked libs in building, have
> to be GPL, that is, to be open source.
>


> It is true that "sbc.c" is LGPL. Then I go up a few steps and find "sbc.c",
> "sbc_primitive.c", "liba2dp.c", "ipc.c" are used together to build liba2dp
> and they are also LGPL. However, as "libbluetooth" and a few other GPL
> dyamic libs are used as "LOCAL_SHARED_LIBS" for liba2dp, I assume that they,
> for example libbluetooth, would force the entire part of liba2dp to be GPL.
>

libbluetooth is not in LOCAL_SHARED_LIBS for liba2dp in the shipping
product. Every source file used to generate liba2dp is LGPL or APACHE.

http://android.git.kernel.org/?p=platform/external/bluez.git;a=blob;f=utils/audio/Android.mk;h=c0b4d107ff6a280aecf489e582697e79d8d2013c;hb=HEAD

So the 'infection' of the GPL license to linked source as you describe does
not apply for liba2dp.


> If this is true, my integration in sbc.c would have to be GPL as well, no
> matter it is linked as static lib or dynamic lib.
>

In a nut-shell:

If you replace liba2dp then you can use any license you like.

If you modify liba2dp then those modifications will probably need to be
LGPL, since liba2dp contains LGPL code.

GPL/LGPL is a tricky area and I recommend you get legal advice from a lawyer
familar with these licenses for an authorative answer.

Nick

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"android-framework" group.
To post to this group, send email to android-framework@googlegroups.com
To unsubscribe from this group, send email to 
android-framework+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/android-framework?hl=en
-~--~~~~--~~--~--~---



Re: SBC integration license issue in BlueZ/Android

2009-04-21 Thread Nick Pelly
Also, the SBC encoder is LPGL not GPL.

Nick

On Tue, Apr 21, 2009 at 5:12 PM, Dave Sparks wrote:

>
> The BlueZ stack was deliberately isolated to accommodate the GPL
> license requirements without affecting the rest of the source code.
>
> On Apr 21, 2:36 pm, Jean-Baptiste Queru  wrote:
> > Indeed, bluez is a rare part of Android that is licensed under the GPL.
> >
> > JBQ
> >
> >
> >
> > On Tue, Apr 21, 2009 at 1:40 PM, Ravi  wrote:
> >
> > > Bumping this up.
> >
> > > Can someone from Google please comment on this?
> >
> > > -Ravi
> >
> > > On Apr 20, 12:56 am, Ravi  wrote:
> > >> I do see the GPL license. That's bizarre. I was under the impression
> > >> that the entire android tree has to be provided with the Apache
> > >> license. Maybe someone from Google can confirm.
> >
> > >> Just fyi...PacketVideo has provided their version of the SBC encoder
> > >> already as part of OpenCORE [external/opencore/codecs_v2/audio/sbc].
> >
> > >> -Ravi
> >
> > >> On Apr 20, 12:13 am, Andy Quan  wrote:
> >
> > >> > Hi,
> > >> > As far as I remember, BlueZ is released under GPL license. Is this
> the same
> > >> > in android? If so, does this mean if I want to integrate my
> customized SBC
> > >> > encoder lib into this framework, I have to make my encoder open
> source?
> >
> > >> > --
> > >> > Thanks,
> > >> > Andy
> >
> > --
> > Jean-Baptiste M. "JBQ" Queru
> > Android Engineer, Google.
> >
> > Questions sent directly to me that have no reason for being private
> > will likely get ignored or forwarded to a public forum with no further
> > warning.
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"android-framework" group.
To post to this group, send email to android-framework@googlegroups.com
To unsubscribe from this group, send email to 
android-framework+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/android-framework?hl=en
-~--~~~~--~~--~--~---



Re: Headset Input event

2009-03-19 Thread Nick Pelly

key 226   HEADSETHOOK

On 3/19/09, rambo  wrote:
>
>  What event ID does android expect when a headsets key is pressed and
>  release.  On the G1 i noticed it was KEY_MEDIA event  but it doesn't
>  seem to work on the more recent releases
>  >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"android-framework" group.
To post to this group, send email to android-framework@googlegroups.com
To unsubscribe from this group, send email to 
android-framework+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/android-framework?hl=en
-~--~~~~--~~--~--~---