Re: cvs commit: apache-2.0/src/os/win32 main_win32.c os.h
#define APR_HAS_THREADS 1 #define APR_HAS_SENDFILE 0 #define APR_HAS_MMAP 0 +#define APR_HAVE_IN_ADDR Please follow the format that the other defines use. It makes it the code much more readable if all of the defines have a specified value. Ryan Come to the first official Apache Software Foundation Conference!!! http://ApacheCon.Com/ ___ Ryan Bloom [EMAIL PROTECTED] 2121 Stonehenge Dr. Apt #3 Raleigh, NC 27615 Ryan Bloom -- thinker, adventurer, artist, writer, but mostly, friend. ---
Re: cvs commit: apache-2.0/src/os/win32 main_win32.c
Windows: Some more work to properly handle -k restart,shutdown. I have made a simplifying assumption that the relative name of the server pidfile is always logs/httpd.pid. This saves the error prone effort of reading the config file in apache.exe (as opposed to ApacheCore.dll). I am really working hard to keep Windows specific junk out of http_main.c. I disagree with this assumption. If somebody wants to change where the pidfile is stored, then we have to be able to deal with it. If that means putting some Windows specific stuff in http_main, then so be it. There are other ways to do this as well (I need to think them through more, and do some more research about Windows before I post about them). I am -1 for this patch, unless it is a stop-gap solution so we can get 2.0 working on Windows until we fix this the right way. Ryan
