Re: [asterisk-dev] [Code Review] 3908: ARI: Fix bug where hanging up while in a bridge during playback causes a crash

2014-08-20 Thread rmudgett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3908/#review13128
---



/branches/12/res/stasis/command.h


Remove this special function and use ast_free_ptr instead.  This is what 
ast_free_ptr is for.



/branches/12/res/stasis/command.h


Remove this special function and use __ao2_cleanup instead.  This is what 
__ao2_cleanup is for.



/branches/12/res/stasis/command.c


You should call the data_destructor here if it is present and then clear 
the data_destructor pointer.  Otherwise, you are extending the life of the data 
object possibly too long from what it was before.



/branches/12/res/stasis/command.c


Call the data_destructor here if there is one to guarantee that the data 
will be destroyed regardless of successfully queueing the command.  Otherwise, 
you could return -1 and the caller would not know if the data was destroyed.

It might be better to have command_create() do this instead if the command 
object could not be created.  This way the other places that create commands 
would be covered as well.


- rmudgett


On Aug. 20, 2014, 4:21 p.m., Jonathan Rose wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3908/
> ---
> 
> (Updated Aug. 20, 2014, 4:21 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore, Matt Jordan, and rmudgett.
> 
> 
> Bugs: ASTERISK-24147
> https://issues.asterisk.org/jira/browse/ASTERISK-24147
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Here's a basic rundown of what was happening:
> 
> 1. Stasis application with a channel in it, channel is in a bridge.  Playback 
> actions for the channel are queued, the stasis control is running them.
> 
> 2. The channel hangs up. Because the stasis control detects a hangup and the 
> depart is expected to be handled when the channel leaves the bridge, the 
> stasis application execution function exits taking the control along with it. 
> When the PBX thread exits, the channel is considered fully hung up and leaves 
> the bridging core. At this point we are running after bridge callbacks with, 
> one of which holds a pointer to a dead control object that we are trying to 
> do all queue actions to along with other things.  This causes the crash.
> 
> In order to fix this, I made sure that if the control execution loop is 
> exited without pulling the channel out of the bridge that the channel depart 
> would occur manually and the control would be marked so that the after bridge 
> cb wouldn't attempt to exit the bridge in this case. This wasn't actually 
> causing problems, but Richard and I both have concerns about an after bridge 
> callback attempting to depart a channel from a bridge... it seems a little 
> out there.
> 
> 
> Diffs
> -
> 
>   /branches/12/res/stasis/stasis_bridge.c 421424 
>   /branches/12/res/stasis/control.c 421424 
>   /branches/12/res/stasis/command.c 421424 
>   /branches/12/res/stasis/command.h 421424 
>   /branches/12/res/res_stasis_recording.c 421424 
>   /branches/12/res/res_stasis_playback.c 421424 
>   /branches/12/res/res_stasis_answer.c 421424 
>   /branches/12/res/res_stasis.c 421424 
>   /branches/12/include/asterisk/stasis_app_impl.h 421424 
> 
> Diff: https://reviewboard.asterisk.org/r/3908/diff/
> 
> 
> Testing
> ---
> 
> Made sure the crash that was happening no longer occurs
> 
> Tested long queues of playback to check what would happen with the additional 
> playbacks.  Each subsequent playback from the one currently running fails (in 
> an expected manner) and reports its failure over stasis.  Nothing too odd 
> there.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 3925: PJSIP: Use IP address in favor of hostname in SDP origin line.

2014-08-20 Thread Mark Michelson 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3925/
---

Review request for Asterisk Developers.


Bugs: ASTERISK-23994
https://issues.asterisk.org/jira/browse/ASTERISK-23994


Repository: Asterisk


Description
---

>From the issue, it was determined that using pj_gethostname() to populate the 
>origin line of SDPs is not guaranteed to meet RFC 4566's requirement that the 
>address be a FQDN or IP address. This changeset modifies the process by 
>getting the hostname and then resolving that into an IP address. On my box, I 
>could change the IP address by modifying my /etc/hosts file to resolve my 
>hostname to a different IP address.


Diffs
-

  /branches/12/res/res_pjsip_session.c 421564 

Diff: https://reviewboard.asterisk.org/r/3925/diff/


Testing
---

Placed an outbound call from Asterisk. I observed that the SDP origin line now 
contained an IP address instead of a hostname. When I modified /etc/hosts to 
resolve the hostname to a different IP address, that IP address appeared in the 
SDP origin line instead.


Thanks,

Mark Michelson

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3906: chan_pjsip: Update media translation paths when new SDP negotiated.

2014-08-20 Thread rmudgett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3906/
---

(Updated Aug. 20, 2014, 5:49 p.m.)


Status
--

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
---

Committed in revision 421645


Bugs: AFS-137
https://issues.asterisk.org/jira/browse/AFS-137


Repository: Asterisk


Description
---

On a SIP reinvite that changes media strams, the PJSIP channel driver was 
flooding the log with "Asked to transmit frame type %s, while native formats is 
%s" warnings.

* Fixes PJSIP not setting up translation paths when the formats change on a 
reinvite.

* Improved the unexpected frame format WARNING message to include more 
information.

* Added protective locking while altering formats on a channel.  Reworked 
set_format() to simplify and protect the formats under manipulation.

* Restored some code that got lost in the media_formats work.


Diffs
-

  /branches/13/res/res_pjsip_sdp_rtp.c 420978 
  /branches/13/main/file.c 420978 
  /branches/13/main/channel.c 420978 
  /branches/13/main/bridge_channel.c 420978 
  /branches/13/main/bridge.c 420978 
  /branches/13/channels/chan_pjsip.c 420978 

Diff: https://reviewboard.asterisk.org/r/3906/diff/


Testing
---

Performed blind SIP transfers (REFER) and the call still passes media.


Thanks,

rmudgett

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 1152: Access to any Exchange 2007 and 2010 calendar.

2014-08-20 Thread Jonathan Rose 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1152/#review13127
---



/trunk/configs/samples/calendar.conf.sample


;mailbox

spacing isn't uniform with the rest of this block. Also it looks like "; 
Primary SMTP address [...]" might be meant to have a line break. Line 79 runs a 
little long, so break it before the URL.

Write casesensitive as 'case-sensitive' or 'case sensitive' (I think both 
are technically 



/trunk/configs/samples/calendar.conf.sample


-folderpath= /meetingroom1
+folderpath = /meetingroom1



/trunk/res/res_calendar_ews.c


fflush appears to be misaligned by a tab.



/trunk/res/res_calendar_ews.c


here too.



/trunk/res/res_calendar_ews.c


You missed a spot :P



/trunk/res/res_calendar_ews.c


There shouldn't be a blank line between XML docs and the function.


Aside from these style issues, this looks good to go to me. It'd be good to 
have someone with some experience with Exchange to take a look at it, but I 
don't believe that's a luxury we have.

- Jonathan Rose


On Aug. 20, 2014, 3:51 a.m., astmiv wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1152/
> ---
> 
> (Updated Aug. 20, 2014, 3:51 a.m.)
> 
> 
> Review request for Asterisk Developers and pitli...@gmail.com.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> This patch will add access to any calendar folder within Exchange 2007 and 
> 2010. 
> 
> The current resource only gives access to the default calendar folder of the 
> specified user. With this patch it is possible to access any calendar folder 
> within the system as long as the user has read rights to the folder and its 
> complete folder path.
> 
> For example:
> - Calendar folders below the publicfoldersroot.
> - Calendar folders below the user's mailbox outside of his default calendar.
> - Calendar folders below the user's default calendar.
> - etc
> 
> Also did some cleanup for XML schema labeling. They are now all the same.
> 
> 
> Diffs
> -
> 
>   /trunk/res/res_calendar_ews.c 421522 
>   /trunk/configs/samples/calendar.conf.sample 421522 
> 
> Diff: https://reviewboard.asterisk.org/r/1152/diff/
> 
> 
> Testing
> ---
> 
> Tested the following scenario's:
> - Access to default calendar of specified user. (folderbase not specified or 
> folderbase=calendar)
> - Access to shared default calendar of other person. 
> (mailbox=emailot...@company.com and folderbase not specified or 
> folderbase=calendar)
> - Access to calendar folder, named testfolder1, below default Calendar. 
> (folderbase=calendar and folderpath=/testfolder1)
> - Access to calendar folder, named testfolder2, below a subfolder, named 
> testfolder3, of the default Calendar. (folderbase=calendar and 
> folderpath=/testfolder3/testfolder2)
> - Access to calendar folder in Public Folders. (folderbase=publicfoldersroot 
> and folderpath=/meetingroom1)
> - Access to calendar folder below a subfolder in Public Folders. 
> (folderbase=publicfoldersroot and folderpath=/meetingrooms/meetingroom1)
> - Access to calendar folder below mailbox of specified user. 
> (folderbase=msgfolderroot and folderpath=/calendar2)
> 
> 
> Thanks,
> 
> astmiv
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3908: ARI: Fix bug where hanging up while in a bridge during playback causes a crash

2014-08-20 Thread Jonathan Rose 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3908/
---

(Updated Aug. 20, 2014, 4:21 p.m.)


Review request for Asterisk Developers, kmoore, Matt Jordan, and rmudgett.


Changes
---

More stringent checking for if the channel is still in a bridge plus command 
destructors added to the command queue


Bugs: ASTERISK-24147
https://issues.asterisk.org/jira/browse/ASTERISK-24147


Repository: Asterisk


Description
---

Here's a basic rundown of what was happening:

1. Stasis application with a channel in it, channel is in a bridge.  Playback 
actions for the channel are queued, the stasis control is running them.

2. The channel hangs up. Because the stasis control detects a hangup and the 
depart is expected to be handled when the channel leaves the bridge, the stasis 
application execution function exits taking the control along with it. When the 
PBX thread exits, the channel is considered fully hung up and leaves the 
bridging core. At this point we are running after bridge callbacks with, one of 
which holds a pointer to a dead control object that we are trying to do all 
queue actions to along with other things.  This causes the crash.

In order to fix this, I made sure that if the control execution loop is exited 
without pulling the channel out of the bridge that the channel depart would 
occur manually and the control would be marked so that the after bridge cb 
wouldn't attempt to exit the bridge in this case. This wasn't actually causing 
problems, but Richard and I both have concerns about an after bridge callback 
attempting to depart a channel from a bridge... it seems a little out there.


Diffs (updated)
-

  /branches/12/res/stasis/stasis_bridge.c 421424 
  /branches/12/res/stasis/control.c 421424 
  /branches/12/res/stasis/command.c 421424 
  /branches/12/res/stasis/command.h 421424 
  /branches/12/res/res_stasis_recording.c 421424 
  /branches/12/res/res_stasis_playback.c 421424 
  /branches/12/res/res_stasis_answer.c 421424 
  /branches/12/res/res_stasis.c 421424 
  /branches/12/include/asterisk/stasis_app_impl.h 421424 

Diff: https://reviewboard.asterisk.org/r/3908/diff/


Testing
---

Made sure the crash that was happening no longer occurs

Tested long queues of playback to check what would happen with the additional 
playbacks.  Each subsequent playback from the one currently running fails (in 
an expected manner) and reports its failure over stasis.  Nothing too odd there.


Thanks,

Jonathan Rose

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] ARI and simple Dial

2014-08-20 Thread Matthew Jordan 
On Wed, Aug 20, 2014 at 7:18 AM, Yuriy Gorlichenko  wrote:
> Hello. We trying to develom app like queue with ARI.
>
> After call to extension we start Stasis from dialplan and call our app.
>
> Our app must create bridge with existing one channel (that calls Stasis from
> dialplan. ChannelId we send over statis parameters like:
>
> exten=>_X.,n,Stasis(CustomQueue,${CHANNEL},${EXTEN})
>
> So after calling CustonQueue we successfully creates bridge, and must send
> new channel (called party) to bridge
>
> We Used POST /channels to do this but we have a problem with Endpoint
> parameter. We do not need Call to Endpoint. We just need to call some
> extension (or device) from some context that creates new channel that will
> join to our already existing bridge.

An endpoint is simply a string that is interpreted by a channel driver
as the target for the channel. It is up to the channel technology to
make sense of the identifier for the endpoint.

If you want to dial a device, you can:

POST /channels?endpoint=PJSIP/alice&app=my_cool_app

If you want to dial an arbitrary SIP URI via the PJSIP channel driver,
you can do that to:

POST 
/channels?endpoint=PJSIP/alice/sip:alice@my_awesome_provider.net&app=my_cool_app

If you want to create a channel that goes to an extension (which is a
dialplan concept) but is also in your Stasis application, then use a
Local channel:

POST /channels?endpoint=Local/1000@default&app=my_cool_app

If you want to just toss a channel into the dialplan and not mess with
it any more in your application, then you can create it directly in
the dialplan:

POST /channels?endpoint=PJSIP/alice&extension=1000&context=default&priority=1

>
> So as I know at develop state of RESTFull interface at ARI was application
> like channels/{channelid}/Dial that was removes:
>
> http://lists.digium.com/pipermail/asterisk-app-dev/2013-October/02.html
>

It was removed because it was really just a combination of POST
/channels with POST /bridges. Combining things into chunk operations,
however, has a large drawback: it requires the operation itself to
contain all of the configuration of what occurs during that operation.
We were about to walk smack into the Dial application laundry list of
arguments; as such, we retreated.

As an FYI, there is a dedicated mailing list for discussing
application development using Asterisk, asterisk-app-dev. You may want
to direct further inquiries to that mailing list.

Matt

-- 
Matthew Jordan
Digium, Inc. | Engineering Manager
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: http://digium.com & http://asterisk.org

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] MeetMe not working in 1.8.29.0 is there a meetme.conf change needed ?

2014-08-20 Thread Matthew Jordan 
On Wed, Aug 20, 2014 at 8:05 AM, Deepak Bhatia  wrote:
> Subject: MeetMe not working in 1.8.29.0 is there a meetme.conf change needed
> ?
>
>
>  - Executing [0@tests:32] MeetMe("DAHDI/i1/009811196957-4", "11i1,1pqCx") in
> new stack
> localhost*CLI>   == Parsing '/etc/asterisk/meetme.conf':   == Found
>   == Parsing '/etc/asterisk/meetme.conf':   == Found
>   == Spawn extension (tests, 0, 32) exited non-zero on
> 'DAHDI/i1/009811196957-4'
>   == Spawn extension (tests, 0, 32) exited non-zero on
> 'DAHDI/i1/009811196957-4'
> -- Executing [h@tests:1] MeetMeAdmin("DAHDI/i1/009811196957-4", "11i1,
> K") in new stack
> -- Executing [h@tests:1] MeetMeAdmin("DAHDI/i1/009811196957-4", "11i1,
> K") in new stack
> localhost*CLI> [Aug 20 17:55:53] WARNING[964]: app_meetme.c:4840 admin_exec:
> Conference number '11i1' not found!
> app_meetme.c:4840 admin_exec: Conference number '11i1' not found
>

The asterisk-dev mailing list is not a support list. It is for
discussing development of Asterisk itself. Please use the
asterisk-users mailing list for your question.

-- 
Matthew Jordan
Digium, Inc. | Engineering Manager
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: http://digium.com & http://asterisk.org

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] How get the spans information into C module

2014-08-20 Thread vassilux . 
Hi,
I want to get the spans information into my C module.

Function sig_pri_cli_show_spans seems be good for me but this function uses
ast_cli.

How I can get the information about spans ?

-- 
Vassili Gontcharov
-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] MeetMe not working in 1.8.29.0 is there a meetme.conf change needed ?

2014-08-20 Thread Deepak Bhatia 
Subject: MeetMe not working in 1.8.29.0 is there a meetme.conf change
needed ?


 - Executing [0@tests:32] MeetMe("DAHDI/i1/009811196957-4", "11i1,1pqCx")
in new stack
localhost*CLI>   == Parsing '/etc/asterisk/meetme.conf':   == Found
  == Parsing '/etc/asterisk/meetme.conf':   == Found
  == Spawn extension (tests, 0, 32) exited non-zero on
'DAHDI/i1/009811196957-4'
  == Spawn extension (tests, 0, 32) exited non-zero on
'DAHDI/i1/009811196957-4'
-- Executing [h@tests:1] MeetMeAdmin("DAHDI/i1/009811196957-4", "11i1,
K") in new stack
-- Executing [h@tests:1] MeetMeAdmin("DAHDI/i1/009811196957-4", "11i1,
K") in new stack
localhost*CLI> [Aug 20 17:55:53] WARNING[964]: app_meetme.c:4840
admin_exec: Conference number '11i1' not found!
app_meetme.c:4840 admin_exec: Conference number '11i1' not found
-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3921: Stasis: Add missing information to blind transfer events

2014-08-20 Thread opticron 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3921/
---

(Updated Aug. 20, 2014, 7:57 a.m.)


Status
--

This change has been marked as submitted.


Review request for Asterisk Developers, Matt Jordan and Mark Michelson.


Changes
---

Committed in revision 421537


Repository: Asterisk


Description
---

When a blind transfer occurs that is forced to create a local channel pair to 
satisfy the transfer request, information about the local channel pair is not 
published. This adds a field to describe that channel to the blind transfer 
message struct so that this information is conveyed properly to consumers of 
the blind transfer message.

This also fixes a bug in which Stasis() was unable to properly identify the 
channel that was replacing an existing Stasis-controlled channel due to a blind 
transfer.


Diffs
-

  branches/12/rest-api/api-docs/events.json 421326 
  branches/12/res/stasis/app.c 421326 
  branches/12/res/ari/ari_model_validators.c 421326 
  branches/12/res/ari/ari_model_validators.h 421326 
  branches/12/main/stasis_bridges.c 421326 
  branches/12/main/bridge.c 421326 
  branches/12/include/asterisk/stasis_bridges.h 421326 

Diff: https://reviewboard.asterisk.org/r/3921/diff/


Testing
---

Verified functionality manually and updated the ARI blind transfer test to 
check for these conditions.


Thanks,

opticron

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3915: AMI: Add AllVariables parameter to Status

2014-08-20 Thread opticron 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3915/
---

(Updated Aug. 20, 2014, 7:39 a.m.)


Status
--

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
---

Committed in revision 421534


Repository: Asterisk


Description
---

This adds the AllVariables parameter to the Status AMI action such that if 
defined and set to "true", all channel variables will be reported in the 
subsequent Status event(s). This parameter does not negate the functionality of 
the "Variables" parameter so that global variables and dialplan functions can 
be requested.


Diffs
-

  trunk/main/manager.c 421392 

Diff: https://reviewboard.asterisk.org/r/3915/diff/


Testing
---

Manual testing via netcat and an automated test here: 
https://reviewboard.asterisk.org/r/3916/


Thanks,

opticron

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] ARI and simple Dial

2014-08-20 Thread Yuriy Gorlichenko 
Hello. We trying to develom app like queue with ARI.

After call to extension we start Stasis from dialplan and call our app.

Our app must create bridge with existing one channel (that calls Stasis
from dialplan. ChannelId we send over statis parameters like:

exten=>_X.,n,Stasis(CustomQueue,${CHANNEL},${EXTEN})

So after calling CustonQueue we successfully creates bridge, and must send
new channel (called party) to bridge

We Used POST /channels to do this but we have a problem with Endpoint
parameter. We do not need Call to Endpoint. We just need to call some
extension (or device) from some context that creates new channel that will
join to our already existing bridge.

So as I know at develop state of RESTFull interface at ARI was application
like channels/{channelid}/Dial that was removes:

http://lists.digium.com/pipermail/asterisk-app-dev/2013-October/02.html

So can we use something else do Generate single channel without calling
EndPoints?
-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 1152: Access to any Exchange 2007 and 2010 calendar.

2014-08-20 Thread astmiv 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1152/
---

(Updated Aug. 20, 2014, 8:51 a.m.)


Review request for Asterisk Developers and pitli...@gmail.com.


Changes
---

One last white space clean up.


Repository: Asterisk


Description
---

This patch will add access to any calendar folder within Exchange 2007 and 
2010. 

The current resource only gives access to the default calendar folder of the 
specified user. With this patch it is possible to access any calendar folder 
within the system as long as the user has read rights to the folder and its 
complete folder path.

For example:
- Calendar folders below the publicfoldersroot.
- Calendar folders below the user's mailbox outside of his default calendar.
- Calendar folders below the user's default calendar.
- etc

Also did some cleanup for XML schema labeling. They are now all the same.


Diffs (updated)
-

  /trunk/res/res_calendar_ews.c 421522 
  /trunk/configs/samples/calendar.conf.sample 421522 

Diff: https://reviewboard.asterisk.org/r/1152/diff/


Testing
---

Tested the following scenario's:
- Access to default calendar of specified user. (folderbase not specified or 
folderbase=calendar)
- Access to shared default calendar of other person. 
(mailbox=emailot...@company.com and folderbase not specified or 
folderbase=calendar)
- Access to calendar folder, named testfolder1, below default Calendar. 
(folderbase=calendar and folderpath=/testfolder1)
- Access to calendar folder, named testfolder2, below a subfolder, named 
testfolder3, of the default Calendar. (folderbase=calendar and 
folderpath=/testfolder3/testfolder2)
- Access to calendar folder in Public Folders. (folderbase=publicfoldersroot 
and folderpath=/meetingroom1)
- Access to calendar folder below a subfolder in Public Folders. 
(folderbase=publicfoldersroot and folderpath=/meetingrooms/meetingroom1)
- Access to calendar folder below mailbox of specified user. 
(folderbase=msgfolderroot and folderpath=/calendar2)


Thanks,

astmiv

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 1152: Access to any Exchange 2007 and 2010 calendar.

2014-08-20 Thread astmiv 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1152/
---

(Updated Aug. 20, 2014, 8:49 a.m.)


Review request for Asterisk Developers and pitli...@gmail.com.


Changes
---

Previous was the wrong file. This is the correct file.


Repository: Asterisk


Description
---

This patch will add access to any calendar folder within Exchange 2007 and 
2010. 

The current resource only gives access to the default calendar folder of the 
specified user. With this patch it is possible to access any calendar folder 
within the system as long as the user has read rights to the folder and its 
complete folder path.

For example:
- Calendar folders below the publicfoldersroot.
- Calendar folders below the user's mailbox outside of his default calendar.
- Calendar folders below the user's default calendar.
- etc

Also did some cleanup for XML schema labeling. They are now all the same.


Diffs (updated)
-

  /trunk/res/res_calendar_ews.c 421522 
  /trunk/configs/samples/calendar.conf.sample 421522 

Diff: https://reviewboard.asterisk.org/r/1152/diff/


Testing
---

Tested the following scenario's:
- Access to default calendar of specified user. (folderbase not specified or 
folderbase=calendar)
- Access to shared default calendar of other person. 
(mailbox=emailot...@company.com and folderbase not specified or 
folderbase=calendar)
- Access to calendar folder, named testfolder1, below default Calendar. 
(folderbase=calendar and folderpath=/testfolder1)
- Access to calendar folder, named testfolder2, below a subfolder, named 
testfolder3, of the default Calendar. (folderbase=calendar and 
folderpath=/testfolder3/testfolder2)
- Access to calendar folder in Public Folders. (folderbase=publicfoldersroot 
and folderpath=/meetingroom1)
- Access to calendar folder below a subfolder in Public Folders. 
(folderbase=publicfoldersroot and folderpath=/meetingrooms/meetingroom1)
- Access to calendar folder below mailbox of specified user. 
(folderbase=msgfolderroot and folderpath=/calendar2)


Thanks,

astmiv

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 1152: Access to any Exchange 2007 and 2010 calendar.

2014-08-20 Thread astmiv 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1152/
---

(Updated Aug. 20, 2014, 8:44 a.m.)


Review request for Asterisk Developers and pitli...@gmail.com.


Changes
---

Removed white space.
Added some inline comment (documentation) It is not the requested XML 
documentation as I do not have time for this at the moment.
Removed some duplicate memory cleanup and used goto and a variable to keep 
track of state.


Repository: Asterisk


Description
---

This patch will add access to any calendar folder within Exchange 2007 and 
2010. 

The current resource only gives access to the default calendar folder of the 
specified user. With this patch it is possible to access any calendar folder 
within the system as long as the user has read rights to the folder and its 
complete folder path.

For example:
- Calendar folders below the publicfoldersroot.
- Calendar folders below the user's mailbox outside of his default calendar.
- Calendar folders below the user's default calendar.
- etc

Also did some cleanup for XML schema labeling. They are now all the same.


Diffs (updated)
-

  /trunk/res/res_calendar_ews.c 311843 
  /trunk/configs/calendar.conf.sample 311843 

Diff: https://reviewboard.asterisk.org/r/1152/diff/


Testing
---

Tested the following scenario's:
- Access to default calendar of specified user. (folderbase not specified or 
folderbase=calendar)
- Access to shared default calendar of other person. 
(mailbox=emailot...@company.com and folderbase not specified or 
folderbase=calendar)
- Access to calendar folder, named testfolder1, below default Calendar. 
(folderbase=calendar and folderpath=/testfolder1)
- Access to calendar folder, named testfolder2, below a subfolder, named 
testfolder3, of the default Calendar. (folderbase=calendar and 
folderpath=/testfolder3/testfolder2)
- Access to calendar folder in Public Folders. (folderbase=publicfoldersroot 
and folderpath=/meetingroom1)
- Access to calendar folder below a subfolder in Public Folders. 
(folderbase=publicfoldersroot and folderpath=/meetingrooms/meetingroom1)
- Access to calendar folder below mailbox of specified user. 
(folderbase=msgfolderroot and folderpath=/calendar2)


Thanks,

astmiv

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev