[Asterisk-Dev] [PATCH] Fix bug in handle_request_info
Hi folks,
I spotted a bug in handle_request_info: in an if condition the code assumes
to receive NULL on error, while in fact it receives an empty string. The
attached trivial patch fixes this.
Patch is done against chan_sip.c from r8023.
C'ya,
Marc
--
Marc Haisenko
Comdasys AG
Rüdesheimer Straße 7
D-80686 München
Tel: +49 (0)89 - 548 43 33 0
Fax: +49 (0)89 - 548 43 33 29
e-mail: [EMAIL PROTECTED]
http://www.comdasys.com
--- chan_sip.c.orig 2006-01-13 18:11:57.0 +0100
+++ chan_sip.c 2006-01-13 18:12:56.760838308 +0100
@@ -8735,7 +8735,7 @@
ast_queue_control(p-owner, AST_CONTROL_VIDUPDATE);
transmit_response(p, 200 OK, req);
return;
- } else if ((c = get_header(req, X-ClientCode))) {
+ } else if (strlen (c = get_header(req, X-ClientCode)) 0) {
/* Client code (from SNOM phone) */
if (ast_test_flag(p, SIP_USECLIENTCODE)) {
if (p-owner p-owner-cdr)
___
--Bandwidth and Colocation provided by Easynews.com --
Asterisk-Dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [Asterisk-Dev] [PATCH] Fix bug in handle_request_info
On 1/13/06, Marc Haisenko [EMAIL PROTECTED] wrote: Hi folks, I spotted a bug in handle_request_info: in an if condition the code assumes to receive NULL on error, while in fact it receives an empty string. The attached trivial patch fixes this. Patch is done against chan_sip.c from r8023. Patched. Thank you! In the future, please also check out http://bugs.digium.com/ for bug reports and patch posting so we've got a better cyber-papertrail of these types of reports. -- Bird's The Word Technologies, Inc. http://www.btwtech.com/ ___ --Bandwidth and Colocation provided by Easynews.com -- Asterisk-Dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [Asterisk-Dev] [PATCH] Fix bug in handle_request_info
On Friday 13 January 2006 18:29, BJ Weschke wrote: Patched. Thank you! In the future, please also check out http://bugs.digium.com/ for bug reports and patch posting so we've got a better cyber-papertrail of these types of reports. ACK. C'ya, Marc -- Marc Haisenko Comdasys AG Rüdesheimer Straße 7 D-80686 München Tel: +49 (0)89 - 548 43 33 0 Fax: +49 (0)89 - 548 43 33 29 e-mail: [EMAIL PROTECTED] http://www.comdasys.com ___ --Bandwidth and Colocation provided by Easynews.com -- Asterisk-Dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
