Re: [asterisk-dev] [Code Review] 3479: chan_pjsip: Call pickup test.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3479/#review11790 --- Ship it! Ship It! - Matt Jordan On April 29, 2014, 6:29 a.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3479/ --- (Updated April 29, 2014, 6:29 a.m.) Review request for Asterisk Developers. Repository: testsuite Description --- This is a modified version of the normal call pickup test which uses chan_pjsip instead of chan_sip to test call pickup functionality. Diffs - /asterisk/trunk/tests/channels/pjsip/call_pickup/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast2/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast2/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/features.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3479/diff/ Testing --- I tested the test by running the test. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3479: chan_pjsip: Call pickup test.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3479/ --- (Updated May 1, 2014, 7:34 a.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Changes --- Committed in revision 5007 Repository: testsuite Description --- This is a modified version of the normal call pickup test which uses chan_pjsip instead of chan_sip to test call pickup functionality. Diffs - /asterisk/trunk/tests/channels/pjsip/call_pickup/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast2/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast2/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/features.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3479/diff/ Testing --- I tested the test by running the test. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3479: chan_pjsip: Call pickup test.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3479/ --- (Updated April 29, 2014, 11:29 a.m.) Review request for Asterisk Developers. Changes --- Incorporate some further feedback Repository: testsuite Description --- This is a modified version of the normal call pickup test which uses chan_pjsip instead of chan_sip to test call pickup functionality. Diffs (updated) - /asterisk/trunk/tests/channels/pjsip/call_pickup/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast2/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast2/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/features.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3479/diff/ Testing --- I tested the test by running the test. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3479: chan_pjsip: Call pickup test.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3479/#review11763 --- /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test https://reviewboard.asterisk.org/r/3479/#comment21569 You shouldn't need this import anymore /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test https://reviewboard.asterisk.org/r/3479/#comment21570 You should be able to remove this entire method - Matt Jordan On April 26, 2014, 5:57 a.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3479/ --- (Updated April 26, 2014, 5:57 a.m.) Review request for Asterisk Developers. Repository: testsuite Description --- This is a modified version of the normal call pickup test which uses chan_pjsip instead of chan_sip to test call pickup functionality. Diffs - /asterisk/trunk/tests/channels/pjsip/call_pickup/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast2/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast2/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/features.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3479/diff/ Testing --- I tested the test by running the test. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3479: chan_pjsip: Call pickup test.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3479/ --- (Updated April 26, 2014, 10:57 a.m.) Review request for Asterisk Developers. Changes --- Incorporated feedback from Matt. Repository: testsuite Description --- This is a modified version of the normal call pickup test which uses chan_pjsip instead of chan_sip to test call pickup functionality. Diffs (updated) - /asterisk/trunk/tests/channels/pjsip/call_pickup/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast2/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast2/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/features.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3479/diff/ Testing --- I tested the test by running the test. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3479: chan_pjsip: Call pickup test.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3479/#review11742 --- /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test https://reviewboard.asterisk.org/r/3479/#comment21536 2014 /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test https://reviewboard.asterisk.org/r/3479/#comment21535 Are you sure you're Jonathan Rose? /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test https://reviewboard.asterisk.org/r/3479/#comment21543 These are always used as regular expressions. Why not just compile them here and use them as such everywhere else? /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test https://reviewboard.asterisk.org/r/3479/#comment21537 Since this is using PJSIP, there's no need to support previous versions of Asterisk. Just the bridging model for 12 is sufficient. /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test https://reviewboard.asterisk.org/r/3479/#comment21540 And just use 12 here as well /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test https://reviewboard.asterisk.org/r/3479/#comment21541 No spaces between parameters and their values: channel=Local/test_out@pickuptest /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test https://reviewboard.asterisk.org/r/3479/#comment21538 Just use the Asterisk 12 logic /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test https://reviewboard.asterisk.org/r/3479/#comment21539 PEP8 Guidelines: no spaces between equals in parameters passed to a function. You may want to pass this through pylint to catch anything else as well. /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test https://reviewboard.asterisk.org/r/3479/#comment21542 Why is the Local channel shouting at me? :-) - Matt Jordan On April 25, 2014, 8:05 a.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3479/ --- (Updated April 25, 2014, 8:05 a.m.) Review request for Asterisk Developers. Repository: testsuite Description --- This is a modified version of the normal call pickup test which uses chan_pjsip instead of chan_sip to test call pickup functionality. Diffs - /asterisk/trunk/tests/channels/pjsip/call_pickup/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast2/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast2/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/features.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3479/diff/ Testing --- I tested the test by running the test. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev