Re: [asterisk-dev] [Code Review] 3883: Testsuite: RLS tests - Lists containing lists tests for MWI
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3883/ --- (Updated Aug. 28, 2014, 4:57 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers and Mark Michelson. Changes --- Committed in revision 5528 Bugs: ASTERISK-23872 https://issues.asterisk.org/jira/browse/ASTERISK-23872 Repository: testsuite Description --- Similar to the MWI tests in https://reviewboard.asterisk.org/r/3875/ The main set of tests follows operations against the following list setup: subscription to mail_list mail_list: carol (MWI), mail_sublist (list) mail_sublist: alice (MWI), bob (MWI) This setup is tested against the following: subscription_establishment: Uses sipp to check that a subscription can successfully be established (only evaluates SIP traffic to and from Asterisk, not concerned with NOTIFY contents) initial_notify: Verifies that a NOTIFY is received after subscribing and that it contains all of the expected elements full_state_alice: After receiving the initial notify, Alice's mailbox state is changed. The following NOTIFY is checked to confirm that it contains full state for all items in mail_list (which includes state information for mail_sublist items as well) full_state_carol: As with full_state_alice, only Carol's mailbox state is changed instead. partial_state_alice: As with full_state_alice, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include mail_sublist and mail_sublist should only include alice. partial_state_carol: As with full_state_carol, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include carol and not the mail_sublist. resubscribe_full_state: After the initial notify, The sipp client resubscribes to the list. We expect to receive full state information even though the individual lists are set to give partial state information on updates. termation_full_state: After the initial notify, the sipp client terminates the subscription. We expect to receive full state information even though the individual lists are set to give partial state information on updates and also we expect the state of each list entry to be terminated since we are unsubscribing. Diffs - /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/sipp/termination.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/sipp/resubscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_alice/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_alice/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_alice/configs/ast1/pjsip.conf PRE-CREATION
Re: [asterisk-dev] [Code Review] 3883: Testsuite: RLS tests - Lists containing lists tests for MWI
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3883/ --- (Updated Aug. 27, 2014, 11:55 a.m.) Review request for Asterisk Developers and Mark Michelson. Changes --- Addresses comment from review for RLS lists of presence: -bpf-filter: 'udp port 5061' -register-observer: True -debug-packets: True -device: 'lo' for all tests. Bugs: ASTERISK-23872 https://issues.asterisk.org/jira/browse/ASTERISK-23872 Repository: testsuite Description --- Similar to the MWI tests in https://reviewboard.asterisk.org/r/3875/ The main set of tests follows operations against the following list setup: subscription to mail_list mail_list: carol (MWI), mail_sublist (list) mail_sublist: alice (MWI), bob (MWI) This setup is tested against the following: subscription_establishment: Uses sipp to check that a subscription can successfully be established (only evaluates SIP traffic to and from Asterisk, not concerned with NOTIFY contents) initial_notify: Verifies that a NOTIFY is received after subscribing and that it contains all of the expected elements full_state_alice: After receiving the initial notify, Alice's mailbox state is changed. The following NOTIFY is checked to confirm that it contains full state for all items in mail_list (which includes state information for mail_sublist items as well) full_state_carol: As with full_state_alice, only Carol's mailbox state is changed instead. partial_state_alice: As with full_state_alice, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include mail_sublist and mail_sublist should only include alice. partial_state_carol: As with full_state_carol, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include carol and not the mail_sublist. resubscribe_full_state: After the initial notify, The sipp client resubscribes to the list. We expect to receive full state information even though the individual lists are set to give partial state information on updates. termation_full_state: After the initial notify, the sipp client terminates the subscription. We expect to receive full state information even though the individual lists are set to give partial state information on updates and also we expect the state of each list entry to be terminated since we are unsubscribing. Diffs (updated) - /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/sipp/termination.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/sipp/resubscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_alice/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_alice/sipp/list_subscribe.xml PRE-CREATION
Re: [asterisk-dev] [Code Review] 3883: Testsuite: RLS tests - Lists containing lists tests for MWI
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3883/#review13193 --- Ship it! Ship It! - Matt Jordan On Aug. 27, 2014, 11:55 a.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3883/ --- (Updated Aug. 27, 2014, 11:55 a.m.) Review request for Asterisk Developers and Mark Michelson. Bugs: ASTERISK-23872 https://issues.asterisk.org/jira/browse/ASTERISK-23872 Repository: testsuite Description --- Similar to the MWI tests in https://reviewboard.asterisk.org/r/3875/ The main set of tests follows operations against the following list setup: subscription to mail_list mail_list: carol (MWI), mail_sublist (list) mail_sublist: alice (MWI), bob (MWI) This setup is tested against the following: subscription_establishment: Uses sipp to check that a subscription can successfully be established (only evaluates SIP traffic to and from Asterisk, not concerned with NOTIFY contents) initial_notify: Verifies that a NOTIFY is received after subscribing and that it contains all of the expected elements full_state_alice: After receiving the initial notify, Alice's mailbox state is changed. The following NOTIFY is checked to confirm that it contains full state for all items in mail_list (which includes state information for mail_sublist items as well) full_state_carol: As with full_state_alice, only Carol's mailbox state is changed instead. partial_state_alice: As with full_state_alice, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include mail_sublist and mail_sublist should only include alice. partial_state_carol: As with full_state_carol, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include carol and not the mail_sublist. resubscribe_full_state: After the initial notify, The sipp client resubscribes to the list. We expect to receive full state information even though the individual lists are set to give partial state information on updates. termation_full_state: After the initial notify, the sipp client terminates the subscription. We expect to receive full state information even though the individual lists are set to give partial state information on updates and also we expect the state of each list entry to be terminated since we are unsubscribing. Diffs - /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/sipp/termination.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/sipp/resubscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_alice/test-config.yaml PRE-CREATION
Re: [asterisk-dev] [Code Review] 3883: Testsuite: RLS tests - Lists containing lists tests for MWI
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3883/ --- (Updated Aug. 7, 2014, 2:21 p.m.) Review request for Asterisk Developers and Mark Michelson. Changes --- All nominal tests are now ran out of rls_test.py (in the tests/channels/pjsip/subscriptions/rls folder) and no longer have their own .py files to execute the tests. This means all of the test parameters are now specified in the yaml files. Yay refactoring. Bugs: ASTERISK-23872 https://issues.asterisk.org/jira/browse/ASTERISK-23872 Repository: testsuite Description --- Similar to the MWI tests in https://reviewboard.asterisk.org/r/3875/ The main set of tests follows operations against the following list setup: subscription to mail_list mail_list: carol (MWI), mail_sublist (list) mail_sublist: alice (MWI), bob (MWI) This setup is tested against the following: subscription_establishment: Uses sipp to check that a subscription can successfully be established (only evaluates SIP traffic to and from Asterisk, not concerned with NOTIFY contents) initial_notify: Verifies that a NOTIFY is received after subscribing and that it contains all of the expected elements full_state_alice: After receiving the initial notify, Alice's mailbox state is changed. The following NOTIFY is checked to confirm that it contains full state for all items in mail_list (which includes state information for mail_sublist items as well) full_state_carol: As with full_state_alice, only Carol's mailbox state is changed instead. partial_state_alice: As with full_state_alice, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include mail_sublist and mail_sublist should only include alice. partial_state_carol: As with full_state_carol, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include carol and not the mail_sublist. resubscribe_full_state: After the initial notify, The sipp client resubscribes to the list. We expect to receive full state information even though the individual lists are set to give partial state information on updates. termation_full_state: After the initial notify, the sipp client terminates the subscription. We expect to receive full state information even though the individual lists are set to give partial state information on updates and also we expect the state of each list entry to be terminated since we are unsubscribing. Diffs (updated) - /asterisk/trunk/tests/channels/pjsip/subscriptions/tests.yaml 5385 /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/rls_test.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/rls_integrity.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/sipp/termination.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/resubscribe_full_state/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/resubscribe_full_state/sipp/resubscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/resubscribe_full_state/configs/ast1/pjsip.conf PRE-CREATION
Re: [asterisk-dev] [Code Review] 3883: Testsuite: RLS tests - Lists containing lists tests for MWI
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3883/#review13051 --- Crap, I put the diff on the wrong review... - Jonathan Rose On Aug. 7, 2014, 2:21 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3883/ --- (Updated Aug. 7, 2014, 2:21 p.m.) Review request for Asterisk Developers and Mark Michelson. Bugs: ASTERISK-23872 https://issues.asterisk.org/jira/browse/ASTERISK-23872 Repository: testsuite Description --- Similar to the MWI tests in https://reviewboard.asterisk.org/r/3875/ The main set of tests follows operations against the following list setup: subscription to mail_list mail_list: carol (MWI), mail_sublist (list) mail_sublist: alice (MWI), bob (MWI) This setup is tested against the following: subscription_establishment: Uses sipp to check that a subscription can successfully be established (only evaluates SIP traffic to and from Asterisk, not concerned with NOTIFY contents) initial_notify: Verifies that a NOTIFY is received after subscribing and that it contains all of the expected elements full_state_alice: After receiving the initial notify, Alice's mailbox state is changed. The following NOTIFY is checked to confirm that it contains full state for all items in mail_list (which includes state information for mail_sublist items as well) full_state_carol: As with full_state_alice, only Carol's mailbox state is changed instead. partial_state_alice: As with full_state_alice, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include mail_sublist and mail_sublist should only include alice. partial_state_carol: As with full_state_carol, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include carol and not the mail_sublist. resubscribe_full_state: After the initial notify, The sipp client resubscribes to the list. We expect to receive full state information even though the individual lists are set to give partial state information on updates. termation_full_state: After the initial notify, the sipp client terminates the subscription. We expect to receive full state information even though the individual lists are set to give partial state information on updates and also we expect the state of each list entry to be terminated since we are unsubscribing. Diffs - /asterisk/trunk/tests/channels/pjsip/subscriptions/tests.yaml 5385 /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/rls_test.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/rls_integrity.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/sipp/termination.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/resubscribe_full_state/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/resubscribe_full_state/sipp/resubscribe.xml PRE-CREATION
Re: [asterisk-dev] [Code Review] 3883: Testsuite: RLS tests - Lists containing lists tests for MWI
On Aug. 7, 2014, 2:23 p.m., Jonathan Rose wrote: Crap, I put the diff on the wrong review... Ignore this one until I put a new diff up. - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3883/#review13051 --- On Aug. 7, 2014, 2:21 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3883/ --- (Updated Aug. 7, 2014, 2:21 p.m.) Review request for Asterisk Developers and Mark Michelson. Bugs: ASTERISK-23872 https://issues.asterisk.org/jira/browse/ASTERISK-23872 Repository: testsuite Description --- Similar to the MWI tests in https://reviewboard.asterisk.org/r/3875/ The main set of tests follows operations against the following list setup: subscription to mail_list mail_list: carol (MWI), mail_sublist (list) mail_sublist: alice (MWI), bob (MWI) This setup is tested against the following: subscription_establishment: Uses sipp to check that a subscription can successfully be established (only evaluates SIP traffic to and from Asterisk, not concerned with NOTIFY contents) initial_notify: Verifies that a NOTIFY is received after subscribing and that it contains all of the expected elements full_state_alice: After receiving the initial notify, Alice's mailbox state is changed. The following NOTIFY is checked to confirm that it contains full state for all items in mail_list (which includes state information for mail_sublist items as well) full_state_carol: As with full_state_alice, only Carol's mailbox state is changed instead. partial_state_alice: As with full_state_alice, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include mail_sublist and mail_sublist should only include alice. partial_state_carol: As with full_state_carol, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include carol and not the mail_sublist. resubscribe_full_state: After the initial notify, The sipp client resubscribes to the list. We expect to receive full state information even though the individual lists are set to give partial state information on updates. termation_full_state: After the initial notify, the sipp client terminates the subscription. We expect to receive full state information even though the individual lists are set to give partial state information on updates and also we expect the state of each list entry to be terminated since we are unsubscribing. Diffs - /asterisk/trunk/tests/channels/pjsip/subscriptions/tests.yaml 5385 /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/rls_test.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/rls_integrity.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/sipp/termination.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/resubscribe_full_state/test-config.yaml PRE-CREATION
Re: [asterisk-dev] [Code Review] 3883: Testsuite: RLS tests - Lists containing lists tests for MWI
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3883/ --- (Updated Aug. 7, 2014, 4:06 p.m.) Review request for Asterisk Developers and Mark Michelson. Changes --- Update to use rls_test.py and remove python code from individual tests. Bugs: ASTERISK-23872 https://issues.asterisk.org/jira/browse/ASTERISK-23872 Repository: testsuite Description --- Similar to the MWI tests in https://reviewboard.asterisk.org/r/3875/ The main set of tests follows operations against the following list setup: subscription to mail_list mail_list: carol (MWI), mail_sublist (list) mail_sublist: alice (MWI), bob (MWI) This setup is tested against the following: subscription_establishment: Uses sipp to check that a subscription can successfully be established (only evaluates SIP traffic to and from Asterisk, not concerned with NOTIFY contents) initial_notify: Verifies that a NOTIFY is received after subscribing and that it contains all of the expected elements full_state_alice: After receiving the initial notify, Alice's mailbox state is changed. The following NOTIFY is checked to confirm that it contains full state for all items in mail_list (which includes state information for mail_sublist items as well) full_state_carol: As with full_state_alice, only Carol's mailbox state is changed instead. partial_state_alice: As with full_state_alice, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include mail_sublist and mail_sublist should only include alice. partial_state_carol: As with full_state_carol, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include carol and not the mail_sublist. resubscribe_full_state: After the initial notify, The sipp client resubscribes to the list. We expect to receive full state information even though the individual lists are set to give partial state information on updates. termation_full_state: After the initial notify, the sipp client terminates the subscription. We expect to receive full state information even though the individual lists are set to give partial state information on updates and also we expect the state of each list entry to be terminated since we are unsubscribing. Diffs (updated) - /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/sipp/termination.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/sipp/resubscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_alice/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_alice/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_alice/configs/ast1/pjsip.conf PRE-CREATION
Re: [asterisk-dev] [Code Review] 3883: Testsuite: RLS tests - Lists containing lists tests for MWI
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3883/ --- (Updated Aug. 7, 2014, 4:24 p.m.) Review request for Asterisk Developers and Mark Michelson. Changes --- Add dependency on 3873 -- that review is required for the rest to go in. Bugs: ASTERISK-23872 https://issues.asterisk.org/jira/browse/ASTERISK-23872 Repository: testsuite Description --- Similar to the MWI tests in https://reviewboard.asterisk.org/r/3875/ The main set of tests follows operations against the following list setup: subscription to mail_list mail_list: carol (MWI), mail_sublist (list) mail_sublist: alice (MWI), bob (MWI) This setup is tested against the following: subscription_establishment: Uses sipp to check that a subscription can successfully be established (only evaluates SIP traffic to and from Asterisk, not concerned with NOTIFY contents) initial_notify: Verifies that a NOTIFY is received after subscribing and that it contains all of the expected elements full_state_alice: After receiving the initial notify, Alice's mailbox state is changed. The following NOTIFY is checked to confirm that it contains full state for all items in mail_list (which includes state information for mail_sublist items as well) full_state_carol: As with full_state_alice, only Carol's mailbox state is changed instead. partial_state_alice: As with full_state_alice, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include mail_sublist and mail_sublist should only include alice. partial_state_carol: As with full_state_carol, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include carol and not the mail_sublist. resubscribe_full_state: After the initial notify, The sipp client resubscribes to the list. We expect to receive full state information even though the individual lists are set to give partial state information on updates. termation_full_state: After the initial notify, the sipp client terminates the subscription. We expect to receive full state information even though the individual lists are set to give partial state information on updates and also we expect the state of each list entry to be terminated since we are unsubscribing. Diffs - /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/sipp/termination.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/sipp/resubscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_alice/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_alice/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_alice/configs/ast1/pjsip.conf PRE-CREATION
Re: [asterisk-dev] [Code Review] 3883: Testsuite: RLS tests - Lists containing lists tests for MWI
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3883/#review13021 --- As a side note, all these IntegrityCheck classes are nearly identical except for degenerate cases where sending the AMI message is not necessary or you only expect one version of the notify. They are also highly similar to the IntegrityCheck classes used in your three other RLS test reviews. If you choose not to move them into a common class, you can probably assume that any findings on the IntegrityCheck class apply across all four reviews for all tests in those reviews. /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/full_state_alice/full_state.py https://reviewboard.asterisk.org/r/3883/#comment23442 This is missing a docstring. - opticron On Aug. 1, 2014, 5:46 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3883/ --- (Updated Aug. 1, 2014, 5:46 p.m.) Review request for Asterisk Developers and Mark Michelson. Bugs: ASTERISK-23872 https://issues.asterisk.org/jira/browse/ASTERISK-23872 Repository: testsuite Description --- Similar to the MWI tests in https://reviewboard.asterisk.org/r/3875/ The main set of tests follows operations against the following list setup: subscription to mail_list mail_list: carol (MWI), mail_sublist (list) mail_sublist: alice (MWI), bob (MWI) This setup is tested against the following: subscription_establishment: Uses sipp to check that a subscription can successfully be established (only evaluates SIP traffic to and from Asterisk, not concerned with NOTIFY contents) initial_notify: Verifies that a NOTIFY is received after subscribing and that it contains all of the expected elements full_state_alice: After receiving the initial notify, Alice's mailbox state is changed. The following NOTIFY is checked to confirm that it contains full state for all items in mail_list (which includes state information for mail_sublist items as well) full_state_carol: As with full_state_alice, only Carol's mailbox state is changed instead. partial_state_alice: As with full_state_alice, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include mail_sublist and mail_sublist should only include alice. partial_state_carol: As with full_state_carol, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include carol and not the mail_sublist. resubscribe_full_state: After the initial notify, The sipp client resubscribes to the list. We expect to receive full state information even though the individual lists are set to give partial state information on updates. termation_full_state: After the initial notify, the sipp client terminates the subscription. We expect to receive full state information even though the individual lists are set to give partial state information on updates and also we expect the state of each list entry to be terminated since we are unsubscribing. Diffs - /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/termination.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/sipp/termination.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/test-config.yaml PRE-CREATION
Re: [asterisk-dev] [Code Review] 3883: Testsuite: RLS tests - Lists containing lists tests for MWI
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3883/ --- (Updated Aug. 1, 2014, 5:46 p.m.) Review request for Asterisk Developers and Mark Michelson. Changes --- Use reactor.callLater to schedule mailbox changes. Also I think I had one of the alice/carol tests backwards in terms of expectations in the last version. Bugs: ASTERISK-23872 https://issues.asterisk.org/jira/browse/ASTERISK-23872 Repository: testsuite Description --- Similar to the MWI tests in https://reviewboard.asterisk.org/r/3875/ The main set of tests follows operations against the following list setup: subscription to mail_list mail_list: carol (MWI), mail_sublist (list) mail_sublist: alice (MWI), bob (MWI) This setup is tested against the following: subscription_establishment: Uses sipp to check that a subscription can successfully be established (only evaluates SIP traffic to and from Asterisk, not concerned with NOTIFY contents) initial_notify: Verifies that a NOTIFY is received after subscribing and that it contains all of the expected elements full_state_alice: After receiving the initial notify, Alice's mailbox state is changed. The following NOTIFY is checked to confirm that it contains full state for all items in mail_list (which includes state information for mail_sublist items as well) full_state_carol: As with full_state_alice, only Carol's mailbox state is changed instead. partial_state_alice: As with full_state_alice, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include mail_sublist and mail_sublist should only include alice. partial_state_carol: As with full_state_carol, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include carol and not the mail_sublist. resubscribe_full_state: After the initial notify, The sipp client resubscribes to the list. We expect to receive full state information even though the individual lists are set to give partial state information on updates. termation_full_state: After the initial notify, the sipp client terminates the subscription. We expect to receive full state information even though the individual lists are set to give partial state information on updates and also we expect the state of each list entry to be terminated since we are unsubscribing. Diffs (updated) - /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/termination.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/sipp/termination.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/sipp/resubscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/resubscribe.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/sipp/list_subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/partial_state.py PRE-CREATION
