Re: [asterisk-dev] Scope Trace: Often no CR on CLI?

2020-12-10 Thread George Joseph 
On Thu, Dec 10, 2020 at 6:45 AM George Joseph  wrote:

>
>
> On Thu, Dec 10, 2020 at 3:48 AM Alexander Traud 
> wrote:
>
>> Thanks for clarifying that this should work. Let me start GDB ... the
>> problem is ast_debug(.) with SCOPE_EXIT_RTN_VALUE(0) in
>> channels/chan_pjsip.c:2594, for example. Then, ast_debug(.) is called just
>> with a space which is not stripped. Consequently, the cause is <
>> https://gerrit.asterisk.org/14783>. Not sure what was intended.
>>
>>
> Ah, the debug output.  I get it now.  I'll take a look.
>

I opened https://issues.asterisk.org/jira/browse/ASTERISK-29209 on your
behalf and pushed up a review that should fix the issue.  Give it a try.
https://gerrit.asterisk.org/c/asterisk/+/15211



>
>
>>
>>
>> --
>> _
>> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>>
>> asterisk-dev mailing list
>> To UNSUBSCRIBE or update options visit:
>>http://lists.digium.com/mailman/listinfo/asterisk-dev
>
>
>
> --
> George Joseph
> Asterisk Software Developer
> direct/fax +1 256 428 6012
> Check us out at www.sangoma.com and www.asterisk.org
> [image: image.png]
>


-- 
George Joseph
Asterisk Software Developer
direct/fax +1 256 428 6012
Check us out at www.sangoma.com and www.asterisk.org
[image: image.png]
-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] Scope Trace: Often no CR on CLI?

2020-12-10 Thread George Joseph 
On Thu, Dec 10, 2020 at 3:48 AM Alexander Traud 
wrote:

> Thanks for clarifying that this should work. Let me start GDB ... the
> problem is ast_debug(.) with SCOPE_EXIT_RTN_VALUE(0) in
> channels/chan_pjsip.c:2594, for example. Then, ast_debug(.) is called just
> with a space which is not stripped. Consequently, the cause is <
> https://gerrit.asterisk.org/14783>. Not sure what was intended.
>
>
Ah, the debug output.  I get it now.  I'll take a look.


>
>
> --
> _
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>http://lists.digium.com/mailman/listinfo/asterisk-dev



-- 
George Joseph
Asterisk Software Developer
direct/fax +1 256 428 6012
Check us out at www.sangoma.com and www.asterisk.org
[image: image.png]
-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] Scope Trace: Often no CR on CLI?

2020-12-10 Thread Alexander Traud 
Thanks for clarifying that this should work. Let me start GDB ... the problem 
is ast_debug(.) with SCOPE_EXIT_RTN_VALUE(0) in channels/chan_pjsip.c:2594, for 
example. Then, ast_debug(.) is called just with a space which is not stripped. 
Consequently, the cause is . Not sure what 
was intended.



-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] Scope Trace: Often no CR on CLI?

2020-12-09 Thread George Joseph 
On Wed, Dec 9, 2020 at 12:11 PM George Joseph  wrote:

>
>
> On Wed, Dec 9, 2020 at 11:09 AM Alexander Traud 
> wrote:
>
>> Currently, I debug something with the new Scope Tracing [1][2] on the
>> Command-Line Interface (CLI) within GDB. Six of the printed messages did
>> not wrap to a new line. In all cases, SCOPE_ did not include a message, and
>> therefore no trailing "\n". With a Regular Expression, I found 32 calls
>> that do not have a "\n". Apparently, Scope Tracing was not intended to be
>> used on the CLI. Which logger(s) are supported?
>>
>>
> All loggers should be supported.  I probably just missed the case of no
> message.  I can fix that real quick.
>

Actually, I just looked at the code and it's there already...
logger,c:2415
ast_str_set(, 0, "%2d %-.*s%s%s:%d %s: %s", (int)indent, (indent_type
== AST_TRACE_INDENT_NONE ? 0 : (int)(indent * 4)),
LOTS_O_SPACES, direction, file, line, func,
S_OR(ast_skip_blanks(format), "\n"));

Which branch/commit are you testing?



>
>
>> [1] 
>> [2] 
>>
>>
>>
>> --
>> _
>> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>>
>> asterisk-dev mailing list
>> To UNSUBSCRIBE or update options visit:
>>http://lists.digium.com/mailman/listinfo/asterisk-dev
>
>
>
> --
> George Joseph
> Asterisk Software Developer
> direct/fax +1 256 428 6012
> Check us out at www.sangoma.com and www.asterisk.org
> [image: image.png]
>


-- 
George Joseph
Asterisk Software Developer
direct/fax +1 256 428 6012
Check us out at www.sangoma.com and www.asterisk.org
[image: image.png]
-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] Scope Trace: Often no CR on CLI?

2020-12-09 Thread George Joseph 
On Wed, Dec 9, 2020 at 11:09 AM Alexander Traud 
wrote:

> Currently, I debug something with the new Scope Tracing [1][2] on the
> Command-Line Interface (CLI) within GDB. Six of the printed messages did
> not wrap to a new line. In all cases, SCOPE_ did not include a message, and
> therefore no trailing "\n". With a Regular Expression, I found 32 calls
> that do not have a "\n". Apparently, Scope Tracing was not intended to be
> used on the CLI. Which logger(s) are supported?
>
>
All loggers should be supported.  I probably just missed the case of no
message.  I can fix that real quick.



> [1] 
> [2] 
>
>
>
> --
> _
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>http://lists.digium.com/mailman/listinfo/asterisk-dev



-- 
George Joseph
Asterisk Software Developer
direct/fax +1 256 428 6012
Check us out at www.sangoma.com and www.asterisk.org
[image: image.png]
-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev