[Asterisk-Users] AGI and broken pipe
Hi All, I was able to track down what I believe is a bug when using AGI services. This bug may crash your system if your extensions.conf script is intensive in using AGI services. Depending on your system's ulimit, * keeps opening files until it reaches the system limit and then stops responding. Function app_agi/launch_script seems to leave an open and unused file. Can someone confirm this? Below is a patch that solves the problem. Index: asterisk/apps/app_agi.c === RCS file: /usr/cvsroot/asterisk/apps/app_agi.c,v retrieving revision 1.22 diff -u -r1.22 app_agi.c --- asterisk/apps/app_agi.c 5 Nov 2003 23:43:31 - 1.22 +++ asterisk/apps/app_agi.c 18 Dec 2003 13:48:38 - @@ -167,6 +167,10 @@ /* close what we're not using in the parent */ close(toast[1]); close(fromast[0]); + + // [PHM 12/18/03] + close(audio[0]) + *opid = pid; return 0; ___ Asterisk-Users mailing list [EMAIL PROTECTED] http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [Asterisk-Users] AGI and broken pipe
On Thu, 18 Dec 2003 11:48:59 -0300 Paulo Mannheimer [EMAIL PROTECTED] wrote: Hi All, I was able to track down what I believe is a bug when using AGI services. This bug may crash your system if your extensions.conf script is intensive in using AGI services. Depending on your system's ulimit, * keeps opening files until it reaches the system limit and then stops responding. Function app_agi/launch_script seems to leave an open and unused file. Can someone confirm this? Below is a patch that solves the problem. Thanks Paulo, I've patched the app_agi.c and now asterisk with EAGI applications is not leaking pipes anymore :-) Angel Index: asterisk/apps/app_agi.c === RCS file: /usr/cvsroot/asterisk/apps/app_agi.c,v retrieving revision 1.22 diff -u -r1.22 app_agi.c --- asterisk/apps/app_agi.c 5 Nov 2003 23:43:31 - 1.22 +++ asterisk/apps/app_agi.c 18 Dec 2003 13:48:38 - @@ -167,6 +167,10 @@ /* close what we're not using in the parent */ close(toast[1]); close(fromast[0]); + + // [PHM 12/18/03] + close(audio[0]) + *opid = pid; return 0; ___ Asterisk-Users mailing list [EMAIL PROTECTED] http://lists.digium.com/mailman/listinfo/asterisk-users ___ Asterisk-Users mailing list [EMAIL PROTECTED] http://lists.digium.com/mailman/listinfo/asterisk-users
RE: [Asterisk-Users] AGI and broken pipe
Great ;-) Can someone else confirm this doesn't have any side effects besides solving the problem? -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Angel Carpintero Sent: quinta-feira, 18 de dezembro de 2003 12:24 To: [EMAIL PROTECTED] Subject: Re: [Asterisk-Users] AGI and broken pipe On Thu, 18 Dec 2003 11:48:59 -0300 Paulo Mannheimer [EMAIL PROTECTED] wrote: Hi All, I was able to track down what I believe is a bug when using AGI services. This bug may crash your system if your extensions.conf script is intensive in using AGI services. Depending on your system's ulimit, * keeps opening files until it reaches the system limit and then stops responding. Function app_agi/launch_script seems to leave an open and unused file. Can someone confirm this? Below is a patch that solves the problem. Thanks Paulo, I've patched the app_agi.c and now asterisk with EAGI applications is not leaking pipes anymore :-) Angel Index: asterisk/apps/app_agi.c === RCS file: /usr/cvsroot/asterisk/apps/app_agi.c,v retrieving revision 1.22 diff -u -r1.22 app_agi.c --- asterisk/apps/app_agi.c 5 Nov 2003 23:43:31 - 1.22 +++ asterisk/apps/app_agi.c 18 Dec 2003 13:48:38 - @@ -167,6 +167,10 @@ /* close what we're not using in the parent */ close(toast[1]); close(fromast[0]); + + // [PHM 12/18/03] + close(audio[0]) + *opid = pid; return 0; ___ Asterisk-Users mailing list [EMAIL PROTECTED] http://lists.digium.com/mailman/listinfo/asterisk-users ___ Asterisk-Users mailing list [EMAIL PROTECTED] http://lists.digium.com/mailman/listinfo/asterisk-users ___ Asterisk-Users mailing list [EMAIL PROTECTED] http://lists.digium.com/mailman/listinfo/asterisk-users
