Re: [asterisk-users] Are .call files working with extensions.ael ? bristuff problem

2009-03-16 Thread Olivier 
Hi,

As soon as I removed back line 266 as suggested by Peer Oliver, it worked.


Lines changed in /usr/src/bristuff-0.4.0-RC4-xr6/asterisk/pbx/pbx_spool.c :
/* Olivier
if (ast_strlen_zero(o-tech) || ast_strlen_zero(o-dest) ||
(ast_strlen_zero(o-app)  ast_strlen_zero(o-exten)) ||
(ast_strlen_zero(o-message)  ast_strlen_zero(o-pdu))) {
*/
if (ast_strlen_zero(o-tech) || ast_strlen_zero(o-dest) ||
(ast_strlen_zero(o-app)  ast_strlen_zero(o-exten))) {


Procedure used to update:
cd /usr/src/bristuff-0.4.0-RC4-xr6/asterisk/
make all
make install

File astup.call :
Channel: Sip/700
Context: mylocal
Extension: 00123457530
Priority: 1



Now, looking at removed line, it would say if both message and pdu are
empty, then print error message.
Question is now, is this a feature (ie you must either add a pdu or a
message (or both) in call files) or a bug ?

Regards

PS: I'll post the answer to Bristuff mailinglist as this must of interest
there ...
___
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users

Re: [asterisk-users] Are .call files working with extensions.ael ? bristuff problem

2009-03-12 Thread Peer Oliver Schmidt 
Olivier wrote:
 Do you by chance use bristuff?
 
 Yes, I do.

bristuff patches pbx/pbx_spool.c

I have no knowledge of C, but there seems to be a problem around line 
266.

The original line (pre-bristuff) looks like this:

if (ast_strlen_zero(o-tech) || ast_strlen_zero(o-dest) || 
(ast_strlen_zero(o-app)  ast_strlen_zero(o-exten))) {


The patched line looks like this:

if (ast_strlen_zero(o-tech) || ast_strlen_zero(o-dest) || 
(ast_strlen_zero(o-app)  ast_strlen_zero(o-exten)) || 
(ast_strlen_zero(o-message)  ast_strlen_zero(o-pdu))) {

Try reverting that line, and see if that helps with your problem. And 
maybe someone with a better understanding of C can take a look at the 
above problem.
-- 
Best regards

Peer Oliver Schmidt
PGP Key ID: 0x83E1C2EA


___
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users

Re: [asterisk-users] Are .call files working with extensions.ael ? bristuff problem

2009-03-12 Thread Mark Michelson 
Peer Oliver Schmidt wrote:
 Olivier wrote:
 Do you by chance use bristuff?
 Yes, I do.
 
 bristuff patches pbx/pbx_spool.c
 
 I have no knowledge of C, but there seems to be a problem around line 
 266.
 
 The original line (pre-bristuff) looks like this:
 
 if (ast_strlen_zero(o-tech) || ast_strlen_zero(o-dest) || 
 (ast_strlen_zero(o-app)  ast_strlen_zero(o-exten))) {
 
 
 The patched line looks like this:
 
 if (ast_strlen_zero(o-tech) || ast_strlen_zero(o-dest) || 
 (ast_strlen_zero(o-app)  ast_strlen_zero(o-exten)) || 
 (ast_strlen_zero(o-message)  ast_strlen_zero(o-pdu))) {
 
 Try reverting that line, and see if that helps with your problem. And 
 maybe someone with a better understanding of C can take a look at the 
 above problem.

Apparently bristuff has added new required parameters to call files. Basically, 
it has the same requirements as vanilla Asterisk (you must specify a full 
channel name and either an app or an extension) and it also requires that one 
of 
the message or pdu fields of the outgoing call are filled in. You may want 
to check bristuff documentation to figure out what these mean since they are 
not 
part of a regular Asterisk installation.

Mark Michelson

___
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users

Re: [asterisk-users] Are .call files working with extensions.ael ? bristuff problem

2009-03-12 Thread Tzafrir Cohen 
On Thu, Mar 12, 2009 at 10:18:22AM -0500, Mark Michelson wrote:

 
 Apparently bristuff has added new required parameters to call files. 

Rather: a new optional parameter. When you initiate a call from a
channel it can also have either a 'message' or a 'pdo' message. 

Those are then passed along (eventually) to the new channel method
send_message. Which is a bit like send_text:

  res = chan-tech-send_message(chan, dest, text, ispdu);

This is part of the code to support the Junghanns GSM cards.

See
http://repo.or.cz/w/asterisk-bristuff.git?a=shortlog;h=refs/heads/bristuff-part-gsm

And specifically:

  
http://repo.or.cz/w/asterisk-bristuff.git?a=shortlog;h=refs/heads/bristuff-part-gsm
  
http://repo.or.cz/w/asterisk-bristuff.git?a=shortlog;h=refs/heads/bristuff-part-gsm
  
http://repo.or.cz/w/asterisk-bristuff.git?a=commit;h=6fb93cd5fc4506dda3eb0cfc3a5d5156b3ee7583
  
http://repo.or.cz/w/asterisk-bristuff.git?a=commit;h=fffd308c5c1fdce3fe43b2d1420cb7cfa3de9fde

/me needs to get that tree in shape.

-- 
   Tzafrir Cohen
icq#16849755  jabber:tzafrir.co...@xorcom.com
+972-50-7952406   mailto:tzafrir.co...@xorcom.com
http://www.xorcom.com  iax:gu...@local.xorcom.com/tzafrir

___
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users

Re: [asterisk-users] Are .call files working with extensions.ael ? bristuff problem

2009-03-12 Thread Olivier 
2009/3/12 Tzafrir Cohen tzafrir.co...@xorcom.com

 On Thu, Mar 12, 2009 at 10:18:22AM -0500, Mark Michelson wrote:

 
  Apparently bristuff has added new required parameters to call files.

 Rather: a new optional parameter. When you initiate a call from a
 channel it can also have either a 'message' or a 'pdo' message.


Maybe this parameter is optional but here, the fact is I can't find a way to
write any single call file accepted by Bristuff.

If someone have a working Bristuff-compliant example, I would be happy to
test it in my Bristuff setup and report to the list if the troubles I met
came from by ignorance (likely) or a bug (unlikely).
I'll also test early next week the example given in the original thread.

At this moment, we know there's Bristuff patch enhancing .call files but
we're still wondering if there's a bug in it.

Regards



 Those are then passed along (eventually) to the new channel method
 send_message. Which is a bit like send_text:

  res = chan-tech-send_message(chan, dest, text, ispdu);

 This is part of the code to support the Junghanns GSM cards.

 See

 http://repo.or.cz/w/asterisk-bristuff.git?a=shortlog;h=refs/heads/bristuff-part-gsm

 And specifically:


 http://repo.or.cz/w/asterisk-bristuff.git?a=shortlog;h=refs/heads/bristuff-part-gsm

 http://repo.or.cz/w/asterisk-bristuff.git?a=shortlog;h=refs/heads/bristuff-part-gsm

 http://repo.or.cz/w/asterisk-bristuff.git?a=commit;h=6fb93cd5fc4506dda3eb0cfc3a5d5156b3ee7583

 http://repo.or.cz/w/asterisk-bristuff.git?a=commit;h=fffd308c5c1fdce3fe43b2d1420cb7cfa3de9fde

 /me needs to get that tree in shape.

 --
   Tzafrir Cohen
 icq#16849755  
 jabber:tzafrir.co...@xorcom.comjabber%3atzafrir.co...@xorcom.com
 +972-50-7952406   mailto:tzafrir.co...@xorcom.com
 http://www.xorcom.com  iax:gu...@local.xorcom.com/tzafrir

 ___
 -- Bandwidth and Colocation Provided by http://www.api-digital.com --

 asterisk-users mailing list
 To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users

___
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users