Re: [Asterisk-Users] BOUNTY: app_hangup from exten = h
On April 14, 2005 08:31 am, Eric Wieling wrote: This is a bounty for a patch to app_hangup.c to generate an error when Hangup is called from exten = h. You should not call Hangup from exten = h. I disagree; you should use Hangup() WHEREEVER you want to make absolutely sure the dialplan stops. If you do post-hangup processing that has some branching it's far simpler to simply Hangup at the various branches than to Goto(h,end,1). A lot neater, too. A warning perhaps, but it should not error out. -A. ___ Asterisk-Users mailing list Asterisk-Users@lists.digium.com http://lists.digium.com/mailman/listinfo/asterisk-users To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [Asterisk-Users] BOUNTY: app_hangup from exten = h
Andrew Kohlsmith wrote: On April 14, 2005 08:31 am, Eric Wieling wrote: This is a bounty for a patch to app_hangup.c to generate an error when Hangup is called from exten = h. You should not call Hangup from exten = h. I disagree; you should use Hangup() WHEREEVER you want to make absolutely sure the dialplan stops. If you do post-hangup processing that has some branching it's far simpler to simply Hangup at the various branches than to Goto(h,end,1). A lot neater, too. A warning perhaps, but it should not error out. exten = h will not be called unless the channel has ALREADY hung up. -- Always do right. This will gratify some people and astonish the rest. Mark Twain ___ Asterisk-Users mailing list Asterisk-Users@lists.digium.com http://lists.digium.com/mailman/listinfo/asterisk-users To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [Asterisk-Users] BOUNTY: app_hangup from exten = h
On April 14, 2005 09:42 am, Eric Wieling wrote: exten = h will not be called unless the channel has ALREADY hung up. I understand that, which is why I'm still suggesting a WARNING and not an error. Something like No need to execute Hangup from the h exten, line is already hung up -A. ___ Asterisk-Users mailing list Asterisk-Users@lists.digium.com http://lists.digium.com/mailman/listinfo/asterisk-users To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [Asterisk-Users] BOUNTY: app_hangup from exten = h
Andrew Kohlsmith wrote: On April 14, 2005 09:42 am, Eric Wieling wrote: exten = h will not be called unless the channel has ALREADY hung up. I understand that, which is why I'm still suggesting a WARNING and not an error. Something like No need to execute Hangup from the h exten, line is already hung up I would consider a NOTICE or WARNING OK. -- Always do right. This will gratify some people and astonish the rest. Mark Twain ___ Asterisk-Users mailing list Asterisk-Users@lists.digium.com http://lists.digium.com/mailman/listinfo/asterisk-users To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
