Re: [PATCH 1/4] cfg80211: Add support to enable or disable btcoex

[Tamizh chelvam]

Hi Johannes,

Thanks for the comments.

On 2016-12-05 20:16, Johannes Berg wrote:

On Tue, 2016-11-08 at 18:45 +0530, c_tr...@qti.qualcomm.com wrote:

From: Tamizh chelvam 

This patch adds support to enable or disable btcoex by
adding NL80211_ATTR_WIPHY_BTCOEX_ENABLE attribute in
NL80211_CMD_SET_WIPHY command. By default BTCOEX disabled in driver.


I think overloading SET_WIPHY even more is a mistake - why not group
this with the new command you're introducing in the second patch?


Sure.


Also, can have a flag attribute to enable/disable, or better even
disable when you're not setting any other parameters.


BTCOEX will be disabled by default. I will use 
NL80211_ATTR_WIPHY_BTCOEX_ENABLE

attribute to enable/disable BTCOEX.


___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH 1/4] cfg80211: Add support to enable or disable btcoex

[Johannes Berg]

On Tue, 2016-11-08 at 18:45 +0530, c_tr...@qti.qualcomm.com wrote:
> From: Tamizh chelvam 
> 
> This patch adds support to enable or disable btcoex by
> adding NL80211_ATTR_WIPHY_BTCOEX_ENABLE attribute in
> NL80211_CMD_SET_WIPHY command. By default BTCOEX disabled in driver.

I think overloading SET_WIPHY even more is a mistake - why not group
this with the new command you're introducing in the second patch?

Also, can have a flag attribute to enable/disable, or better even
disable when you're not setting any other parameters.

johannes

___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k