Re: [PATCH 1/7] mmc: sdio: store owner from modules with sdio_register_driver()
On 31/03/2024 22:37, Francesco Dolcini wrote:
> Hello Krzysztof,
>
> On Fri, Mar 29, 2024 at 06:24:31PM +0100, Krzysztof Kozlowski wrote:
>> Modules registering driver with sdio_register_driver() might
>> forget to set .owner field. The field is used by some of other kernel
> ^^ double space here
>
>> parts for reference counting (try_module_get()), so it is expected that
>> drivers will set it.
>>
>> Solve the problem by moving this task away from the drivers to the core
>> code, just like we did for platform_driver in
>> commit 9447057eaff8 ("platform_device: use a macro instead of
>> platform_driver_register").
>>
>> Since many drivers forget to set the .owner, this effectively will fix
>> them. Examples of fixed drivers are: ath6kl, b43, btsdio.c, ks7010,
>^^ and here
Which is correct :). Double space is on purpose.
>
>> libertas, MediaTek WiFi drivers, Realtek WiFi drivers, rsi, siano,
>> wilc1000, wl1251 and more.
>>
>> Signed-off-by: Krzysztof Kozlowski
>
> My nit comments are irrelevant, but given you did the same twice I felt
> like letting you know.
>
> Reviewed-by: Francesco Dolcini
>
Best regards,
Krzysztof
Re: [PATCH 1/7] mmc: sdio: store owner from modules with sdio_register_driver()
Hello Krzysztof,
On Fri, Mar 29, 2024 at 06:24:31PM +0100, Krzysztof Kozlowski wrote:
> Modules registering driver with sdio_register_driver() might
> forget to set .owner field. The field is used by some of other kernel
^^ double space here
> parts for reference counting (try_module_get()), so it is expected that
> drivers will set it.
>
> Solve the problem by moving this task away from the drivers to the core
> code, just like we did for platform_driver in
> commit 9447057eaff8 ("platform_device: use a macro instead of
> platform_driver_register").
>
> Since many drivers forget to set the .owner, this effectively will fix
> them. Examples of fixed drivers are: ath6kl, b43, btsdio.c, ks7010,
^^ and here
> libertas, MediaTek WiFi drivers, Realtek WiFi drivers, rsi, siano,
> wilc1000, wl1251 and more.
>
> Signed-off-by: Krzysztof Kozlowski
My nit comments are irrelevant, but given you did the same twice I felt
like letting you know.
Reviewed-by: Francesco Dolcini
