[kvalo-ath:ath-next] BUILD SUCCESS 2372c6d28032b8336fb41c2dfa9209936cd27452
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next branch HEAD: 2372c6d28032b8336fb41c2dfa9209936cd27452 wifi: ath12k: don't use %pK in dmesg format strings elapsed time: 921m configs tested: 128 configs skipped: 3 The following configs have been built successfully. More configs may be tested in the coming days. tested configs: alpha allnoconfig gcc alphaallyesconfig gcc alpha defconfig gcc arc allmodconfig gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20240419 gcc arc randconfig-002-20240419 gcc arm allmodconfig gcc arm allnoconfig clang arm allyesconfig gcc arm defconfig clang arm randconfig-001-20240419 gcc arm randconfig-002-20240419 clang arm randconfig-003-20240419 gcc arm randconfig-004-20240419 clang arm64allmodconfig clang arm64 allnoconfig gcc arm64 defconfig gcc arm64 randconfig-001-20240419 clang arm64 randconfig-002-20240419 clang arm64 randconfig-003-20240419 clang arm64 randconfig-004-20240419 clang csky allmodconfig gcc csky allnoconfig gcc csky allyesconfig gcc cskydefconfig gcc csky randconfig-001-20240419 gcc csky randconfig-002-20240419 gcc hexagon allmodconfig clang hexagon allnoconfig clang hexagon allyesconfig clang hexagon defconfig clang hexagon randconfig-001-20240419 clang hexagon randconfig-002-20240419 clang i386 allmodconfig gcc i386 allnoconfig gcc i386 allyesconfig gcc i386 buildonly-randconfig-001-20240419 clang i386 buildonly-randconfig-002-20240419 gcc i386 buildonly-randconfig-003-20240419 gcc i386 buildonly-randconfig-004-20240419 gcc i386 buildonly-randconfig-005-20240419 gcc i386 buildonly-randconfig-006-20240419 gcc i386defconfig clang i386 randconfig-001-20240419 clang i386 randconfig-002-20240419 clang i386 randconfig-003-20240419 clang i386 randconfig-004-20240419 gcc i386 randconfig-005-20240419 clang i386 randconfig-006-20240419 clang i386 randconfig-011-20240419 gcc i386 randconfig-012-20240419 clang i386 randconfig-013-20240419 gcc i386 randconfig-014-20240419 clang i386 randconfig-015-20240419 gcc i386 randconfig-016-20240419 clang loongarchallmodconfig gcc loongarch allnoconfig gcc loongarch defconfig gcc loongarch randconfig-001-20240419 gcc loongarch randconfig-002-20240419 gcc m68k allmodconfig gcc m68k allnoconfig gcc m68k allyesconfig gcc m68kdefconfig gcc microblaze allmodconfig gcc microblazeallnoconfig gcc microblaze allyesconfig gcc microblaze defconfig gcc mips allnoconfig gcc mips allyesconfig gcc nios2allmodconfig gcc nios2 allnoconfig gcc nios2allyesconfig gcc nios2 defconfig gcc nios2 randconfig-001-20240419 gcc nios2 randconfig-002-20240419 gcc openrisc allnoconfig gcc openrisc allyesconfig gcc openriscdefconfig gcc parisc allmodconfig gcc pariscallnoconfig gcc parisc allyesconfig gcc p
Re: [PATCH wireless] wifi: ath10k: Fix an error code problem in ath10k_dbg_sta_write_peer_debug_trigger()
On 4/17/2024 1:17 AM, Su Hui wrote:
> Clang Static Checker (scan-build) Warning:
> drivers/net/wireless/ath/ath10k/debugfs_sta.c:line 429, column 3
> Value stored to 'ret' is never read.
>
> Return 'ret' rather than 'count' when 'ret' stores an error code.
> By the way, remove some useless code.
>
> Fixes: ee8b08a1be82 ("ath10k: add debugfs support to get per peer tids log
> via tracing")
> Signed-off-by: Su Hui
> ---
> drivers/net/wireless/ath/ath10k/debugfs_sta.c | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/debugfs_sta.c
> b/drivers/net/wireless/ath/ath10k/debugfs_sta.c
> index 394bf3c32abf..5525dabe390a 100644
> --- a/drivers/net/wireless/ath/ath10k/debugfs_sta.c
> +++ b/drivers/net/wireless/ath/ath10k/debugfs_sta.c
> @@ -415,7 +415,7 @@ ath10k_dbg_sta_write_peer_debug_trigger(struct file *file,
> struct ath10k_sta *arsta = (struct ath10k_sta *)sta->drv_priv;
> struct ath10k *ar = arsta->arvif->ar;
> u8 peer_debug_trigger;
> - int ret;
> + int ret = 0;
this is unnecessary since this will be written in all paths that lead to the
return that reads it
>
> if (kstrtou8_from_user(user_buf, count, 0, &peer_debug_trigger))
> return -EINVAL;
> @@ -432,14 +432,12 @@ ath10k_dbg_sta_write_peer_debug_trigger(struct file
> *file,
>
> ret = ath10k_wmi_peer_set_param(ar, arsta->arvif->vdev_id, sta->addr,
> ar->wmi.peer_param->debug,
> peer_debug_trigger);
> - if (ret) {
> + if (ret)
> ath10k_warn(ar, "failed to set param to trigger peer tid logs
> for station ret: %d\n",
> ret);
> - goto out;
> - }
> out:
> mutex_unlock(&ar->conf_mutex);
> - return count;
> + return ret ?: count;
> }
>
> static const struct file_operations fops_peer_debug_trigger = {
I'd suggest as an alternate solution that this function is a good candidate
for the the cleanup.h functionality. By scoping the mutex_lock() you can
simply return at each error location, and remove the explicit mutex_unlock().
But I'd accept this with the initializer change removed as well since I don't
think ath10k has any cleanup.h usages yet.
/jeff
[kvalo-ath:master-pending] BUILD SUCCESS 0f3af12807666e3921214d6d7f3664a85535483d
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git master-pending branch HEAD: 0f3af12807666e3921214d6d7f3664a85535483d Merge branch 'pending' into master-pending elapsed time: 734m configs tested: 101 configs skipped: 3 The following configs have been built successfully. More configs may be tested in the coming days. tested configs: alpha allnoconfig gcc alphaallyesconfig gcc alpha defconfig gcc arc allmodconfig gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arm allmodconfig gcc arm allnoconfig clang arm allyesconfig gcc arm defconfig clang arm64allmodconfig clang arm64 allnoconfig gcc arm64 defconfig gcc csky allmodconfig gcc csky allnoconfig gcc csky allyesconfig gcc cskydefconfig gcc hexagon allmodconfig clang hexagon allnoconfig clang hexagon allyesconfig clang hexagon defconfig clang i386 allmodconfig gcc i386 allnoconfig gcc i386 allyesconfig gcc i386 buildonly-randconfig-001-20240419 clang i386 buildonly-randconfig-002-20240419 gcc i386 buildonly-randconfig-003-20240419 gcc i386 buildonly-randconfig-004-20240419 gcc i386 buildonly-randconfig-005-20240419 gcc i386 buildonly-randconfig-006-20240419 gcc i386defconfig clang i386 randconfig-001-20240419 clang i386 randconfig-002-20240419 clang i386 randconfig-003-20240419 clang i386 randconfig-004-20240419 gcc i386 randconfig-005-20240419 clang i386 randconfig-006-20240419 clang i386 randconfig-011-20240419 gcc i386 randconfig-012-20240419 clang i386 randconfig-013-20240419 gcc i386 randconfig-014-20240419 clang i386 randconfig-015-20240419 gcc i386 randconfig-016-20240419 clang loongarchallmodconfig gcc loongarch allnoconfig gcc loongarch defconfig gcc m68k allmodconfig gcc m68k allnoconfig gcc m68k allyesconfig gcc m68kdefconfig gcc microblaze allmodconfig gcc microblazeallnoconfig gcc microblaze allyesconfig gcc microblaze defconfig gcc mips allnoconfig gcc mips allyesconfig gcc nios2allmodconfig gcc nios2 allnoconfig gcc nios2allyesconfig gcc nios2 defconfig gcc openrisc allnoconfig gcc openrisc allyesconfig gcc openriscdefconfig gcc parisc allmodconfig gcc pariscallnoconfig gcc parisc allyesconfig gcc parisc defconfig gcc parisc64defconfig gcc powerpc allmodconfig gcc powerpc allnoconfig gcc powerpc allyesconfig clang riscvallmodconfig clang riscv allnoconfig gcc riscvallyesconfig clang riscv defconfig clang s390 allmodconfig clang s390 allnoconfig clang s390 allyesconfig gcc s390defconfig clang sh allmodconfig gcc shallnoconfig gcc sh allyesconfig gcc sh defconfig gcc sparcallmodconfig g
[kvalo-ath:pending] BUILD SUCCESS 5d1a18e1b0dbc588ec7ebf77e4be097565c9b86f
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending branch HEAD: 5d1a18e1b0dbc588ec7ebf77e4be097565c9b86f wifi: ath12k: fix kernel crash during resume elapsed time: 817m configs tested: 126 configs skipped: 4 The following configs have been built successfully. More configs may be tested in the coming days. tested configs: alpha allnoconfig gcc alphaallyesconfig gcc alpha defconfig gcc arc allmodconfig gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20240419 gcc arc randconfig-002-20240419 gcc arm allmodconfig gcc arm allnoconfig clang arm allyesconfig gcc arm defconfig clang arm randconfig-001-20240419 gcc arm randconfig-002-20240419 clang arm randconfig-003-20240419 gcc arm randconfig-004-20240419 clang arm64allmodconfig clang arm64 allnoconfig gcc arm64 defconfig gcc arm64 randconfig-001-20240419 clang arm64 randconfig-002-20240419 clang arm64 randconfig-003-20240419 clang arm64 randconfig-004-20240419 clang csky allmodconfig gcc csky allnoconfig gcc csky allyesconfig gcc cskydefconfig gcc csky randconfig-001-20240419 gcc csky randconfig-002-20240419 gcc hexagon allmodconfig clang hexagon allnoconfig clang hexagon allyesconfig clang hexagon defconfig clang hexagon randconfig-001-20240419 clang hexagon randconfig-002-20240419 clang i386 allmodconfig gcc i386 allnoconfig gcc i386 allyesconfig gcc i386 buildonly-randconfig-001-20240419 clang i386 buildonly-randconfig-002-20240419 gcc i386 buildonly-randconfig-003-20240419 gcc i386 buildonly-randconfig-004-20240419 gcc i386 buildonly-randconfig-005-20240419 gcc i386 buildonly-randconfig-006-20240419 gcc i386defconfig clang loongarchallmodconfig gcc loongarch allnoconfig gcc loongarch defconfig gcc loongarch randconfig-001-20240419 gcc loongarch randconfig-002-20240419 gcc m68k allmodconfig gcc m68k allnoconfig gcc m68k allyesconfig gcc m68kdefconfig gcc microblaze allmodconfig gcc microblazeallnoconfig gcc microblaze allyesconfig gcc microblaze defconfig gcc mips allnoconfig gcc mips allyesconfig gcc nios2allmodconfig gcc nios2 allnoconfig gcc nios2allyesconfig gcc nios2 defconfig gcc nios2 randconfig-001-20240419 gcc nios2 randconfig-002-20240419 gcc openrisc allnoconfig gcc openrisc allyesconfig gcc openriscdefconfig gcc parisc allmodconfig gcc pariscallnoconfig gcc parisc allyesconfig gcc parisc defconfig gcc pariscrandconfig-001-20240419 gcc pariscrandconfig-002-20240419 gcc parisc64defconfig gcc powerpc allnoconfig gcc powerpc allyesconfig clang powerpc randconfig-001-20240419 gcc powerpc randconfig-002-20240419 gcc powerpc randconfig-003-20240419 gcc powerpc64 randconfig-001-20240419 gcc powerpc64 randconfig-002-20240419 gcc powerpc64 randconfig-003-20240419 clang riscv
