Re: [ath9k-devel] Weird Atheros 9485 http connecting problems
Hi, 0xdeadbeef says the registers are unavailable. Did you disable Station mode powersave? -a On 18 May 2014 17:29, Arkh4mKn1ght arkh4mkn1...@gmail.com wrote: Hi I'm still testing but the issue reappeared again with the ASPM disabled on the card. This ocurred after starting the computer from hibernation and as i mentioned before ASPM was disabled only on the card and not on the root complex. I found these messages on the log: May 18 10:42:56 localhost kernel: mei_me :00:16.0: suspend May 18 10:42:57 localhost kernel: ath: phy0: RX failed to go idle in 10 ms RXSM=0xdeadbeef May 18 10:42:57 localhost kernel: ath: phy0: DMA failed to stop in 10 ms AR_CR=0xdeadbeef AR_DIAG_SW=0xdeadbeef DMADBG_7=0xdeadbeef After rebooting the computer everything worked fine again. Now i have disabled ASPM on both the root complex and the atheros card so i'm still testing to see if the issue happens again. until now (7+ hours everything is fine). I will let you know if the issue reappears after these changes Greetings Oskar. On 05/18/2014 08:51 PM, Adrian Chadd wrote: So was it ASPM? -a On 16 May 2014 05:22, Arkh4mKn1ght arkh4mkn1...@gmail.com wrote: Hi That was a nice find. I thought ASPM was disabled because i always boot my kernel with the pcie_aspm=off flag. I have now disabled ASPM following the link you shared with me for my card but is it enough to disable ASPM on the card or do i have to disable it also for the root complex? root complex: (byte 0x50 has value 42 it means L1 is enabled) [root@localhost kernel]# lspci -s 00:1c.0 -xxx 00:1c.0 PCI bridge: Intel Corporation 7 Series/C210 Series Chipset Family PCI Express Root Port 1 (rev c4) 00: 86 80 10 1e 07 00 10 00 c4 00 04 06 10 00 81 00 10: 00 00 00 00 00 00 00 00 00 07 07 00 f0 00 00 00 20: 20 c1 20 c1 51 c1 51 c1 00 00 00 00 00 00 00 00 30: 00 00 00 00 40 00 00 00 00 00 00 00 0a 01 00 00 40: 10 80 42 01 00 80 00 00 00 00 10 00 12 3c 12 01 50: 42 00 11 70 00 b2 04 00 00 00 40 01 00 00 00 00 60: 00 00 00 00 16 00 00 00 00 00 00 00 00 00 00 00 70: 02 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 80: 05 90 00 00 00 00 00 00 00 00 00 00 00 00 00 00 90: 0d a0 00 00 4d 10 ab 90 00 00 00 00 00 00 00 00 a0: 01 00 02 c8 00 00 00 00 00 00 00 00 00 00 00 00 b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 d0: 00 00 00 01 02 0b 00 00 00 80 11 81 00 00 00 00 e0: 00 3f 00 00 00 00 00 00 01 00 00 00 00 00 00 00 f0: 00 00 00 00 00 00 00 00 87 0f 04 08 00 00 00 00 [root@localhost kernel]# Atheros card with ASPM disabled: 07:00.0 Network controller: Qualcomm Atheros AR9485 Wireless Network Adapter (rev 01) Subsystem: Foxconn International, Inc. Device e044 Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast TAbort- TAbort- MAbort- SERR- PERR- INTx- Interrupt: pin A routed to IRQ 11 Region 0: Memory at c120 (64-bit, non-prefetchable) [size=512K] Expansion ROM at c150 [disabled] [size=64K] Capabilities: [40] Power Management version 2 Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA PME(D0+,D1+,D2+,D3hot+,D3cold+) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- Capabilities: [50] MSI: Enable- Count=1/4 Maskable+ 64bit+ Address: Data: Masking: Pending: Capabilities: [70] Express (v2) Endpoint, MSI 00 DevCap:MaxPayload 128 bytes, PhantFunc 0, Latency L0s unlimited, L1 64us ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset- DevCtl:Report errors: Correctable- Non-Fatal- Fatal- Unsupported- RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop- MaxPayload 128 bytes, MaxReadReq 512 bytes DevSta:CorrErr- UncorrErr- FatalErr- UnsuppReq- AuxPwr+ TransPend- LnkCap:Port #0, Speed 2.5GT/s, Width x1, ASPM L0s L1, Exit Latency L0s 4us, L1 64us ClockPM- Surprise- LLActRep- BwNot- LnkCtl:ASPM Disabled; RCB 64 bytes Disabled- CommClk+ ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt- How do i make the changes permanent when booting the system ? Greetings Oskar On 05/16/2014 06:06 AM, Rajkumar Manoharan wrote: On Thu, May 15, 2014 at 08:02:20PM -0300, Arkh4mKn1ght wrote: Hi The problem happened again suddenly i had difficulty browsing websites. When i tried to load a site the browser stays in connecting. for some minutes. After a while it does load the sites but painfully slow. Pings, ssh connections work fine, but a connection to smtp.gmail.com to send you this email also stayed in connecting...(im using thunderbird as email client) though. I disabled ANI after it happened but nothing changed, the problem persisted. One thing i noticed though, as
Re: [ath9k-devel] Weird Atheros 9485 http connecting problems
No. i decided to leave powersave on. My idea was to start discarding what could be creating the problem, so i just disabled ASPM on the card but i left powersave on. The problem was that ASPM was enabled on the root complex so im not sure if that was the culprit of the last appearance of the issue. But now i'm thinking, if ASPM is disabled on both the root complex and the atheros card, is leaving powersave mode on meaningless? because right now ASPM is both disabled on the root complex + atheros card, and the ath9k module is loaded with ps_enable=1. [root@localhost oskar]# iwconfig wlan0 wlan0 IEEE 802.11bgn ESSID:TP-LINK_E6342E Mode:Managed Frequency:2.462 GHz Access Point: 00:21:27:E6:34:2E Bit Rate=48 Mb/s Tx-Power=16 dBm Retry short limit:7 RTS thr:off Fragment thr:off Encryption key:off Power Management:on Link Quality=68/70 Signal level=-42 dBm Rx invalid nwid:0 Rx invalid crypt:0 Rx invalid frag:0 Tx excessive retries:6 Invalid misc:26 Missed beacon:0 Still the issue has not re appeared yet I will keep you updated Thanks for the help Greetings Oskar On 05/19/2014 03:10 AM, Adrian Chadd wrote: Hi, 0xdeadbeef says the registers are unavailable. Did you disable Station mode powersave? -a On 18 May 2014 17:29, Arkh4mKn1ght arkh4mkn1...@gmail.com wrote: Hi I'm still testing but the issue reappeared again with the ASPM disabled on the card. This ocurred after starting the computer from hibernation and as i mentioned before ASPM was disabled only on the card and not on the root complex. I found these messages on the log: May 18 10:42:56 localhost kernel: mei_me :00:16.0: suspend May 18 10:42:57 localhost kernel: ath: phy0: RX failed to go idle in 10 ms RXSM=0xdeadbeef May 18 10:42:57 localhost kernel: ath: phy0: DMA failed to stop in 10 ms AR_CR=0xdeadbeef AR_DIAG_SW=0xdeadbeef DMADBG_7=0xdeadbeef After rebooting the computer everything worked fine again. Now i have disabled ASPM on both the root complex and the atheros card so i'm still testing to see if the issue happens again. until now (7+ hours everything is fine). I will let you know if the issue reappears after these changes Greetings Oskar. On 05/18/2014 08:51 PM, Adrian Chadd wrote: So was it ASPM? -a On 16 May 2014 05:22, Arkh4mKn1ght arkh4mkn1...@gmail.com wrote: Hi That was a nice find. I thought ASPM was disabled because i always boot my kernel with the pcie_aspm=off flag. I have now disabled ASPM following the link you shared with me for my card but is it enough to disable ASPM on the card or do i have to disable it also for the root complex? root complex: (byte 0x50 has value 42 it means L1 is enabled) [root@localhost kernel]# lspci -s 00:1c.0 -xxx 00:1c.0 PCI bridge: Intel Corporation 7 Series/C210 Series Chipset Family PCI Express Root Port 1 (rev c4) 00: 86 80 10 1e 07 00 10 00 c4 00 04 06 10 00 81 00 10: 00 00 00 00 00 00 00 00 00 07 07 00 f0 00 00 00 20: 20 c1 20 c1 51 c1 51 c1 00 00 00 00 00 00 00 00 30: 00 00 00 00 40 00 00 00 00 00 00 00 0a 01 00 00 40: 10 80 42 01 00 80 00 00 00 00 10 00 12 3c 12 01 50: 42 00 11 70 00 b2 04 00 00 00 40 01 00 00 00 00 60: 00 00 00 00 16 00 00 00 00 00 00 00 00 00 00 00 70: 02 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 80: 05 90 00 00 00 00 00 00 00 00 00 00 00 00 00 00 90: 0d a0 00 00 4d 10 ab 90 00 00 00 00 00 00 00 00 a0: 01 00 02 c8 00 00 00 00 00 00 00 00 00 00 00 00 b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 d0: 00 00 00 01 02 0b 00 00 00 80 11 81 00 00 00 00 e0: 00 3f 00 00 00 00 00 00 01 00 00 00 00 00 00 00 f0: 00 00 00 00 00 00 00 00 87 0f 04 08 00 00 00 00 [root@localhost kernel]# Atheros card with ASPM disabled: 07:00.0 Network controller: Qualcomm Atheros AR9485 Wireless Network Adapter (rev 01) Subsystem: Foxconn International, Inc. Device e044 Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast TAbort- TAbort- MAbort- SERR- PERR- INTx- Interrupt: pin A routed to IRQ 11 Region 0: Memory at c120 (64-bit, non-prefetchable) [size=512K] Expansion ROM at c150 [disabled] [size=64K] Capabilities: [40] Power Management version 2 Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA PME(D0+,D1+,D2+,D3hot+,D3cold+) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- Capabilities: [50] MSI: Enable- Count=1/4 Maskable+ 64bit+ Address: Data: Masking: Pending: Capabilities: [70] Express (v2) Endpoint, MSI 00 DevCap:MaxPayload 128 bytes, PhantFunc 0, Latency L0s unlimited, L1 64us ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
Re: [ath9k-devel] Weird Atheros 9485 http connecting problems
On Mon, May 19, 2014 at 10:12:38AM -0300, Arkh4mKn1ght wrote: On 05/19/2014 03:29 AM, Rajkumar Manoharan wrote: On Sun, May 18, 2014 at 09:29:08PM -0300, Arkh4mKn1ght wrote: Hi I'm still testing but the issue reappeared again with the ASPM disabled on the card. This ocurred after starting the computer from hibernation and as i mentioned before ASPM was disabled only on the card and not on the root complex. I found these messages on the log: May 18 10:42:56 localhost kernel: mei_me :00:16.0: suspend May 18 10:42:57 localhost kernel: ath: phy0: RX failed to go idle in 10 ms RXSM=0xdeadbeef May 18 10:42:57 localhost kernel: ath: phy0: DMA failed to stop in 10 ms AR_CR=0xdeadbeef AR_DIAG_SW=0xdeadbeef DMADBG_7=0xdeadbeef After rebooting the computer everything worked fine again. Now i have disabled ASPM on both the root complex and the atheros card so i'm still testing to see if the issue happens again. until now (7+ hours everything is fine). I will let you know if the issue reappears after these changes Oskar, Generally the boot argument pcie_aspm=off disables ASPM in both root complex and device. Im not sure why it is not working in your m/c. I think there could be some option in BIOS to disable PCI powersave. Please check that. Can you please test with attached patch? -Rajkumar Rajkumar, yeah i also thought using pcie_aspm=off would disable ASPM completely, so i dont know what is going on. My laptop is a sony vaio SVE model, and it has a crappy BIOS designed specialy for windows 8 and all that UEFI crap. Las time i checked the BIOS it was really a simple one, not many options to deal with, but i will check again if the issue reappears and try the patch. Until now everything is fine with ASPM disabled on both the root complex and wifi card.(ath9k is loaded with ps_enable=1) Btw as i said in a previous email, if ASPM is disabled completely, leaving powersave mode on for the ath9k module meaningless? in other words would powersave work with ASPM disabled but ath9k module loaded with ps_enable=1 ? powersave is nothing but 802.11 protocol implementation to put the station into network sleep when it is idle and wake it up whenever it is active. IIRC it is not related to ASPM. So yes powersave would work event without ASPM. Since the issue is happending only when ASPM is enabled, please test the patch with ASPM. -Rajkumar ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
[ath9k-devel] ath9k tx-hangs in 3.14.4+
This is from our modified 3.14.4+ kernel, but there are relatively few changes to ath9k. Test case is create 128 stations and run them against another ath9k AP, overdriving with UDP frames in bi-directional flows. Both AP and station system show similar log messages. Some of the printouts below is from our debugging patches I believe... We have seen this since at least 3.7 era kernels, so it is probably not a regression, but it does seem to be easier to hit these days..maybe just some RF environment change though. My tree is here: http://dmz2.candelatech.com/git/gitweb.cgi?p=linux-3.14.dev.y/.git;a=summary This sounds a bit like the problems Dave Taht was reporting, though it appears my hack that resets the NIC when it is hung like this keeps it at least mostly working. Since it seems I have a good way to reproduce this now, I'm curious if anyone has suggestions for how to debug this better (or perhaps better work-arounds?) [313823.128460] ath: 1400503010.313367 wiphy0: BB_WATCHDOG: Skipping interrupts [313965.440167] ath: 1400503152.625074 wiphy0: BB_WATCHDOG: Skipping interrupts [314656.950849] ath: 1400503844.135752 wiphy0: Timeout while waiting for nf to load: AR_PHY_AGC_CONTROL=0x1d0dda [314656.951071] ath: 1400503844.135981 wiphy0: BB_WATCHDOG: Skipping interrupts [315343.351639] ath: 1400504530.536546 wiphy0: BB_WATCHDOG: Skipping interrupts [315661.015172] ath: 1400504848.200078 wiphy0: BB_WATCHDOG: Skipping interrupts [316949.624973] ath: 1400506136.809879 wiphy0: BB_WATCHDOG: Skipping interrupts [317259.273747] ath: 1400506446.458652 wiphy0: BB_WATCHDOG: Skipping interrupts [317601.176352] ath: 1400506788.361258 wiphy0: BB_WATCHDOG: Skipping interrupts [317727.457658] ath: 1400506914.642565 wiphy0: BB_WATCHDOG: Skipping interrupts [318416.860840] ath: 1400507604.45749 wiphy0: BB_WATCHDOG: Skipping interrupts [330581.299111] ath: 1400519768.484019 wiphy0: soft tx hang: queue: 2 pending-frames: 123, resetting chip [330581.309359] ath: 1400519768.494267 wiphy0: Pending frames still exist on txq: 2 after drain: 123 axq-depth: 0 ampdu-depth: 0 Thanks, Ben -- Ben Greear gree...@candelatech.com Candela Technologies Inc http://www.candelatech.com ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [PATCH] Make ath9k debug mask setting modifiable via /sys/module.
Any thoughts on this?
It's rather handy to be able to update the debug mask on the fly rather
than having to remove and reinsert the module (especially if you only want
to turn on debugging after something has happened).
Thanks!
On Tue, May 13, 2014 at 11:03 PM, David Held drh...@gmail.com wrote:
Updating /sys/module/ath9k/parameters/debug will update the debug mask
used if debugging is enabled and can be read to see the current mask.
Signed-off-by: David Held drh...@gmail.com
---
Ideally there'd be a nicer way to do this. Definitely open to suggestions.
It seems ugly to pull the int out of the struct, but that (and the
spinlock to
avoid destruction races) was the best idea I had.
drivers/net/wireless/ath/ath9k/init.c | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/init.c
b/drivers/net/wireless/ath/ath9k/init.c
index 8894e96..5b99fe2 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -21,6 +21,7 @@
#include linux/ath9k_platform.h
#include linux/module.h
#include linux/relay.h
+#include linux/spinlock.h
#include net/ieee80211_radiotap.h
#include ath9k.h
@@ -37,8 +38,23 @@ MODULE_DESCRIPTION(Support for Atheros 802.11n
wireless LAN cards.);
MODULE_SUPPORTED_DEVICE(Atheros 802.11n WLAN cards);
MODULE_LICENSE(Dual BSD/GPL);
+static DEFINE_SPINLOCK(debug_lock);
static unsigned int ath9k_debug = ATH_DBG_DEFAULT;
-module_param_named(debug, ath9k_debug, uint, 0);
+static int *ath_common_debug = NULL;
+static int ath9k_update_debug(const char *val, const struct kernel_param
*kp) {
+ int ret = param_set_uint(val, kp);
+ if (ret 0) return ret;
+
+ spin_lock(debug_lock);
+ if (ath_common_debug) *ath_common_debug = ath9k_debug;
+ spin_unlock(debug_lock);
+ return 0;
+}
+static const struct kernel_param_ops ath9k_debug_param_ops = {
+ .set = ath9k_update_debug,
+ .get = param_get_uint,
+};
+module_param_cb(debug, ath9k_debug_param_ops, ath9k_debug, 0644);
MODULE_PARM_DESC(debug, Debugging mask);
int ath9k_modparam_nohwcrypt;
@@ -525,10 +541,14 @@ static int ath9k_init_softc(u16 devid, struct
ath_softc *sc,
common-ah = ah;
common-hw = sc-hw;
common-priv = sc;
- common-debug_mask = ath9k_debug;
common-btcoex_enabled = ath9k_btcoex_enable == 1;
common-disable_ani = false;
+ spin_lock(debug_lock);
+ ath_common_debug = common-debug_mask;
+ spin_unlock(debug_lock);
+ common-debug_mask = ath9k_debug;
+
/*
* Platform quirks.
*/
@@ -875,6 +895,9 @@ static void ath9k_deinit_softc(struct ath_softc *sc)
void ath9k_deinit_device(struct ath_softc *sc)
{
struct ieee80211_hw *hw = sc-hw;
+ spin_lock(debug_lock);
+ ath_common_debug = NULL;
+ spin_unlock(debug_lock);
ath9k_ps_wakeup(sc);
--
1.7.10
___
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel
[ath9k-devel] [PATCH] ath9k_htc: use 'struct ath_htc_rx_status *' in call to ath9k_htc_err_stat_rx
CC [M] drivers/net/wireless/ath/ath9k/htc_drv_txrx.o drivers/net/wireless/ath/ath9k/htc_drv_txrx.c: In function ‘ath9k_rx_prepare’: drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:1006:2: warning: passing argument 2 of ‘ath9k_htc_err_stat_rx’ from incompatible pointer type [enabled by default] ath9k_htc_err_stat_rx(priv, rx_stats); ^ In file included from drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:17:0: drivers/net/wireless/ath/ath9k/htc.h:380:20: note: expected ‘struct ath_htc_rx_status *’ but argument is of type ‘struct ath_rx_status *’ static inline void ath9k_htc_err_stat_rx(struct ath9k_htc_priv *priv, Signed-off-by: John W. Linville linvi...@tuxdriver.com --- Compile-test only...seems reasonable? drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c index bb86eb2ffc95..c1490ddc2965 100644 --- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c +++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c @@ -1003,7 +1003,7 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv, /* Copy everything from ath_htc_rx_status (HTC_RX_FRAME_HEADER). * After this, we can drop this part of skb. */ rx_status_htc_to_ath(rx_stats, rxstatus); - ath9k_htc_err_stat_rx(priv, rx_stats); + ath9k_htc_err_stat_rx(priv, rxstatus); rx_status-mactime = be64_to_cpu(rxstatus-rs_tstamp); skb_pull(skb, HTC_RX_FRAME_HEADER_SIZE); -- 1.9.0 ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [PATCH] ath9k_htc: use 'struct ath_htc_rx_status *' in call to ath9k_htc_err_stat_rx
Am 19.05.2014 23:07, schrieb John W. Linville: CC [M] drivers/net/wireless/ath/ath9k/htc_drv_txrx.o drivers/net/wireless/ath/ath9k/htc_drv_txrx.c: In function ‘ath9k_rx_prepare’: drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:1006:2: warning: passing argument 2 of ‘ath9k_htc_err_stat_rx’ from incompatible pointer type [enabled by default] ath9k_htc_err_stat_rx(priv, rx_stats); ^ In file included from drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:17:0: drivers/net/wireless/ath/ath9k/htc.h:380:20: note: expected ‘struct ath_htc_rx_status *’ but argument is of type ‘struct ath_rx_status *’ static inline void ath9k_htc_err_stat_rx(struct ath9k_htc_priv *priv, Signed-off-by: John W. Linville linvi...@tuxdriver.com --- Compile-test only...seems reasonable? Hm... that is incorrect. Some missing patch? [PATCH 06/10] ath9k ath9k_htc: move ath_rx_stats to cmn did correct change. your patch will brake it. drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c index bb86eb2ffc95..c1490ddc2965 100644 --- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c +++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c @@ -1003,7 +1003,7 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv, /* Copy everything from ath_htc_rx_status (HTC_RX_FRAME_HEADER). * After this, we can drop this part of skb. */ rx_status_htc_to_ath(rx_stats, rxstatus); - ath9k_htc_err_stat_rx(priv, rx_stats); + ath9k_htc_err_stat_rx(priv, rxstatus); rx_status-mactime = be64_to_cpu(rxstatus-rs_tstamp); skb_pull(skb, HTC_RX_FRAME_HEADER_SIZE); -- Regards, Oleksij signature.asc Description: OpenPGP digital signature ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [PATCH] ath9k_htc: use 'struct ath_htc_rx_status *' in call to ath9k_htc_err_stat_rx
On Mon, May 19, 2014 at 11:28:42PM +0200, Oleksij Rempel wrote: Am 19.05.2014 23:07, schrieb John W. Linville: CC [M] drivers/net/wireless/ath/ath9k/htc_drv_txrx.o drivers/net/wireless/ath/ath9k/htc_drv_txrx.c: In function ‘ath9k_rx_prepare’: drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:1006:2: warning: passing argument 2 of ‘ath9k_htc_err_stat_rx’ from incompatible pointer type [enabled by default] ath9k_htc_err_stat_rx(priv, rx_stats); ^ In file included from drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:17:0: drivers/net/wireless/ath/ath9k/htc.h:380:20: note: expected ‘struct ath_htc_rx_status *’ but argument is of type ‘struct ath_rx_status *’ static inline void ath9k_htc_err_stat_rx(struct ath9k_htc_priv *priv, Signed-off-by: John W. Linville linvi...@tuxdriver.com --- Compile-test only...seems reasonable? Hm... that is incorrect. Some missing patch? [PATCH 06/10] ath9k ath9k_htc: move ath_rx_stats to cmn did correct change. your patch will brake it. The patch you mention is in wireless-next and wireless-testing. The warning only shows-up in my wireless-testing build, although the configs are slightly different. Would you be interested in tracking down the problem? John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [PATCH] ath9k_htc: use 'struct ath_htc_rx_status *' in call to ath9k_htc_err_stat_rx
Am 19.05.2014 23:41, schrieb John W. Linville: On Mon, May 19, 2014 at 11:28:42PM +0200, Oleksij Rempel wrote: Am 19.05.2014 23:07, schrieb John W. Linville: CC [M] drivers/net/wireless/ath/ath9k/htc_drv_txrx.o drivers/net/wireless/ath/ath9k/htc_drv_txrx.c: In function ‘ath9k_rx_prepare’: drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:1006:2: warning: passing argument 2 of ‘ath9k_htc_err_stat_rx’ from incompatible pointer type [enabled by default] ath9k_htc_err_stat_rx(priv, rx_stats); ^ In file included from drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:17:0: drivers/net/wireless/ath/ath9k/htc.h:380:20: note: expected ‘struct ath_htc_rx_status *’ but argument is of type ‘struct ath_rx_status *’ static inline void ath9k_htc_err_stat_rx(struct ath9k_htc_priv *priv, Signed-off-by: John W. Linville linvi...@tuxdriver.com --- Compile-test only...seems reasonable? Hm... that is incorrect. Some missing patch? [PATCH 06/10] ath9k ath9k_htc: move ath_rx_stats to cmn did correct change. your patch will brake it. The patch you mention is in wireless-next and wireless-testing. The warning only shows-up in my wireless-testing build, although the configs are slightly different. Would you be interested in tracking down the problem? Ok, thank you for the tip, i found it. Will send patch ASAP. -- Regards, Oleksij signature.asc Description: OpenPGP digital signature ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] Weird Atheros 9485 http connecting problems
Right; powersave is nothing but 802.11 protocol implementation to put the station into network sleep when it is idle and wake it up whenever it is active. IIRC it is not related to ASPM. So yes powersave would work event without ASPM. Since the issue is happending only when ASPM is enabled, please test the patch with ASPM. Just to be clear - the powersave support when loading ath9k also puts the MAC/PHY to sleep and wakes it up as appropriate. You're seeing 0xdeadc0de which the internal AHB glue reports if there's a transaction timeout (ie, the MAC/PHY is asleep or powered down when you went to access it.) ASPM has to do with the PHYs at both ends being awake (or not.) I think you'd either trigger some pcie error or read 0x if things were screwed up there. So I'd try with ASPM enabled/disabled as well as ps_enable on or off. It could be an interplay between the two as well. -a ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
