Re: [ath9k-devel] ath9k-devel Digest, Vol 79, Issue 6
Hi Arend My development environment is LINUX 2.26.31 Kernel, and I could not use new version kernel (The whole project work in Kernel 2.26.31, and the 2.26.31 is provided by my device manufactuer, I had no power to update to new kernel). Could you give a suggestion how to test your patch in LINUX 2.26.31? I am new to LINUX. Thanks, David -- Original -- From: Arend van Sprielar...@broadcom.com; Date: Fri, Jan 9, 2015 06:01 PM To: 杨铁军y...@nethdv.com; Cc: ath9k-develath9k-devel@lists.ath9k.org; Subject: Re: ath9k-devel Digest, Vol 79, Issue 6 On 01/09/15 02:54, 杨铁军 wrote: Hi Arend, I had ATH9k hardware, my wireless device is WLE350NX, it is AR9580 chip. Please send me your code to test! I am new to LINUX. Ok. The patch can be found on patchwork [1]. That page contains download links to get the patch. _mbox_ link can be used with 'git am' command. _patch_ link can be used with 'patch' command. Regards, Arend [1] https://patchwork.kernel.org/patch/5544621/ Regards, David Yang -- Original -- *From: * ath9k-devel-requestath9k-devel-requ...@lists.ath9k.org; *Date: * Thu, Jan 8, 2015 07:00 PM *To: * ath9k-develath9k-devel@lists.ath9k.org; *Subject: * ath9k-devel Digest, Vol 79, Issue 6 Send ath9k-devel mailing list submissions to ath9k-devel@lists.ath9k.org To subscribe or unsubscribe via the World Wide Web, visit https://lists.ath9k.org/mailman/listinfo/ath9k-devel or, via email, send a message with subject or body 'help' to ath9k-devel-requ...@lists.ath9k.org You can reach the person managing the list at ath9k-devel-ow...@lists.ath9k.org When replying, please edit your Subject line so it is more specific than Re: Contents of ath9k-devel digest... Today's Topics: 1. Re: [PATCH] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries (Kalle Valo) 2. Re: [PATCH] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries (Sujith Manoharan) -- Message: 1 Date: Wed, 07 Jan 2015 20:05:00 +0200 From: Kalle Valo kv...@codeaurora.org Subject: Re: [ath9k-devel] [PATCH] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries To: Arend van Spriel ar...@broadcom.com Cc: ath9k-devel@lists.ath9k.org, linux-wireless linux-wirel...@vger.kernel.org Message-ID: 87bnmapiur@kamboji.qca.qualcomm.com Content-Type: text/plain; charset=us-ascii Arend van Spriel ar...@broadcom.com writes: Use the helper to get rid of the file operations per debugfs file. The device driver data contains struct ieee80211_hw pointer and the struct ath9k_softc pointer is assigned to ieee80211_hw::priv so it can be accessed in the seq_file read operation. Cc: ath9k-devel@lists.ath9k.org Signed-off-by: Arend van Spriel ar...@broadcom.com --- Hi Kalle, This patch was reverted in the driver-core repository as I overlooked the use of driver data and caused ath9k driver to crash. I believe this revised patch properly uses it now although I have no ath9k hardware to test this. So I hope some ath9k developers out there can give this patch a run for its money. It compiles and no checkpatch or sparse warnings. The patch applies to the master branch of the wireless-drivers-next repository. Can someone with ath9k hardware test this, please? I'm hesitant to apply this without testing. -- Kalle Valo -- Message: 2 Date: Thu, 8 Jan 2015 08:49:00 +0530 From: Sujith Manoharan suj...@msujith.org Subject: Re: [ath9k-devel] [PATCH] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries To: Kalle Valo kv...@codeaurora.org Cc: Arend van Spriel ar...@broadcom.com, ath9k-devel@lists.ath9k.org, linux-wireless linux-wirel...@vger.kernel.org Message-ID: 21677.63268.657151.679...@gargle.gargle.howl Content-Type: text/plain; charset=us-ascii Arend van Spriel ar...@broadcom.com writes: Use the helper to get rid of the file operations per debugfs file. The device driver data contains struct ieee80211_hw pointer and the struct ath9k_softc pointer is assigned to ieee80211_hw::priv so it can be accessed in the seq_file read operation. Cc: ath9k-devel@lists.ath9k.org Signed-off-by: Arend van Spriel ar...@broadcom.com Thanks for the patch. Can someone with ath9k hardware test this, please? I'm hesitant to apply this without testing. I tested it and there were no crashes. Sujith -- ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel End of ath9k-devel Digest, Vol 79, Issue 6 **___ ath9k-devel mailing list
Re: [ath9k-devel] [PATCH] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries
On 01/09/15 01:34, Sujith Manoharan wrote: Arend van Spriel wrote: So the content of the modified debugfs files looks sane? Yep, as sane as the code populating the debug data. :-) :-D Thanks, Arend Sujith ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] Can I disable LED blinking on AR9271
Am 09.01.2015 um 01:48 schrieb Hong Xu: Hi all, I checked ath9k_htc driver does not have an option to disable led blinking. Is it possible to add this option for ath9k_htc like ath9k? Hi, currently there is only compile option to disable it. Patches are welcome, it should be easy since all blinking is triggered from the host. -- Regards, Oleksij signature.asc Description: OpenPGP digital signature ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] Can I disable LED blinking on AR9271
Maybe eventually use 'Sysctl' for this feature? See: http://people.ee.ethz.ch/~arkeller/linux/multi/kernel_user_space_howto-2.html#ss2.6 Eg. to disable the LED: echo 0 /proc/sys/../ath9k../led_blinking Kind regards, Melroy van den Berg 2015-01-09 10:37 GMT+01:00 Oleksij Rempel li...@rempel-privat.de: Am 09.01.2015 um 01:48 schrieb Hong Xu: Hi all, I checked ath9k_htc driver does not have an option to disable led blinking. Is it possible to add this option for ath9k_htc like ath9k? Hi, currently there is only compile option to disable it. Patches are welcome, it should be easy since all blinking is triggered from the host. -- Regards, Oleksij ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] ath9k-devel Digest, Vol 79, Issue 6
On 01/09/15 02:54, 杨铁军 wrote: Hi Arend, I had ATH9k hardware, my wireless device is WLE350NX, it is AR9580 chip. Please send me your code to test! I am new to LINUX. Ok. The patch can be found on patchwork [1]. That page contains download links to get the patch. _mbox_ link can be used with 'git am' command. _patch_ link can be used with 'patch' command. Regards, Arend [1] https://patchwork.kernel.org/patch/5544621/ Regards, David Yang -- Original -- *From: * ath9k-devel-requestath9k-devel-requ...@lists.ath9k.org; *Date: * Thu, Jan 8, 2015 07:00 PM *To: * ath9k-develath9k-devel@lists.ath9k.org; *Subject: * ath9k-devel Digest, Vol 79, Issue 6 Send ath9k-devel mailing list submissions to ath9k-devel@lists.ath9k.org To subscribe or unsubscribe via the World Wide Web, visit https://lists.ath9k.org/mailman/listinfo/ath9k-devel or, via email, send a message with subject or body 'help' to ath9k-devel-requ...@lists.ath9k.org You can reach the person managing the list at ath9k-devel-ow...@lists.ath9k.org When replying, please edit your Subject line so it is more specific than Re: Contents of ath9k-devel digest... Today's Topics: 1. Re: [PATCH] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries (Kalle Valo) 2. Re: [PATCH] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries (Sujith Manoharan) -- Message: 1 Date: Wed, 07 Jan 2015 20:05:00 +0200 From: Kalle Valo kv...@codeaurora.org Subject: Re: [ath9k-devel] [PATCH] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries To: Arend van Spriel ar...@broadcom.com Cc: ath9k-devel@lists.ath9k.org, linux-wireless linux-wirel...@vger.kernel.org Message-ID: 87bnmapiur@kamboji.qca.qualcomm.com Content-Type: text/plain; charset=us-ascii Arend van Spriel ar...@broadcom.com writes: Use the helper to get rid of the file operations per debugfs file. The device driver data contains struct ieee80211_hw pointer and the struct ath9k_softc pointer is assigned to ieee80211_hw::priv so it can be accessed in the seq_file read operation. Cc: ath9k-devel@lists.ath9k.org Signed-off-by: Arend van Spriel ar...@broadcom.com --- Hi Kalle, This patch was reverted in the driver-core repository as I overlooked the use of driver data and caused ath9k driver to crash. I believe this revised patch properly uses it now although I have no ath9k hardware to test this. So I hope some ath9k developers out there can give this patch a run for its money. It compiles and no checkpatch or sparse warnings. The patch applies to the master branch of the wireless-drivers-next repository. Can someone with ath9k hardware test this, please? I'm hesitant to apply this without testing. -- Kalle Valo -- Message: 2 Date: Thu, 8 Jan 2015 08:49:00 +0530 From: Sujith Manoharan suj...@msujith.org Subject: Re: [ath9k-devel] [PATCH] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries To: Kalle Valo kv...@codeaurora.org Cc: Arend van Spriel ar...@broadcom.com, ath9k-devel@lists.ath9k.org, linux-wireless linux-wirel...@vger.kernel.org Message-ID: 21677.63268.657151.679...@gargle.gargle.howl Content-Type: text/plain; charset=us-ascii Arend van Spriel ar...@broadcom.com writes: Use the helper to get rid of the file operations per debugfs file. The device driver data contains struct ieee80211_hw pointer and the struct ath9k_softc pointer is assigned to ieee80211_hw::priv so it can be accessed in the seq_file read operation. Cc: ath9k-devel@lists.ath9k.org Signed-off-by: Arend van Spriel ar...@broadcom.com Thanks for the patch. Can someone with ath9k hardware test this, please? I'm hesitant to apply this without testing. I tested it and there were no crashes. Sujith -- ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel End of ath9k-devel Digest, Vol 79, Issue 6 ** ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [PATCH] ath9k: ignore radar PHY errors when DFS is not enabled
On 01/09/15 17:54, Simon Wunderlich wrote:
Performing spectral scans on 5 GHz channels may result in PHY errors
sent by the hardware, even if DFS support is not enabled in the driver
(e.g. channel scanning or passive monitoring). In that case channels may
falsely get marked as 'unusable'. To fix that, only process radar PHY
errors when radar is explicitly enabled in the driver.
Hi Simon,
Not an ath9k expert, but I would think those channels would already be
marked as unusable, because DFS is disabled in the driver. Or does this
also affect 5G channels that do not require DFS.
Regards,
Arend
Cc: Stablesta...@vger.kernel.org [v3.10+]
Reported-by: Mathias Kretschmermathias.kretsch...@fokus.fraunhofer.de
Signed-off-by: Simon Wunderlichs...@simonwunderlich.de
---
drivers/net/wireless/ath/ath9k/dfs.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/wireless/ath/ath9k/dfs.c
b/drivers/net/wireless/ath/ath9k/dfs.c
index 726271c..3d04905 100644
--- a/drivers/net/wireless/ath/ath9k/dfs.c
+++ b/drivers/net/wireless/ath/ath9k/dfs.c
@@ -152,6 +152,12 @@ void ath9k_dfs_process_phyerr(struct ath_softc *sc, void
*data,
return;
}
+ if (!sc-hw-conf.radar_enabled) {
+ ath_dbg(common, DFS,
+ Error: received radar phyerr while radar was
disabled\n);
+ return;
+ }
+
datalen = rs-rs_datalen;
if (datalen == 0) {
DFS_STAT_INC(sc, datalen_discards);
___
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel
[ath9k-devel] [PATCH] ath9k: ignore radar PHY errors when DFS is not enabled
Performing spectral scans on 5 GHz channels may result in PHY errors
sent by the hardware, even if DFS support is not enabled in the driver
(e.g. channel scanning or passive monitoring). In that case channels may
falsely get marked as 'unusable'. To fix that, only process radar PHY
errors when radar is explicitly enabled in the driver.
Cc: Stable sta...@vger.kernel.org [v3.10+]
Reported-by: Mathias Kretschmer mathias.kretsch...@fokus.fraunhofer.de
Signed-off-by: Simon Wunderlich s...@simonwunderlich.de
---
drivers/net/wireless/ath/ath9k/dfs.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/wireless/ath/ath9k/dfs.c
b/drivers/net/wireless/ath/ath9k/dfs.c
index 726271c..3d04905 100644
--- a/drivers/net/wireless/ath/ath9k/dfs.c
+++ b/drivers/net/wireless/ath/ath9k/dfs.c
@@ -152,6 +152,12 @@ void ath9k_dfs_process_phyerr(struct ath_softc *sc, void
*data,
return;
}
+ if (!sc-hw-conf.radar_enabled) {
+ ath_dbg(common, DFS,
+ Error: received radar phyerr while radar was
disabled\n);
+ return;
+ }
+
datalen = rs-rs_datalen;
if (datalen == 0) {
DFS_STAT_INC(sc, datalen_discards);
--
2.1.4
___
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel
[ath9k-devel] TDLS in Linux?
Hi, I'm searching for a guide on how to setup TDLS between two atheros STA which support TDLS. But I'm not sure how do I make them establish TDLS for the data transfer to happen directly among these two clients rather than going through AP. When I searched in google, I see wpa-supplicant supports it. But there are not config entries indicating the same. Any help? Regards, Ramprasad ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
