Re: [ath9k-devel] [PATCH 0/3] debugfs: adding helper for single seq_file
On Thu, Oct 30, 2014 at 03:19:22PM -0400, John W. Linville wrote: On Tue, Oct 28, 2014 at 01:19:09PM +0100, Arend van Spriel wrote: The first patch was already posted earlier: Message-ID: 1413043315-22332-1-git-send-email-ar...@broadcom.com This series include changes in driver code to investigate potential code savings. As example used the ath9k driver as it has a fair amount of debugfs files. In this series it changes 7 debugfs entries to use seq_file and the helper function. Below the output of the size utility: textdata bss dec hex filename 1159681225 28 117221 1c9e5 original/ath9k.o 1132241225 28 114477 1bf2d seq_file/ath9k.o 1110241225 28 112277 1b695 helper/ath9k.o This series is for 3.19 kernel and applies to the driver-core-next branch of the driver-core repository. If needed the ath9k patches may be dropped for now and I will resubmit them to wireless-next once the debugfs patch has made it into linux-next. Arend van Spriel (3): debugfs: add helper function to create device related seq_file ath: use seq_file api for ath9k debugfs files ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries Greg, If you are happy with the debugfs change then feel free to merge the wireless patches along with it. Ok, will do, can I get your Ack for them? thanks, greg k-h ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [PATCH 0/3] debugfs: adding helper for single seq_file
On 10/30/14 20:39, Greg Kroah-Hartman wrote: On Thu, Oct 30, 2014 at 03:19:22PM -0400, John W. Linville wrote: On Tue, Oct 28, 2014 at 01:19:09PM +0100, Arend van Spriel wrote: The first patch was already posted earlier: Message-ID:1413043315-22332-1-git-send-email-ar...@broadcom.com This series include changes in driver code to investigate potential code savings. As example used the ath9k driver as it has a fair amount of debugfs files. In this series it changes 7 debugfs entries to use seq_file and the helper function. Below the output of the size utility: text data bss dec hex filename 115968 1225 28 117221 1c9e5 original/ath9k.o 113224 1225 28 114477 1bf2d seq_file/ath9k.o 111024 1225 28 112277 1b695 helper/ath9k.o This series is for 3.19 kernel and applies to the driver-core-next branch of the driver-core repository. If needed the ath9k patches may be dropped for now and I will resubmit them to wireless-next once the debugfs patch has made it into linux-next. Arend van Spriel (3): debugfs: add helper function to create device related seq_file ath: use seq_file api for ath9k debugfs files ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries Greg, If you are happy with the debugfs change then feel free to merge the wireless patches along with it. Ok, will do, can I get your Ack for them? I saw a patch from Dan Carpenter on one of the functions I converted so if John has taken that one [1] it may give merge conflict in linux-next. Regards, Arend [1] http://mid.gmane.org/20141029154805.GC5290@mwanda thanks, greg k-h ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [PATCH 0/3] debugfs: adding helper for single seq_file
On Tue, Oct 28, 2014 at 01:19:09PM +0100, Arend van Spriel wrote: The first patch was already posted earlier: Message-ID: 1413043315-22332-1-git-send-email-ar...@broadcom.com This series include changes in driver code to investigate potential code savings. As example used the ath9k driver as it has a fair amount of debugfs files. In this series it changes 7 debugfs entries to use seq_file and the helper function. Below the output of the size utility: text data bss dec hex filename 115968 1225 28 117221 1c9e5 original/ath9k.o 113224 1225 28 114477 1bf2d seq_file/ath9k.o 111024 1225 28 112277 1b695 helper/ath9k.o This series is for 3.19 kernel and applies to the driver-core-next branch of the driver-core repository. If needed the ath9k patches may be dropped for now and I will resubmit them to wireless-next once the debugfs patch has made it into linux-next. Arend van Spriel (3): debugfs: add helper function to create device related seq_file ath: use seq_file api for ath9k debugfs files ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries Greg, If you are happy with the debugfs change then feel free to merge the wireless patches along with it. John drivers/net/wireless/ath/ath9k/ahb.c | 1 + drivers/net/wireless/ath/ath9k/debug.c | 429 +++-- drivers/net/wireless/ath/ath9k/debug.h | 3 +- drivers/net/wireless/ath/ath9k/pci.c | 1 + fs/debugfs/file.c | 54 + include/linux/debugfs.h| 16 +- 6 files changed, 207 insertions(+), 297 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
[ath9k-devel] [PATCH 0/3] debugfs: adding helper for single seq_file
The first patch was already posted earlier: Message-ID: 1413043315-22332-1-git-send-email-ar...@broadcom.com This series include changes in driver code to investigate potential code savings. As example used the ath9k driver as it has a fair amount of debugfs files. In this series it changes 7 debugfs entries to use seq_file and the helper function. Below the output of the size utility: textdata bss dec hex filename 1159681225 28 117221 1c9e5 original/ath9k.o 1132241225 28 114477 1bf2d seq_file/ath9k.o 1110241225 28 112277 1b695 helper/ath9k.o This series is for 3.19 kernel and applies to the driver-core-next branch of the driver-core repository. If needed the ath9k patches may be dropped for now and I will resubmit them to wireless-next once the debugfs patch has made it into linux-next. Arend van Spriel (3): debugfs: add helper function to create device related seq_file ath: use seq_file api for ath9k debugfs files ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries drivers/net/wireless/ath/ath9k/ahb.c | 1 + drivers/net/wireless/ath/ath9k/debug.c | 429 +++-- drivers/net/wireless/ath/ath9k/debug.h | 3 +- drivers/net/wireless/ath/ath9k/pci.c | 1 + fs/debugfs/file.c | 54 + include/linux/debugfs.h| 16 +- 6 files changed, 207 insertions(+), 297 deletions(-) -- 1.9.1 ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
