Re: [ath9k-devel] ath9k: Add concurrent WLAN and BT tx support for MCI based chips

2012-11-27 Thread Rajkumar Manoharan 
On Tue, Nov 27, 2012 at 12:03:37AM +0300, Dan Carpenter wrote:
 Hello Rajkumar Manoharan,
 
 The patch db60428b1af1: ath9k: Add concurrent WLAN and BT tx support
 for MCI based chips from Oct 12, 2012, leads to the following
 warning:
 drivers/net/wireless/ath/ath9k/btcoex.c:414
   ath9k_hw_btcoex_set_concur_txprio()
   error: buffer overflow 'stomp_txprio' 4 = 4
 
Dan,

Thanks a lot. Is there a way to enable all checks while building smatch tool?

-Rajkumar
___
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] ath9k: Add concurrent WLAN and BT tx support for MCI based chips

2012-11-27 Thread Dan Carpenter 
On Tue, Nov 27, 2012 at 01:58:35PM +0530, Rajkumar Manoharan wrote:
 On Tue, Nov 27, 2012 at 12:03:37AM +0300, Dan Carpenter wrote:
  Hello Rajkumar Manoharan,
  
  The patch db60428b1af1: ath9k: Add concurrent WLAN and BT tx support
  for MCI based chips from Oct 12, 2012, leads to the following
  warning:
  drivers/net/wireless/ath/ath9k/btcoex.c:414
  ath9k_hw_btcoex_set_concur_txprio()
  error: buffer overflow 'stomp_txprio' 4 = 4
  
 Dan,
 
 Thanks a lot. Is there a way to enable all checks while building smatch tool?
 

This one requires the sqlite database to get the cross function
info.  It's a two compile process, the first builds the db and the
next does the test.  Replace the path names as appropriate:

~/progs/smatch/devel/smatch_scripts/build_kernel_data.sh
~/progs/smatch/devel/smatch_scripts/test_kernel.sh

regards,
dan carpenter

___
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] ath9k: Add concurrent WLAN and BT tx support for MCI based chips

2012-11-26 Thread Dan Carpenter 
Hello Rajkumar Manoharan,

The patch db60428b1af1: ath9k: Add concurrent WLAN and BT tx support
for MCI based chips from Oct 12, 2012, leads to the following
warning:
drivers/net/wireless/ath/ath9k/btcoex.c:414
ath9k_hw_btcoex_set_concur_txprio()
error: buffer overflow 'stomp_txprio' 4 = 4

stomp_txprio has 4 elements.
u8 stomp_txprio[] = { 0, 0, 0, 0 }; /* all, low, none, low_ftp */

drivers/net/wireless/ath/ath9k/btcoex.c
   408  void ath9k_hw_btcoex_set_concur_txprio(struct ath_hw *ah, u8 
*stomp_txprio)
   409  {
   410  struct ath_btcoex_hw *btcoex = ah-btcoex_hw;
   411  int i;
   412  
   413  for (i = 0; i  ATH_BTCOEX_STOMP_MAX; i++)

This is 5.

   414  btcoex-tx_prio[i] = stomp_txprio[i];
 ^^
We are reading one positition past the end of the array.

   415  }

Possibly we need to add some code to handle ATH_BTCOEX_STOMP_AUDIO which
was added recently in 2884561a ath9k: stomp audio profiles on weak
signal strength.

regards,
dan carpenter

___
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel