[PATCH] Update the aurweb Git URLs to GitLab

2020-07-13 Thread Frédéric Mangano-Tarumi
---
 INSTALL | 2 +-
 README.md   | 4 ++--
 TESTING | 2 +-
 doc/i18n.txt| 2 +-
 web/lib/version.inc.php | 1 +
 web/template/footer.php | 2 +-
 6 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/INSTALL b/INSTALL
index 7087aca2..1db69a9c 100644
--- a/INSTALL
+++ b/INSTALL
@@ -12,7 +12,7 @@ read the instructions below.
 1) Clone the aurweb project:
 
$ cd /srv/http/
-   $ git clone git://git.archlinux.org/aurweb.git
+   $ git clone https://gitlab.archlinux.org/archlinux/aurweb.git
 
 2) Setup a web server with PHP and MySQL. Configure the web server to redirect
all URLs to /index.php/foo/bar/. The following block can be used with nginx:
diff --git a/README.md b/README.md
index f7285a51..3105889a 100644
--- a/README.md
+++ b/README.md
@@ -29,8 +29,8 @@ Directory Layout
 Links
 -
 
-* The repository is hosted at git://git.archlinux.org/aurweb.git -- see
-  doc/CodingGuidelines for information on the patch submission process.
+* The repository is hosted at 
.
+  See doc/CodingGuidelines for information on the patch submission process.
 
 * Bugs can (and should) be submitted to the aurweb bug tracker:
   https://bugs.archlinux.org/index.php?project=2
diff --git a/TESTING b/TESTING
index d7df3672..9a211877 100644
--- a/TESTING
+++ b/TESTING
@@ -7,7 +7,7 @@ INSTALL.
 
 1) Clone the aurweb project:
 
-$ git clone git://git.archlinux.org/aurweb.git
+$ git clone https://gitlab.archlinux.org/archlinux/aurweb.git
 
 2) Install the necessary packages:
 
diff --git a/doc/i18n.txt b/doc/i18n.txt
index 8216c084..44fb0f1f 100644
--- a/doc/i18n.txt
+++ b/doc/i18n.txt
@@ -21,7 +21,7 @@ strings for the translation to be usable, and it may have to 
be disabled.
 
 1. Check out the aurweb source using git:
 
-$ git clone git://git.archlinux.org/aurweb.git aurweb-git
+$ git clone https://gitlab.archlinux.org/archlinux/aurweb.git aurweb-git
 
 2. Go into the "po/" directory in the aurweb source and run msginit(1) to
create a initial translation file from our translation catalog:
diff --git a/web/lib/version.inc.php b/web/lib/version.inc.php
index 27eef718..d96ce590 100644
--- a/web/lib/version.inc.php
+++ b/web/lib/version.inc.php
@@ -1,3 +1,4 @@
 

-   aurweb https://git.archlinux.org/aurweb.git/log/?h=">
+   aurweb https://gitlab.archlinux.org/archlinux/aurweb/-/tags/">



-- 
2.27.0


[PATCH] Fix typos in CONTRIBUTING.md

2020-07-13 Thread Frédéric Mangano-Tarumi
---
 CONTRIBUTING.md | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index a37d980a..7b9ff466 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -2,9 +2,9 @@
 
 Patches should be sent to the [aur-dev@archlinux.org][1] mailing list.
 
-Before sending patched you are recomended to run the `flake8` and `isort`.
+Before sending patches, you are recommended to run `flake8` and `isort`.
 
-You can add git hook to do this by installing `python-pre-install` and running
-`pre-install install`.
+You can add a git hook to do this by installing `python-pre-commit` and running
+`pre-commit install`.
 
 [1] https://lists.archlinux.org/listinfo/aur-dev
-- 
2.27.0


Re: [PATCH] Exclude suspended Users from being notified

2020-07-13 Thread Frédéric Mangano-Tarumi
Hi Kevin,

Kevin Morris [2020-07-03 18:29:16 -0700]
> diff --git a/aurweb/scripts/notify.py b/aurweb/scripts/notify.py
> index 5b18a476..223ed61f 100755
> --- a/aurweb/scripts/notify.py
> +++ b/aurweb/scripts/notify.py
> @@ -171,7 +171,8 @@ class CommentNotification(Notification):
> 'ON PackageNotifications.UserID = Users.ID WHERE 
> ' +
> 'Users.CommentNotify = 1 AND ' +
> 'PackageNotifications.UserID != ? AND ' +
> -   'PackageNotifications.PackageBaseID = ?',
> +   'PackageNotifications.PackageBaseID = ? AND ' +
> +   'Users.Suspended = 0' +,

In that last line, `+,` is not a valid Python syntax. The test suite is
screaming.

Since you’re a new contributor, you might want to read `test/README.md`
and `CONTRIBUTING.md` to prevent these little errors.

Regards,
-- 
fmang