Re: [PATCH] Handle empty resultset getting recent 10 packages

[Lukas Fleischer]

On Tue, 20 Mar 2018 at 21:47:44, nodivbyzero wrote:
> ---
>  web/lib/stats.inc.php | 8 +---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> [...]

Merged, thanks!

Re: [PATCH] Handle empty resultset getting recent 10 packages

[Nodiv Byzero]

Replaced spaces w/ tabs in this version

On Tue, Mar 20, 2018 at 8:47 PM, nodivbyzero  wrote:
> ---
>  web/lib/stats.inc.php | 8 +---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/web/lib/stats.inc.php b/web/lib/stats.inc.php
> index 80619fe..f5692f9 100644
> --- a/web/lib/stats.inc.php
> +++ b/web/lib/stats.inc.php
> @@ -19,10 +19,12 @@ function updates_table() {
> $result = $dbh->query($q);
>
> $newest_packages = new ArrayObject();
> -   while ($row = $result->fetch(PDO::FETCH_ASSOC)) {
> -   $newest_packages->append($row);
> +   if ($result) {
> +   while ($row = $result->fetch(PDO::FETCH_ASSOC)) {
> +   $newest_packages->append($row);
> +   }
> +   set_cache_value($key, $newest_packages);
> }
> -   set_cache_value($key, $newest_packages);
> }
> include('stats/updates_table.php');
>  }
> --
> 2.16.1
>

Re: [PATCH] Handle empty resultset getting recent 10 packages

[Nodiv Byzero]

It renders incorrectly main page(Statistics) with empty database.

On Tue, Mar 20, 2018 at 8:33 PM, nodivbyzero  wrote:
> ---
>  web/lib/stats.inc.php | 11 +++
>  1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/web/lib/stats.inc.php b/web/lib/stats.inc.php
> index 80619fe..0fa3ec6 100644
> --- a/web/lib/stats.inc.php
> +++ b/web/lib/stats.inc.php
> @@ -19,10 +19,13 @@ function updates_table() {
> $result = $dbh->query($q);
>
> $newest_packages = new ArrayObject();
> -   while ($row = $result->fetch(PDO::FETCH_ASSOC)) {
> -   $newest_packages->append($row);
> -   }
> -   set_cache_value($key, $newest_packages);
> +if ($result) {
> +
> +   while ($row = $result->fetch(PDO::FETCH_ASSOC)) {
> +   $newest_packages->append($row);
> +   }
> +   set_cache_value($key, $newest_packages);
> +}
> }
> include('stats/updates_table.php');
>  }
> --
> 2.16.1
>