Re: [aur-general] amiwm PKGBUILD file

[Panayotis Katsaloulis via aur-general]

Exactly that's the reason.

I tried to contact upstream and see how it goes.


Στις Τετ, 24 Ιαν, 2018 at 1:44 ΜΜ, ο/η Eli Schwartz via 
aur-general <aur-general@archlinux.org> έγραψε:
> On 01/24/2018 05:32 AM, Panayotis Katsaloulis via aur-general wrote:
>>  Thank you for the comments.
>>  Indeed I didn't try to use "namcap" to catch most of the comments. 
>> Now
>>  I did and sorry about that.
>> 
>> 
>>  Looking deeper at the resutls, I found another issue, which I don't
>>  know which is the most appropriate method to fix it.
>> 
>>  Inside the produced package has references to the build directory, 
>> i.e.
>> 
>>  
>> lib/amiwm/Xsession2:DEFAULT_XINITRC="/home/teras/Sources/amiwm/pkg/amiwm/usr/lib/amiwm/Xinitrc"
>>  lib/amiwm/Xinitrc:/home/teras/Sources/amiwm/pkg/amiwm/usr/bin/amiwm 
>> &
>>  wmpid=$!
>>  lib/amiwm/Xinitrc:
>>  /home/teras/Sources/amiwm/pkg/amiwm/usr/lib/amiwm/amiwm-init#
>>  Default amiwm tools
>>  lib/amiwm/Xsession: export
>>  
>> SDT_ALT_SESSION="/home/teras/Sources/amiwm/pkg/amiwm/usr/lib/amiwm/Xsession2"
>> 
>> 
>>  All of them "remember" the "/home/teras/Sources/amiwm" which if I am
>>  not mistaken is the ${pkgdir} folder.
>>  Should I do something like:
>> 
>>  for i in "${pkgdir}/usr/lib/amiwm/{Xsession2,Xinitrc,Xsession}" ; do
>>  sed -e "s%${pkgdir}%%g" "$i" >"$i.fix"; mv -v "$i.fix" "$i" ; done
> 
> 
> 
> This happens because you use prefix="$pkgdir/usr" during package(), 
> does
> the software not support DESTDIR?
> 
> If not, then you'll need to copy everything over by hand rather than
> using make install. Or, if upstream is still alive, asking them to fix
> their Makefile so it respects DESTDIR.
> 
> You could also fix the Makefile, and ship a patch alongside the
> PKGBUILD, then apply it in prepare() via `patch`.
> 
> --
> Eli Schwartz
> Bug Wrangler and Trusted User
> 

Re: [aur-general] amiwm PKGBUILD file

[Panayotis Katsaloulis via aur-general]

Thank you for the comments.
Indeed I didn't try to use "namcap" to catch most of the comments. Now 
I did and sorry about that.


Looking deeper at the resutls, I found another issue, which I don't 
know which is the most appropriate method to fix it.

Inside the produced package has references to the build directory, i.e.

lib/amiwm/Xsession2:DEFAULT_XINITRC="/home/teras/Sources/amiwm/pkg/amiwm/usr/lib/amiwm/Xinitrc"
lib/amiwm/Xinitrc:/home/teras/Sources/amiwm/pkg/amiwm/usr/bin/amiwm & 
wmpid=$!
lib/amiwm/Xinitrc:
/home/teras/Sources/amiwm/pkg/amiwm/usr/lib/amiwm/amiwm-init# 
Default amiwm tools
lib/amiwm/Xsession: export 
SDT_ALT_SESSION="/home/teras/Sources/amiwm/pkg/amiwm/usr/lib/amiwm/Xsession2"


All of them "remember" the "/home/teras/Sources/amiwm" which if I am 
not mistaken is the ${pkgdir} folder.
Should I do something like:

for i in "${pkgdir}/usr/lib/amiwm/{Xsession2,Xinitrc,Xsession}" ; do 
sed -e "s%${pkgdir}%%g" "$i" >"$i.fix"; mv -v "$i.fix" "$i" ; done


The full corected PKGBUILD follows:


# Maintainer: Panayotis Katsaloulis 
pkgname=amiwm
pkgver=0.21pl2
pkgrel=1
pkgdesc="An X window manager that tries to make your display look and 
feel like an Amiga® Workbench® screen"
arch=('x86_64' 'i686')
url="https://www.lysator.liu.se/~marcus/amiwm.html;
license=('CUSTOM')
source=("ftp://ftp.lysator.liu.se/pub/X11/wm/amiwm/amiwm${pkgver}.tar.gz;)
md5sums=('3a47e88e2be2978363220cf815ef')
depends=('libxmu')

build() {
cd "$pkgname$pkgver"
./configure --prefix=/usr
make
}

package() {
cd "$pkgname$pkgver"
make prefix="$pkgdir/usr" install
rm -v "$pkgdir/usr/bin/requestchoice"
mv -v "${pkgdir}/usr/man" "${pkgdir}/usr/share"
for i in "${pkgdir}"/usr/lib/amiwm/{Xsession2,Xinitrc,Xsession} ; 
do sed -e "s%${pkgdir}%%g" "$i" >"$i.fix" ; mv -v "$i.fix" "$i" ; done
install -v -Dm644 LICENSE 
"$pkgdir"/usr/share/licenses/$pkgname/LICENSE
}

[aur-general] amiwm PKGBUILD file

[Panayotis Katsaloulis via aur-general]

Hello all

This is my first attempt to create a valid PKGBUILD file for Arch Linux.
It is about the missing amiwm window manager.

Please tell me what you think



# Maintainer: Panayotis Katsaloulis 
pkgname=amiwm
pkgver=0.21pl2
pkgrel=1
pkgdesc="An X window manager that tries to make your display look and 
feel like an Amiga® Workbench® screen"
arch=('x86_64' 'i686')
url="https://www.lysator.liu.se/~marcus/amiwm.html;
license=('FREEWARE')
source=('ftp://ftp.lysator.liu.se/pub/X11/wm/amiwm/amiwm0.21pl2.tar.gz')
md5sums=('3a47e88e2be2978363220cf815ef')

build() {
cd "$pkgname$pkgver"
./configure --prefix=/usr
make
}

package() {
cd "$pkgname$pkgver"
make prefix="$pkgdir/usr" install
rm $pkgdir/usr/bin/requestchoice
install -Dm644 LICENSE "$pkgdir"/usr/share/licenses/$pkgname/LICENSE
}

Re: [aur-general] Wrong AUR Build file

[Panayotis Katsaloulis via aur-general]

Picking up the package doesn't also have the great responsibility of 
maintaining the package? :-o


Στις Πεμ, 18 Ιαν, 2018 at 10:02 ΜΜ, ο/η Morgan Adamiec 
via aur-general <aur-general@archlinux.org> έγραψε:
> I would probably leave a comment over emailing directly.
> If you get no response after a while I would then send an 
> orphan/deletion
> request detailing the problem and pick up the package myself and fix
> the problems.
> 
> On 18 January 2018 at 19:55, Panayotis Katsaloulis via aur-general
> <aur-general@archlinux.org> wrote:
>>  Hello people
>> 
>>  Newbie here in Arch Linux.
>> 
>>  I have a question, which I didn't find in the documentation.
>> 
>>  What is the proposed way to inform about an AUR build file 
>> containing
>>  errors? Especially if I e-mailed the maintainer with no response?
>> 
>>  Thank you!

[aur-general] Wrong AUR Build file

[Panayotis Katsaloulis via aur-general]

Hello people

Newbie here in Arch Linux.

I have a question, which I didn't find in the documentation.

What is the proposed way to inform about an AUR build file containing 
errors? Especially if I e-mailed the maintainer with no response?

Thank you!