[PATCH] autoreconf: Support AM_GNU_GETTEXT_REQUIRE_VERSION
As reported in https://github.com/gentoo/gentoo/pull/163, gettext 0.19.6 supports using AM_GNU_GETTEXT_REQUIRE_VERSION instead of AM_GNU_GETTEXT_VERSION. Update autoreconf to support both. Signed-off-by: Michał Górny <mgo...@gentoo.org> --- bin/autoreconf.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/autoreconf.in b/bin/autoreconf.in index 9f353b0..db408f7 100644 --- a/bin/autoreconf.in +++ b/bin/autoreconf.in @@ -264,7 +264,7 @@ sub autoreconf_current_directory () s/dnl.*//; $uses_autoconf = 1 if /AC_INIT/; # See below for why we look for gettext here. - $uses_gettext = 1 if /^AM_GNU_GETTEXT_VERSION/; + $uses_gettext = 1 if /^AM_GNU_GETTEXT_(REQUIRE_)?VERSION/; } } if (!$uses_autoconf) @@ -435,9 +435,9 @@ sub autoreconf_current_directory () } # Gettext consistency checks... - error "$configure_ac: AM_GNU_GETTEXT is used, but not AM_GNU_GETTEXT_VERSION" + error "$configure_ac: AM_GNU_GETTEXT is used, but not AM_GNU_GETTEXT_VERSION or AM_GNU_GETTEXT_REQUIRE_VERSION" if $uses_gettext_via_traces && ! $uses_gettext; - error "$configure_ac: AM_GNU_GETTEXT_VERSION is used, but not AM_GNU_GETTEXT" + error "$configure_ac: AM_GNU_GETTEXT_VERSION or AM_GNU_GETTEXT_REQUIRE_VERSION is used, but not AM_GNU_GETTEXT" if $uses_gettext && ! $uses_gettext_via_traces; -- 2.6.1
[PATCH] autoreconf: Support AM_GNU_GETTEXT_REQUIRE_VERSION
As reported in https://github.com/gentoo/gentoo/pull/163, gettext 0.19.6 supports using AM_GNU_GETTEXT_REQUIRE_VERSION instead of AM_GNU_GETTEXT_VERSION. Update autoreconf to support both. Signed-off-by: Michał Górny <mgo...@gentoo.org> --- bin/autoreconf.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/autoreconf.in b/bin/autoreconf.in index 9f353b0..db408f7 100644 --- a/bin/autoreconf.in +++ b/bin/autoreconf.in @@ -264,7 +264,7 @@ sub autoreconf_current_directory () s/dnl.*//; $uses_autoconf = 1 if /AC_INIT/; # See below for why we look for gettext here. - $uses_gettext = 1 if /^AM_GNU_GETTEXT_VERSION/; + $uses_gettext = 1 if /^AM_GNU_GETTEXT_(REQUIRE_)?VERSION/; } } if (!$uses_autoconf) @@ -435,9 +435,9 @@ sub autoreconf_current_directory () } # Gettext consistency checks... - error "$configure_ac: AM_GNU_GETTEXT is used, but not AM_GNU_GETTEXT_VERSION" + error "$configure_ac: AM_GNU_GETTEXT is used, but not AM_GNU_GETTEXT_VERSION or AM_GNU_GETTEXT_REQUIRE_VERSION" if $uses_gettext_via_traces && ! $uses_gettext; - error "$configure_ac: AM_GNU_GETTEXT_VERSION is used, but not AM_GNU_GETTEXT" + error "$configure_ac: AM_GNU_GETTEXT_VERSION or AM_GNU_GETTEXT_REQUIRE_VERSION is used, but not AM_GNU_GETTEXT" if $uses_gettext && ! $uses_gettext_via_traces; -- 2.6.1
Feature request: AC_PROG_CC_* macros for gnu89/gnu99-compliant compiler
Hello, With the late increase in number of clang users, we're getting a number of bugs related to the packages relying on gnu89/gnu99 standards compiler compliance without proper checks for it. Those packages fail to build because clang uses strict -std=c99 by default, and they fail to provide proper -std=gnu89 or -std=gnu99. In order to solve that properly, I would like to request having two new macros in autoconf: AC_PROG_CC_GNU89 and AC_PROG_CC_GNU99, in a similar manner to the AC_PROG_CC_C99 macro. I'm not sure what checks can be used to distinguish between strict standards and GNU ones. But the general idea is that those macros should cause clang to be run with '-std=gnu89' or '-std=gnu99' as required by the package. What are your thoughts? -- Best regards, Michał Górny signature.asc Description: PGP signature ___ Autoconf mailing list Autoconf@gnu.org https://lists.gnu.org/mailman/listinfo/autoconf
Re: Feature request: AC_PROG_CC_* macros for gnu89/gnu99-compliant compiler
On Sat, 02 Feb 2013 08:36:17 -0800 Paul Eggert egg...@cs.ucla.edu wrote: On 02/02/2013 05:13 AM, Michał Górny wrote: In order to solve that properly, I would like to request having two new macros in autoconf: AC_PROG_CC_GNU89 and AC_PROG_CC_GNU99, in a similar manner to the AC_PROG_CC_C99 macro. We've been moving in the opposite direction: AC_PROG_CC_STDC, AC_PROG_CC_C89 and AC_PROG_CC_C99 will be marked as obsolescent in the next version of Autoconf. The idea is that AC_PROG_CC should just work, and maintainers shouldn't have to fiddle with all those AC_PROG_CC_whatever macros whenever a new compiler comes out. Can you give an example of a package that has a problem, and symptoms of the problem? That might help us come up with a better solution. For example, what happens if you configure with ./configure CC='clang -std=gnu11'? The major issue we've been having is difference in inline semantics between gnu89 and c99. It hit us at least with libgcrypt [1,2], pkg-config [3,4], e2fsprogs [5]. The usual way of fixing it on our side was appending 'std=gnu89' or a similar option. But I believe configure scripts should handle this for us... [1]:https://bugs.gentoo.org/show_bug.cgi?id=420899 [2]:https://bugs.g10code.com/gnupg/issue1406 [3]:https://bugs.gentoo.org/show_bug.cgi?id=297248 [4]:https://bugs.freedesktop.org/show_bug.cgi?id=29313 [5]:https://bugs.gentoo.org/show_bug.cgi?id=297243 -- Best regards, Michał Górny signature.asc Description: PGP signature ___ Autoconf mailing list Autoconf@gnu.org https://lists.gnu.org/mailman/listinfo/autoconf
