Re: sub conditionals_true_when (@@) [PATCH]

[Tom Tromey]

Richard --

I got notification today that your copyright assignment has come in.
So I hope to look at this patch pretty soon.
If I haven't replied about it in the next week or so, please feel free
to remind me.

Thanks,
Tom

Re: Supporting include in Makefiles

[Akim Demaille]

I might be wrong, but I believe that what you describe is already in
the current Automake.  It might be documented, but at least there is
the macro:

src/am/m4 % less make.m4 nostromo 18:34

# AM_MAKE_INCLUDE()
# -
# Check to see how make treats includes.
AC_DEFUN([AM_MAKE_INCLUDE],
[am_make=${MAKE-make}
cat  confinc  'END'
doit:
@echo done
END
# If we don't find an include directive, just comment out the code.
AC_MSG_CHECKING([for style of include used by $am_make])
_am_include='#'
_am_quote=
_am_result=none
# First try GNU make style include.
echo include confinc  confmf
# We grep out `Entering directory' and `Leaving directory'
# messages which can occur if `w' ends up in MAKEFLAGS.
# In particular we don't look at `^make:' because GNU make might
# be invoked under some other name (usually gmake), in which
# case it prints its new name instead of `make'.
if test `$am_make -s -f confmf 2 /dev/null | fgrep -v 'ing directory'` = don
e; then
   _am_include=include
   _am_quote=
   _am_result=GNU
fi
# Now try BSD make style include.
if test $_am_include = #; then
   echo '.include confinc'  confmf
   if test `$am_make -s -f confmf 2 /dev/null` = done; then
  _am_include=.include
  _am_quote=''
  _am_result=BSD
   fi
fi
AC_SUBST(_am_include)
AC_SUBST(_am_quote)
AC_MSG_RESULT($_am_result)
rm -f confinc confmf
])

Re: Supporting include in Makefiles

[Akim Demaille]

I've read into more details your proposal, and it looks very good,
much more robust than the current approach in Automake IIRC.

I'm OK with integrating this with minor changes into Autoconf, but as
Automake 1.5 will already provide something similar (and it will not
require 2.51+ yet, 1.6 will) we should be sure to have the same
interface.

I.e., I propose that 1.5 integrates your proposal with AM_, and 2.51
with AC_, and AM_ AU defined to AC_.


BTW, does Automake *use* that feature?  If not, then it should not
provide this macro IMHO.  It should stop distributing macros, that's
Autoconf job, not Automake's.

Re: Supporting include in Makefiles

[Raja R Harinath]

Hi,

Akim Demaille [EMAIL PROTECTED] writes:
 BTW, does Automake *use* that feature?  If not, then it should not
 provide this macro IMHO.  It should stop distributing macros, that's
 Autoconf job, not Automake's.

It is used internally to support the dependency tracking mechanism.
It is almost definitely not intended as a generic mechanism to support
Makefile includes.

After all, automake already has it's own support for including
makefile fragments -- and that mechanism is already portable to
'make's that don't support any form of 'include's.

- Hari
-- 
Raja R Harinath -- [EMAIL PROTECTED]
When all else fails, read the instructions.  -- Cahn's Axiom
Our policy is, when in doubt, do the right thing.   -- Roy L Ash