Re: {testsuite-work} [PATCH] tests: avoid spurious failures in cross-compile mode

2011-05-19 Thread Stefano Lattarini
On Wednesday 18 May 2011, Ralf Wildenhues wrote:
 Hi Stefano,
 
 * Stefano Lattarini wrote on Wed, May 18, 2011 at 06:19:55PM CEST:
  I will wait until tomorrow for a review, before pushing.
 
 I really don't have the time to do a close review right now,

Bummer :-(

 but can you use 'native' instead of 'non-cross' and go ahead with
 that?  That would fit the lingo better.

Of course.  I never liked 'non-cross' very much, but I failed to
come up with a better name.

Unfortunately, I've already used the 'non-cross' requirement in a
commit on 'maint'.  But luckily, that's used only in 'tests/defs',
so I can change it without any real churn; then I'll rebase my
patch accordingly.

Regards,
  Stefano



Re: {testsuite-work} [PATCH] tests: avoid spurious failures in cross-compile mode

2011-05-19 Thread Stefano Lattarini
On Thursday 19 May 2011, Stefano Lattarini wrote:
 On Wednesday 18 May 2011, Ralf Wildenhues wrote:
  Can you use 'native' instead of 'non-cross' and go ahead with
  that?  That would fit the lingo better.
 
 Of course.  I never liked 'non-cross' very much, but I failed to
 come up with a better name.
 
 Unfortunately, I've already used the 'non-cross' requirement in a
 commit on 'maint'.  But luckily, that's used only in 'tests/defs',
 so I can change it without any real churn; then I'll rebase my
 patch accordingly.
 
 Regards,
   Stefano
 
Attached is what I've finally pushed.

Regards,
  Stefano
From e9e5d4ac2d8ba980211303c9b1e16c3199f34478 Mon Sep 17 00:00:00 2001
Message-Id: e9e5d4ac2d8ba980211303c9b1e16c3199f34478.1305837207.git.stefano.lattar...@gmail.com
From: Stefano Lattarini stefano.lattar...@gmail.com
Date: Sun, 15 May 2011 16:33:01 +0200
Subject: [PATCH] tests: avoid spurious failures in cross-compile mode

* tests/depcomp2.test: Ensure verbose printing of captured stderr
from configure.
* tests/ansi3.test ($required): Add 'native', as the ansi2knr
functionality is not meant to work with a cross-compiler.
* tests/ansi3b.test: Likewise.
* tests/ansi5.test: Likewise.
* tests/ansi6.test: Likewise.
* tests/ansi7.test: Likewise.
* tests/ansi8.test: Likewise.
* tests/ansi10.test: Likewise.
* tests/subobj3.test: Likewise.
* tests/check8.test ($required): Add 'native', as this test is
not meant to work with a cross-compiler.
* tests/gnits2.test: Likewise.
* tests/ltconv.test: Likewise.
* tests/ltcond2.test: Likewise.
* tests/parallel-tests5.test: Likewise.
* tests/specflg7.test: Likewise.
* tests/specflg8.test: Likewise.
* tests/check5.test: Likewise.  Also, ensure verbose printing of
captured make output, and thrown in few cosmetic and consistency
improvements.
* tests/ltinit.test: Be laxer in grepping configure output, to
avoid spurious failures on systems which lack POSIX dynamic
linking (e.g., MinGW), or when cross-compiling for such systems.
* tests/ansi9.test: Skip parts of the test that would require a
native compiler.
* tests/backcompat6.test: Likewise.
* tests/depcomp8a.test: Likewise.
* tests/pr401.test: Likewise.
* tests/pr401b.test: Likewise.
* tests/pr401c.test: Likewise.
* tests/target-cflags.test: Likewise.
* tests/lex3.test: Likewise.
* tests/yacc-basic.test: Likewise.
* tests/autohdr4.test: Likewise.  Also, extend the test to ensure
more coverage in cross-compile mode.
* tests/canon7.test: Likewise.
* tests/check9.test: Removed, split into two new tests ...
* tests/check-subst-prog.test: ... this one, which requires a
native C compiler ...
* tests/check-subst.test: ... and this one, which doesn't require
any compiler.
* tests/parallel-tests4.test: Removed, split into two new tests ...
* tests/parallel-tests-suffix-prog.test: ... this one, which
requires a native C compiler ...
* tests/parallel-tests-suffix.test: ... and this one, which
doesn't require any compiler.
* tests/parallel-tests7.test: Removed, split into two new tests ...
* tests/parallel-tests-ext-driver-prog.test: ... this one, which
requires a native C compiler ...
* tests/parallel-tests-ext-driver.test: ... and this one, which
doesn't require any compiler.
* tests/Makefile.am (TESTS): Update.
---
 ChangeLog  |   58 +
 tests/Makefile.am  |9 +-
 tests/Makefile.in  |   22 ++--
 tests/ansi10.test  |1 +
 tests/ansi3.test   |1 +
 tests/ansi3b.test  |1 +
 tests/ansi5.test   |1 +
 tests/ansi6.test   |1 +
 tests/ansi7.test   |1 +
 tests/ansi9.test   |   13 ++-
 tests/autohdr4.test|   21 +++-
 tests/backcompat6.test |5 +-
 tests/canon7.test  |7 +
 tests/{check9.test = check-subst-prog.test}   |   15 +-
 tests/{check9.test = check-subst.test}|   73 ++-
 tests/check5.test  |   17 ++-
 tests/check8.test  |2 +
 tests/depcomp2.test|1 +
 tests/depcomp8a.test   |4 +-
 tests/gnits2.test  |1 +
 tests/lex3.test|6 +-
 tests/ltcond2.test |2 +-
 tests/ltconv.test  |2 +-
 tests/ltinit.test  |2 +-
 ...s7.test = parallel-tests-ext-driver-prog.test} |   24 ++--
 tests/parallel-tests-ext-driver.test   |  136 
 ...tests4.test = parallel-tests-suffix-prog.test} |   22 +++-
 ...llel-tests4.test = parallel-tests-suffix.test} | 

Re: {testsuite-work} [PATCH] tests: avoid spurious failures in cross-compile mode

2011-05-18 Thread Ralf Wildenhues
Hi Stefano,

* Stefano Lattarini wrote on Wed, May 18, 2011 at 06:19:55PM CEST:
 I will wait until tomorrow for a review, before pushing.

I really don't have the time to do a close review right now, but can you
use 'native' instead of 'non-cross' and go ahead with that?  That would
fit the lingo better.

Thanks,
Ralf

 Subject: [PATCH] tests: avoid spurious failures in cross-compile mode
 
 * tests/depcomp2.test: Ensure verbose printing of captured stderr
 from configure.
 * tests/ansi3.test ($required): Add 'non-cross', as the ansi2knr
 functionality is not meant to work with a cross-compiler.
[...]