[Avogadro-devel] Problem with Gerrit
Hi, I pushed a patch to gerrit but it doesn't show up on the webpage. When I try to push it again it says there is no Change-Id so I think the patch was uploaded correctly. Any ideas what might have gone wrong? Thanks in advance, Tim -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ Avogadro-devel mailing list Avogadro-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/avogadro-devel
Re: [Avogadro-devel] Problem with Gerrit
Hi Tim, On Sun, Mar 18, 2012 at 11:45 AM, Tim Vandermeersch tim.vandermeer...@gmail.com wrote: Hi, I pushed a patch to gerrit but it doesn't show up on the webpage. When I try to push it again it says there is no Change-Id so I think the patch was uploaded correctly. Any ideas what might have gone wrong? Since we switched to topic based review we need to have a Change-Id line as the final line in the commit message (I have been looking at whether we can relax that). The setup for development script contains instructions for downloading the local hook that will add that automatically for you, http://avogadro.openmolecules.net/wiki/Working_with_Gerrit You can add the line to your last commit by running git commit --amend, if you downloaded the local hook it will simply append it for you once you save and close. Let me know if you are still having trouble - I would like to automate the local hook stuff soon to make this simpler. Marcus -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ Avogadro-devel mailing list Avogadro-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/avogadro-devel
Re: [Avogadro-devel] Problem with Gerrit
Hi, On Sun, Mar 18, 2012 at 5:08 PM, Marcus D. Hanwell marcus.hanw...@kitware.com wrote: Hi Tim, On Sun, Mar 18, 2012 at 11:45 AM, Tim Vandermeersch tim.vandermeer...@gmail.com wrote: Hi, I pushed a patch to gerrit but it doesn't show up on the webpage. When I try to push it again it says there is no Change-Id so I think the patch was uploaded correctly. Any ideas what might have gone wrong? Since we switched to topic based review we need to have a Change-Id line as the final line in the commit message (I have been looking at whether we can relax that). The setup for development script contains instructions for downloading the local hook that will add that automatically for you, http://avogadro.openmolecules.net/wiki/Working_with_Gerrit You can add the line to your last commit by running git commit --amend, if you downloaded the local hook it will simply append it for you once you save and close. Let me know if you are still having trouble - I would like to automate the local hook stuff soon to make this simpler. Once I installed the hook and did git gerrit-push it appeared in gerrit. Thanks, Tim Marcus -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ Avogadro-devel mailing list Avogadro-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/avogadro-devel
[Avogadro-devel] open babel doesn't find eigen2 in avogadro-squared build
Hi, When building avogadro using avogadro squared, open babel doesn't find the eigen2 include files. I pushed a patch to gerrit to include the new conformer options from OB but these require OB to be build with eigen2. I think we need to add the eigen2 path to avogadro_build_vars before including External_openbabel but I'm not sure how this all works yet. Tim -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ Avogadro-devel mailing list Avogadro-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/avogadro-devel
