Re: [PATCH] awful-xml-escaping.patch
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julien Danjou wrote: At 1233085574 time_t, Matthew Wild wrote: The current routines for escaping XML in awful.util.[escape/unescape] are not too good, both in terms of performance and accuracy. They use multiple gsubs, generating a new string each time, which is instantly discarded and must then be garbage-collected, etc. Thanks, commited! Cheers, Hi, maybe we should stop implementing integrated functions over and over again and use CGI.escapeHTML() instead. However we have to require 'cgi' for this and we have to decide if this is too much overhead or not. Regards, Leon Winter -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkmEn48ACgkQ3qn9m9SfDYcVwwCghS6zZLPMDugNh7F7PUANKiO9 lcMAoOrtOKYTjgxR/rZj52E2Gn6v5lo0 =tlaQ -END PGP SIGNATURE- -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
Re: [PATCH] awful-xml-escaping.patch
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Leon Winter wrote: Julien Danjou wrote: At 1233085574 time_t, Matthew Wild wrote: The current routines for escaping XML in awful.util.[escape/unescape] are not too good, both in terms of performance and accuracy. They use multiple gsubs, generating a new string each time, which is instantly discarded and must then be garbage-collected, etc. Thanks, commited! Cheers, Hi, maybe we should stop implementing integrated functions over and over again and use CGI.escapeHTML() instead. However we have to require 'cgi' for this and we have to decide if this is too much overhead or not. Regards, Leon Winter Ignore this, this in only possible in Ruby. I was just confused about the same syntax :F Regards, Leon Winter -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkmEqrEACgkQ3qn9m9SfDYfDtgCg1CuIgMtRyQwsO30fdeqHWLe+ cDwAn2mm7qfvOWP/A6V/CJieB3Zdt1xw =+X7V -END PGP SIGNATURE- -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
Re: [PATCH] awful-xml-escaping.patch
At 1233085574 time_t, Matthew Wild wrote: The current routines for escaping XML in awful.util.[escape/unescape] are not too good, both in terms of performance and accuracy. They use multiple gsubs, generating a new string each time, which is instantly discarded and must then be garbage-collected, etc. Thanks, commited! Cheers, -- Julien Danjou // ᐰ jul...@danjou.info http://julien.danjou.info // 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD signature.asc Description: Digital signature