[awesome bugs] #1124 - ssh-askpass either doesn't show at all or is shown below all other windows
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#1124 - ssh-askpass either doesn't show at all or is shown below all other windows User who did this - Uli Schlachter (psychon) -- commit 389a54e356f700a4f2a621e05dbdbafab4a3a03a Author: Uli Schlachter psyc...@znc.in Date: Sat Nov 23 14:42:56 2013 +0100 Really ignore loops in transient_for (FS#1124) The code in property_update_wm_transient_for() looked at the transient_for relation before the new transient got set. However, the code is supposed to check if we get a loop after introducing this new transient_for. Thus, if we arrive back at the client that we started from, we can be sure that there is a cycle. Signal this by setting the loop counter high enough to abort the loop and make the rest of this function do nothing. No idea how I missed this case before nor why I cannot reproduce this on debian, but can reproduce it on Arch just fine. -- More information can be found at the following URL: https://awesome.naquadah.org/bugs/index.php?do=detailstask_id=1124#comment3757 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
[awesome bugs] #1124 - ssh-askpass either doesn't show at all or is shown below all other windows
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#1124 - ssh-askpass either doesn't show at all or is shown below all other windows User who did this - Uli Schlachter (psychon) Reason for closing: Fixed Additional comments about closing: commit 3269656d59209f86b279d99fa8481dd4e0ba4fd4 Author: Uli Schlachter psyc...@znc.in Date: Fri Oct 4 14:31:48 2013 +0200 client: Ignore transient_for causing loops (FS#1124) Lots of code assumes that it can recursively follow a client's transient_for field until it reached an end without a transient_for client. Instead of fixing all those places to properly handle loops, this patch just makes us ignore WM_TRANSIENT_FOR if the property causes a loop. This means that it can be a little random which WM_TRANSIENT_FOR property is ignored, because it will always be the one that happens to complete the cycle. I don't think that this is bad, because there shouldn't be any loops in the first place. Lots-of-kudos-to: David Mohr da...@mcbf.net Signed-off-by: Uli Schlachter psyc...@znc.in More information can be found at the following URL: https://awesome.naquadah.org/bugs/index.php?do=detailstask_id=1124 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
[awesome bugs] #1124 - ssh-askpass either doesn't show at all or is shown below all other windows
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#1124 - ssh-askpass either doesn't show at all or is shown below all other
windows
User who did this - Uli Schlachter (psychon)
--
WM_CLASS(STRING) = ssh-askpass, SshAskpass
{ class = ssh-askpass },
The class is SshAskpass, not ssh-askpass (that's the instance). That's why your
rule doesn't work. However, you don't want that rule to work, because it once
again crashes awesome. We should just ignore loops in WM_TRANSIENT_FOR
properties... :-(
--
More information can be found at the following URL:
https://awesome.naquadah.org/bugs/index.php?do=detailstask_id=1124#comment3498
You are receiving this message because you have requested it from the Flyspray
bugtracking system. If you did not expect this message or don't want to
receive mails in future, you can change your notification settings at the URL
shown above.
--
To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
[awesome bugs] #1124 - ssh-askpass either doesn't show at all or is shown below all other windows (Attachment added)
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#1124 - ssh-askpass either doesn't show at all or is shown below all other windows User who did this - David Mohr (squisher) -- This aleviates the problem for me. It only catches self-references, but maybe that's enough? -- One or more files have been attached. More information can be found at the following URL: https://awesome.naquadah.org/bugs/index.php?do=detailstask_id=1124#comment3500 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
[awesome bugs] #1124 - ssh-askpass either doesn't show at all or is shown below all other windows
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#1124 - ssh-askpass either doesn't show at all or is shown below all other windows User who did this - Uli Schlachter (psychon) -- That's kind of a cheap hack. I guess the best we can do is to ignore WM_TRANSIENT if it causes a loop and revert the fix for FS#573. Clients should still be marked as dialogs, but just their .transient property should be nil. I am not sure if I like that, but that should fix all the endless loop due to transients-bug once and for all (and it would also fix this bug since ssh-askpass will no longer be in the ignore layer, but instead get stacked normally). -- More information can be found at the following URL: https://awesome.naquadah.org/bugs/index.php?do=detailstask_id=1124#comment3504 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
[awesome bugs] #1124 - ssh-askpass either doesn't show at all or is shown below all other windows
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#1124 - ssh-askpass either doesn't show at all or is shown below all other windows User who did this - David Mohr (squisher) -- Yeah, sorry, I don't know awesome (or X11 for that matter) to provide a nicer fix... The resolution you outlined seems reasonable to me. The desired behavior is that ssh-askpass is visible, i.e. on top, and can grab the focus. -- More information can be found at the following URL: https://awesome.naquadah.org/bugs/index.php?do=detailstask_id=1124#comment3505 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
[awesome bugs] #1124 - ssh-askpass either doesn't show at all or is shown below all other windows
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#1124 - ssh-askpass either doesn't show at all or is shown below all other windows User who did this - David Mohr (squisher) -- I do realize that the behavior of ssh-askpass is probably not optimal. A friend, for example, explicitly prefers ssh-askpass over its alternatives because it has been security audited. That means its unlikely to change, so I'm kindly asking to work around these quirks. I'm definitely offering my help in the process. -- More information can be found at the following URL: https://awesome.naquadah.org/bugs/index.php?do=detailstask_id=1124#comment3496 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
[awesome bugs] #1124 - ssh-askpass either doesn't show at all or is shown below all other windows
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#1124 - ssh-askpass either doesn't show at all or is shown below all other windows User who did this - David Mohr (squisher) -- I can confirm the issue in the git version (4540b8927a61d97d9536dd7500deeed688605a38). Is the 'above = true' even recognized by awesome? Reading the code seems to suggest it doesn't. Is there some other way to raise a window? -- More information can be found at the following URL: https://awesome.naquadah.org/bugs/index.php?do=detailstask_id=1124#comment3497 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
[awesome bugs] #1124 - ssh-askpass either doesn't show at all or is shown below all other windows
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
A new Flyspray task has been opened. Details are below.
User who did this - David Mohr (squisher)
Attached to Project - awesome
Summary - ssh-askpass either doesn't show at all or is shown below all other
windows
Task Type - Bug Report
Category - Core
Status - Unconfirmed
Assigned To -
Operating System - Linux
Severity - Medium
Priority - Normal
Reported Version - 3.4.15
Due in Version - Undecided
Due Date - Undecided
Details - ssh-askpass is an X11 GUI asking for your ssh key password.
After starting it, it is listed in the task bar, but I can't find the window
anywhere.
If I test it in Xephyr I can see the window, but it's on the lowest layer; all
other windows are above it.
I attempted the following rule to no avail
{ rule = { class = ssh-askpass }, properties = { above = true, floating =
true } },
xprop lists:
_NET_WM_DESKTOP(CARDINAL) = 0
WM_STATE(WM_STATE):
window state: Normal
icon window: 0x0
WM_PROTOCOLS(ATOM): protocols WM_DELETE_WINDOW
WM_TRANSIENT_FOR(WINDOW): window id # 0x89
WM_LOCALE_NAME(STRING) = C
WM_CLASS(STRING) = ssh-askpass, SshAskpass
WM_HINTS(WM_HINTS):
Client accepts input or input focus: True
Initial state is Normal State.
WM_NORMAL_HINTS(WM_SIZE_HINTS):
program specified location: 0, 0
program specified size: 0 by 0
program specified minimum size: 375 by 95
program specified maximum size: 375 by 95
program specified base size: 375 by 95
WM_CLIENT_MACHINE(STRING) = alucardo
WM_COMMAND(STRING) = { ssh-askpass }
WM_NAME(STRING) = OpenSSH Authentication Passphrase Request
It'd be awesome to get it fixed! It's not entirely trustworthy to enter your
ssh key password without seeing the window to know it actually got the focus...
Thanks, ~David
More information can be found at the following URL:
https://awesome.naquadah.org/bugs/index.php?do=detailstask_id=1124
You are receiving this message because you have requested it from the Flyspray
bugtracking system. If you did not expect this message or don't want to
receive mails in future, you can change your notification settings at the URL
shown above.
--
To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
