Re: [PATCH] awful.autofocus: restore focus on hide/minimize

[koniu]

On Tue, Aug 25, 2009 at 14:19, Julien Danjoujul...@danjou.info wrote:
 At 1251205054 time_t, koniu wrote:
 Confirmed. However, if you do the same without awesome-client, just
 from lua prompt the behaviour is as I described.

 keyboard grab - focusout - - minimize the window RETURN -
 focusin event - unminimize the window - give it focus back

OK, so that's yet another issue.

 It starts ok, but then if i try to minimize it while its in focus
 (using binding which launches above function) it will just lose focus
 but not go away. Only if I press the combo again (while it's not
 focused anymore) it minimizes.

 You do not grab the mouse/keyboard, aren't you?

Nope, it's just a regular function spawned by awful.key. Curiously
enough it works fine when I use c.hidden but c.minimized bears the
described effect.

k

-- 
To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Re: [PATCH] awful.autofocus: restore focus on hide/minimize

[Julien Danjou]

At 1251160039 time_t, koniu wrote:
 1. client.focus.hidden = true hides the client but doesn't restore focus

The emitted signal was wrong, I've fixed.

 2. client.focus.minimized = true fails to minimized the client and but
 switches the focus to the previous in history

It works fine here.

-- 
Julien Danjou
// ᐰ jul...@danjou.info   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
// Don't give up.


signature.asc
Description: Digital signature

Re: [PATCH] awful.autofocus: restore focus on hide/minimize

[koniu]

On Tue, Aug 25, 2009 at 09:06, Julien Danjoujul...@danjou.info wrote:
 2. client.focus.minimized = true fails to minimized the client and but
 switches the focus to the previous in history

 It works fine here.

Can you try with two clients in the tag (tile layout helps), it's
definitely broken here - just tested with default config.

cheers,
koniu

-- 
To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Re: [PATCH] awful.autofocus: restore focus on hide/minimize

[Julien Danjou]

At 1251201180 time_t, koniu wrote:
 Can you try with two clients in the tag (tile layout helps), it's
 definitely broken here - just tested with default config.

I spawn 2 terms in tag with tiled layout.
I type:
awesome-client
client.focus.minimized = true

It got minimized and focus switch.
Same with .hidden = true

Cheers,
-- 
Julien Danjou
// ᐰ jul...@danjou.info   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
// Ferns will rule the world.


signature.asc
Description: Digital signature

Re: [PATCH] awful.autofocus: restore focus on hide/minimize

[koniu]

Hmm, i did some more testing and this doesn't quite work as expected.
I've seen this problem before, prior to signals and all that jazz but
I did have it working right with the following hook (where
restore_focus is a function like one in autofocus):

awful.hooks.property.register(function (c, prop)
  if type(c) == client and (prop == minimized or prop == hide) then
restore_focus(c.screen, c)
end

Right now, with the patch applied:

1. client.focus.hidden = true hides the client but doesn't restore focus
2. client.focus.minimized = true fails to minimized the client and but
switches the focus to the previous in history

I'm confused.

k

-- 
To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.