AWT Dev hg: jdk8/awt/jdk: 7190597: Nimbus: regtest for 4235420 fails
Changeset: 8d570757fe95 Author:rupashka Date: 2012-08-17 17:04 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8d570757fe95 7190597: Nimbus: regtest for 4235420 fails Reviewed-by: alexsch + test/javax/swing/JTable/4235420/bug4235420.java
AWT Dev hg: jdk8/awt/jdk: 7190543: Nimbus LaF: regression: JSplitPane is not opaque -- or should it?
Changeset: 164919db548b Author:rupashka Date: 2012-08-15 14:33 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/164919db548b 7190543: Nimbus LaF: regression: JSplitPane is not opaque -- or should it? Reviewed-by: alexsch + test/javax/swing/JSplitPane/4201995/bug4201995.java
AWT Dev hg: jdk8/awt/jdk: 7167780: Hang javasoft.sqe.tests.api.javax.swing.Timer.Ctor2Tests
Changeset: 3502753a9d66 Author:rupashka Date: 2012-07-25 13:41 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3502753a9d66 7167780: Hang javasoft.sqe.tests.api.javax.swing.Timer.Ctor2Tests Reviewed-by: alexsch ! src/share/classes/javax/swing/TimerQueue.java
AWT Dev hg: jdk8/awt/jdk: 7124330: [macosx] javax.swing.JComboBox throws unexpected ClassCastException
Changeset: 28665fa73b4a Author:rupashka Date: 2012-07-19 19:09 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/28665fa73b4a 7124330: [macosx] javax.swing.JComboBox throws unexpected ClassCastException Reviewed-by: kizune ! src/macosx/classes/com/apple/laf/AquaComboBoxUI.java
Re: AWT Dev [8] Review request for 7170657: [macosx] There seems to be no keyboard/mouse action to select non-contiguous items in List
Hi Sergey, Looks good for me. Regards, Pavel Hi, Pavel. Thanks for review. See comments inline 12.07.2012 20:26, Pavel Porvatov wrote: Hi Sergey, The fix looks good. Could you please remove unnecessary code from the test like: 1. @run main/othervm bug7170657 done 2. The FAILED field: you can throw exception from the fail method In this case we skip part of the test. Useful for debug. 3. What is the reason to use final here: public final class? I do not think that someone will want to be inherited from it. I just make all classes final by default. New version of the fix: http://cr.openjdk.java.net/~serb/7170657/webrev.01/ Regards, Pavel Hi Everyone, Please review the fix. Bug in SwingUtilities.convertMouseEvent().This method does not convert extended state of the event. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170657 Webrev can be found at: http://cr.openjdk.java.net/~serb/7170657/webrev.00
AWT Dev hg: jdk8/awt/jdk: 7169111: Unreadable menu bar with Ambiance theme in GTK LF
Changeset: 85f72a4f5f68 Author:rupashka Date: 2012-06-28 14:05 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/85f72a4f5f68 7169111: Unreadable menu bar with Ambiance theme in GTK LF Reviewed-by: kizune ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKStyleFactory.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuUI.java
AWT Dev hg: jdk8/awt/jdk: 7165725: JAVA6 HTML PARSER CANNOT PARSE MULTIPLE SCRIPT TAGS IN A LINE CORRECTLY
Changeset: 45259658e158 Author:rupashka Date: 2012-06-09 17:42 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/45259658e158 7165725: JAVA6 HTML PARSER CANNOT PARSE MULTIPLE SCRIPT TAGS IN A LINE CORRECTLY Reviewed-by: alexsch ! src/share/classes/javax/swing/text/html/parser/Parser.java + test/javax/swing/text/html/parser/Parser/7165725/bug7165725.java + test/javax/swing/text/html/parser/Parser/7165725/false-text-after-script.html + test/javax/swing/text/html/parser/Parser/7165725/successive-script-tag.html
AWT Dev hg: jdk8/awt/jdk: 7156657: Version 7 doesn't support translucent popup menus against a translucent window
Changeset: 4acd0211f48b Author:rupashka Date: 2012-06-07 21:49 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4acd0211f48b 7156657: Version 7 doesn't support translucent popup menus against a translucent window Reviewed-by: art, alexsch ! src/share/classes/javax/swing/PopupFactory.java ! src/share/demo/jfc/TransparentRuler/transparentruler/Ruler.java + test/javax/swing/JPopupMenu/7156657/bug7156657.java
AWT Dev hg: jdk8/awt/jdk: 7168144: No appropriate CCC request for changes introduced by 7154030
Changeset: 1ee12bca4823 Author:rupashka Date: 2012-05-21 18:55 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1ee12bca4823 7168144: No appropriate CCC request for changes introduced by 7154030 Reviewed-by: alexsch ! src/share/classes/javax/swing/JComponent.java
AWT Dev hg: jdk8/awt/jdk: 7166322: closed/javax/swing/text/html/HTMLEditorKit/4242228/bug4242228.java failed since 1.8.0b36
Changeset: f9217bd87199 Author:rupashka Date: 2012-05-17 15:41 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f9217bd87199 7166322: closed/javax/swing/text/html/HTMLEditorKit/4242228/bug4242228.java failed since 1.8.0b36 Reviewed-by: alexsch + test/javax/swing/text/html/HTMLEditorKit/4242228/bug4242228.java
AWT Dev hg: jdk8/awt/jdk: 7149090: Nimbus:BorderFactory.createTitledBorder() the DEFAULT position of a title is not the same as the TOP
Changeset: 602398b3a8e7 Author:rupashka Date: 2012-04-15 12:58 +0300 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/602398b3a8e7 7149090: Nimbus:BorderFactory.createTitledBorder() the DEFAULT position of a title is not the same as the TOP Reviewed-by: alexp ! src/share/classes/javax/swing/BorderFactory.java + test/javax/swing/border/Test7149090.java
AWT Dev hg: jdk8/awt/jdk: 7160653: test/javax/swing/plaf/synth/7158712/bug7158712.java failed on Ubuntu
Changeset: 9b4e642a3053 Author:rupashka Date: 2012-04-12 12:48 +0300 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9b4e642a3053 7160653: test/javax/swing/plaf/synth/7158712/bug7158712.java failed on Ubuntu Reviewed-by: alexp ! test/javax/swing/plaf/synth/7158712/bug7158712.java
AWT Dev hg: jdk8/awt/jdk: 7158712: Synth Property ComboBox.popupInsets is ignored
Changeset: 8fe9b93e2474 Author:rupashka Date: 2012-04-10 19:09 +0300 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8fe9b93e2474 7158712: Synth Property ComboBox.popupInsets is ignored Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/synth/SynthComboPopup.java + test/javax/swing/plaf/synth/7158712/bug7158712.java ! test/javax/swing/regtesthelpers/Util.java
AWT Dev hg: jdk8/awt/jdk: 4310381: Text in multi-row/col JTabbedPane tabs can be truncated/clipped
Changeset: 1dd6fe680681 Author:rupashka Date: 2012-03-23 15:16 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1dd6fe680681 4310381: Text in multi-row/col JTabbedPane tabs can be truncated/clipped Reviewed-by: rupashka Contributed-by: Charles Lee litt...@linux.vnet.ibm.com ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java + test/javax/swing/JTabbedPane/4310381/bug4310381.html + test/javax/swing/JTabbedPane/4310381/bug4310381.java
AWT Dev hg: jdk8/awt/jdk: 6888634: test/closed/javax/swing/Popup/TaskbarPositionTest.java fails
Changeset: 100b6c2f75ba Author:rupashka Date: 2012-03-22 17:10 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/100b6c2f75ba 6888634: test/closed/javax/swing/Popup/TaskbarPositionTest.java fails Reviewed-by: alexp ! src/share/classes/javax/swing/JPopupMenu.java
Re: AWT Dev Swing Dev Review request for 7154030: java.awt.Component.hide() does not repaint parent container
Hi Jonathan,
Hi Artem,
2012/3/20 Artem Ananiev artem.anan...@oracle.com
mailto:artem.anan...@oracle.com
Hi, Jonathan,
I'm adding swing-dev to CC as we now consider changing Swing code.
What you propose sounds technically reasonable, but I don't think
it is worth doing anyway as show() and hide() have been deprecated
for years now.
Although show() and hide() have been deprecated for years, in my
opinion supporting these APIs will still benefit many applications and
convince users that Java still has got strong backward compatibility
:D. Any ideas from Swing group?
I don't see why the words backward compatibility are here. There is a
bug in deprecated methods show and hide (I've checked that jdk5 has
the same problem), and that's one additional reason to use setVisible().
I agree with Artem that fixing deprecated API is not a high priority
task (but we should keep backward compatibility, of course). I also
think, that to leave all as is is a good decision for the described
problem
Regards, Pavel
Even if we accept the change in JComponent.hide(), we should then
override show() as well (lightweight component may be non-opaque,
so we should repaint from its parent), so there will be code
duplication. This is one more reason to leave all as is.
Yes, I noticed that code duplication too and am trying to make a more
compact patch for this problem.
This is my personal opinion, I'm not a Swing expert, though. Let
anyone from the Swing group comment.
Thanks,
Artem
On 3/20/2012 12:28 PM, Jonathan Lu wrote:
Hi Artem,
Thanks for your time.
2012/3/19 Artem Ananiev artem.anan...@oracle.com
mailto:artem.anan...@oracle.com
mailto:artem.anan...@oracle.com
mailto:artem.anan...@oracle.com
Hi, Jonathan,
given the code in java.awt.Component, your statement about
difference between hide() and setVisible(false) looks
pretty strange
to me. Indeed, here is the implementation:
public void show(boolean b) {
if (b) {
show();
} else {
hide();
}
}
and
public void setVisible(boolean b) {
show(b);
}
In JComponent the latter method is overridden and adds
exactly what
you propose: parent.repaint(). This addition makes sense for
lightweight components (e.g. Swing), but heavyweight AWT
components
shouldn't require this: repaint request is sent from the
native system.
Yes, lightweight and heavyweight components differ in
painting. The
original test case only works for the conditions of lightweight
components, with another test case for heavyweight components,
I found
that the problem could not be reproduced on AWT any more. I
think the
change is only applicable for Swing components, so how about
repaint in
JComponent.hide() like this?
diff -r cdbb33303ea3 src/share/classes/javax/swing/JComponent.java
--- a/src/share/classes/javax/swing/JComponent.javaWed Mar 14
13:50:37 2012 -0700 tel:2012%20-0700 tel:2012%20-0700
+++ b/src/share/classes/javax/swing/JComponent.javaTue Mar 20
16:24:09 2012 +0800
@@ -5237,6 +5237,16 @@
}
}
+public void hide() {
+super.hide();
+Container parent = getParent();
+if (parent != null) {
+Rectangle r = getBounds();
+parent.repaint(r.x, r.y, r.width, r.height);
+parent.invalidate();
+}
+}
+
/**
* Returns whether or not the region of the specified
component is
* obscured by a sibling.
Thanks,
Artem
On 3/15/2012 12:24 PM, Jonathan Lu wrote:
Hi awt-dev,
java.awt.Component.hide() was declared as deprecation and
replaced by
setVisible(boolean), but in my tests, it does not works
in the
same way
as setVisible(false). The reason of this failure is that
java.awt.Component.hide() does not repaint the special
area it
used to
taken of parent container. Although this is deprecated
method,
it may
still valuable for customers due to compatibility
reason. Bug
7154030
created for this issue.
Here's a simple test case to demonstrate this problem.
/*
* Copyright (c) 2012 Oracle and/or its affiliates.
AWT Dev hg: jdk8/awt/jdk: 7027139: getFirstIndex() does not return the first index that has changed
Changeset: 84ba9688893f Author:rupashka Date: 2012-03-13 13:18 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/84ba9688893f 7027139: getFirstIndex() does not return the first index that has changed Reviewed-by: alexp ! src/share/classes/javax/swing/DefaultListSelectionModel.java + test/javax/swing/JTable/7027139/bug7027139.java
Re: AWT Dev Regression: JTextField content cannot be selected
Hi Alex, That's a known problem and will be fixed soon. See http://bugs.sun.com/view_bug.do?bug_id=7146377. Regards, Pavel With the latest Java 8 (b28) on Windows 7, I cannot use my mouse to drag and select text in any text fields. This is working fine previously (tested on Java 7 u2, u3 and Java 6 u30). Thanks, Alex.
AWT Dev hg: jdk8/awt/jdk: 7107099: JScrollBar does not show up even if there are enough lebgth of textstring in textField
Changeset: 13a4490cba63 Author:rupashka Date: 2012-02-22 14:31 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/13a4490cba63 7107099: JScrollBar does not show up even if there are enough lebgth of textstring in textField Reviewed-by: alexp ! src/share/classes/javax/swing/JViewport.java + test/javax/swing/JViewport/7107099/bug7107099.java
AWT Dev hg: jdk8/awt/jdk: 7089914: Focus on image icons are not visible in javaws cache with high contrast mode
Changeset: 362867d5caa4 Author:rupashka Date: 2012-02-16 17:42 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/362867d5caa4 7089914: Focus on image icons are not visible in javaws cache with high contrast mode Reviewed-by: rupashka Contributed-by: Sean Chou zho...@linux.vnet.ibm.com ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsRadioButtonUI.java + test/com/sun/java/swing/plaf/windows/WindowsRadioButtonUI/7089914/bug7089914.java
AWT Dev hg: jdk8/awt/jdk: 7141573: JProgressBar resize exception, if setStringPainted in Windows LAF
Changeset: 10fa63972ad5 Author:rupashka Date: 2012-02-03 17:57 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/10fa63972ad5 7141573: JProgressBar resize exception, if setStringPainted in Windows LAF Reviewed-by: malenkov ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsProgressBarUI.java + test/javax/swing/JProgressBar/7141573/bug7141573.java
AWT Dev hg: jdk8/awt/jdk: 7143857: Memory leak in javax.swing.plaf.synth.SynthTreeUI
Changeset: d43447758eba Author:rupashka Date: 2012-02-09 14:21 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d43447758eba 7143857: Memory leak in javax.swing.plaf.synth.SynthTreeUI Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/synth/SynthTreeUI.java
AWT Dev hg: jdk8/awt/jdk: 7142955: DefaultTreeCellRenderer doesn't honor 'Tree.rendererFillBackground' LAF property
Changeset: 403e3bb8a162 Author:rupashka Date: 2012-02-09 18:26 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/403e3bb8a162 7142955: DefaultTreeCellRenderer doesn't honor 'Tree.rendererFillBackground' LAF property Reviewed-by: malenkov ! src/share/classes/javax/swing/tree/DefaultTreeCellRenderer.java + test/javax/swing/tree/DefaultTreeCellRenderer/7142955/bug7142955.java
AWT Dev hg: jdk8/awt/jdk: 7138665: JOptionPane.getValue() unexpected change between JRE 1.6 and JRE 1.7
Changeset: 1880e8cc89b8 Author:rupashka Date: 2012-02-08 16:15 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1880e8cc89b8 7138665: JOptionPane.getValue() unexpected change between JRE 1.6 and JRE 1.7 Reviewed-by: alexp ! src/share/classes/javax/swing/JOptionPane.java ! src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java + test/javax/swing/JOptionPane/7138665/bug7138665.java
AWT Dev hg: jdk8/awt/jdk: 7010561: Tab text position with Synth based LaF is different to Java 5/6
Changeset: 4f2a2bf0ce84 Author:rupashka Date: 2012-01-26 17:38 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4f2a2bf0ce84 7010561: Tab text position with Synth based LaF is different to Java 5/6 Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java + test/javax/swing/JTabbedPane/7010561/bug7010561.java
AWT Dev hg: jdk8/awt/jdk: 7110440: closed/javax/swing/JScrollBar/4865918/bug4865918.java fails on Aqua LF
Changeset: 051beb804b12 Author:rupashka Date: 2011-11-30 16:54 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/051beb804b12 7110440: closed/javax/swing/JScrollBar/4865918/bug4865918.java fails on Aqua LF Reviewed-by: rupashka Contributed-by: alexandr.scherba...@oracle.com + test/javax/swing/JScrollBar/4865918/bug4865918.java
AWT Dev hg: jdk8/awt/jdk: 7115357: closed/javax/swing/JTable/6263446/bug6263446Table.java fails on MacOS
Changeset: 7dd4395fe4a5 Author:rupashka Date: 2011-11-30 19:38 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7dd4395fe4a5 7115357: closed/javax/swing/JTable/6263446/bug6263446Table.java fails on MacOS Reviewed-by: rupashka Contributed-by: alexandr.scherba...@oracle.com + test/javax/swing/JTable/6263446/bug6263446.java
AWT Dev hg: jdk8/awt/jdk: 7112925: closed/javax/swing/JTabbedPane/4624207/bug4624207.java fails on MacOS
Changeset: 9cbc208dcf08 Author:rupashka Date: 2011-11-29 12:47 +0300 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9cbc208dcf08 7112925: closed/javax/swing/JTabbedPane/4624207/bug4624207.java fails on MacOS Reviewed-by: rupashka Contributed-by: alexandr.scherba...@oracle.com + test/javax/swing/JTabbedPane/4624207/bug4624207.java
AWT Dev hg: jdk8/awt/jdk: 7113337: Swing closed test tries to click in the area reserved for resize by Mac OS X
Changeset: c3c80f96cb83 Author:rupashka Date: 2011-11-25 11:52 +0300 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c3c80f96cb83 7113337: Swing closed test tries to click in the area reserved for resize by Mac OS X Reviewed-by: rupashka Contributed-by: alexandr.scherba...@oracle.com + test/javax/swing/PopupFactory/6276087/NonOpaquePopupMenuTest.java
AWT Dev hg: jdk8/awt/jdk: 7109085: Test use hotkeys not intended for Mac
Changeset: 90d33a64a404 Author:rupashka Date: 2011-11-21 18:22 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/90d33a64a404 7109085: Test use hotkeys not intended for Mac Reviewed-by: rupashka Contributed-by: alexandr.scherba...@oracle.com ! test/javax/swing/regtesthelpers/Util.java + test/javax/swing/text/DefaultEditorKit/4278839/bug4278839.java + test/javax/swing/text/JTextComponent/5074573/bug5074573.java + test/javax/swing/text/html/HTMLEditorKit/5043626/bug5043626.java
AWT Dev hg: jdk8/awt/jdk: 7109617: Test was writed for Metal LF but not set it
Changeset: c0f3f1558a94 Author:rupashka Date: 2011-11-14 14:00 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c0f3f1558a94 7109617: Test was writed for Metal LF but not set it Reviewed-by: rupashka Contributed-by: alexandr.scherba...@oracle.com + test/javax/swing/plaf/metal/MetalLookAndFeel/5073047/bug5073047.java
AWT Dev hg: jdk8/awt/jdk: 6938583: Unexpected NullPointerException by InputContext.endComposition()
Changeset: 84e473cf4531 Author:rupashka Date: 2011-11-10 14:10 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/84e473cf4531 6938583: Unexpected NullPointerException by InputContext.endComposition() Reviewed-by: rupashka Contributed-by: Charles Lee litt...@linux.vnet.ibm.com ! src/share/classes/javax/swing/text/DefaultCaret.java + test/javax/swing/text/DefaultCaret/6938583/bug6938583.java
AWT Dev hg: jdk8/awt/jdk: 7107585: Test incorrect calculate position of object on frame
Changeset: f8a3dff76b48 Author:rupashka Date: 2011-11-08 14:36 +0300 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f8a3dff76b48 7107585: Test incorrect calculate position of object on frame Reviewed-by: rupashka Contributed-by: alexandr.scherba...@oracle.com + test/javax/swing/JSlider/6348946/bug6348946.java
AWT Dev hg: jdk8/awt/jdk: 7080203: JTree.getSelectionPaths() now returns empty array instead of null
Changeset: adb31ff942ef Author:rupashka Date: 2011-11-07 16:50 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/adb31ff942ef 7080203: JTree.getSelectionPaths() now returns empty array instead of null Reviewed-by: malenkov ! src/share/classes/javax/swing/JTree.java
Re: AWT Dev CFV: 3 New AWT Group Members
Vote: YES (for everyone) I hereby nominate the following people to Membership in the AWT Group: Alexander Zuev (kizune) Leonid Romanov (leonidr) Oleg Pekhovskiy (bagiras) Alexander and Leonid did significant number of contributions to implement AWT on Mac OS X platform. Oleg fixed several major AWT bugs in JDK7, JDK7u and JDK8. Votes are due by November 21, 2011. Only current Members of the AWT Group [1] are eligible to vote on this nomination. For Lazy Consensus voting instructions, see [2]. Thanks, Artem [1] http://openjdk.java.net/census#awt [2] http://openjdk.java.net/groups#member-vote
AWT Dev hg: jdk8/awt/jdk: 6624077: Regression test fails: closed/javax/swing/ToolTipManager/6256140/bug6256140.java
Changeset: 41610a897379 Author:rupashka Date: 2011-11-02 14:17 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/41610a897379 6624077: Regression test fails: closed/javax/swing/ToolTipManager/6256140/bug6256140.java Reviewed-by: rupashka Contributed-by: alexandr.scherba...@oracle.com + test/javax/swing/ToolTipManager/Test6256140.java
AWT Dev hg: jdk8/awt/jdk: 7049024: DnD fails with JTextArea and JTextField
Changeset: 323f6d046cc9 Author:rupashka Date: 2011-11-02 23:53 +0300 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/323f6d046cc9 7049024: DnD fails with JTextArea and JTextField Reviewed-by: rupashka Contributed-by: Sean Chou zho...@linux.vnet.ibm.com ! src/share/classes/javax/swing/text/DefaultCaret.java + test/javax/swing/JTextArea/7049024/bug7049024.java
Re: AWT Dev CFV: New AWT Group Member: Sergey Bylokhov
Vote YES I hereby nominate Sergey Bylokhov to Membership in the AWT Group. Sergey has fixed a number of AWT bugs in JDK7u and JDK8 projects and been actively contributing to the AWT part of the Mac OS X OpenJDK port. Votes are due by November 10, 2011. Only current Members of the AWT Group [1] are eligible to vote on this nomination. For Lazy Consensus voting instructions, see [2]. Thanks, Artem [1] http://openjdk.java.net/census#awt [2] http://openjdk.java.net/groups#member-vote
AWT Dev hg: jdk8/awt/jdk: 7100004: javax.swing.JTable.setAutoCreateRowSorter(boolean autoCreateRowSorter) should mention default value
Changeset: 4f74e3fdf86b Author:rupashka Date: 2011-10-17 16:40 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4f74e3fdf86b 714: javax.swing.JTable.setAutoCreateRowSorter(boolean autoCreateRowSorter) should mention default value Reviewed-by: rupashka Contributed-by: alexandr.scherba...@oracle.com ! src/share/classes/javax/swing/JTable.java
AWT Dev hg: jdk8/awt/jdk: 7077293: javax/swing/JComponent/4337267/bug4337267.java failed on windows 2003
Changeset: f1dbc62c7c6d Author:rupashka Date: 2011-10-17 17:19 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f1dbc62c7c6d 7077293: javax/swing/JComponent/4337267/bug4337267.java failed on windows 2003 Reviewed-by: rupashka Contributed-by: alexandr.scherba...@oracle.com ! src/share/classes/sun/swing/SwingUtilities2.java
AWT Dev hg: jdk8/awt/jdk: 7076791: closed/javax/swing/JColorChooser/Test6827032.java failed on windows
Changeset: 98901d41e1e2 Author:rupashka Date: 2011-10-11 15:22 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/98901d41e1e2 7076791: closed/javax/swing/JColorChooser/Test6827032.java failed on windows Reviewed-by: rupashka Contributed-by: alexandr.scherba...@oracle.com + test/javax/swing/JColorChooser/Test6827032.java ! test/javax/swing/regtesthelpers/Util.java
AWT Dev hg: jdk8/awt/jdk: 7072167: The root field in BufferStrategyPaintManager leaks memory
Changeset: fcdb588d77ef Author:rupashka Date: 2011-10-05 18:21 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/fcdb588d77ef 7072167: The root field in BufferStrategyPaintManager leaks memory Reviewed-by: alexp ! src/share/classes/javax/swing/BufferStrategyPaintManager.java
AWT Dev hg: jdk8/awt/jdk: 7032018: The file list in JFileChooser does not have an accessible name
Changeset: 16c3dcad4252 Author:rupashka Date: 2011-09-21 17:08 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/16c3dcad4252 7032018: The file list in JFileChooser does not have an accessible name Reviewed-by: rupashka Contributed-by: Charles Lee litt...@linux.vnet.ibm.com ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_TW.properties ! src/share/classes/sun/swing/FilePane.java
AWT Dev hg: jdk8/awt/jdk: 7090007: Missing style.css in nimbus/doc-files/properties.html
Changeset: 3487d0d48662 Author:rupashka Date: 2011-09-15 16:43 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3487d0d48662 7090007: Missing style.css in nimbus/doc-files/properties.html Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html
AWT Dev hg: jdk8/awt/jdk: 7024118: possible hardcoded mnemonic for JFileChooser metal and motif lf
Changeset: 7fbc8d86c477 Author:rupashka Date: 2011-09-09 17:44 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7fbc8d86c477 7024118: possible hardcoded mnemonic for JFileChooser metal and motif lf Reviewed-by: alexp Contributed-by: Charles Lee litt...@linux.vnet.ibm.com ! src/share/classes/com/sun/java/swing/plaf/motif/MotifFileChooserUI.java ! src/share/classes/com/sun/java/swing/plaf/motif/MotifLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_de.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_es.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_fr.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_it.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ja.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ko.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_sv.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_TW.properties ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_de.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_es.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_fr.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_it.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ja.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ko.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_sv.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_de.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_es.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_it.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_TW.properties ! src/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java
AWT Dev hg: jdk8/awt/jdk: 7080281: AbtsractButton.checkVerticalKey()/checkHorizontalKey() methods do not specify returned value
Changeset: 22c60997bf3c Author:rupashka Date: 2011-08-30 13:07 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/22c60997bf3c 7080281: AbtsractButton.checkVerticalKey()/checkHorizontalKey() methods do not specify returned value Reviewed-by: alexp ! src/share/classes/javax/swing/AbstractButton.java
AWT Dev hg: jdk8/awt/jdk: 7030332: Default borders in tables looks incorrect JEditorPane
Changeset: e05ea8ab1807 Author:rupashka Date: 2011-08-29 16:25 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e05ea8ab1807 7030332: Default borders in tables looks incorrect JEditorPane Reviewed-by: peterz ! src/share/classes/javax/swing/text/html/CSS.java ! src/share/classes/javax/swing/text/html/TableView.java + test/javax/swing/text/html/TableView/7030332/bug7030332.html + test/javax/swing/text/html/TableView/7030332/bug7030332.java + test/javax/swing/text/html/TableView/7030332/sample0.png + test/javax/swing/text/html/TableView/7030332/sample1.png + test/javax/swing/text/html/TableView/7030332/sample2.png + test/javax/swing/text/html/TableView/7030332/sample3.png + test/javax/swing/text/html/TableView/7030332/sample4.png
AWT Dev hg: jdk8/awt/jdk: 7075563: Broken link in javax.swing.SwingWorker
Changeset: 6ca2e7babaf0 Author:rupashka Date: 2011-08-17 19:35 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6ca2e7babaf0 7075563: Broken link in javax.swing.SwingWorker Reviewed-by: alexp ! src/share/classes/javax/swing/SwingUtilities.java ! src/share/classes/javax/swing/SwingWorker.java ! src/share/classes/javax/swing/package.html ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/javax/swing/text/DefaultCaret.java ! src/share/classes/javax/swing/text/DefaultStyledDocument.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/javax/swing/text/PlainDocument.java ! src/share/classes/javax/swing/text/StyleContext.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/sun/swing/PrintingStatus.java
AWT Dev hg: jdk8/awt/jdk: 7032436: When running with the Nimbus look and feel, the JFileChooser does not display mnemonics
Changeset: 0e03455d868c Author:rupashka Date: 2011-08-17 20:08 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0e03455d868c 7032436: When running with the Nimbus look and feel, the JFileChooser does not display mnemonics Reviewed-by: alexp Contributed-by: Charles Lee litt...@linux.vnet.ibm.com ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_de.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_es.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_it.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_zh_TW.properties
Re: AWT Dev hg: jdk8/awt/jdk: 6995769: occasion NPE thrown from SwingUtilities.computeIntersection()
Hi Roman, Find attached a testcase. Upon running, this will bring up a small frame and a JOptionPane. None of them renders for me, but after some blind clicking in the option pane it throws exactly this NPE. Regards, Roman Thanks for the test! I'll review the fix... Regards, Pavel Am Donnerstag, den 28.07.2011, 20:22 +0200 schrieb Mario Torre: 2011/7/28 Artem Ananievartem.anan...@oracle.com: +1 Yeah, I agree with Roman, IllegalStateException sounds like the perfect option to me. Cheers, Mario
AWT Dev hg: jdk8/awt/jdk: 7071166: LayoutStyle.getPreferredGap() - IAE is expected but not thrown
Changeset: 86098b3f7789 Author:rupashka Date: 2011-07-28 18:24 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/86098b3f7789 7071166: LayoutStyle.getPreferredGap() - IAE is expected but not thrown Reviewed-by: peterz ! src/share/classes/sun/swing/DefaultLayoutStyle.java + test/javax/swing/GroupLayout/7071166/bug7071166.java
AWT Dev hg: jdk8/awt/jdk: 6509273: Password in JPasswordField gets Printed in clear text
Changeset: 3ac81907aa7d Author:rupashka Date: 2011-07-18 17:40 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3ac81907aa7d 6509273: Password in JPasswordField gets Printed in clear text Reviewed-by: alexp ! src/share/classes/sun/swing/text/TextComponentPrintable.java
AWT Dev hg: jdk8/awt/jdk: 7031941: Use generificated JComboBox and JList in core libraries
Changeset: c05b36e4749e Author:rupashka Date: 2011-07-18 18:21 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c05b36e4749e 7031941: Use generificated JComboBox and JList in core libraries Reviewed-by: alexp ! src/share/classes/com/sun/java/swing/plaf/motif/MotifFileChooserUI.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java ! src/share/classes/javax/swing/plaf/basic/BasicComboPopup.java ! src/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java ! src/share/classes/javax/swing/text/html/FormView.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/javax/swing/text/html/HTMLWriter.java ! src/share/classes/javax/swing/text/html/OptionComboBoxModel.java ! src/share/classes/javax/swing/text/html/OptionListModel.java ! src/share/classes/sun/swing/FilePane.java ! src/share/classes/sun/swing/plaf/synth/SynthFileChooserUIImpl.java
AWT Dev hg: jdk8/awt/jdk: 4909150: WindowsTreeUI can cause NullPointerException occasionally
Changeset: 5c22624d193e Author:rupashka Date: 2011-07-15 14:43 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5c22624d193e 4909150: WindowsTreeUI can cause NullPointerException occasionally Reviewed-by: alexp ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTreeUI.java
AWT Dev hg: jdk8/awt/jdk: 7019963: The goto parent directory button doesn't operate in JFileChooser
Changeset: cce5659427bb Author:rupashka Date: 2011-07-12 11:41 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cce5659427bb 7019963: The goto parent directory button doesn't operate in JFileChooser Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java
