[Ayatana] Unity: An interactive Mock up of GUI ideas

2010-09-13 Thread Michael Jonker
I have put up an interactive mock up of some of the ways I feel Unity
can evolve here:

http://www.reviveyourpc.ie/unity/welcome.html

Give each screen a bit of time to cache - it is just linked html.

The key features are:

  * Fully navigable by mousepad tap (therefore screen touch)
  * Desktop is utilised productively
  * Only two modes - 1)Application open  2)System GUI root and
quickaccess exposed.
  * Apps get maximum real estate

For the mock up - in application mode - switching is done by clicking on
the Ubuntu logo @ top left. This could be a mouse gesture or hover-over
in reality. On touch it could be a shake of the device optional to
touching the logo.

If anybody wants to tinker, I have put the Gimp file for the screens
here:

http://dl.dropbox.com/u/1306731/Unity.xcf

Michael
___
Mailing list: https://launchpad.net/~ayatana
Post to : ayatana@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana
More help   : https://help.launchpad.net/ListHelp


Re: [Ayatana] Unity: An interactive Mock up of GUI ideas

2010-09-13 Thread frederik.nn...@gmail.com
Hi Michael,

On Mon, Sep 13, 2010 at 11:20, Michael Jonker citizen.jon...@gmail.comwrote:

  I have put up an interactive mock up of some of the ways I feel Unity
 can evolve here:

 http://www.reviveyourpc.ie/unity/welcome.html


Now that's what i call a mockup!!
Since it is interaction design we are discussing here much of the time, i
think it is about time Mockups become interactive, too, so: whow, great
work! :D

please consider also integrating the symbolic approach Ayatana has chosen,
especially regarding colors.
Symbolic design considers rather the symbolic (purpose/context) significance
of an item, than it's absolute appearance.

In the case of colors, a color that is being used in a symbolic fashion has
a direct meaning, i.e. for example color change means there is a direct
communicative purpose attached to changing the color.
If we can not state a purpose or use case worth introducing a color change,
the color change has no symbolic significance/relevance and can be seen as a
redundant if not even confusing element of the interaction designed, and
should be re-thought.

Again, much respect for your mockup and thanks for inspiring!
___
Mailing list: https://launchpad.net/~ayatana
Post to : ayatana@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana
More help   : https://help.launchpad.net/ListHelp


Re: [Ayatana] Unity: An interactive Mock up of GUI ideas

2010-09-13 Thread Diego Moya
Beautiful demo!

I miss the ability to close several applications with the X button. That
could be alleviated by showing the window toolbar in the quickaccess view
[1]. That would also show the windicators, when they are implemented.

Also when one of the main menus [2][3][4] is open, clicking on the menu icon
should toggle between that menu and the quickaccess view [1] .

[1] http://www.reviveyourpc.ie/unity/wall1_2_3.html
[2] http://www.reviveyourpc.ie/unity/apps1_2_3.html
[3] http://www.reviveyourpc.ie/unity/files1_2_3.html
[4] http://www.reviveyourpc.ie/unity/settings1_2_3.html

Good work, I really like the resulting usability of your two maximized
application vs unmaximized system design.

There could be a third optional mode when the focused application is
fullscreen, but you still see the Unity launcher to the left. My Nokia N800
works that way, and it's great for rapid switching between applications and
to see context and state of applications in the background.

The N800 has a dedicated button to swap this mode and fullscreen, but I
think in Unity it would be enough having a pin icon in the launcher panel
to enter this mode.



On 13 September 2010 11:20, Michael Jonker citizen.jon...@gmail.com wrote:

  I have put up an interactive mock up of some of the ways I feel Unity
 can evolve here:

 http://www.reviveyourpc.ie/unity/welcome.html

 Give each screen a bit of time to cache - it is just linked html.

 The key features are:

   * Fully navigable by mousepad tap (therefore screen touch)
   * Desktop is utilised productively
   * Only two modes - 1)Application open  2)System GUI root and
 quickaccess exposed.
   * Apps get maximum real estate

 For the mock up - in application mode - switching is done by clicking on
 the Ubuntu logo @ top left. This could be a mouse gesture or hover-over
 in reality. On touch it could be a shake of the device optional to
 touching the logo.

 If anybody wants to tinker, I have put the Gimp file for the screens here:

 http://dl.dropbox.com/u/1306731/Unity.xcf

 Michael

 ___
 Mailing list: https://launchpad.net/~ayatanahttps://launchpad.net/%7Eayatana
 Post to : ayatana@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~ayatanahttps://launchpad.net/%7Eayatana
 More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~ayatana
Post to : ayatana@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana
More help   : https://help.launchpad.net/ListHelp


Re: [Ayatana] Unity interface - my Beta review and proposals

2010-09-13 Thread frederik.nn...@gmail.com
On Sat, Sep 11, 2010 at 14:35, Michael Jonker citizen.jon...@gmail.comwrote:

 Basically - Unity already has all the goodness built in. It just needs
 to be evolved into something that is so obvious that Bill Gates or my
 granny, after turning it on for the first time, can understand the whole
 workflow instantly and find everything they may need quickly.


I think Bill is interested in profit more than accessibility or usability,
according to his own statements, therefore doesn't belong into this example
use case.


 On top of that it needs to run on the most simple of devices, for
 example the $35 tablet, reliably - so no fancy hiding and animation
 effects for the core functionality.


Yeah, this devices is a perfect example for the subtle revolution we are
currently in the midst of:
http://www.youtube.com/watch?v=Ok4z9Xpapzc

Accessibility starts with affordability. Even when talking about screen real
estate for example:
an appliance can sometimes not afford to lose screen real estate to a
toolbar, navigation bar, window list or dock. Affordability is therefore the
key argument in the design of an accessible Interaction Device.
Affordance is the key to optimizing the affordability of an appliance, no
matter what type, style or brand.

Thanks for bringing another great example of why Ubuntu / Ayatana makes
sense ;)
___
Mailing list: https://launchpad.net/~ayatana
Post to : ayatana@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana
More help   : https://help.launchpad.net/ListHelp


[Ayatana] Presence: custom status

2010-09-13 Thread frederik.nn...@gmail.com
Hello there,

today, i'm kinda lazy, so i'll just get straight to the point without a lot
of introduction:

Presence in the MeMenu should focus absolutely on how to display and handle
custom status.
Custom status meaning the state of presence you design yourself, e.g. in a
meeting with BUSY or AWAY on it.

With favourites in empathy available now, we could pin our list of favourite
contacts to the MeMenu, as Me favourites ;)
even when offline or invisible, we would then see their last custom state or
public status message.

For the text field, which would then be primarily for personal (custom)
status aka Me-status we could also introduce a checkbox for publish, which
would then send my custom status to those Activity Streams¹ that are
enabled.
The whole discussion about why how and where to coordinate 2 seperate text
fields in the MeMenu, one for broadcasting status and one for status, seems
unnecessary to me, considering the solution presented here..

thoughts?

¹ http://en.wikipedia.org/wiki/Activity_stream
___
Mailing list: https://launchpad.net/~ayatana
Post to : ayatana@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana
More help   : https://help.launchpad.net/ListHelp


Re: [Ayatana] Unity: An interactive Mock up of GUI ideas

2010-09-13 Thread frederik.nn...@gmail.com
On Mon, Sep 13, 2010 at 14:41, zekopeko zekop...@gmail.com wrote:

 Closing multiple windows could be implemented by simply adding an X in
 the upper left corner of window thumbnails when using workspaces or
 scale/expose.


yeah, like in GNOME Shell..
___
Mailing list: https://launchpad.net/~ayatana
Post to : ayatana@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana
More help   : https://help.launchpad.net/ListHelp


Re: [Ayatana] Unity interface - my Beta review and proposals

2010-09-13 Thread frederik.nn...@gmail.com
On Mon, Sep 13, 2010 at 16:24, Kerberos kerbe...@piestar.net wrote:




 On 13/09/2010 13:56, frederik.nn...@gmail.com frederik.nn...@gmail.com
 wrote:

 On Sat, Sep 11, 2010 at 14:35, Michael Jonker citizen.jon...@gmail.com
 wrote:

 Basically - Unity already has all the goodness built in. It just needs
 to be evolved into something that is so obvious that Bill Gates or my
 granny, after turning it on for the first time, can understand the whole
 workflow instantly and find everything they may need quickly.


 I think Bill is interested in profit more than accessibility or usability,
 according to his own statements, therefore doesn't belong into this example
 use case.

 *“It is said that if you know your enemies and know yourself, you will not
 be imperiled in a hundred battles; if you do not know your enemies but do
 know yourself, you will win one and lose one; if you do not know your
 enemies nor yourself, you will be imperiled in every single battle.” *-
 Sun Tzu


Bill Gates is no enemy to Freedom, he is primarily interested in offering
profitable commercial solutions, according to what he states in interviews
and speeches.
I think we are derailing a little here, too, so let's keep the wisdom on
topic, if you agree..
___
Mailing list: https://launchpad.net/~ayatana
Post to : ayatana@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana
More help   : https://help.launchpad.net/ListHelp


Re: [Ayatana] Unity: An interactive Mock up of GUI ideas

2010-09-13 Thread Sohail Mirza
Fantastic mockup Michael.  :)  I can only echo the kudos being given by the
others.

One question:  In this scenario of expose mode, maximized window, and
nothing else, how will smaller windowed applicatoins like the Calculator be
handled?  In Meerkat I notice that the Calculator cannot even be maximized,
and no doubt it would look rather strange when maximized.

Thanks and keep the ideas coming!

Sohail Mirza


On Mon, Sep 13, 2010 at 5:20 AM, Michael Jonker citizen.jon...@gmail.comwrote:

  I have put up an interactive mock up of some of the ways I feel Unity
 can evolve here:

 http://www.reviveyourpc.ie/unity/welcome.html

 Give each screen a bit of time to cache - it is just linked html.

 The key features are:

   * Fully navigable by mousepad tap (therefore screen touch)
   * Desktop is utilised productively
   * Only two modes - 1)Application open  2)System GUI root and
 quickaccess exposed.
   * Apps get maximum real estate

 For the mock up - in application mode - switching is done by clicking on
 the Ubuntu logo @ top left. This could be a mouse gesture or hover-over
 in reality. On touch it could be a shake of the device optional to
 touching the logo.

 If anybody wants to tinker, I have put the Gimp file for the screens here:

 http://dl.dropbox.com/u/1306731/Unity.xcf

 Michael

 ___
 Mailing list: https://launchpad.net/~ayatanahttps://launchpad.net/%7Eayatana
 Post to : ayatana@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~ayatanahttps://launchpad.net/%7Eayatana
 More help   : https://help.launchpad.net/ListHelp




-- 
sfm
___
Mailing list: https://launchpad.net/~ayatana
Post to : ayatana@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana
More help   : https://help.launchpad.net/ListHelp


Re: [Ayatana] Unity: An interactive Mock up of GUI ideas

2010-09-13 Thread Michael Jonker
Some great ideas are emerging:

1)Also when one of the main menus [2][3][4] is open, clicking on
the menu icon should toggle between that menu and the quickaccess view
[1]

Implemented in the Mock Up - Wow, adds a whole new level of access.
Everything is either on or off. Everything is one click away.

2)There could be a third optional mode when the focused application
is fullscreen, but you still see the Unity launcher to the left. My
Nokia N800 works that way, and it's great for rapid switching between
applications and to see context and state of applications in the
background. The N800 has a dedicated button to swap this mode and
fullscreen, but I think in Unity it would be enough having a pin icon
in the launcher panel to enter this mode.

I wouldn't call it another mode - just a user preference. A little pin
icon in the side menu (what is the correct name for it?) should do the
trick nicely. A lot of work in the HTML for the Mock Up though.

3)Please consider also integrating the symbolic approach Ayatana
has chosen, especially regarding colors. Symbolic design considers
rather the symbolic (purpose/context) significance of an item, than it's
absolute appearance.

A1, +1, Amen This level of graphic design is not my strength. I was
thinking maybe everything is in greyscale until it is 'switched on'. In
this state it is in colour, thus active. It will be very easy to tell at
a glance what is active, where you are in the menu map, etc. Please grab
the Gimp file and post suggestions.

4)Closing multiple windows could be implemented by simply adding an
X in the upper left corner of window thumbnails when using workspaces or
scale/expose

Yes. I think Gnome Shell has done this nicely. Could also work with
showing the toolbar, as suggested by Diego, but this may be a bit small
on a small screen.


Does anybody have ideas of how we can host this kind of Mock Up and have
anybody in Ayatana who wants collaborate on it? Maybe HTML is not the
most flexible platform - it is easy though! Possibly could also be and
OpenOffice 'Impress' file.

I have put all the HTML and images here if anybody wants to implement
ideas:

http://dl.dropbox.com/u/1306731/unity.tar.gz

The Gimp file link is in the top of the thread.


On Mon, 2010-09-13 at 10:20 +0100, Michael Jonker wrote:

 I have put up an interactive mock up of some of the ways I feel Unity
 can evolve here:
 
 http://www.reviveyourpc.ie/unity/welcome.html
 
 Give each screen a bit of time to cache - it is just linked html.
 
 The key features are:
 
   * Fully navigable by mousepad tap (therefore screen touch)
   * Desktop is utilised productively
   * Only two modes - 1)Application open  2)System GUI root and
 quickaccess exposed.
   * Apps get maximum real estate
 
 For the mock up - in application mode - switching is done by clicking
 on
 the Ubuntu logo @ top left. This could be a mouse gesture or
 hover-over
 in reality. On touch it could be a shake of the device optional to
 touching the logo.
 
 If anybody wants to tinker, I have put the Gimp file for the screens
 here:
 
 http://dl.dropbox.com/u/1306731/Unity.xcf
 
 Michael


___
Mailing list: https://launchpad.net/~ayatana
Post to : ayatana@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana
More help   : https://help.launchpad.net/ListHelp


Re: [Ayatana] Unity: An interactive Mock up of GUI ideas

2010-09-13 Thread Michael Jonker
A tricky one!

I have the beginning of an idea for this in a sketch I posted one thread
down. It could lie on the desktop wall, the same as the other
'background apps' are. When it gets the focus it renders above
everything else. Clicking anywhere outside of the calculator minimises
it back to the wall. When it is active, everything else is slightly
greyed out.

There are loads of other issues to think about. The big one is how to
make it work in portrait mode and what is the transition between
portrait/ landscape.

There is also a lot of potential for radical ideas (I am not a
programmer, so talk is easy :D )

How about if the whole GUI was rendered through HTML5 and CSS? This has
potential for an almost 'instant on' GUI after network and web services
have loaded. The rest of the system resources could start up in the
background, giving priority to user web activity. A  red indicator light
somewhere on the screen could go green and fade away to let the user
know that all services are now available. This simplifies the current
approach of having to choose between 'quick' or 'full' mode at start-up.
I think that starting in quick mode will quickly be followed by a user
desire to be in full mode. Having to restart then will be an annoyance.

On Mon, 2010-09-13 at 11:38 -0400, Sohail Mirza wrote:

 Fantastic mockup Michael.  :)  I can only echo the kudos being given
 by the others.
 
 One question:  In this scenario of expose mode, maximized window, and
 nothing else, how will smaller windowed applicatoins like the
 Calculator be handled?  In Meerkat I notice that the Calculator cannot
 even be maximized, and no doubt it would look rather strange when
 maximized.
 
 Thanks and keep the ideas coming!
 
 Sohail Mirza
 
 
 
 On Mon, Sep 13, 2010 at 5:20 AM, Michael Jonker
 citizen.jon...@gmail.com wrote:
 
 I have put up an interactive mock up of some of the ways I
 feel Unity
 can evolve here:
 
 http://www.reviveyourpc.ie/unity/welcome.html
 
 Give each screen a bit of time to cache - it is just linked
 html.
 
 The key features are:
 
   * Fully navigable by mousepad tap (therefore screen
 touch)
   * Desktop is utilised productively
   * Only two modes - 1)Application open  2)System GUI root
 and
 quickaccess exposed.
   * Apps get maximum real estate
 
 For the mock up - in application mode - switching is done by
 clicking on
 the Ubuntu logo @ top left. This could be a mouse gesture or
 hover-over
 in reality. On touch it could be a shake of the device
 optional to
 touching the logo.
 
 If anybody wants to tinker, I have put the Gimp file for the
 screens here:
 
 http://dl.dropbox.com/u/1306731/Unity.xcf
 
 Michael
 
 
 ___
 Mailing list: https://launchpad.net/~ayatana
 Post to : ayatana@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~ayatana
 More help   : https://help.launchpad.net/ListHelp
 
 
 
 
 
 -- 
 sfm


___
Mailing list: https://launchpad.net/~ayatana
Post to : ayatana@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana
More help   : https://help.launchpad.net/ListHelp


Re: [Ayatana] Unity interface - my Beta review and proposals

2010-09-13 Thread Scott Kitterman
On Monday, September 13, 2010 11:49:47 am Kerberos wrote:
 On 13/09/2010 16:15, Scott Kitterman ubu...@kitterman.com wrote:
  On Monday, September 13, 2010 10:48:36 am frederik.nn...@gmail.com wrote:
  Bill Gates is no enemy to Freedom, he is primarily interested in
  offering profitable commercial solutions, according to what he states
  in interviews and speeches.
  I think we are derailing a little here, too, so let's keep the wisdom on
  topic, if you agree..
  
  I agree with staying on topic, but not the part before that.
  
  Scott K
 
 Indeed.  My original post was much longer and rantier so I just chopped it
 down to the quote.  The anti-MS propaganda should stay on Ubuntuforums, or
 the mid 90's, where it belongs.
 
 Microsoft has 90%+ of the desktop market.  Linux has slipped to a two year
 low of 0.85%.  Microsoft are the primary competitor and should be treated
 with fear and respect.  Why does MS have majority marketshare?  Find the
 answer to that question and victory is almost assured.
 
 Besides every time someone takes a cheap shot at Windows, Microsoft, Bill
 Gates or Steve Ballmer you are taking a cheap shot at the people who
 voluntarily use such software.  Insulting your target audience is never a
 good idea and will only increase the massive selection bias already present
 in the Linux community.

It's not propaganda when it's true.  In my career I've only ever had to deal 
with one company falsely claiming to have invented something I'd been involved 
in developing in their patent application (and they were well aware since 
their engineers had been involved too).  Stating the truth is not a cheap 
shot.  I suspect you should probably stop now.

Scott K

___
Mailing list: https://launchpad.net/~ayatana
Post to : ayatana@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana
More help   : https://help.launchpad.net/ListHelp


Re: [Ayatana] Unity interface - my Beta review and proposals

2010-09-13 Thread Mark Curtis

So, hey guys, how about that interface proposal, interesting stuff...

 From: ubu...@kitterman.com
 To: ayatana@lists.launchpad.net
 Date: Mon, 13 Sep 2010 13:13:17 -0400
 Subject: Re: [Ayatana] Unity interface - my Beta review and proposals
 
 On Monday, September 13, 2010 11:49:47 am Kerberos wrote:
  On 13/09/2010 16:15, Scott Kitterman ubu...@kitterman.com wrote:
   On Monday, September 13, 2010 10:48:36 am frederik.nn...@gmail.com wrote:
   Bill Gates is no enemy to Freedom, he is primarily interested in
   offering profitable commercial solutions, according to what he states
   in interviews and speeches.
   I think we are derailing a little here, too, so let's keep the wisdom on
   topic, if you agree..
   
   I agree with staying on topic, but not the part before that.
   
   Scott K
  
  Indeed.  My original post was much longer and rantier so I just chopped it
  down to the quote.  The anti-MS propaganda should stay on Ubuntuforums, or
  the mid 90's, where it belongs.
  
  Microsoft has 90%+ of the desktop market.  Linux has slipped to a two year
  low of 0.85%.  Microsoft are the primary competitor and should be treated
  with fear and respect.  Why does MS have majority marketshare?  Find the
  answer to that question and victory is almost assured.
  
  Besides every time someone takes a cheap shot at Windows, Microsoft, Bill
  Gates or Steve Ballmer you are taking a cheap shot at the people who
  voluntarily use such software.  Insulting your target audience is never a
  good idea and will only increase the massive selection bias already present
  in the Linux community.
 
 It's not propaganda when it's true.  In my career I've only ever had to deal 
 with one company falsely claiming to have invented something I'd been 
 involved 
 in developing in their patent application (and they were well aware since 
 their engineers had been involved too).  Stating the truth is not a cheap 
 shot.  I suspect you should probably stop now.
 
 Scott K
 
 ___
 Mailing list: https://launchpad.net/~ayatana
 Post to : ayatana@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~ayatana
 More help   : https://help.launchpad.net/ListHelp
  ___
Mailing list: https://launchpad.net/~ayatana
Post to : ayatana@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana
More help   : https://help.launchpad.net/ListHelp


Re: [Ayatana] Do Not Disturb vs Indicator Session

2010-09-13 Thread frederik.nn...@gmail.com
Hi Ralph,

On Tue, Sep 14, 2010 at 01:08, Ralph Green sira...@gmail.com wrote:

 On 9/13/10, frederik.nn...@gmail.com frederik.nn...@gmail.com wrote:
  Should we add an item high in the Session Menu called Do Not Disturb
 with
  a checkbox before it??
 ...
  i think offering an undisturbed session mode is a valid suggestion for a
  comfortable experience..
 



 I hope you mean everything.


yeah, everything users suggest frequently. It est all common use cases. We
don't want to create a bloated configuration page.. just the most frequent
use cases for the beginning.
Update Manager's automatic apt queries and popup windows could be inhibited
for this temporary state of undisturbedness.


 It should stop Update Notifier from
 popping up, too.  I might be able to live with update notifier
 running, if I could tell it and IMs and the like to be quiet at times.


I'd suggest make everything silent by default, and add configurability for
the more difficult cases such as Empathy's IM and voice call Availablity or
Custom Presence.


  When recording a screencast or doing a presentation, an IM popup or
 update notifier are very distracting.


i feel your idea, this is something i encountered in all creative activities
on all my machines, whether sound-related, DTP or during photo/video
production.

A special Do Not Disturb icon would be nice,


are you suggesting the development of a visual metaphor?


 Good day,
 Ralph


in an environment in which not even being online can stop the system from
spamming me with popup alerts about www-related actions that are now
possible, we need an undisturbed mode that can be activated for occasions of
focus or peace of mind.
___
Mailing list: https://launchpad.net/~ayatana
Post to : ayatana@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana
More help   : https://help.launchpad.net/ListHelp


Re: [Ayatana] Do Not Disturb vs Indicator Session

2010-09-13 Thread frederik.nn...@gmail.com
On Tue, Sep 14, 2010 at 01:39, frederik.nn...@gmail.com 
frederik.nn...@gmail.com wrote:

 in an environment in which not even being online can stop the system from
 spamming me with popup alerts about www-related actions that are now
 possible, we need an undisturbed mode that can be activated for occasions of
 focus or peace of mind.


sorry.. i meant not even being offline
___
Mailing list: https://launchpad.net/~ayatana
Post to : ayatana@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana
More help   : https://help.launchpad.net/ListHelp


[Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/properties-changed-issues into lp:indicator-sound

2010-09-13 Thread Conor Curran
Conor Curran has proposed merging 
lp:~cjcurran/indicator-sound/properties-changed-issues into lp:indicator-sound.

Requested reviews:
  Indicator Applet Developers (indicator-applet-developers)
Related bugs:
  #631893 mpris2 playback status behaving as if it were static
  https://bugs.launchpad.net/bugs/631893


Fixes related bug and removes redundant scrub code from the controller and the 
indicator.
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/properties-changed-issues/+merge/35273
Your team ayatana-commits is subscribed to branch lp:indicator-sound.
=== modified file 'src/Makefile.am'
--- src/Makefile.am	2010-09-01 14:29:26 +
+++ src/Makefile.am	2010-09-13 12:35:57 +
@@ -62,7 +62,6 @@
 	music-player-bridge.vala \
 	transport-menu-item.vala \
 	metadata-menu-item.vala \
-	scrub-menu-item.vala \
 	title-menu-item.vala \
 	player-controller.vala \
 	mpris2-controller.vala \

=== modified file 'src/mpris2-controller.vala'
--- src/mpris2-controller.vala	2010-09-09 16:07:19 +
+++ src/mpris2-controller.vala	2010-09-13 12:35:57 +
@@ -1,5 +1,4 @@
 /*
-This service primarily controls PulseAudio and is driven by the sound indicator menu on the panel.
 Copyright 2010 Canonical Ltd.
 
 Authors:
@@ -84,10 +83,8 @@
 			this.player = (MprisPlayer) connection.get_object (root_interface.concat(.).concat(this.owner.name.down()),
    /org/mpris/MediaPlayer2,
    root_interface.concat(.Player));		
-			this.player.Seeked += onSeeked;
-
-			this.properties_interface = (FreeDesktopProperties) connection.get_object(root_interface.concat(.).concat(this.owner.name.down()),
-			  /org/mpris/MediaPlayer2);
+			this.properties_interface = (FreeDesktopProperties) connection.get_object(org.freedesktop.Properties.PropertiesChanged,//root_interface.concat(.).concat(this.owner.name.down()),
+			  /org/mpris/MediaPlayer2);
 			this.properties_interface.PropertiesChanged += property_changed_cb;			
 			
 		} catch (DBus.Error e) {
@@ -98,16 +95,14 @@
 	public void property_changed_cb(string interface_source, HashTablestring, Value? changed_properties, string[] invalid )
 	{	
 		debug(properties-changed for interface %s and owner %s, interface_source, this.owner.name.down());
-debug(is the invalid array null : %s, (invalid == null).to_string());
-debug(invalid length  : %i, invalid.length);
 
 		if(changed_properties == null || interface_source.has_prefix(this.root_interface) == false ){
-			warning(Property-changed hash is null or this is an interface that concerns us);
+			warning(Property-changed hash is null or this is an interface that doesn't concerns us);
 			return;
 		}
 		Value? play_v = changed_properties.lookup(PlaybackStatus);
 		if(play_v != null){
-			string state = play_v.get_string();		
+			string state = this.player.PlaybackStatus;		
 			debug(new playback state = %s, state);			
 			TransportMenuitem.state p = (TransportMenuitem.state)this.determine_play_state(state);
 			(this.owner.custom_items[PlayerController.widget_order.TRANSPORT] as TransportMenuitem).change_play_state(p);			
@@ -207,42 +202,6 @@
 			}
 		}	
 	}
-	/**
-		TODO: SetPosition on the player object is not working with rhythmbox,
-	  runtime error - dbus function not supported
-	 */
-	public void set_track_position(double position)
-	{			
-		debug(Set position with pos (0-100) %f, position);
-		Value? time_value = this.player.Metadata.lookup(mpris:length);
-		if(time_value == null){
-			warning(Can't fetch the duration of the track therefore cant set the position);
-			return;
-		}
-		// work in microseconds (scale up by 10 TTP-of 6)
-		int64 total_time = time_value.get_int64();
-		debug(total time of track = %i, (int)total_time);
-		double new_time_position = total_time * (position/100.0);
-		debug(new position = %f, (new_time_position));		
-
-		Value? v = this.player.Metadata.lookup(mpris:trackid);
-		if(v != null){
-			if(v.holds (typeof (string))){
-DBus.ObjectPath path = new ObjectPath(v.get_string());
-try{
-	this.player.SetPosition(path, (int64)(new_time_position));
-}
-catch(DBus.Error e){
-	error(DBus Error calling the player objects SetPosition method %s,
-		 e.message);
-}			
-			}
-		}			
-	}
-
-	public void onSeeked(int64 position){
-		debug(Seeked signal callback with pos = %i, (int)position/1000);
-	}
 	
 	public bool connected()
 	{

=== modified file 'src/transport-widget.c'
--- src/transport-widget.c	2010-09-07 09:04:07 +
+++ src/transport-widget.c	2010-09-13 12:35:57 +
@@ -46,7 +46,6 @@
 
 static void transport_widget_set_twin_item(TransportWidget* self,
 DbusmenuMenuitem* 

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/properties-changed-issues into lp:indicator-sound

2010-09-13 Thread Conor Curran
The proposal to merge lp:~cjcurran/indicator-sound/properties-changed-issues 
into lp:indicator-sound has been updated.

Status: Needs review = Superseded
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/properties-changed-issues/+merge/35273
Your team ayatana-commits is subscribed to branch lp:indicator-sound.

___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp


[Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/properties-changed-issues into lp:indicator-sound

2010-09-13 Thread Conor Curran
Conor Curran has proposed merging 
lp:~cjcurran/indicator-sound/properties-changed-issues into lp:indicator-sound.

Requested reviews:
  Indicator Applet Developers (indicator-applet-developers)
Related bugs:
  #631893 mpris2 playback status behaving as if it were static
  https://bugs.launchpad.net/bugs/631893


Fixes related bug and removes redundant scrub code from the controller and the 
indicator.
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/properties-changed-issues/+merge/35274
Your team ayatana-commits is subscribed to branch lp:indicator-sound.
=== modified file 'src/Makefile.am'
--- src/Makefile.am	2010-09-01 14:29:26 +
+++ src/Makefile.am	2010-09-13 12:38:46 +
@@ -18,8 +18,6 @@
 	indicator-sound.c \
 	title-widget.c \
 	title-widget.h \
-	scrub-widget.c \
-	scrub-widget.h \
 	volume-widget.c \
 	volume-widget.h \
 	dbus-shared-names.h \
@@ -62,7 +60,6 @@
 	music-player-bridge.vala \
 	transport-menu-item.vala \
 	metadata-menu-item.vala \
-	scrub-menu-item.vala \
 	title-menu-item.vala \
 	player-controller.vala \
 	mpris2-controller.vala \

=== modified file 'src/indicator-sound.c'
--- src/indicator-sound.c	2010-09-08 17:06:26 +
+++ src/indicator-sound.c	2010-09-13 12:38:46 +
@@ -36,7 +36,6 @@
 #include transport-widget.h
 #include metadata-widget.h
 #include title-widget.h
-#include scrub-widget.h
 #include volume-widget.h
 
 #include dbus-shared-names.h
@@ -79,7 +78,6 @@
 static gboolean new_transport_widget(DbusmenuMenuitem * newitem, DbusmenuMenuitem * parent, DbusmenuClient * client);
 static gboolean new_metadata_widget(DbusmenuMenuitem * newitem, DbusmenuMenuitem * parent, DbusmenuClient * client);
 static gboolean new_title_widget(DbusmenuMenuitem * newitem, DbusmenuMenuitem * parent, DbusmenuClient * client);
-static gboolean new_scrub_bar_widget(DbusmenuMenuitem * newitem, DbusmenuMenuitem * parent, DbusmenuClient * client);
 
 // DBUS communication
 static DBusGProxy *sound_dbus_proxy = NULL;
@@ -219,7 +217,6 @@
   dbusmenu_client_add_type_handler(DBUSMENU_CLIENT(client), DBUSMENU_TRANSPORT_MENUITEM_TYPE, new_transport_widget);
   dbusmenu_client_add_type_handler(DBUSMENU_CLIENT(client), DBUSMENU_METADATA_MENUITEM_TYPE, new_metadata_widget);
   dbusmenu_client_add_type_handler(DBUSMENU_CLIENT(client), DBUSMENU_TITLE_MENUITEM_TYPE, new_title_widget);
-	dbusmenu_client_add_type_handler(DBUSMENU_CLIENT(client), DBUSMENU_SCRUB_MENUITEM_TYPE, new_scrub_bar_widget);	
 	// register Key-press listening on the menu widget as the slider does not allow this.
   g_signal_connect(menu, key-press-event, G_CALLBACK(key_press_cb), io);
 
@@ -297,26 +294,6 @@
 }
 
 static gboolean
-new_scrub_bar_widget(DbusmenuMenuitem * newitem, DbusmenuMenuitem * parent, DbusmenuClient * client)
-{
-  g_debug(indicator-sound: new_scrub_bar_widget);
-
-  GtkWidget* scrub_bar = NULL;
-
-  g_return_val_if_fail(DBUSMENU_IS_MENUITEM(newitem), FALSE);
-  g_return_val_if_fail(DBUSMENU_IS_GTKCLIENT(client), FALSE);
-
-  scrub_bar = scrub_widget_new (newitem);
-  GtkMenuItem *menu_scrub_widget = GTK_MENU_ITEM(scrub_widget_get_ido_bar(SCRUB_WIDGET(scrub_bar)));
-
-  gtk_widget_show_all(scrub_widget_get_ido_bar(SCRUB_WIDGET(scrub_bar)));
-
-	dbusmenu_gtkclient_newitem_base(DBUSMENU_GTKCLIENT(client), newitem, menu_scrub_widget, parent);
-
-  return TRUE;
-}
-
-static gboolean
 new_volume_slider_widget(DbusmenuMenuitem * newitem, DbusmenuMenuitem * parent, DbusmenuClient * client)
 {
   g_debug(indicator-sound: new_volume_slider_widget);

=== modified file 'src/mpris2-controller.vala'
--- src/mpris2-controller.vala	2010-09-09 16:07:19 +
+++ src/mpris2-controller.vala	2010-09-13 12:38:46 +
@@ -1,5 +1,4 @@
 /*
-This service primarily controls PulseAudio and is driven by the sound indicator menu on the panel.
 Copyright 2010 Canonical Ltd.
 
 Authors:
@@ -84,10 +83,8 @@
 			this.player = (MprisPlayer) connection.get_object (root_interface.concat(.).concat(this.owner.name.down()),
    /org/mpris/MediaPlayer2,
    root_interface.concat(.Player));		
-			this.player.Seeked += onSeeked;
-
-			this.properties_interface = (FreeDesktopProperties) connection.get_object(root_interface.concat(.).concat(this.owner.name.down()),
-			  /org/mpris/MediaPlayer2);
+			this.properties_interface = (FreeDesktopProperties) connection.get_object(org.freedesktop.Properties.PropertiesChanged,//root_interface.concat(.).concat(this.owner.name.down()),
+			  /org/mpris/MediaPlayer2);
 			this.properties_interface.PropertiesChanged += property_changed_cb;			
 			
 		} catch (DBus.Error e) {
@@ -98,16 +95,14 @@
 	public void property_changed_cb(string interface_source, HashTablestring, Value? 

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/properties-changed-issues into lp:indicator-sound

2010-09-13 Thread Cody Russell
Review: Approve

-- 
https://code.launchpad.net/~cjcurran/indicator-sound/properties-changed-issues/+merge/35274
Your team ayatana-commits is subscribed to branch lp:indicator-sound.

___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp


[Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/missing-nonmono-icon into lp:indicator-sound

2010-09-13 Thread Conor Curran
Conor Curran has proposed merging 
lp:~cjcurran/indicator-sound/missing-nonmono-icon into lp:indicator-sound.

Requested reviews:
  Indicator Applet Developers (indicator-applet-developers)
Related bugs:
  #628896 sound_icon for indicator-sound missing for ubuntu-light
  https://bugs.launchpad.net/bugs/628896


fixes bug attached
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/missing-nonmono-icon/+merge/35291
Your team ayatana-commits is subscribed to branch lp:indicator-sound.
=== modified file 'configure.ac'
--- configure.ac	2010-09-10 13:21:38 +
+++ configure.ac	2010-09-13 14:59:40 +
@@ -135,6 +135,9 @@
 Makefile
 src/Makefile
 data/Makefile
+data/icons/Makefile
+data/icons/scalable/Makefile
+data/icons/scalable/status/Makefile
 tests/Makefile
 po/Makefile.in
 ])

=== modified file 'data/Makefile.am'
--- data/Makefile.am	2010-07-07 14:08:34 +
+++ data/Makefile.am	2010-09-13 14:59:40 +
@@ -1,3 +1,5 @@
+SUBDIRS = icons
+
 dbus_servicesdir = $(DBUSSERVICEDIR)
 service_in_files =  indicator-sound.service.in 
 dbus_services_DATA = $(service_in_files:.service.in=.service)

=== added directory 'data/icons'
=== added file 'data/icons/Makefile.am'
--- data/icons/Makefile.am	1970-01-01 00:00:00 +
+++ data/icons/Makefile.am	2010-09-13 14:59:40 +
@@ -0,0 +1,15 @@
+SUBDIRS = scalable
+
+gtk_update_icon_cache = gtk-update-icon-cache -f -t $(pkgdatadir)/icons/hicolor
+
+install-data-hook: update-icon-cache
+uninstall-hook: update-icon-cache
+update-icon-cache:
+	@-if test -z $(DESTDIR); then \
+		echo Updating Gtk icon cache.; \
+		$(gtk_update_icon_cache); \
+	else \
+		echo *** Icon cache not updated.  After (un)install, run this:; \
+		echo ***   $(gtk_update_icon_cache); \
+	fi
+

=== added directory 'data/icons/scalable'
=== added file 'data/icons/scalable/Makefile.am'
--- data/icons/scalable/Makefile.am	1970-01-01 00:00:00 +
+++ data/icons/scalable/Makefile.am	2010-09-13 14:59:40 +
@@ -0,0 +1,1 @@
+SUBDIRS = status

=== added directory 'data/icons/scalable/status'
=== added file 'data/icons/scalable/status/Makefile.am'
--- data/icons/scalable/status/Makefile.am	1970-01-01 00:00:00 +
+++ data/icons/scalable/status/Makefile.am	2010-09-13 14:59:40 +
@@ -0,0 +1,8 @@
+
+iconsdir = $(INDICATORICONSDIR)/hicolor/scalable/status
+
+icons_DATA =  \
+	sound-icon.svg
+
+EXTRA_DIST = $(icons_DATA)
+

=== added file 'data/icons/scalable/status/sound-icon.svg'
--- data/icons/scalable/status/sound-icon.svg	1970-01-01 00:00:00 +
+++ data/icons/scalable/status/sound-icon.svg	2010-09-13 14:59:40 +
@@ -0,0 +1,102 @@
+?xml version=1.0 encoding=UTF-8 standalone=no?
+!-- Created with Inkscape (http://www.inkscape.org/) --
+
+svg
+   xmlns:svg=http://www.w3.org/2000/svg;
+   xmlns=http://www.w3.org/2000/svg;
+   xmlns:xlink=http://www.w3.org/1999/xlink;
+   version=1.1
+   width=16
+   height=16
+   id=svg3809
+  defs
+ id=defs3811
+linearGradient
+   x1=28.739122
+   y1=144.11652
+   x2=26.256771
+   y2=125.39074
+   id=linearGradient2974
+   xlink:href=#linearGradient2372
+   gradientUnits=userSpaceOnUse
+   gradientTransform=matrix(0.2545239,0,0,0.12875595,6.0849926,-15.173532) /
+linearGradient
+   id=linearGradient2372
+  stop
+ id=stop2374
+ style=stop-color:#ff;stop-opacity:1
+ offset=0 /
+  stop
+ id=stop2376
+ style=stop-color:#ff;stop-opacity:0.37931034
+ offset=1 /
+/linearGradient
+linearGradient
+   x1=28.739122
+   y1=144.11652
+   x2=25.400293
+   y2=119.86452
+   id=linearGradient2977
+   xlink:href=#linearGradient2372
+   gradientUnits=userSpaceOnUse
+   gradientTransform=matrix(0.12649532,0,0,0.12875595,2.1139996,-14.056928) /
+radialGradient
+   cx=17.058823
+   cy=41.058823
+   r=5.7384715
+   fx=15.970393
+   fy=39.105911
+   id=radialGradient2980
+   xlink:href=#linearGradient7067-814-120-245
+   gradientUnits=userSpaceOnUse
+   gradientTransform=matrix(0.3698584,-0.06212313,0,0.35879901,4.6705097,-1.5148309) /
+linearGradient
+   id=linearGradient7067-814-120-245
+  stop
+ id=stop3877
+ style=stop-color:#aa;stop-opacity:1
+ offset=0 /
+  stop
+ id=stop3879
+ style=stop-color:#4d4d4d;stop-opacity:1
+ offset=1 /
+/linearGradient
+radialGradient
+   cx=17.058823
+   cy=41.058823
+   r=5.7384715
+   fx=15.544384
+   fy=39.027378
+   id=radialGradient2983
+   xlink:href=#linearGradient7067-814-120-245
+   gradientUnits=userSpaceOnUse
+   gradientTransform=matrix(0.37667571,-0.06311262,0,0.36451394,-2.446246,-0.69065449) /
+  /defs
+  g
+ id=layer1
+path
+   d=M 12.887143,11.242639 12.520463,8.2875931
+   id=path2931
+   style=fill:none;stroke:none /
+path
+   d=M 12.862181,0.50107998 C 10.505078,0.88091513 7.3505507,1.2719259 

[Ayatana-commits] [Merge] lp:~bratsche/appmenu-gtk/rebuild-item-cache-fix into lp:appmenu-gtk

2010-09-13 Thread Cody Russell
Cody Russell has proposed merging 
lp:~bratsche/appmenu-gtk/rebuild-item-cache-fix into lp:appmenu-gtk.

Requested reviews:
  Canonical Desktop Experience Team (canonical-dx-team)
Related bugs:
  #636962 Nautilus Open With items duplicated
  https://bugs.launchpad.net/bugs/636962

-- 
https://code.launchpad.net/~bratsche/appmenu-gtk/rebuild-item-cache-fix/+merge/35296
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
=== modified file 'src/bridge.c'
--- src/bridge.c	2010-09-09 18:22:00 +
+++ src/bridge.c	2010-09-13 15:31:02 +
@@ -878,11 +878,17 @@
 }
 }
 
-  recurse-stack[recurse-count] = g_hash_table_lookup (recurse-context-lookup, widget);
-  if (!recurse-stack[recurse-count])
+  DbusmenuMenuitem *dmi = g_hash_table_lookup (recurse-context-lookup, widget);
+  if (dmi != NULL)
+{
+  if (increment)
+recurse-count--;
+
+  return;
+}
+  else
 {
   recurse-stack[recurse-count] = construct_dbusmenu_for_widget (widget, previous_separator);
-
   g_hash_table_insert (recurse-context-lookup, widget, recurse-stack[recurse-count]);
 }
 
@@ -921,7 +927,7 @@
   GList *children = NULL;
   GList *peek = NULL;
 
-  if (recurse-stack[recurse-count -1])
+  if (recurse-stack[recurse-count - 1])
 {
   children = dbusmenu_menuitem_get_children (recurse-stack[recurse-count - 1]);
 

___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp


[Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/missing-nonmono-icon into lp:indicator-sound

2010-09-13 Thread Conor Curran
Conor Curran has proposed merging 
lp:~cjcurran/indicator-sound/missing-nonmono-icon into lp:indicator-sound.

Requested reviews:
  Indicator Applet Developers (indicator-applet-developers)
Related bugs:
  #628896 sound_icon for indicator-sound missing for ubuntu-light
  https://bugs.launchpad.net/bugs/628896


fixes the bug attached
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/missing-nonmono-icon/+merge/35299
Your team ayatana-commits is subscribed to branch lp:indicator-sound.
=== modified file 'configure.ac'
--- configure.ac	2010-09-10 13:21:38 +
+++ configure.ac	2010-09-13 16:06:55 +
@@ -135,6 +135,11 @@
 Makefile
 src/Makefile
 data/Makefile
+data/icons/Makefile
+data/icons/16x16/Makefile
+data/icons/16x16/status/Makefile
+data/icons/scalable/Makefile
+data/icons/scalable/status/Makefile
 tests/Makefile
 po/Makefile.in
 ])

=== modified file 'data/Makefile.am'
--- data/Makefile.am	2010-07-07 14:08:34 +
+++ data/Makefile.am	2010-09-13 16:06:55 +
@@ -1,3 +1,5 @@
+SUBDIRS = icons
+
 dbus_servicesdir = $(DBUSSERVICEDIR)
 service_in_files =  indicator-sound.service.in 
 dbus_services_DATA = $(service_in_files:.service.in=.service)

=== added directory 'data/icons'
=== added directory 'data/icons/16x16'
=== added file 'data/icons/16x16/Makefile.am'
--- data/icons/16x16/Makefile.am	1970-01-01 00:00:00 +
+++ data/icons/16x16/Makefile.am	2010-09-13 16:06:55 +
@@ -0,0 +1,1 @@
+SUBDIRS = status

=== added directory 'data/icons/16x16/status'
=== added file 'data/icons/16x16/status/Makefile.am'
--- data/icons/16x16/status/Makefile.am	1970-01-01 00:00:00 +
+++ data/icons/16x16/status/Makefile.am	2010-09-13 16:06:55 +
@@ -0,0 +1,8 @@
+
+iconsdir = $(INDICATORICONSDIR)/hicolor/16x16/status
+
+icons_DATA =  \
+	sound-icon.png 
+
+EXTRA_DIST = $(icons_DATA)
+

=== added file 'data/icons/16x16/status/sound-icon.png'
Binary files data/icons/16x16/status/sound-icon.png	1970-01-01 00:00:00 + and data/icons/16x16/status/sound-icon.png	2010-09-13 16:06:55 + differ
=== added file 'data/icons/Makefile.am'
--- data/icons/Makefile.am	1970-01-01 00:00:00 +
+++ data/icons/Makefile.am	2010-09-13 16:06:55 +
@@ -0,0 +1,15 @@
+SUBDIRS = scalable
+
+gtk_update_icon_cache = gtk-update-icon-cache -f -t $(pkgdatadir)/icons/hicolor
+
+install-data-hook: update-icon-cache
+uninstall-hook: update-icon-cache
+update-icon-cache:
+	@-if test -z $(DESTDIR); then \
+		echo Updating Gtk icon cache.; \
+		$(gtk_update_icon_cache); \
+	else \
+		echo *** Icon cache not updated.  After (un)install, run this:; \
+		echo ***   $(gtk_update_icon_cache); \
+	fi
+

=== added directory 'data/icons/scalable'
=== added file 'data/icons/scalable/Makefile.am'
--- data/icons/scalable/Makefile.am	1970-01-01 00:00:00 +
+++ data/icons/scalable/Makefile.am	2010-09-13 16:06:55 +
@@ -0,0 +1,1 @@
+SUBDIRS = status

=== added directory 'data/icons/scalable/status'
=== added file 'data/icons/scalable/status/Makefile.am'
--- data/icons/scalable/status/Makefile.am	1970-01-01 00:00:00 +
+++ data/icons/scalable/status/Makefile.am	2010-09-13 16:06:55 +
@@ -0,0 +1,8 @@
+
+iconsdir = $(INDICATORICONSDIR)/hicolor/scalable/status
+
+icons_DATA =  \
+	sound-icon.svg
+
+EXTRA_DIST = $(icons_DATA)
+

=== added file 'data/icons/scalable/status/sound-icon.svg'
--- data/icons/scalable/status/sound-icon.svg	1970-01-01 00:00:00 +
+++ data/icons/scalable/status/sound-icon.svg	2010-09-13 16:06:55 +
@@ -0,0 +1,102 @@
+?xml version=1.0 encoding=UTF-8 standalone=no?
+!-- Created with Inkscape (http://www.inkscape.org/) --
+
+svg
+   xmlns:svg=http://www.w3.org/2000/svg;
+   xmlns=http://www.w3.org/2000/svg;
+   xmlns:xlink=http://www.w3.org/1999/xlink;
+   version=1.1
+   width=16
+   height=16
+   id=svg3809
+  defs
+ id=defs3811
+linearGradient
+   x1=28.739122
+   y1=144.11652
+   x2=26.256771
+   y2=125.39074
+   id=linearGradient2974
+   xlink:href=#linearGradient2372
+   gradientUnits=userSpaceOnUse
+   gradientTransform=matrix(0.2545239,0,0,0.12875595,6.0849926,-15.173532) /
+linearGradient
+   id=linearGradient2372
+  stop
+ id=stop2374
+ style=stop-color:#ff;stop-opacity:1
+ offset=0 /
+  stop
+ id=stop2376
+ style=stop-color:#ff;stop-opacity:0.37931034
+ offset=1 /
+/linearGradient
+linearGradient
+   x1=28.739122
+   y1=144.11652
+   x2=25.400293
+   y2=119.86452
+   id=linearGradient2977
+   xlink:href=#linearGradient2372
+   gradientUnits=userSpaceOnUse
+   gradientTransform=matrix(0.12649532,0,0,0.12875595,2.1139996,-14.056928) /
+radialGradient
+   cx=17.058823
+   cy=41.058823
+   r=5.7384715
+   fx=15.970393
+   fy=39.105911
+   id=radialGradient2980
+   xlink:href=#linearGradient7067-814-120-245
+   gradientUnits=userSpaceOnUse
+   

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/missing-nonmono-icon into lp:indicator-sound

2010-09-13 Thread Conor Curran
The proposal to merge lp:~cjcurran/indicator-sound/missing-nonmono-icon into 
lp:indicator-sound has been updated.

Status: Needs review = Superseded
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/missing-nonmono-icon/+merge/35299
Your team ayatana-commits is subscribed to branch lp:indicator-sound.

___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp


[Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/missing-nonmono-icon into lp:indicator-sound

2010-09-13 Thread Conor Curran
Conor Curran has proposed merging 
lp:~cjcurran/indicator-sound/missing-nonmono-icon into lp:indicator-sound.

Requested reviews:
  Indicator Applet Developers (indicator-applet-developers)
Related bugs:
  #628896 sound_icon for indicator-sound missing for ubuntu-light
  https://bugs.launchpad.net/bugs/628896


fixes the bug attached
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/missing-nonmono-icon/+merge/35302
Your team ayatana-commits is subscribed to branch lp:indicator-sound.
=== modified file 'configure.ac'
--- configure.ac	2010-09-10 13:21:38 +
+++ configure.ac	2010-09-13 16:17:52 +
@@ -135,6 +135,11 @@
 Makefile
 src/Makefile
 data/Makefile
+data/icons/Makefile
+data/icons/16x16/Makefile
+data/icons/16x16/status/Makefile
+data/icons/scalable/Makefile
+data/icons/scalable/status/Makefile
 tests/Makefile
 po/Makefile.in
 ])

=== modified file 'data/Makefile.am'
--- data/Makefile.am	2010-07-07 14:08:34 +
+++ data/Makefile.am	2010-09-13 16:17:52 +
@@ -1,3 +1,5 @@
+SUBDIRS = icons
+
 dbus_servicesdir = $(DBUSSERVICEDIR)
 service_in_files =  indicator-sound.service.in 
 dbus_services_DATA = $(service_in_files:.service.in=.service)

=== added directory 'data/icons'
=== added directory 'data/icons/16x16'
=== added file 'data/icons/16x16/Makefile.am'
--- data/icons/16x16/Makefile.am	1970-01-01 00:00:00 +
+++ data/icons/16x16/Makefile.am	2010-09-13 16:17:52 +
@@ -0,0 +1,1 @@
+SUBDIRS = status

=== added directory 'data/icons/16x16/status'
=== added file 'data/icons/16x16/status/Makefile.am'
--- data/icons/16x16/status/Makefile.am	1970-01-01 00:00:00 +
+++ data/icons/16x16/status/Makefile.am	2010-09-13 16:17:52 +
@@ -0,0 +1,8 @@
+
+iconsdir = $(INDICATORICONSDIR)/hicolor/16x16/status
+
+icons_DATA =  \
+	sound-icon.png 
+
+EXTRA_DIST = $(icons_DATA)
+

=== added file 'data/icons/16x16/status/sound-icon.png'
Binary files data/icons/16x16/status/sound-icon.png	1970-01-01 00:00:00 + and data/icons/16x16/status/sound-icon.png	2010-09-13 16:17:52 + differ
=== added file 'data/icons/Makefile.am'
--- data/icons/Makefile.am	1970-01-01 00:00:00 +
+++ data/icons/Makefile.am	2010-09-13 16:17:52 +
@@ -0,0 +1,15 @@
+SUBDIRS = scalable 16x16
+
+gtk_update_icon_cache = gtk-update-icon-cache -f -t $(pkgdatadir)/icons/hicolor
+
+install-data-hook: update-icon-cache
+uninstall-hook: update-icon-cache
+update-icon-cache:
+	@-if test -z $(DESTDIR); then \
+		echo Updating Gtk icon cache.; \
+		$(gtk_update_icon_cache); \
+	else \
+		echo *** Icon cache not updated.  After (un)install, run this:; \
+		echo ***   $(gtk_update_icon_cache); \
+	fi
+

=== added directory 'data/icons/scalable'
=== added file 'data/icons/scalable/Makefile.am'
--- data/icons/scalable/Makefile.am	1970-01-01 00:00:00 +
+++ data/icons/scalable/Makefile.am	2010-09-13 16:17:52 +
@@ -0,0 +1,1 @@
+SUBDIRS = status

=== added directory 'data/icons/scalable/status'
=== added file 'data/icons/scalable/status/Makefile.am'
--- data/icons/scalable/status/Makefile.am	1970-01-01 00:00:00 +
+++ data/icons/scalable/status/Makefile.am	2010-09-13 16:17:52 +
@@ -0,0 +1,8 @@
+
+iconsdir = $(INDICATORICONSDIR)/hicolor/scalable/status
+
+icons_DATA =  \
+	sound-icon.svg
+
+EXTRA_DIST = $(icons_DATA)
+

=== added file 'data/icons/scalable/status/sound-icon.svg'
--- data/icons/scalable/status/sound-icon.svg	1970-01-01 00:00:00 +
+++ data/icons/scalable/status/sound-icon.svg	2010-09-13 16:17:52 +
@@ -0,0 +1,102 @@
+?xml version=1.0 encoding=UTF-8 standalone=no?
+!-- Created with Inkscape (http://www.inkscape.org/) --
+
+svg
+   xmlns:svg=http://www.w3.org/2000/svg;
+   xmlns=http://www.w3.org/2000/svg;
+   xmlns:xlink=http://www.w3.org/1999/xlink;
+   version=1.1
+   width=16
+   height=16
+   id=svg3809
+  defs
+ id=defs3811
+linearGradient
+   x1=28.739122
+   y1=144.11652
+   x2=26.256771
+   y2=125.39074
+   id=linearGradient2974
+   xlink:href=#linearGradient2372
+   gradientUnits=userSpaceOnUse
+   gradientTransform=matrix(0.2545239,0,0,0.12875595,6.0849926,-15.173532) /
+linearGradient
+   id=linearGradient2372
+  stop
+ id=stop2374
+ style=stop-color:#ff;stop-opacity:1
+ offset=0 /
+  stop
+ id=stop2376
+ style=stop-color:#ff;stop-opacity:0.37931034
+ offset=1 /
+/linearGradient
+linearGradient
+   x1=28.739122
+   y1=144.11652
+   x2=25.400293
+   y2=119.86452
+   id=linearGradient2977
+   xlink:href=#linearGradient2372
+   gradientUnits=userSpaceOnUse
+   gradientTransform=matrix(0.12649532,0,0,0.12875595,2.1139996,-14.056928) /
+radialGradient
+   cx=17.058823
+   cy=41.058823
+   r=5.7384715
+   fx=15.970393
+   fy=39.105911
+   id=radialGradient2980
+   xlink:href=#linearGradient7067-814-120-245
+   gradientUnits=userSpaceOnUse
+   

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/missing-nonmono-icon into lp:indicator-sound

2010-09-13 Thread Ted Gould
Review: Approve

-- 
https://code.launchpad.net/~cjcurran/indicator-sound/missing-nonmono-icon/+merge/35302
Your team ayatana-commits is subscribed to branch lp:indicator-sound.

___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp


[Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/missing-nonmono-icon into lp:indicator-sound

2010-09-13 Thread noreply
The proposal to merge lp:~cjcurran/indicator-sound/missing-nonmono-icon into 
lp:indicator-sound has been updated.

Status: Needs review = Merged
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/missing-nonmono-icon/+merge/35302
Your team ayatana-commits is subscribed to branch lp:indicator-sound.

___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp


[Ayatana-commits] [Merge] lp:~bratsche/appmenu-gtk/rebuild-item-cache-fix into lp:appmenu-gtk

2010-09-13 Thread noreply
The proposal to merge lp:~bratsche/appmenu-gtk/rebuild-item-cache-fix into 
lp:appmenu-gtk has been updated.

Status: Needs review = Merged
-- 
https://code.launchpad.net/~bratsche/appmenu-gtk/rebuild-item-cache-fix/+merge/35296
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.

___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp