Re: [Ayatana] Ideas for scrollbar's light themes
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Martín A. Casco wrote on 16/01/11 13:22: ... With the last release of Elementary theme, authors include a modd for Scrollbars.. No Steppers. The argument: Users normally don't use them, just use mouse scroll or handle scrollbars. well I think that's true, at least in most cases. I don't think you, or they, have any idea how often people use them. http://imgur.com/6ETb4 But, in NON GTK apps, like LibreOffice, have some problems with that modd. The only solution for elementary it's include steppers. If we think in the actual light themes ( and I don't know if there are any plans about this) have steppers, they are separate and if we want to use theme we have to make a considerable movement for up and down. So, why don't put them together? I've made a mockup only for vertically scrollbars (sorry), but the Idea it's have theme for horizontal scrollbars to. This will make that the 4 steppers will be in the same area and if we want to use them are more easy, fast an simple.. ... That's a great idea. Probably there would be the same problem with non-native applications like LibreOffice and Firefox, though. They would need their own code to recognize the arrows-together setting. Martín A. Casco wrote on 16/01/11 13:39: Well, for my last mail I've been thinking. Maybe 3 steppers for each scrollbar could be more simple. If we are on the top off apps with the mouse and want to use upper stepper we have to go down with the mouse (thats the concept of my first mockup), this solution its not better at all. So maybe this mockup represents better the concept of simplicity on scrollbar's steppers. ... That's what KDE does. But it goes against the principle of parsimony: having two similarly accessible methods of doing the same thing slows people down, by making them dither. (For example, it's okay to have a title bar close button and a Close menu item, but having two close buttons is bad. Similarly, having two scroll-up buttons would be bad.) - -- mpt -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk1BlNwACgkQ6PUxNfU6ecpy0QCeO9TQD1dfn//D/HqAGDgutCV9 rsgAn2KZvFSMVyOb6cv9sf4S9B7NwW4w =d2iH -END PGP SIGNATURE- ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Left close buttons on tabs
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Valeryan_24 wrote on 17/01/11 09:41: ... As Ubuntu now has Close - Minimize - Maximize buttons on right side of the window, as Unity panel will be on the left side of screen, I wonder if it would be possible also to get the X close buttons on tabs put to the left for the applications which are using tabs : Firefox - Thunderbird - Libre Office - Empathy - Nautilus - Gedit - Shutter... ... Chromium and Chrome have close buttons on the right of their tabs because it's faster to use than having them on the left. http://www.theinvisibl.com/2009/12/08/chrometabs/ So that probably won't change any time soon. - -- mpt -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk1BozgACgkQ6PUxNfU6ecqzbQCglxQOJjtAGDJHYWk9DXuNGBoQ VO8AoIi/w6TbZkWKPOYmzXSayL1NfC8a =ILOF -END PGP SIGNATURE- ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
[Ayatana] Places vs Journals
Hello List,
Places has been a very rare topic as far as i remember.
It is quite obvious that the concept of having Places is step towards making
things more simple for the user.
Currently, we have the following Places:
* Documents
* Music
* Pictures
* Videos
* Downloads
* Computer
* Home
* Trash
* Templates
* Recent (History)
These 10 items have the potential to work in a useful way, complementing
each other.
An interesting comparison might be the Internet, which evolved a great
number of methods to identify, locate and access the billions of items
connected throughout it.
At first everything was seperated into classes, until the classes and
subnetworks became overloaded and a scalable solution needed to be found.¹
So the concept of classless networks was introduced.
In our local computing environment, Places is a mediating technology, trying
to bridge the conceptual gap between how something is stored and how the
user may best remember a path to accessing it.
The Internet Protocol has a very good analogy for this:
*A name indicates what we seek. An address indicates where it is. A route
indicates how to get there.
*
( see: http://tools.ietf.org/html/rfc791#section-2.3 )
In this understanding, Places would be the how to get there part,
filenames are where it is and Document Title or Name represents what we
seek, in the best case accompanied by a very telling preview.
So Places are not physical locations, and they shouldn't be. Much more
appropriate would be to have a managed content space presenting items and
relational information to the user intelligently.
This starts with what we call XDG User Dirs, these are pointers rather than
fixed locations. XDG User Dirs are meant to put a particular content type
into a space that will manage it for the user..
At the moment, the only form of management in the default GNOME desktop is a
folder icon that represents the media type. This is insufficient.
Unity has a different approach. We have Content Managers, i.e.
Rhythmbox|Banshee for Music files, Shotwell for Pictures, hopefully soon
Dmedia for Videos and a potent system to present Documents, especially
recently and frequently used documents.
The reason why i think Content Manager haven't been so popular until today,
is because they were not designed to manage content, but to play it back or
to display it in Single Document mode so far.
Management of a library of songs was never part of e.g. Totem's agenda,
whereas Totem was always and is still until today the default music and
video player in Ubuntu.
In order to make this whole thing work properly consistently and without
app-related constraints, Unity might help by introducing intelligently
managed Places equipped with a relevance-promoting Journal.
I'll now attempt to sketch up what this might look like wrt PlacesDocuments
as an example:
Documents[ type to find ...|]
SUGGESTIONS and RESULTS: {
* Pinned [Title - Preview|Thumb - Action-Emblems on hover]
* Most Recent [Title - Preview|Thumb - Action-Emblems on hover]
/* including also most recently downloaded and most recently
received */
show more
* Last Modified1 [Title - Preview|Thumb - Action-Emblems on hover]
* Last Viewed1 [Title - Preview|Thumb - Action-Emblems on hover]
show more /* showing frequently viewed|modified,
sorted by an adequate recency|frequency sort algorithm */
}
this pattern might also be applicable to PlacesPictures, PlacesMusic and
PlacesVideos, whereas i would suggest to reconsider the Pinned part for
each Place.
Pinned is useful for Documents, but it might be disturbing when it comes to
music. I wouldn't mind pinning two or three genre types, or collections,
such as lounge, or hacking, or e.g. gaming.
It would feel very disturbing to have a single Song pinned or a single album
alwas come up on top when i go to my music library.. i want its order to be
arbitrary in a way, since that would be the closest thing to dynamic or
live that i can imagine..
Even though i rewrote this email several times with the aim to make it as
small as possible, i am noticing that it is getting a little large again, so
i'll stop right here and let the list decide if these ideas are valuable and
worth discussing any further.
Thanks for readin ;)
___
Mailing list: https://launchpad.net/~ayatana
Post to : ayatana@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana
More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Ideas for scrollbar's light themes
On Thu, Jan 27, 2011 at 16:53, Matthew Paul Thomas m...@canonical.comwrote: Martín A. Casco wrote on 16/01/11 13:39: Well, for my last mail I've been thinking. Maybe 3 steppers for each scrollbar could be more simple. If we are on the top off apps with the mouse and want to use upper stepper we have to go down with the mouse (thats the concept of my first mockup), this solution its not better at all. So maybe this mockup represents better the concept of simplicity on scrollbar's steppers. ... That's what KDE does. But it goes against the principle of parsimony: having two similarly accessible methods of doing the same thing slows people down, by making them dither. (For example, it's okay to have a title bar close button and a Close menu item, but having two close buttons is bad. Similarly, having two scroll-up buttons would be bad.) In an ideal world, yes. In our world, we need workarounds for all kinds of problems, such as misrepresentation of content or antiquted vertical and horizontal panning widgets. In this case, i think it is better to see a duplication of methods as the method itself. We already have scrollbar steppers all over the place in multiple open windows at a time, sometimes overlapping, and i think that makes it irrelevant whether they appear once or 100times within one window. At the end of the day, ideas from ZUI and Semantic Scaling will make content navigation easier, scrollbars will appear on demand if at alll, they will be transparent and they will offer semantic relationships to the content they are meant to help navigate. imo. ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Places vs Journals
ooops.. On Thu, Jan 27, 2011 at 13:46, frederik.nn...@gmail.com frederik.nn...@gmail.com wrote: At first everything was seperated into classes, until the classes and subnetworks became overloaded and a scalable solution needed to be found.¹ So the concept of classless networks was introduced. ¹ http://en.wikipedia.org/wiki/Scalability ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/serializable-menuitem into lp:dbusmenu
Review: Needs Fixing The function prototypes DbusmenuClientTypeHandler and DbusmenuClientTypeDestroyHandler needs documentation. Can we avoid double namespacing on these two functions?: dbusmenu_gtk_serializable_menu_item_build_dbusmenu_menuitem() dbusmenu_gtk_serializable_menu_item_set_dbusmenu_menuitem() Becomes: dbusmenu_gtk_serializable_menu_item_build_menuitem() dbusmenu_gtk_serializable_menu_item_set_menuitem() Can you add some section docs describing what the purpose of DbusmenuGtkSerializableMenuItem is, and how to use it? After reviewing this code I am still not entirely sure what it's supposed to do :-) -- https://code.launchpad.net/~ted/dbusmenu/serializable-menuitem/+merge/47604 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/parse-serializable-menuitem into lp:dbusmenu
Review: Needs Information How does this branch relate to https://code.launchpad.net/~ted/dbusmenu/serializable-menuitem/+merge/47604 ? They look identical? -- https://code.launchpad.net/~ted/dbusmenu/parse-serializable-menuitem/+merge/47605 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~mterry/appmenu-gtk/toggle-state-is-int into lp:appmenu-gtk
Michael Terry has proposed merging lp:~mterry/appmenu-gtk/toggle-state-is-int
into lp:appmenu-gtk.
Requested reviews:
Canonical Desktop Experience Team (canonical-dx-team)
Related bugs:
#682075 keyboard indicator has dot beside wrong layout
https://bugs.launchpad.net/bugs/682075
For more details, see:
https://code.launchpad.net/~mterry/appmenu-gtk/toggle-state-is-int/+merge/47659
I believe I proposed this before, but the proposal seems gone.
--
https://code.launchpad.net/~mterry/appmenu-gtk/toggle-state-is-int/+merge/47659
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
=== modified file 'src/bridge.c'
--- src/bridge.c 2011-01-21 16:34:43 +
+++ src/bridge.c 2011-01-27 14:14:58 +
@@ -692,9 +692,9 @@
}
else if (pspec-name == g_intern_static_string (active))
{
- dbusmenu_menuitem_property_set_bool (mi,
- DBUSMENU_MENUITEM_PROP_TOGGLE_STATE,
- gtk_toggle_action_get_active (GTK_TOGGLE_ACTION (action)));
+ dbusmenu_menuitem_property_set_int (mi,
+ DBUSMENU_MENUITEM_PROP_TOGGLE_STATE,
+ gtk_toggle_action_get_active (GTK_TOGGLE_ACTION (action)) ? DBUSMENU_MENUITEM_TOGGLE_STATE_CHECKED : DBUSMENU_MENUITEM_TOGGLE_STATE_UNCHECKED);
}
else if (pspec-name == g_intern_static_string (label))
{
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/now-with-parsing into lp:dbusmenu
On Thu, 2011-01-27 at 08:46 +, Mikkel Kamstrup Erlandsen wrote: dbusmenu_gtk_parse_menu_structure() needs documentation. r211 In order to help would/be consumers with debugging you should also add a g_return_val_if_fail(GTK_IS_MENU_ITEM(widget) || GTK_IS_MENU_SHELL (widget),NULL). r212 -- https://code.launchpad.net/~ted/dbusmenu/now-with-parsing/+merge/47603 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~mterry/appmenu-gtk/misc-fixes into lp:appmenu-gtk
The proposal to merge lp:~mterry/appmenu-gtk/misc-fixes into lp:appmenu-gtk has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~mterry/appmenu-gtk/misc-fixes/+merge/47114 -- https://code.launchpad.net/~mterry/appmenu-gtk/misc-fixes/+merge/47114 Your team ayatana-commits is subscribed to branch lp:appmenu-gtk. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/dbusmenu/now-with-parsing into lp:dbusmenu
The proposal to merge lp:~ted/dbusmenu/now-with-parsing into lp:dbusmenu has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~ted/dbusmenu/now-with-parsing/+merge/47603 -- https://code.launchpad.net/~ted/dbusmenu/now-with-parsing/+merge/47603 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Branch ~dbusmenu-team/dbusmenu/trunk] Rev 198: Making the parser recognize when it hits serializable menu items
Merge authors:
Ted Gould (ted)
Related merge proposals:
https://code.launchpad.net/~ted/dbusmenu/parse-serializable-menuitem/+merge/47710
proposed by: Ted Gould (ted)
revno: 198 [merge]
committer: Ted Gould t...@gould.cx
branch nick: trunk
timestamp: Thu 2011-01-27 13:54:18 -0600
message:
Making the parser recognize when it hits serializable menu items
modified:
.bzrignore
libdbusmenu-gtk/parser.c
--
lp:dbusmenu
https://code.launchpad.net/~dbusmenu-team/dbusmenu/trunk
Your team ayatana-commits is subscribed to branch lp:dbusmenu.
To unsubscribe from this branch go to
https://code.launchpad.net/~dbusmenu-team/dbusmenu/trunk/+edit-subscription
=== modified file '.bzrignore'
--- .bzrignore 2011-01-27 19:49:40 +
+++ .bzrignore 2011-01-27 19:54:18 +
@@ -220,10 +220,10 @@
libdbusmenu-gtk/DbusmenuGtk-0.4.vapi
libdbusmenu-gtk/dbusmenu-gtk-0.4.pc
libdbusmenu-gtk/dbusmenu-gtk3-0.4.pc
+libdbusmenu-gtk/libdbusmenu_gtk_la-serializablemenuitem.lo
+docs/libdbusmenu-gtk/reference/html/DbusmenuGtkSerializableMenuItem.html
+docs/libdbusmenu-gtk/reference/tmpl/serializablemenuitem.sgml
libdbusmenu-gtk/libdbusmenu_gtk_la-parser.lo
test-gtk-parser
test-gtk-parser-test
test-gtk-parser.xml
-libdbusmenu-gtk/libdbusmenu_gtk_la-serializablemenuitem.lo
-docs/libdbusmenu-gtk/reference/html/DbusmenuGtkSerializableMenuItem.html
-docs/libdbusmenu-gtk/reference/tmpl/serializablemenuitem.sgml
=== modified file 'libdbusmenu-gtk/parser.c'
--- libdbusmenu-gtk/parser.c 2011-01-27 14:50:24 +
+++ libdbusmenu-gtk/parser.c 2011-01-27 19:54:18 +
@@ -28,6 +28,7 @@
#include parser.h
#include menuitem.h
+#include serializablemenuitem.h
#define CACHED_MENUITEM dbusmenu-gtk-parser-cached-item
@@ -221,13 +222,23 @@
return;
}
+/* Turn a widget into a dbusmenu item depending on the type of GTK
+ object that it is. */
static DbusmenuMenuitem *
construct_dbusmenu_for_widget (GtkWidget * widget)
{
- DbusmenuMenuitem *mi = dbusmenu_menuitem_new ();
+ /* If it's a subclass of our serializable menu item then we can
+ use its own build function */
+ if (DBUSMENU_IS_GTK_SERIALIZABLE_MENU_ITEM(widget)) {
+ DbusmenuGtkSerializableMenuItem * smi = DBUSMENU_GTK_SERIALIZABLE_MENU_ITEM(widget);
+ return dbusmenu_gtk_serializable_menu_item_build_menuitem(smi);
+ }
+ /* If it's a standard GTK Menu Item we need to do some of our own work */
if (GTK_IS_MENU_ITEM (widget))
{
+ DbusmenuMenuitem *mi = dbusmenu_menuitem_new ();
+
gboolean visible = FALSE;
gboolean sensitive = FALSE;
if (GTK_IS_SEPARATOR_MENU_ITEM (widget))
@@ -360,11 +371,12 @@
notify,
G_CALLBACK (widget_notify_cb),
mi);
+ return mi;
}
- return mi;
-
- return NULL;
+ /* If it's none of those we're going to just create a
+ generic menuitem as a place holder for it. */
+ return dbusmenu_menuitem_new();
}
static void
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Branch ~dbusmenu-team/dbusmenu/trunk] Rev 197: Adding in a serializable menuitem object
Merge authors:
Ted Gould (ted)
Related merge proposals:
https://code.launchpad.net/~ted/dbusmenu/serializable-menuitem/+merge/47604
proposed by: Ted Gould (ted)
review: Needs Fixing - Mikkel Kamstrup Erlandsen (kamstrup)
revno: 197 [merge]
committer: Ted Gould t...@gould.cx
branch nick: trunk
timestamp: Thu 2011-01-27 13:49:40 -0600
message:
Adding in a serializable menuitem object
added:
libdbusmenu-gtk/serializablemenuitem.c
libdbusmenu-gtk/serializablemenuitem.h
modified:
.bzrignore
docs/libdbusmenu-gtk/reference/Makefile.am
docs/libdbusmenu-gtk/reference/libdbusmenu-gtk-docs.sgml
libdbusmenu-glib/client.c
libdbusmenu-glib/client.h
libdbusmenu-gtk/Makefile.am
libdbusmenu-gtk/client.c
libdbusmenu-gtk/dbusmenu-gtk.h
libdbusmenu-gtk/menuitem.h
--
lp:dbusmenu
https://code.launchpad.net/~dbusmenu-team/dbusmenu/trunk
Your team ayatana-commits is subscribed to branch lp:dbusmenu.
To unsubscribe from this branch go to
https://code.launchpad.net/~dbusmenu-team/dbusmenu/trunk/+edit-subscription
=== modified file '.bzrignore'
--- .bzrignore 2011-01-23 19:30:00 +
+++ .bzrignore 2011-01-27 19:49:40 +
@@ -224,3 +224,6 @@
test-gtk-parser
test-gtk-parser-test
test-gtk-parser.xml
+libdbusmenu-gtk/libdbusmenu_gtk_la-serializablemenuitem.lo
+docs/libdbusmenu-gtk/reference/html/DbusmenuGtkSerializableMenuItem.html
+docs/libdbusmenu-gtk/reference/tmpl/serializablemenuitem.sgml
=== modified file 'docs/libdbusmenu-gtk/reference/Makefile.am'
--- docs/libdbusmenu-gtk/reference/Makefile.am 2010-11-23 21:19:52 +
+++ docs/libdbusmenu-gtk/reference/Makefile.am 2011-01-21 23:01:41 +
@@ -54,7 +54,7 @@
# Header files to ignore when scanning.
# e.g. IGNORE_HFILES=gtkdebug.h gtkintl.h
-IGNORE_HFILES=
+IGNORE_HFILES=genericmenuitem.h
# Images to copy into HTML directory.
# e.g. HTML_IMAGES=$(top_srcdir)/gtk/stock-icons/stock_about_24.png
=== modified file 'docs/libdbusmenu-gtk/reference/libdbusmenu-gtk-docs.sgml'
--- docs/libdbusmenu-gtk/reference/libdbusmenu-gtk-docs.sgml 2010-06-09 16:24:31 +
+++ docs/libdbusmenu-gtk/reference/libdbusmenu-gtk-docs.sgml 2011-01-21 23:01:41 +
@@ -13,8 +13,8 @@
titleAPI/title
xi:include href=xml/menu.xml/
xi:include href=xml/client.xml/
-xi:include href=xml/genericmenuitem.xml/
xi:include href=xml/menuitem.xml/
+xi:include href=xml/serializablemenuitem.xml/
/chapter
chapter id=object-tree
=== modified file 'libdbusmenu-glib/client.c'
--- libdbusmenu-glib/client.c 2011-01-26 23:12:22 +
+++ libdbusmenu-glib/client.c 2011-01-27 19:49:40 +
@@ -120,6 +120,15 @@
guint timestamp;
};
+typedef struct _type_handler_t type_handler_t;
+struct _type_handler_t {
+ DbusmenuClient * client;
+ DbusmenuClientTypeHandler cb;
+ DbusmenuClientTypeDestroyHandler destroy_cb;
+ gpointer user_data;
+ gchar * type;
+};
+
#define DBUSMENU_CLIENT_GET_PRIVATE(o) (DBUSMENU_CLIENT(o)-priv)
#define DBUSMENU_INTERFACE com.canonical.dbusmenu
@@ -148,6 +157,7 @@
static void menuproxy_build_cb (GObject * object, GAsyncResult * res, gpointer user_data);
static void menuproxy_name_changed_cb (GObject * object, GParamSpec * pspec, gpointer user_data);
static void menuproxy_signal_cb (GDBusProxy * proxy, gchar * sender, gchar * signal, GVariant * params, gpointer user_data);
+static void type_handler_destroy (gpointer user_data);
/* Globals */
static GDBusNodeInfo *dbusmenu_node_info = NULL;
@@ -310,7 +320,7 @@
priv-dbusproxy = 0;
priv-type_handlers = g_hash_table_new_full(g_str_hash, g_str_equal,
- g_free, NULL);
+ g_free, type_handler_destroy);
priv-delayed_idle = 0;
priv-delayed_property_list = g_array_new(TRUE, FALSE, sizeof(gchar *));
@@ -1153,17 +1163,17 @@
gboolean handled = FALSE;
const gchar * type;
- DbusmenuClientTypeHandler newfunc = NULL;
+ type_handler_t * th = NULL;
type = dbusmenu_menuitem_property_get(propdata-item, DBUSMENU_MENUITEM_PROP_TYPE);
if (type != NULL) {
- newfunc = g_hash_table_lookup(priv-type_handlers, type);
+ th = (type_handler_t *)g_hash_table_lookup(priv-type_handlers, type);
} else {
- newfunc = g_hash_table_lookup(priv-type_handlers, DBUSMENU_CLIENT_TYPES_DEFAULT);
+ th = (type_handler_t *)g_hash_table_lookup(priv-type_handlers, DBUSMENU_CLIENT_TYPES_DEFAULT);
}
- if (newfunc != NULL) {
- handled = newfunc(propdata-item, propdata-parent, propdata-client);
+ if (th != NULL th-cb != NULL) {
+ handled = th-cb(propdata-item, propdata-parent, propdata-client, th-user_data);
}
#ifdef MASSIVEDEBUGGING
@@ -1679,6 +1689,19 @@
return priv-root;
}
+/* Remove the type handler when we're all done with it */
+static void
+type_handler_destroy (gpointer user_data)
+{
+ type_handler_t * th = (type_handler_t *)user_data;
+ if (th-destroy_cb != NULL) {
+ th-destroy_cb(th-client,
[Ayatana-commits] [Branch ~indicator-applet-developers/indicator-me/trunk] Rev 125: version bump 0.2.12
revno: 125 tags: 0.2.12 committer: Ken VanDine ken.vand...@canonical.com branch nick: indicator-me timestamp: Thu 2011-01-27 14:50:34 -0500 message: version bump 0.2.12 modified: configure.ac -- lp:indicator-me https://code.launchpad.net/~indicator-applet-developers/indicator-me/trunk Your team ayatana-commits is subscribed to branch lp:indicator-me. To unsubscribe from this branch go to https://code.launchpad.net/~indicator-applet-developers/indicator-me/trunk/+edit-subscription === modified file 'configure.ac' --- configure.ac 2011-01-13 22:53:43 + +++ configure.ac 2011-01-27 19:50:34 + @@ -6,7 +6,7 @@ AC_PREREQ(2.53) AM_CONFIG_HEADER(config.h) -AM_INIT_AUTOMAKE(indicator-me, 0.2.11) +AM_INIT_AUTOMAKE(indicator-me, 0.2.12) AM_MAINTAINER_MODE ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~3v1n0/indicator-applet/scroll-event-support into lp:indicator-applet
The proposal to merge lp:~3v1n0/indicator-applet/scroll-event-support into lp:indicator-applet has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~3v1n0/indicator-applet/scroll-event-support/+merge/47612 -- https://code.launchpad.net/~3v1n0/indicator-applet/scroll-event-support/+merge/47612 Your team ayatana-commits is subscribed to branch lp:indicator-applet. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Branch ~indicator-applet-developers/indicator-applet/applet] Rev 378: 0.4.7
revno: 378 tags: 0.4.7 committer: Ted Gould t...@gould.cx branch nick: trunk timestamp: Thu 2011-01-27 15:43:31 -0600 message: 0.4.7 modified: configure.ac -- lp:indicator-applet https://code.launchpad.net/~indicator-applet-developers/indicator-applet/applet Your team ayatana-commits is subscribed to branch lp:indicator-applet. To unsubscribe from this branch go to https://code.launchpad.net/~indicator-applet-developers/indicator-applet/applet/+edit-subscription === modified file 'configure.ac' --- configure.ac 2011-01-27 21:43:05 + +++ configure.ac 2011-01-27 21:43:31 + @@ -4,7 +4,7 @@ AC_PREREQ(2.53) AM_CONFIG_HEADER(config.h) -AM_INIT_AUTOMAKE(indicator-applet, 0.4.6) +AM_INIT_AUTOMAKE(indicator-applet, 0.4.7) AM_MAINTAINER_MODE m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES]) ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Branch ~indicator-applet-developers/indicator-applet/applet] Rev 377: Require libindicator with new signal
revno: 377 committer: Ted Gould t...@gould.cx branch nick: trunk timestamp: Thu 2011-01-27 15:43:05 -0600 message: Require libindicator with new signal modified: configure.ac -- lp:indicator-applet https://code.launchpad.net/~indicator-applet-developers/indicator-applet/applet Your team ayatana-commits is subscribed to branch lp:indicator-applet. To unsubscribe from this branch go to https://code.launchpad.net/~indicator-applet-developers/indicator-applet/applet/+edit-subscription === modified file 'configure.ac' --- configure.ac 2010-11-10 18:28:18 + +++ configure.ac 2011-01-27 21:43:05 + @@ -26,7 +26,7 @@ ### GTK_REQUIRED_VERSION=2.12 -INDICATOR_REQUIRED_VERSION=0.3.14 +INDICATOR_REQUIRED_VERSION=0.3.18 PKG_CHECK_MODULES(APPLET, gtk+-2.0 = $GTK_REQUIRED_VERSION x11 ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Branch ~indicator-applet-developers/indicator-messages/trunk] Rev 206: Upgrading to new type handler prototype
revno: 206
committer: Ted Gould t...@gould.cx
branch nick: trunk
timestamp: Thu 2011-01-27 16:57:04 -0600
message:
Upgrading to new type handler prototype
modified:
configure.ac
src/indicator-messages.c
--
lp:indicator-messages
https://code.launchpad.net/~indicator-applet-developers/indicator-messages/trunk
Your team ayatana-commits is subscribed to branch lp:indicator-messages.
To unsubscribe from this branch go to
https://code.launchpad.net/~indicator-applet-developers/indicator-messages/trunk/+edit-subscription
=== modified file 'configure.ac'
--- configure.ac 2011-01-14 20:22:31 +
+++ configure.ac 2011-01-27 22:57:04 +
@@ -40,7 +40,7 @@
PANEL_REQUIRED_VERSION=2.0.0
INDICATE_REQUIRED_VERSION=0.4.90
INDICATOR_REQUIRED_VERSION=0.3.5
-DBUSMENUGTK_REQUIRED_VERSION=0.3.90
+DBUSMENUGTK_REQUIRED_VERSION=0.3.94
PKG_CHECK_MODULES(APPLET, gtk+-2.0 = $GTK_REQUIRED_VERSION
gio-unix-2.0 = $GIO_UNIX_REQUIRED_VERSION
=== modified file 'src/indicator-messages.c'
--- src/indicator-messages.c 2011-01-14 19:10:10 +
+++ src/indicator-messages.c 2011-01-27 22:57:04 +
@@ -489,7 +489,7 @@
/* Builds a menu item representing a running application in the
messaging menu */
static gboolean
-new_application_item (DbusmenuMenuitem * newitem, DbusmenuMenuitem * parent, DbusmenuClient * client)
+new_application_item (DbusmenuMenuitem * newitem, DbusmenuMenuitem * parent, DbusmenuClient * client, gpointer user_data)
{
g_debug (%s (\%s\), __func__, dbusmenu_menuitem_property_get(newitem, APPLICATION_MENUITEM_PROP_NAME));
@@ -597,7 +597,7 @@
shifting over and putting the icon in with some right
side text that'll be determined by the service. */
static gboolean
-new_indicator_item (DbusmenuMenuitem * newitem, DbusmenuMenuitem * parent, DbusmenuClient * client)
+new_indicator_item (DbusmenuMenuitem * newitem, DbusmenuMenuitem * parent, DbusmenuClient * client, gpointer user_data)
{
g_return_val_if_fail(DBUSMENU_IS_MENUITEM(newitem), FALSE);
g_return_val_if_fail(DBUSMENU_IS_GTKCLIENT(client), FALSE);
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help : https://help.launchpad.net/ListHelp
