[Ayatana-dev] Limiting the vertical size of the Unity launcher
Hello! This is probably a question for Jason, but I'm not 100% sure. When Unity lands, I intend to use the bottom left corner to place a small conky window, as I am a system stats junkie. But I won't want the Unity launcher to get in the way of conky and vice versa, so I need the Unity launcher to stop at X pixels from the bottom. How can I achieve that? Because this is of no interest whatsoever to the average user, I'm not asking for a setting or anything... I would just like to know where in the code I should hack into. (hence posting this to ayatana-dev) Thanks in advance! ___ Mailing list: https://launchpad.net/~ayatana-dev Post to : ayatana-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-dev More help : https://help.launchpad.net/ListHelp
[Ayatana] Global menu really frustrating in virtual machines
The global menu is based on the assumption that it's easier to hit the corner of the screen than it is to hit the edge of the active window. This breaks down, however, when the mouse doesn't actually stop at the corner of the screen, which is exactly the case in virtual machines that integrate with the host OS. Should VMs behave differently? Should they grab mouse input on click, like how vmware behaves without its tools installed? Thanks, Scott Ritchie ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Regarding the Sound Menu Spec's closing of inactive audio applications
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Chow Loong Jin wrote on 15/02/11 17:05: On Tuesday 08,February,2011 09:36 PM, Matthew Paul Thomas wrote: A window's close button should close the window. Anything else the program does should aim for the least overall distraction. Please correct me if I am wrong, but does this not mean that the original behaviour of having the media players (Banshee and Rhythmbox) close their windows, but remain running in the background, ready to resume at a moment's notice, is the correct behaviour after all? I don't claim to be an expert on when a media player should unload itself. What I do claim is that hardly anyone else is an expert on that topic either. :-) It's something best worked out by the Banshee and Rhythmbox developers. It seems to me that the original behaviour (as opposed to the current behaviour) closes the window and yields the least overall distraction, thus complying with the statement you made. The user does not need to know that the media player is actually still running in the background. The Quit action does create a bit of confusion in that case though. It does. That much, at least, is easily solved: rename it to Close. http://design.canonical.com/2011/03/quit/ - -- mpt -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk12DzcACgkQ6PUxNfU6ecp6pACeP4VfyMoK39gEq9Y+GoURpQJR p4QAnis8F6cPiqHs6MvElEAZbWPRCWtg =GLek -END PGP SIGNATURE- ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
[Ayatana] config files and apps are diferent.
Hi, now in unity configuration files are merged with apps and it's dificult for user differentiate them. i proposed to merge configuration files in control center, like kde, macos or windows. watch the mockups for better understand it. what do you think? its simply but important change for dialy use. http://www.lightgraphite.com/mockup1.jpg http://www.lightgraphite.com/mockup2.jpg Daniel Planas.A www.lightgraphite.com ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] config files and apps are diferent.
On Tue, Mar 8, 2011 at 13:13, dani daniplana...@gmail.com wrote: Hi, now in unity configuration files are merged with apps and it's dificult for user differentiate them. i proposed to merge configuration files in control center, like kde, macos or windows. watch the mockups for better understand it. what do you think? its simply but important change for dialy use. http://www.lightgraphite.com/mockup1.jpg http://www.lightgraphite.com/mockup2.jpg good thinking, imo! ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] config files and apps are diferent.
+1 Liked the idea. The interface will be easier for an user. On 8 March 2011 13:53, frederik.nn...@gmail.com frederik.nn...@gmail.comwrote: On Tue, Mar 8, 2011 at 13:13, dani daniplana...@gmail.com wrote: Hi, now in unity configuration files are merged with apps and it's dificult for user differentiate them. i proposed to merge configuration files in control center, like kde, macos or windows. watch the mockups for better understand it. what do you think? its simply but important change for dialy use. http://www.lightgraphite.com/mockup1.jpg http://www.lightgraphite.com/mockup2.jpg good thinking, imo! ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp -- M. Adnan Quaium URL: http://adnan.quaium.com ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] config files and apps are diferent.
On Tue, Mar 8, 2011 at 14:05, M. Adnan Quaium adnan.qua...@linux.org.bdwrote: +1 Liked the idea. The interface will be easier for an user. and semantically, a configuration page is not an application. it is a configuration page for applications. So Daniel is quite right, these don't belong with apps.. ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Global menu really frustrating in virtual machines
Perhaps a better way would be for the VM software to have edge resistance within the VM area. That way you can still move the mouse out of the VM without pressing key combos. On Tue, Mar 8, 2011 at 11:57 AM, Scott Ritchie sc...@open-vote.org wrote: The global menu is based on the assumption that it's easier to hit the corner of the screen than it is to hit the edge of the active window. This breaks down, however, when the mouse doesn't actually stop at the corner of the screen, which is exactly the case in virtual machines that integrate with the host OS. Should VMs behave differently? Should they grab mouse input on click, like how vmware behaves without its tools installed? Thanks, Scott Ritchie ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] No one will ever use the upper-left Ubuntu button
On 08/03/11 14:14, Marc Lajoie wrote: If I had a say (which I don't), I'd have a two-sided dock: on one side, the application buttons, on the other, the function buttons. The Ubuntu button would flip the dock over (perhaps with a pretty revolving animation!). See the attached mockup. Of course, if the dock is hidden, the first click will recall it. The second click will flip the dock. It might seem to waste time to have the extra click to get to the function buttons, but I think it comes to the same as having to hunt through the application buttons in the dock to find them. An interesting suggestion - maybe a web-based mockup would help test it? signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
[Ayatana] A better chat experience
Ok so ive been thinking a lot about chat and empathy/telepathy is awesome but Shell is pulling away from unity in terms of how to best use it. At the moment we have the default empathy so we have the window and messaging menu system. While Shell has a special chat notifier that you can see the chat history and type but still continue with what you are doing and type on the fly. I think this is a lot faster, easier and better looking in general. Im not saying build a new chat and notification system specifically for empathy chat but a quick window in the right corner with the last few messages or something and a text box would do and it would only pop up if the user clicks on the messaging menu item for that chat. I think it would be pretty nice to use. Thoughts? ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
[Ayatana] Where did the top folding go?
Hello, I've been bugging Neil Patel about this on Twitter lately and would like to know what the rest of the team has to say. It seems that Unity has purposefully dropped the ability to fold icons on top and now only folds the bottom ones. Even after some weeks, I still think it's very awkward to use because it feels like a scrollbar that always returns to the top when you leave it: an icon folded at the bottom will always re-fold even though it was the last icon clicked. This kinda goes against muscle memory and gives an unbalanced distribution of importance among the icons: the top ones are always faster to access. At least for me, it is very common for the workflow to be focused on the more recently opened windows, which are precisely the bottom ones. Neil mentioned possibilities of making the active window icon more noticeable even when it's in the folded area. This would be nice, but the unbalance would still be there. What was, after all, the reasoning for removing top folding? ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Where did the top folding go?
I agree with you too. I especially feel awkward when I have six applications or so opening (and none of them is pinned to the launcher). These applications are all set in the bottom of the panel instead of the top, and they are all fold, making it difficult to access... I think Ubuntu developers need a solution for this... On Tue, Mar 8, 2011 at 12:58 PM, Conscious User consciousu...@aol.comwrote: Hello, I've been bugging Neil Patel about this on Twitter lately and would like to know what the rest of the team has to say. It seems that Unity has purposefully dropped the ability to fold icons on top and now only folds the bottom ones. Even after some weeks, I still think it's very awkward to use because it feels like a scrollbar that always returns to the top when you leave it: an icon folded at the bottom will always re-fold even though it was the last icon clicked. This kinda goes against muscle memory and gives an unbalanced distribution of importance among the icons: the top ones are always faster to access. At least for me, it is very common for the workflow to be focused on the more recently opened windows, which are precisely the bottom ones. Neil mentioned possibilities of making the active window icon more noticeable even when it's in the folded area. This would be nice, but the unbalance would still be there. What was, after all, the reasoning for removing top folding? ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] No one will ever use the upper-left Ubuntu button
For the dash when you hit the ubuntu button you can use it for anything +1 I find myself only using the ubuntu button as well because I can get to anything from it where as the other buttons are limited in their scope and I need to think more about which one to use. ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/calendarmenuitemsignals into lp:indicator-datetime
Karl Lattimer has proposed merging
lp:~karl-qdh/indicator-datetime/calendarmenuitemsignals into
lp:indicator-datetime.
Requested reviews:
Ted Gould (ted)
Related bugs:
#726531 Browsing calendar widget should update appointments
https://bugs.launchpad.net/bugs/726531
For more details, see:
https://code.launchpad.net/~karl-qdh/indicator-datetime/calendarmenuitemsignals/+merge/52570
Partially fixes bug #726531
--
https://code.launchpad.net/~karl-qdh/indicator-datetime/calendarmenuitemsignals/+merge/52570
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.
=== modified file 'src/datetime-service.c'
--- src/datetime-service.c 2011-03-04 10:35:22 +
+++ src/datetime-service.c 2011-03-08 15:46:34 +
@@ -82,6 +82,7 @@
static GList * dconflocations = NULL;
static GList * comp_instances = NULL;
static gboolean updating_appointments = FALSE;
+static time_t start_time_appointments = (time_t) 0;
GSettings *conf;
@@ -277,14 +278,15 @@
}
static gboolean
-month_changed_cb (DbusmenuMenuitem * menuitem, GVariant *variant, guint timestamp)
+month_changed_cb (DbusmenuMenuitem * menuitem, gchar *name, GVariant *variant, guint timestamp)
{
- // BLOCKED: We're not getting the signal from calendar the ido calendar menuitem
- // TODO: * Decode the month/year from the string we received
- // * Check what our current month/year are
- // * Set some globals so when we-re-run update appointment menu items it gets the right start date
+ // BLOCKED: get type, then get type as string from the variant causes segfault in glib
+ // TODO: * Set some globals so when we-re-run update appointment menu items it gets the right start date
// * update appointment menu items
- g_debug(Received month changed : %s, g_variant_get_string(variant, NULL));
+ start_time_appointments = (time_t)g_variant_get_uint32(variant);
+
+ g_debug(Received month changed with timestamp: %d - %s,(int)start_time_appointments, ctime(start_time_appointments));
+ update_appointment_menu_items(NULL);
return TRUE;
}
@@ -537,6 +539,7 @@
{
// FFR: we should take into account short term timers, for instance
// tea timers, pomodoro timers etc... that people may add, this is hinted to in the spec.
+ g_debug(Update appointments called);
if (calendar == NULL) return FALSE;
if (!g_settings_get_boolean(conf, SETTINGS_SHOW_EVENTS_S)) return FALSE;
if (updating_appointments) return TRUE;
@@ -552,22 +555,12 @@
gint width, height;
ESourceList * sources = NULL;
- time(t1);
- time(t2);
- t2 += (time_t) (7 * 24 * 60 * 60); /* 7 days ahead of now, we actually need number_of_days_in_this_month */
+ if (start_time_appointments 0)
+ t1 = start_time_appointments;
+ else
+ time(t1);
- /* Remove all of the previous appointments */
- if (appointments != NULL) {
- g_debug(Freeing old appointments);
- while (appointments != NULL) {
- DbusmenuMenuitem * litem = DBUSMENU_MENUITEM(appointments-data);
- g_debug(Freeing old appointment: %p, litem);
- // Remove all the existing menu items which are in appointments.
- appointments = g_list_remove(appointments, litem);
- dbusmenu_menuitem_child_delete(root, DBUSMENU_MENUITEM(litem));
- g_object_unref(G_OBJECT(litem));
- }
- }
+ t2 = t1 + (time_t) (7 * 24 * 60 * 60); /* 7 days ahead of now, we actually need number_of_days_in_this_month */
// TODO Remove all highlights from the calendar widget
@@ -611,11 +604,26 @@
g_debug(Number of ECalComponents returned: %d, g_list_length(comp_instances));
GList *sorted_comp_instances = g_list_sort(comp_instances, compare_comp_instances);
comp_instances = NULL;
-
- gtk_icon_size_lookup(GTK_ICON_SIZE_MENU, width, height);
+
+ /* Remove all of the previous appointments */
+ if (appointments != NULL) {
+ g_debug(Freeing old appointments);
+ while (appointments != NULL) {
+ DbusmenuMenuitem * litem = DBUSMENU_MENUITEM(appointments-data);
+ g_debug(Freeing old appointment: %p, litem);
+ // Remove all the existing menu items which are in appointments.
+ appointments = g_list_remove(appointments, litem);
+ dbusmenu_menuitem_child_delete(root, DBUSMENU_MENUITEM(litem));
+ g_object_unref(G_OBJECT(litem));
+ }
+ }
+
+ gtk_icon_size_lookup(GTK_ICON_SIZE_MENU, width, height);
+ // Sometimes these give negative numbers, sometimes large numbers which look like timestampss
if (width = 0) width = 12;
- if (height = 0) height = 13;
-
+ if (height = 0) height = 12;
+ if (width 30) width = 12;
+ if (height 30) height = 12;
i = 0;
for (l = sorted_comp_instances; l; l = l-next) {
struct comp_instance *ci = l-data;
@@ -671,7 +679,7 @@
else
strftime(right, 20, %a %l:%M %p, due);
- g_debug(Appointment time: %s, right);
+ g_debug(Appointment time: %s, for date %s, right, asctime(due));
dbusmenu_menuitem_property_set (item, APPOINTMENT_MENUITEM_PROP_RIGHT, right);
// Now we pull out the URI for the calendar event and try to create a URI that'll work when we
[Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/fixappointmentformat into lp:indicator-datetime
Karl Lattimer has proposed merging
lp:~karl-qdh/indicator-datetime/fixappointmentformat into lp:indicator-datetime
with lp:~karl-qdh/indicator-datetime/calendarmenuitemsignals as a prerequisite.
Requested reviews:
Ted Gould (ted)
Related bugs:
#727100 Appointments' time format doesn't respect the settings
https://bugs.launchpad.net/bugs/727100
For more details, see:
https://code.launchpad.net/~karl-qdh/indicator-datetime/fixappointmentformat/+merge/52574
Fixes bug #727100
--
https://code.launchpad.net/~karl-qdh/indicator-datetime/fixappointmentformat/+merge/52574
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.
=== modified file 'src/datetime-service.c'
--- src/datetime-service.c 2011-03-08 16:09:42 +
+++ src/datetime-service.c 2011-03-08 16:09:42 +
@@ -624,6 +624,17 @@
if (height = 0) height = 12;
if (width 30) width = 12;
if (height 30) height = 12;
+
+ gchar *time_format_str = g_settings_get_string(conf, SETTINGS_TIME_FORMAT_S);
+ gint apt_output;
+ if (g_strcmp0(time_format_str, 12-hour) == 0) {
+ apt_output = SETTINGS_TIME_12_HOUR;
+ } else if (g_strcmp0(time_format_str, 24-hour) == 0) {
+ apt_output = SETTINGS_TIME_24_HOUR;
+ } else {
+ apt_output = SETTINGS_TIME_LOCALE;
+ }
+
i = 0;
for (l = sorted_comp_instances; l; l = l-next) {
struct comp_instance *ci = l-data;
@@ -674,11 +685,23 @@
int dmon = due-tm_mon;
int dyear = due-tm_year;
- if ((mday == dmday) (mon == dmon) (year == dyear))
- strftime(right, 20, %l:%M %p, due);
- else
- strftime(right, 20, %a %l:%M %p, due);
-
+ if (apt_output == SETTINGS_TIME_12_HOUR) {
+ if ((mday == dmday) (mon == dmon) (year == dyear))
+strftime(right, 20, DEFAULT_TIME_12_FORMAT, due);
+ else
+strftime(right, 20, DEFAULT_TIME_12_FORMAT_WITH_DAY, due);
+ } else if (apt_output == SETTINGS_TIME_24_HOUR) {
+ if ((mday == dmday) (mon == dmon) (year == dyear))
+strftime(right, 20, DEFAULT_TIME_24_FORMAT, due);
+ else
+strftime(right, 20, DEFAULT_TIME_24_FORMAT_WITH_DAY, due);
+ } else {
+ if ((mday == dmday) (mon == dmon) (year == dyear))
+strftime(right, 20, DEFAULT_TIME_FORMAT, due);
+ else
+strftime(right, 20, DEFAULT_TIME_FORMAT_WITH_DAY, due);
+ }
+
g_debug(Appointment time: %s, for date %s, right, asctime(due));
dbusmenu_menuitem_property_set (item, APPOINTMENT_MENUITEM_PROP_RIGHT, right);
=== modified file 'src/settings-shared.h'
--- src/settings-shared.h 2011-02-25 14:18:57 +
+++ src/settings-shared.h 2011-03-08 16:09:42 +
@@ -51,5 +51,9 @@
#define DEFAULT_TIME_24_FORMAT N_(%H:%M)
#define DEFAULT_TIME_FORMAT DEFAULT_TIME_12_FORMAT
+#define DEFAULT_TIME_FORMAT_WITH_DAY DEFAULT_TIME_12_FORMAT
+
+#define DEFAULT_TIME_12_FORMAT_WITH_DAY N_(%a %l:%M %p)
+#define DEFAULT_TIME_24_FORMAT_WITH_DAY N_(%a %H:%M)
#endif
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/calendarmenuitemsignals into lp:indicator-datetime
Review: Needs Fixing
On Tue, 2011-03-08 at 15:46 +, Karl Lattimer wrote:
+ t2 = t1 + (time_t) (7 * 24 * 60 * 60); /* 7 days ahead of now, we
actually need number_of_days_in_this_month */
Could you please make this comment a TODO.
+ } else if (!g_strcmp0(prop, CALENDAR_MENUITEM_PROP_SET_DATE)) {
+ // TODO This needs to be an array of 3 ints
+ //ido_calendar_menu_item_set_date (IDO_CALENDAR_MENU_ITEM
(mi_data), );
Confused here... use an array of 3 ints then? :)
+static void
+day_selected_double_click_cb (IdoCalendarMenuItem *ido,
+ guint day,
+ gpointeruser_data)
+{
+ gchar datestring[20];
+ guint d,m,y;
+ DbusmenuMenuitem * item = DBUSMENU_MENUITEM (user_data);
+ ido_calendar_menu_item_get_date(ido, y, m, d);
+ g_sprintf(datestring, %d-%d-%d, y, m, d);
+ GVariant *variant = g_variant_new_string(datestring);
+ guint timestamp = (guint)time(NULL);
+ dbusmenu_menuitem_handle_event(DBUSMENU_MENUITEM(item),
day-selected-double-click, variant, timestamp);
+ g_debug(Got day-selected-double-click signal: %s, datestring);
+}
+*/
Why are you encoding the data into a string instead of just passing an
array of ints? Seems it would be better to let GVariant do the encoding
for us.
+ dbusmenu_gtkclient_newitem_base(DBUSMENU_GTKCLIENT(client), newitem,
GTK_MENU_ITEM(ido), parent);
+ /*g_signal_connect_after(ido, day-selected,
G_CALLBACK(day_selected_cb), (gpointer)newitem);
+ dbusmenu_gtkclient_newitem_base(DBUSMENU_GTKCLIENT(client), newitem,
GTK_MENU_ITEM(ido), parent);
+ g_signal_connect_after(ido, day-selected-double-click,
G_CALLBACK(day_selected_double_click_cb), (gpointer)newitem);*/
_newitem_base() should only need to be called once here.
review needsfixing
--
https://code.launchpad.net/~karl-qdh/indicator-datetime/calendarmenuitemsignals/+merge/52570
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/fixappointmentformat into lp:indicator-datetime
Review: Needs Fixing
On Tue, 2011-03-08 at 16:09 +, Karl Lattimer wrote:
+ gchar *time_format_str = g_settings_get_string(conf,
SETTINGS_TIME_FORMAT_S);
+ gint apt_output;
+ if (g_strcmp0(time_format_str, 12-hour) == 0) {
+ apt_output = SETTINGS_TIME_12_HOUR;
+ } else if (g_strcmp0(time_format_str, 24-hour) == 0) {
+ apt_output = SETTINGS_TIME_24_HOUR;
+ } else {
+ apt_output = SETTINGS_TIME_LOCALE;
+ }
I think that you should be able to use priv-time_mode instead of
apt_output here.
+ if (apt_output == SETTINGS_TIME_12_HOUR) {
+ if ((mday == dmday) (mon == dmon) (year == dyear))
+ strftime(right, 20, DEFAULT_TIME_12_FORMAT,
due);
+ else
+ strftime(right, 20,
DEFAULT_TIME_12_FORMAT_WITH_DAY, due);
+ } else if (apt_output == SETTINGS_TIME_24_HOUR) {
+ if ((mday == dmday) (mon == dmon) (year == dyear))
+ strftime(right, 20, DEFAULT_TIME_24_FORMAT,
due);
+ else
+ strftime(right, 20,
DEFAULT_TIME_24_FORMAT_WITH_DAY, due);
+ } else {
+ if ((mday == dmday) (mon == dmon) (year == dyear))
+ strftime(right, 20, DEFAULT_TIME_FORMAT, due);
+ else
+ strftime(right, 20,
DEFAULT_TIME_FORMAT_WITH_DAY, due);
+ }
+
All of the strings being passed to strftime need a _() around them so
that they go through gettext.
review needsfixing
--
https://code.launchpad.net/~karl-qdh/indicator-datetime/fixappointmentformat/+merge/52574
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help : https://help.launchpad.net/ListHelp
