Re: [Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/nopwdprompt into lp:indicator-datetime

[David Barth]

Review: Approve
The branch fixes the issue, ie the service does not crash anymore if I have a 
remote calendar for which the credentials are not saved in evolution.
It means that the integration will only work in the case where the user 
accepted to keep the credentials in the evolution keyring.

-- 
https://code.launchpad.net/~karl-qdh/indicator-datetime/nopwdprompt/+merge/53846
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.

___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp

[Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/nopwdprompt into lp:indicator-datetime

[Karl Lattimer]

Karl Lattimer has proposed merging lp:~karl-qdh/indicator-datetime/nopwdprompt 
into lp:indicator-datetime.

Requested reviews:
  Ted Gould (ted)

For more details, see:
https://code.launchpad.net/~karl-qdh/indicator-datetime/nopwdprompt/+merge/53846

Removes prompting for password if no stored credential exists.
-- 
https://code.launchpad.net/~karl-qdh/indicator-datetime/nopwdprompt/+merge/53846
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.
=== modified file 'src/datetime-service.c'
--- src/datetime-service.c	2011-03-16 21:47:51 +
+++ src/datetime-service.c	2011-03-17 15:55:46 +
@@ -469,7 +469,6 @@
const gchar *key, 
gpointer user_data)
 {
-	gboolean remember; // TODO: Is this useful?  Should we be storing it somewhere?
 	ESource *source = e_cal_get_source (ecal);
 	gchar *auth_domain = e_source_get_duped_property (source, auth-domain);
 
@@ -479,16 +478,6 @@
 	
 	gchar *password = e_passwords_get_password (component_name, key);
 	
-	if (password == NULL) {
-		password = e_passwords_ask_password (
-			_(Enter password),
-			component_name, key, prompt,
-			E_PASSWORDS_REMEMBER_FOREVER |
-			E_PASSWORDS_SECRET |
-			E_PASSWORDS_ONLINE,
-			remember, NULL);
-	}
-	
 	g_free (auth_domain);
 
 	return password;

___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp