[Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/sniffles into lp:indicator-datetime

2011-03-23 Thread Karl Lattimer 
Karl Lattimer has proposed merging lp:~karl-qdh/indicator-datetime/sniffles 
into lp:indicator-datetime.

Requested reviews:
  David Barth (dbarth)
Related bugs:
  Bug #740806 in indicator-datetime (Ubuntu): Add Appointment should be Add 
Event…
  https://bugs.launchpad.net/ubuntu/+source/indicator-datetime/+bug/740806
  Bug #740819 in indicator-datetime (Ubuntu): Date item isn't sensitive when 
Evolution is installed
  https://bugs.launchpad.net/ubuntu/+source/indicator-datetime/+bug/740819

For more details, see:
https://code.launchpad.net/~karl-qdh/indicator-datetime/sniffles/+merge/54501

Two UX bugs from MPT 'sniffles' 
-- 
https://code.launchpad.net/~karl-qdh/indicator-datetime/sniffles/+merge/54501
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.
=== modified file 'src/datetime-service.c'
--- src/datetime-service.c	2011-03-22 21:38:50 +
+++ src/datetime-service.c	2011-03-23 12:06:08 +
@@ -371,11 +371,15 @@
 		dbusmenu_menuitem_property_set_bool(calendar, DBUSMENU_MENUITEM_PROP_ENABLED, TRUE);
 		dbusmenu_menuitem_property_set_bool(calendar, DBUSMENU_MENUITEM_PROP_VISIBLE, TRUE);
 
+		dbusmenu_menuitem_property_set_bool(date, DBUSMENU_MENUITEM_PROP_ENABLED, TRUE);
+		g_signal_connect (G_OBJECT(date), DBUSMENU_MENUITEM_SIGNAL_ITEM_ACTIVATED,
+		  G_CALLBACK (activate_cb), evolution -c calendar);
+		  
 		events_separator = dbusmenu_menuitem_new();
 		dbusmenu_menuitem_property_set(events_separator, DBUSMENU_MENUITEM_PROP_TYPE, DBUSMENU_CLIENT_TYPES_SEPARATOR);
 		dbusmenu_menuitem_child_add_position(root, events_separator, 2);
 		add_appointment = dbusmenu_menuitem_new();
-		dbusmenu_menuitem_property_set (add_appointment, DBUSMENU_MENUITEM_PROP_LABEL, _(Add Appointment));
+		dbusmenu_menuitem_property_set (add_appointment, DBUSMENU_MENUITEM_PROP_LABEL, _(Add Event...));
 		dbusmenu_menuitem_property_set_bool(add_appointment, DBUSMENU_MENUITEM_PROP_ENABLED, TRUE);
 		g_signal_connect(G_OBJECT(add_appointment), DBUSMENU_MENUITEM_SIGNAL_ITEM_ACTIVATED, G_CALLBACK(activate_cb), evolution -c calendar);
 		dbusmenu_menuitem_child_add_position (root, add_appointment, 3);

___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp

Re: [Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/sniffles into lp:indicator-datetime

2011-03-23 Thread David Barth 
Review: Needs Fixing
You need to check that evolution is installed before you enable the items. It's 
ok not to update that when it's installed after the indicator has started or if 
it gets uninstalled though.

There is an example for that at: 
http://bazaar.launchpad.net/~indicator-applet-developers/indicator-me/trunk/view/head:/src/me-service.c#L251
-- 
https://code.launchpad.net/~karl-qdh/indicator-datetime/sniffles/+merge/54501
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.

___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp

Re: [Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/sniffles into lp:indicator-datetime

2011-03-23 Thread Karl Lattimer 
this is already done a few lines above the diff;

368: datetime-service.c
gchar *evo = g_find_program_in_path(evolution);
if (evo != NULL) {
g_debug(Found the calendar application: %s, evo);
-- 
https://code.launchpad.net/~karl-qdh/indicator-datetime/sniffles/+merge/54501
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.

___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp

[Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/sniffles into lp:indicator-datetime

2011-03-23 Thread noreply 
The proposal to merge lp:~karl-qdh/indicator-datetime/sniffles into 
lp:indicator-datetime has been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~karl-qdh/indicator-datetime/sniffles/+merge/54501
-- 
https://code.launchpad.net/~karl-qdh/indicator-datetime/sniffles/+merge/54501
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.

___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp