Re: [Ayatana-commits] [Merge] lp:~bilalakhtar/dbusmenu/fix-634003 into lp:dbusmenu

[Karl Lattimer]

 I'm going to mark this as Needs Fixing as we need to instead of setting a
 specific color value move this over to a semantic meaning.  So have a lookup
 of alert is #FF type of thing.  That should come from the theme's
 symbolic colors as well.  A bigger change is needed, but this should be the
 basis of it.

I can think of another use case where specific colour is useful, that's where 
we're setting the hint of the indicator-datetime calendar menu items. 

As specified here; https://wiki.ubuntu.com/TimeAndDate#Coming%20events

So yeah, it needs fixing, but there's probably something useful we can do with 
this.
-- 
https://code.launchpad.net/~bilalakhtar/dbusmenu/fix-634003/+merge/34985
Your team ayatana-commits is subscribed to branch lp:dbusmenu.

___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp

Re: [Ayatana-commits] [Merge] lp:~bilalakhtar/dbusmenu/fix-634003 into lp:dbusmenu

[Ted Gould]

Review: Needs Fixing
I'm going to mark this as Needs Fixing as we need to instead of setting a 
specific color value move this over to a semantic meaning.  So have a lookup of 
alert is #FF type of thing.  That should come from the theme's symbolic 
colors as well.  A bigger change is needed, but this should be the basis of it.
-- 
https://code.launchpad.net/~bilalakhtar/dbusmenu/fix-634003/+merge/34985
Your team ayatana-commits is subscribed to branch lp:dbusmenu.

___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp

Re: [Ayatana-commits] [Merge] lp:~bilalakhtar/dbusmenu/fix-634003 into lp:dbusmenu

[Karl Lattimer]

Review: Approve
This part of the patches is fine, a very simple change that should survive the 
gtk3 transition well.
-- 
https://code.launchpad.net/~bilalakhtar/dbusmenu/fix-634003/+merge/34985
Your team ayatana-commits is subscribed to branch lp:dbusmenu.

___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp

[Ayatana-commits] [Merge] lp:~bilalakhtar/dbusmenu/fix-634003 into lp:dbusmenu

[Bilal Akhtar]

Bilal Akhtar has proposed merging lp:~bilalakhtar/dbusmenu/fix-634003 into 
lp:dbusmenu.

Requested reviews:
  DBus Menu Team (dbusmenu-team)
Related bugs:
  #634003 Restart to complete updates entry should be red
  https://bugs.launchpad.net/bugs/634003

-- 
https://code.launchpad.net/~bilalakhtar/dbusmenu/fix-634003/+merge/34985
Your team ayatana-commits is subscribed to branch lp:dbusmenu.
=== modified file 'libdbusmenu-glib/menuitem.h'
--- libdbusmenu-glib/menuitem.h	2010-08-20 19:49:33 +
+++ libdbusmenu-glib/menuitem.h	2010-09-09 14:53:42 +
@@ -61,6 +61,7 @@
 #define DBUSMENU_MENUITEM_PROP_TOGGLE_STATE  toggle-state
 #define DBUSMENU_MENUITEM_PROP_SHORTCUT  shortcut
 #define DBUSMENU_MENUITEM_PROP_CHILD_DISPLAY children-display
+#define DBUSMENU_MENUITEM_PROP_FG_COLOUR	 fgcolour
 
 #define DBUSMENU_MENUITEM_TOGGLE_CHECK   checkmark
 #define DBUSMENU_MENUITEM_TOGGLE_RADIO   radio

=== modified file 'libdbusmenu-gtk/client.c'
--- libdbusmenu-gtk/client.c	2010-08-30 20:22:43 +
+++ libdbusmenu-gtk/client.c	2010-09-09 14:53:42 +
@@ -393,6 +393,9 @@
 		process_toggle_type(mi, gmi, value);
 	} else if (!g_strcmp0(prop, DBUSMENU_MENUITEM_PROP_TOGGLE_STATE)) {
 		process_toggle_state(mi, gmi, value);
+	} else if (!g_strcmp0(prop, DBUSMENU_MENUITEM_PROP_FG_COLOUR)) {
+		gtk_widget_modify_fg(GTK_WIDGET(gmi), GTK_STATE_NORMAL, g_value_get_int(value));
+		gtk_widget_modify_fg(GTK_WIDGET(gmi), GTK_STATE_PRELIGHT, g_value_get_int(value));
 	}
 
 	return;

___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp