Re: [PATCH] ARM: MXS: duckbill: set duart to serial0

[Lucas Stach]

Am Freitag, den 29.05.2020, 14:51 +0200 schrieb Michael Grzeschik:
> In the imx28.dtsi the serial0 is set to auart0 which is not the one
> used on the duckbill. We set duart to serial0 so the console will be
> properly set.

If the aliases are the same in the Barebox and Linux DTs there should
be no need to override the alias numbering in the individual board DTs.

Is the Linux driver ignoring the alias, or what is the issue being
fixed here?

Regards,
Lucas

> Signed-off-by: Michael Grzeschik 
> ---
>  arch/arm/dts/imx28-duckbill.dts | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/dts/imx28-duckbill.dts b/arch/arm/dts/imx28-
> duckbill.dts
> index 2a995a7938..299c33e270 100644
> --- a/arch/arm/dts/imx28-duckbill.dts
> +++ b/arch/arm/dts/imx28-duckbill.dts
> @@ -4,6 +4,10 @@
>   chosen {
>   stdout-path = &duart;
>   };
> +
> + aliases {
> + serial0 = &duart;
> + };
>  };
>  
>  &duart {


___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] serial: stm: set linux_console_name

[Ahmad Fatoum]

Hello Michael,

On 5/29/20 2:51 PM, Michael Grzeschik wrote:
> We set the linux_console_name so for this uart the
> linux.bootargs.console will be properly set.
> 
> Signed-off-by: Michael Grzeschik 
> ---
>  drivers/serial/stm-serial.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/serial/stm-serial.c b/drivers/serial/stm-serial.c
> index ea482415ce..a2c3dcf56e 100644
> --- a/drivers/serial/stm-serial.c
> +++ b/drivers/serial/stm-serial.c
> @@ -159,6 +159,7 @@ static int stm_serial_probe(struct device_d *dev)
>   cdev->flush = stm_serial_flush;
>   cdev->setbrg = stm_serial_setbaudrate;
>   cdev->dev = dev;
> + cdev->linux_console_name = "ttyAMA";

Couldn't we just combine the two drivers? On a cursory look, only
difference is how they're probed?

>  
>   dev->priv = priv;
>   iores = dev_request_mem_resource(dev, 0);
> 

-- 
Pengutronix e.K.   | |
Steuerwalder Str. 21   | http://www.pengutronix.de/  |
31137 Hildesheim, Germany  | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH] serial: amba-pl011: set linux_console_name

[Michael Grzeschik]

We set the linux_console_name so for this uart the
linux.bootargs.console will be properly set.

Signed-off-by: Michael Grzeschik 
---
 drivers/serial/amba-pl011.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/serial/amba-pl011.c b/drivers/serial/amba-pl011.c
index 0751c52513..865ecdddb2 100644
--- a/drivers/serial/amba-pl011.c
+++ b/drivers/serial/amba-pl011.c
@@ -204,6 +204,7 @@ static int pl011_probe(struct amba_device *dev, const 
struct amba_id *id)
cdev->putc = pl011_putc;
cdev->getc = pl011_getc;
cdev->setbrg = pl011_setbaudrate;
+   cdev->linux_console_name = "ttyAMA";
 
pl011_init_port(cdev);
 
-- 
2.26.2


___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH] ARM: MXS: duckbill: set duart to serial0

[Michael Grzeschik]

In the imx28.dtsi the serial0 is set to auart0 which is not the one
used on the duckbill. We set duart to serial0 so the console will be
properly set.

Signed-off-by: Michael Grzeschik 
---
 arch/arm/dts/imx28-duckbill.dts | 4 
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/dts/imx28-duckbill.dts b/arch/arm/dts/imx28-duckbill.dts
index 2a995a7938..299c33e270 100644
--- a/arch/arm/dts/imx28-duckbill.dts
+++ b/arch/arm/dts/imx28-duckbill.dts
@@ -4,6 +4,10 @@
chosen {
stdout-path = &duart;
};
+
+   aliases {
+   serial0 = &duart;
+   };
 };
 
 &duart {
-- 
2.26.2


___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH] serial: stm: set linux_console_name

[Michael Grzeschik]

We set the linux_console_name so for this uart the
linux.bootargs.console will be properly set.

Signed-off-by: Michael Grzeschik 
---
 drivers/serial/stm-serial.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/serial/stm-serial.c b/drivers/serial/stm-serial.c
index ea482415ce..a2c3dcf56e 100644
--- a/drivers/serial/stm-serial.c
+++ b/drivers/serial/stm-serial.c
@@ -159,6 +159,7 @@ static int stm_serial_probe(struct device_d *dev)
cdev->flush = stm_serial_flush;
cdev->setbrg = stm_serial_setbaudrate;
cdev->dev = dev;
+   cdev->linux_console_name = "ttyAMA";
 
dev->priv = priv;
iores = dev_request_mem_resource(dev, 0);
-- 
2.26.2


___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox