Re: [PATCH 1/2] ARM: i.MX8MP: skov: fix variant detection on boards without state

2024-05-15 Thread Sascha Hauer 


On Wed, 15 May 2024 13:20:32 +0200, Ahmad Fatoum wrote:
> If barebox booted a board without state partition on the eMMC it did not set a
> refined compatible at all resulting in a failure to boot into Linux userspace.
> 
> Instead just default to the LVDS flavor of the board variant which at least
> leads to a working Linux userspace.
> 
> 
> [...]

Applied, thanks!

[1/2] ARM: i.MX8MP: skov: fix variant detection on boards without state
  https://git.pengutronix.de/cgit/barebox/commit/?id=61808f7f9e31 (link may 
not be stable)
[2/2] ARM: i.MX8MP: skov: update timing parameters for Samsung RAM
  https://git.pengutronix.de/cgit/barebox/commit/?id=592fed919ca8 (link may 
not be stable)

Best regards,
-- 
Sascha Hauer

[PATCH 1/2] ARM: i.MX8MP: skov: fix variant detection on boards without state

2024-05-15 Thread Ahmad Fatoum 
From: Soren Andersen 

If barebox booted a board without state partition on the eMMC it did not set a
refined compatible at all resulting in a failure to boot into Linux userspace.

Instead just default to the LVDS flavor of the board variant which at least
leads to a working Linux userspace.

Signed-off-by: Soren Andersen 
Signed-off-by: Ulrich Ölmann 
Reviewed-by: Oleksij Rempel 
Signed-off-by: Ahmad Fatoum 
---
 arch/arm/boards/skov-imx8mp/board.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/arm/boards/skov-imx8mp/board.c 
b/arch/arm/boards/skov-imx8mp/board.c
index 3cb7a8752a27..ce8d154a7355 100644
--- a/arch/arm/boards/skov-imx8mp/board.c
+++ b/arch/arm/boards/skov-imx8mp/board.c
@@ -186,10 +186,7 @@ static int skov_imx8mp_init_variant(struct 
skov_imx8mp_priv *priv)
 
if (variant->flags & SKOV_IMX8MP_HAS_HDMI) {
ret = skov_imx8mp_get_hdmi(dev);
-   if (ret < 0)
-   return ret;
-
-   if (ret)
+   if (ret == 1)
compatible = variant->dts_compatible_hdmi;
else
compatible = variant->dts_compatible;
-- 
2.39.2