Re: [PATCH 61/78] ARM: aarch64: mmu: Make zero page faulting

[Sascha Hauer]

Hi Andrey,

On Tue, Mar 20, 2018 at 09:53:56PM -0700, Andrey Smirnov wrote:
> On Fri, Mar 16, 2018 at 5:53 AM, Sascha Hauer  wrote:
> > Make zero page faulting which allows us to catch NULL pointer derefs.
> >
> > Signed-off-by: Sascha Hauer 
> > ---
> >  arch/arm/cpu/mmu_64.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/cpu/mmu_64.c b/arch/arm/cpu/mmu_64.c
> > index 20f6c387f3..094bc0ac62 100644
> > --- a/arch/arm/cpu/mmu_64.c
> > +++ b/arch/arm/cpu/mmu_64.c
> > @@ -316,6 +316,8 @@ static int mmu_init(void)
> > for_each_memory_bank(bank)
> > create_sections(bank->start, bank->start, bank->size, 
> > CACHED_MEM);
> >
> > +   create_sections(0x0, 0x0, 0x1000, 0x0);
> 
> Sascha:
> 
> Maybe add commit message as comment to the line above as well?

Sorry, somehow I ended up ignoring this mail. I added a separate patch
adding a comment.

Sascha


-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 61/78] ARM: aarch64: mmu: Make zero page faulting

[Andrey Smirnov]

On Fri, Mar 16, 2018 at 5:53 AM, Sascha Hauer  wrote:
> Make zero page faulting which allows us to catch NULL pointer derefs.
>
> Signed-off-by: Sascha Hauer 
> ---
>  arch/arm/cpu/mmu_64.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/cpu/mmu_64.c b/arch/arm/cpu/mmu_64.c
> index 20f6c387f3..094bc0ac62 100644
> --- a/arch/arm/cpu/mmu_64.c
> +++ b/arch/arm/cpu/mmu_64.c
> @@ -316,6 +316,8 @@ static int mmu_init(void)
> for_each_memory_bank(bank)
> create_sections(bank->start, bank->start, bank->size, 
> CACHED_MEM);
>
> +   create_sections(0x0, 0x0, 0x1000, 0x0);

Sascha:

Maybe add commit message as comment to the line above as well?


Thanks,
Andrey Smirnov

> +
> mmu_enable();
>
> return 0;
> --
> 2.16.1
>
>
> ___
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 61/78] ARM: aarch64: mmu: Make zero page faulting

[Sascha Hauer]

Make zero page faulting which allows us to catch NULL pointer derefs.

Signed-off-by: Sascha Hauer 
---
 arch/arm/cpu/mmu_64.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/cpu/mmu_64.c b/arch/arm/cpu/mmu_64.c
index 20f6c387f3..094bc0ac62 100644
--- a/arch/arm/cpu/mmu_64.c
+++ b/arch/arm/cpu/mmu_64.c
@@ -316,6 +316,8 @@ static int mmu_init(void)
for_each_memory_bank(bank)
create_sections(bank->start, bank->start, bank->size, 
CACHED_MEM);
 
+   create_sections(0x0, 0x0, 0x1000, 0x0);
+
mmu_enable();
 
return 0;
-- 
2.16.1


___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox