Re: [PATCH master] ARM: i.MX9: tqma93xx: handle unknown form factors

2024-05-06 Thread Sascha Hauer
On Fri, May 03, 2024 at 12:09:23PM +0200, Ahmad Fatoum wrote:
> GCC warns that fdt may be uninitialized. Fix that by treating unknown
> variants as the CA variant. CA was chosen for no particular reason.
> 
> Signed-off-by: Ahmad Fatoum 
> ---
>  arch/arm/boards/tqma93xx/lowlevel.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boards/tqma93xx/lowlevel.c 
> b/arch/arm/boards/tqma93xx/lowlevel.c
> index 8d89ee530ff8..66991fc6b03b 100644
> --- a/arch/arm/boards/tqma93xx/lowlevel.c
> +++ b/arch/arm/boards/tqma93xx/lowlevel.c
> @@ -89,6 +89,9 @@ static noinline void tqma93xx_continue(void)
>   case VARD_FORMFACTOR_TYPE_LGA:
>   fdt = __dtb_z_imx93_tqma9352_mba93xxla_start;
>   break;
> + default:
> + pr_warn("Unknown formfactor: 0%x. Assuming connector\n", 
> formfactor);
> + fallthrough;

tqma93xx_get_formfactor() always returns one of the values handled in
this switch/case, so this will never trigger. If gcc mourns about it
then adding the default: is enough, no need to add a message.

Sascha

-- 
Pengutronix e.K.   | |
Steuerwalder Str. 21   | http://www.pengutronix.de/  |
31137 Hildesheim, Germany  | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |



[PATCH master] ARM: i.MX9: tqma93xx: handle unknown form factors

2024-05-03 Thread Ahmad Fatoum
GCC warns that fdt may be uninitialized. Fix that by treating unknown
variants as the CA variant. CA was chosen for no particular reason.

Signed-off-by: Ahmad Fatoum 
---
 arch/arm/boards/tqma93xx/lowlevel.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boards/tqma93xx/lowlevel.c 
b/arch/arm/boards/tqma93xx/lowlevel.c
index 8d89ee530ff8..66991fc6b03b 100644
--- a/arch/arm/boards/tqma93xx/lowlevel.c
+++ b/arch/arm/boards/tqma93xx/lowlevel.c
@@ -89,6 +89,9 @@ static noinline void tqma93xx_continue(void)
case VARD_FORMFACTOR_TYPE_LGA:
fdt = __dtb_z_imx93_tqma9352_mba93xxla_start;
break;
+   default:
+   pr_warn("Unknown formfactor: 0%x. Assuming connector\n", 
formfactor);
+   fallthrough;
case VARD_FORMFACTOR_TYPE_CONNECTOR:
fdt = __dtb_z_imx93_tqma9352_mba93xxca_start;
break;
-- 
2.39.2