Re: [PATCH 2/2] EFI: handle more boot devices

2014-09-01 Thread Michael Olbrich
On Mon, Sep 01, 2014 at 11:06:19AM +0200, Sascha Hauer wrote:
 On Tue, Aug 12, 2014 at 11:37:21AM +0200, Michael Olbrich wrote:
  efi_get_boot() fails for partitions that are not supported, so errors must
  be ignored to find all supported devices.
  
  Signed-off-by: Michael Olbrich m.olbr...@pengutronix.de
  ---
  
  I'm not sure about this one. We're not doing anythings with the return
  value of efi_get_boot(), so this is just some debug output + memory leak.
 
 So maybe we should rather comment out the code until we do something
 meaningful with it?

I don't care either way. What's this stuff for anyways?

Michael

-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


Re: [PATCH 2/2] EFI: handle more boot devices

2014-09-01 Thread Sascha Hauer
On Mon, Sep 01, 2014 at 12:02:00PM +0200, Michael Olbrich wrote:
 On Mon, Sep 01, 2014 at 11:06:19AM +0200, Sascha Hauer wrote:
  On Tue, Aug 12, 2014 at 11:37:21AM +0200, Michael Olbrich wrote:
   efi_get_boot() fails for partitions that are not supported, so errors must
   be ignored to find all supported devices.
   
   Signed-off-by: Michael Olbrich m.olbr...@pengutronix.de
   ---
   
   I'm not sure about this one. We're not doing anythings with the return
   value of efi_get_boot(), so this is just some debug output + memory leak.
  
  So maybe we should rather comment out the code until we do something
  meaningful with it?
 
 I don't care either way. What's this stuff for anyways?

These variables contain the boot order. I added this stuff to verify
that I can read EFI variables.

Sascha

-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox