Re: bbdb-record-set-field, strings, and 'eq
Roland Winkler wink...@gnu.org writes: On Tue Mar 10 2015 Eric Abrahamsen wrote: When `bbdb-record-set-field' is setting a phone or address field, it adds the new label to the list of existing labels like this: (add-to-list 'bbdb-phone-label-list (bbdb-phone-label phone) nil 'eq) The labels are strings, and 'eq comparison means they're never equal Thank you, that's a bug, though fortunately one that does not affect daily usage of BBDB too much. I guess I thought these labels were symbols when I wrote this code. The same problem exists with bbdb-address-label-list. Yeah, I figured they were probably symbols at some point. And no, it certainly never became an issue -- I wouldn't have even noticed if I hadn't tried to upgrade helm-bbdb. I have several (more or less minor) patches for BBDB waiting, where lately I was too busy with other things to install them. I hope that soon I'll find the time to do that. Let us know if you want any help. I ought to have push access to the savannah repo, if it's just a matter of formatting some patches and throwing them up there. Eric -- Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: bbdb-record-set-field, strings, and 'eq
On Tue Mar 10 2015 Eric Abrahamsen wrote: When `bbdb-record-set-field' is setting a phone or address field, it adds the new label to the list of existing labels like this: (add-to-list 'bbdb-phone-label-list (bbdb-phone-label phone) nil 'eq) The labels are strings, and 'eq comparison means they're never equal Thank you, that's a bug, though fortunately one that does not affect daily usage of BBDB too much. I guess I thought these labels were symbols when I wrote this code. The same problem exists with bbdb-address-label-list. I have several (more or less minor) patches for BBDB waiting, where lately I was too busy with other things to install them. I hope that soon I'll find the time to do that. Roland -- Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
bbdb-record-set-field, strings, and 'eq
When `bbdb-record-set-field' is setting a phone or address field, it adds the new label to the list of existing labels like this: (add-to-list 'bbdb-phone-label-list (bbdb-phone-label phone) nil 'eq) The labels are strings, and 'eq comparison means they're never equal, so duplicate strings are added each time: (length bbdb-phone-label-list) - 197 (length (delete-dups bbdb-phone-label-list)) - 7 I'm assuming it should just be using 'equal instead -- is there any reason for the duplication? Eric -- Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
