DO NOT REPLY [Bug 41660] - Fields in Annotations and AnnotationEntry are private, should be protected
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=41660. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=41660 --- Additional Comments From [EMAIL PROTECTED] 2007-06-13 12:21 --- Can someone please review this patch? It's a very simple fix. If you like, I can submit another one that uses accessor methods instead of protected fields. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 41660] - Fields in Annotations and AnnotationEntry are private, should be protected
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=41660. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=41660 --- Additional Comments From [EMAIL PROTECTED] 2007-03-10 07:23 --- Could you elaborate why you have to extend them? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 41660] - Fields in Annotations and AnnotationEntry are private, should be protected
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=41660. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=41660 --- Additional Comments From [EMAIL PROTECTED] 2007-03-10 11:56 --- I need to extend them in order to tell BCEL how to process non-standard annotations. Currently BCEL is hard-coded for the existing annotation names: RuntimeInvisibleAnnotations, RuntimeInvisibleAnnotations, RuntimeInvisibleParameterAnnotations, and RuntimeVisibleParameterAnnotations. However, with the JSR-308 proposal, new annotation names are likely on the way: RuntimeInvisibleTypeAnnotations/RuntimeVisibleTypeAnnotations and (possibly) RuntimeInvisibleStatementAnnotations/RuntimeVisibleStatementAnnotations. Now, I'd like to use BCEL to parse and display these new annotation types. In fact, I've already written such a utility here: http://volta.svn.sourceforge.net/viewvc/volta/util/dump-annotations/ However, the utility can't work with the current BCEL trunk because the Annotations and AnnotationEntry classes have private inaccessible fields. This makes extending those classes in any meaningful way impossible. But if I simply modify BCEL so that those fields are exposed to subclasses, then my utility works perfectly. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 41660] - Fields in Annotations and AnnotationEntry are private, should be protected
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=41660. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=41660 --- Additional Comments From [EMAIL PROTECTED] 2007-02-20 00:50 --- Created an attachment (id=19614) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=19614action=view) Simple patch that makes the private fields protected -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 41660] - Fields in Annotations and AnnotationEntry are private, should be protected
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=41660. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=41660 --- Additional Comments From [EMAIL PROTECTED] 2007-02-20 14:55 --- Just as a general note, protected fields should be used with caution as they have significant implications for binary compatibility; once added they become part of the public api of the class and cannot be changed without potentially breaking existing code. Where possible, protected accessor methods are better than allowing direct access to protected fields. Note, however, that I haven't reviewed this patch to determine what the best solution is for this particular case. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 41660] - Fields in Annotations and AnnotationEntry are private, should be protected
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=41660. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=41660 --- Additional Comments From [EMAIL PROTECTED] 2007-02-20 15:25 --- I think accessor methods might also work in my case, but I would prefer protected members (possibly in addition to accessors) because it offers the most flexibility and control. And yes, field access rights raise compatibility issues, which is why I hope this bug can be resolved before the annotation support in BCEL migrates from the trunk to an official release. In any case, something must be changed, otherwise it will be impossible for users to extend BCEL's annotation support. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
