Re: [PATCH V2] ieee80211: Output frequency rather than channel in scan results
On Sat, 2007-04-21 at 15:42 +0200, Joerg Mayer wrote: On Fri, Apr 20, 2007 at 11:25:40PM -0500, Larry Finger wrote: + if (network-channel 15) + iwe.u.freq.m = 2407 + 5 * network-channel; + else + iwe.u.freq.m = 5000 + 5 * network-channel; + if (network-channel == 14) + iwe.u.freq.m = 2484;/* special case for Japan */ As you are taking japanese channels into account: How about handling the = 4.9 GHz case for Japan as well? See 802.11j-2004.pdf 17.3.8.3.2, 17.3.8.3.3 and table J.3 for details. How about just adding some sort of table in other common code and using that. Then you can submit a patch for that table :P johannes signature.asc Description: This is a digitally signed message part ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH V2] ieee80211: Output frequency rather than channel in scan results
Johannes Berg wrote: On Sat, 2007-04-21 at 15:42 +0200, Joerg Mayer wrote: On Fri, Apr 20, 2007 at 11:25:40PM -0500, Larry Finger wrote: + if (network-channel 15) + iwe.u.freq.m = 2407 + 5 * network-channel; + else + iwe.u.freq.m = 5000 + 5 * network-channel; + if (network-channel == 14) + iwe.u.freq.m = 2484;/* special case for Japan */ As you are taking japanese channels into account: How about handling the = 4.9 GHz case for Japan as well? See 802.11j-2004.pdf 17.3.8.3.2, 17.3.8.3.3 and table J.3 for details. How about just adding some sort of table in other common code and using that. Then you can submit a patch for that table :P I did a variation of your suggestion by adding the ieee80211_channel_to_freq routine that ieee80211 was lacking. This way if anyone adds the 4.9 GHz channels in Japan to the ieee80211_geo struct, my routine will be just fine. Larry ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH] ieee80211: Output frequency rather than channel in scan results
Dan Williams wrote: On Sat, 2007-04-21 at 00:12 -0400, Pavel Roskin wrote: Quoting Larry Finger [EMAIL PROTECTED]: In ieee80211, the output of scan results lists channels rather than frequencies; however, NetworkManager needs frequency. This patch changes the output from channel to frequency. The driver can report both, and I think it should. This would make the iwlist output a bit longer, but kernel drivers shouldn't be written to make userspace program generate pretty output. I'm trying to remember why NM cares about frequency, and I think it's for ad-hoc mode; but wpa_supplicant didn't historically support a channel configuration parameter and so you can't create adhoc networks with NM right now anyway... What's the failure mode? In the KDE NM applet, the frequency is listed as 0. Larry ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
