Re: [PATCH] b43: Remove PIO support

2008-01-10 Thread Johannes Berg
John,

On Wed, 2007-12-26 at 14:41 +0100, Michael Buesch wrote:
 Remove b43 PIO support.
 DMA works well on all supported devices. There's no reason to use PIO.
 Additionally, new devices don't support PIO in hardware anymore.
 b43 PIO support is dead and unused code.

You merged this patch, but

 After applying this patch please do
 git rm drivers/net/wireless/b43/pio.h
 git rm drivers/net/wireless/b43/pio.c
 to remove the main PIO support code.

forgot this.

johannes


signature.asc
Description: This is a digitally signed message part
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev


Re: [PATCH] b43: Remove PIO support

2008-01-10 Thread John W. Linville
On Wed, Jan 09, 2008 at 06:58:12PM +0100, Johannes Berg wrote:
 John,
 
 On Wed, 2007-12-26 at 14:41 +0100, Michael Buesch wrote:
  Remove b43 PIO support.
  DMA works well on all supported devices. There's no reason to use PIO.
  Additionally, new devices don't support PIO in hardware anymore.
  b43 PIO support is dead and unused code.
 
 You merged this patch, but
 
  After applying this patch please do
  git rm drivers/net/wireless/b43/pio.h
  git rm drivers/net/wireless/b43/pio.c
  to remove the main PIO support code.
 
 forgot this.

You're right -- thanks for the reminder!

-- 
John W. Linville
[EMAIL PROTECTED]
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev


[PATCH] b43: Remove PIO support

2007-12-26 Thread Michael Buesch
Remove b43 PIO support.
DMA works well on all supported devices. There's no reason to use PIO.
Additionally, new devices don't support PIO in hardware anymore.
b43 PIO support is dead and unused code.

After applying this patch please do
git rm drivers/net/wireless/b43/pio.h
git rm drivers/net/wireless/b43/pio.c
to remove the main PIO support code.

Signed-off-by: Michael Buesch [EMAIL PROTECTED]

Index: wireless-2.6/drivers/net/wireless/b43/Kconfig
===
--- wireless-2.6.orig/drivers/net/wireless/b43/Kconfig  2007-12-26 
14:31:03.0 +0100
+++ wireless-2.6/drivers/net/wireless/b43/Kconfig   2007-12-26 
14:32:49.0 +0100
@@ -83,51 +83,3 @@ config B43_DEBUG
 
  Say Y, if you want to find out why the driver does not
  work for you.
-
-config B43_DMA
-   bool
-   depends on B43
-config B43_PIO
-   bool
-   depends on B43
-
-choice
-   prompt Broadcom 43xx data transfer mode
-   depends on B43
-   default B43_DMA_AND_PIO_MODE
-
-config B43_DMA_AND_PIO_MODE
-   bool DMA + PIO
-   select B43_DMA
-   select B43_PIO
-   ---help---
- Include both, Direct Memory Access (DMA) and Programmed I/O (PIO)
- data transfer modes.
- The actually used mode is selectable through the module
- parameter pio. If the module parameter is pio=0, DMA is used.
- Otherwise PIO is used. DMA is default.
-
- If unsure, choose this option.
-
-config B43_DMA_MODE
-   bool DMA (Direct Memory Access) only
-   select B43_DMA
-   ---help---
- Only include Direct Memory Access (DMA).
- This reduces the size of the driver module, by omitting the PIO code.
-
-config B43_PIO_MODE
-   bool PIO (Programmed I/O) only
-   select B43_PIO
-   ---help---
- Only include Programmed I/O (PIO).
- This reduces the size of the driver module, by omitting the DMA code.
- Please note that PIO transfers are slow (compared to DMA).
-
- Also note that not all devices of the 43xx series support PIO.
- The 4306 (Apple Airport Extreme and others) supports PIO, while
- the 4318 is known to _not_ support PIO.
-
- Only use PIO, if DMA does not work for you.
-
-endchoice
Index: wireless-2.6/drivers/net/wireless/b43/Makefile
===
--- wireless-2.6.orig/drivers/net/wireless/b43/Makefile 2007-12-26 
14:31:03.0 +0100
+++ wireless-2.6/drivers/net/wireless/b43/Makefile  2007-12-26 
14:33:36.0 +0100
@@ -1,4 +1,3 @@
-# b43 core
 b43-y  += main.o
 b43-y  += tables.o
 b43-y  += phy.o
@@ -6,16 +5,10 @@ b43-y += sysfs.o
 b43-y  += xmit.o
 b43-y  += lo.o
 b43-y  += wa.o
-# b43 RFKILL button support
+b43-y  += dma.o
 b43-$(CONFIG_B43_RFKILL)   += rfkill.o
-# b43 LED support
 b43-$(CONFIG_B43_LEDS) += leds.o
-# b43 PCMCIA support
 b43-$(CONFIG_B43_PCMCIA)   += pcmcia.o
-# b43 debugging
 b43-$(CONFIG_B43_DEBUG)+= debugfs.o
-# b43 DMA and PIO
-b43-$(CONFIG_B43_DMA)  += dma.o
-b43-$(CONFIG_B43_PIO)  += pio.o
 
 obj-$(CONFIG_B43)  += b43.o
Index: wireless-2.6/drivers/net/wireless/b43/b43.h
===
--- wireless-2.6.orig/drivers/net/wireless/b43/b43.h2007-12-26 
14:31:03.0 +0100
+++ wireless-2.6/drivers/net/wireless/b43/b43.h 2007-12-26 14:32:49.0 
+0100
@@ -68,11 +68,6 @@
 #define B43_MMIO_DMA64_BASE3   0x2C0
 #define B43_MMIO_DMA64_BASE4   0x300
 #define B43_MMIO_DMA64_BASE5   0x340
-/* PIO */
-#define B43_MMIO_PIO1_BASE 0x300
-#define B43_MMIO_PIO2_BASE 0x310
-#define B43_MMIO_PIO3_BASE 0x320
-#define B43_MMIO_PIO4_BASE 0x330
 
 #define B43_MMIO_PHY_VER   0x3E0
 #define B43_MMIO_PHY_RADIO 0x3E2
@@ -577,14 +572,6 @@ struct b43_dma {
struct b43_dmaring *rx_ring3;   /* only available on core.rev  5 */
 };
 
-/* Data structures for PIO transmission, per 80211 core. */
-struct b43_pio {
-   struct b43_pioqueue *queue0;
-   struct b43_pioqueue *queue1;
-   struct b43_pioqueue *queue2;
-   struct b43_pioqueue *queue3;
-};
-
 /* Context information for a noise calculation (Link Quality). */
 struct b43_noise_calculation {
u8 channel_at_start;
@@ -700,7 +687,6 @@ struct b43_wldev {
/* Saved init status for handling suspend. */
int suspend_init_status;
 
-   bool __using_pio;   /* Internal, use b43_using_pio(). */
bool bad_frames_preempt;/* Use Bad Frames Preemption (default 
off) */
bool reg124_set_0x4;/* Some variable to keep track of IRQ