Re: Bcm43xx oops after suspend to disk

2007-02-04 Thread Larry Finger 
roucaries bastien wrote:
 
 Sorry for the delay it works. This time I can use iwlist eth scan.
 I have some difficulties to associate and I need to rmmod/modprobe in
 order to associate but it is another problem linked to a really weak
 power.

Bastien,

Please try this patch instead.

Thanks,

Larry



Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
===
--- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -3638,6 +3638,7 @@ error:
 static int bcm43xx_init_board(struct bcm43xx_private *bcm)
 {
int err;
+   struct bcm43xx_phyinfo *phy = bcm43xx_current_phy(bcm);

mutex_lock((bcm)-mutex);

@@ -3658,6 +3659,8 @@ static int bcm43xx_init_board(struct bcm
if (err)
goto err_sysfs_unreg;
bcm43xx_periodic_tasks_setup(bcm);
+   /* force initial LO calibration */
+   phy-lo_control-txctl2 = 0x;

/*FIXME: This should be handled by softmac instead. */
schedule_delayed_work(bcm-softmac-associnfo.work, 0);
@@ -3763,7 +3766,6 @@ static int bcm43xx_read_phyinfo(struct b
phy-lo_control = kzalloc(sizeof(*(phy-lo_control)), 
GFP_KERNEL);
if (!phy-lo_control)
return -ENOMEM;
-   phy-lo_control-txctl2 = 0x;//FIXME this is the wrong place
}

return 0;


___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Re: Bcm43xx oops after suspend to disk

2007-02-04 Thread Rafael J. Wysocki 
On Sunday, 4 February 2007 18:42, Larry Finger wrote:
 roucaries bastien wrote:
  
  Sorry for the delay it works. This time I can use iwlist eth scan.
  I have some difficulties to associate and I need to rmmod/modprobe in
  order to associate but it is another problem linked to a really weak
  power.
 
 Bastien,
 
 Please try this patch instead.

Hm, it doesn't seem to apply to the mainline version of the driver.  Any chance
for a fix against 2.6.20?

Rafael
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Re: Bcm43xx oops after suspend to disk

2007-02-04 Thread Larry Finger 
Rafael J. Wysocki wrote:
 On Sunday, 4 February 2007 18:42, Larry Finger wrote:
 roucaries bastien wrote:
 Sorry for the delay it works. This time I can use iwlist eth scan.
 I have some difficulties to associate and I need to rmmod/modprobe in
 order to associate but it is another problem linked to a really weak
 power.
 Bastien,

 Please try this patch instead.
 
 Hm, it doesn't seem to apply to the mainline version of the driver.  Any 
 chance
 for a fix against 2.6.20?

Please try this one. I forgot about some other stuff in my working copy of 
wireless-2.6.

Larry



Index: linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
===
--- linux-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -3617,6 +3617,7 @@ error:
 static int bcm43xx_init_board(struct bcm43xx_private *bcm)
 {
int err;
+   struct bcm43xx_phyinfo *phy = bcm43xx_current_phy(bcm);

mutex_lock((bcm)-mutex);

@@ -3637,6 +3638,8 @@ static int bcm43xx_init_board(struct bcm
if (err)
goto err_sysfs_unreg;
bcm43xx_periodic_tasks_setup(bcm);
+   /* force initial LO calibration */
+   phy-lo_control-txctl2 = 0x;

/*FIXME: This should be handled by softmac instead. */
schedule_delayed_work(bcm-softmac-associnfo.work, 0);
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Re: Bcm43xx oops after suspend to disk

2007-01-29 Thread Matthew Garrett 
On Mon, Jan 29, 2007 at 01:55:41PM +0100, roucaries bastien wrote:
 -   return 0;
 +   return bcm43xx_init_one(pdev, NULL);
 }

While this may well work (it's basically equivalent to unloading and 
reloading the module), it's not a long-term fix - userspace is going to 
notice the interface vanishing and reappearing. Larry, I guess you just 
mean this as a test patch?

-- 
Matthew Garrett | [EMAIL PROTECTED]
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Re: Bcm43xx oops after suspend to disk

2007-01-29 Thread Larry Finger 
Matthew Garrett wrote:
 On Mon, Jan 29, 2007 at 01:55:41PM +0100, roucaries bastien wrote:
 -   return 0;
 +   return bcm43xx_init_one(pdev, NULL);
 }
 
 While this may well work (it's basically equivalent to unloading and 
 reloading the module), it's not a long-term fix - userspace is going to 
 notice the interface vanishing and reappearing. Larry, I guess you just 
 mean this as a test patch?
 

Yes. If this doesn't work, then we have real problems. If it does, then I try 
to find the part that
is missing in the current code.

Larry

___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Re: Bcm43xx oops after suspend to disk

2007-01-26 Thread Larry Finger 
roucaries bastien wrote:
 On 1/26/07, Larry Finger [EMAIL PROTECTED] wrote:
 roucaries bastien wrote:
  Do you have the log stuff that precedes this part? In particular, was
  there a assertion that failed?
 
  It is oops on resume and no asseertion failled this boot. However I
  have usually a lot of
  bcm43xx: ASSERTION FAILED (radio_attenuation  10) at:
  drivers/net/wireless/bcm43xx/bcm43xx_phy.c:1496:bcm43xx_find_lopair()

 Those are well known and do not affect this problem.

  Moreover after the first oops I have a second oops (Surelly a
  consequence of the first).

 I think that is right.

 Unfortunately, I cannot test for this problem on my system as it
 doesn't suspend at all.

 Does this oops happen every time, or is it intermittent? I'm looking
 at the code to find places to
 insert debugging statements. At present, I don't understand how it
 gets to the shutdown code while
 resuming!
 Perhaps because syslog log it after resume...
 I will investigate this evening

Thanks. One other thing to try is booting with the 'maxcpus=1' kernel option.

Larry
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Re: Bcm43xx oops after suspend to disk

2007-01-26 Thread Larry Finger 
roucaries bastien wrote:
 On 1/26/07, Larry Finger [EMAIL PROTECTED] wrote:
 roucaries bastien wrote:
  On 1/26/07, Larry Finger [EMAIL PROTECTED] wrote:
  roucaries bastien wrote:
   Do you have the log stuff that precedes this part? In
 particular, was
   there a assertion that failed?
  
   It is oops on resume and no asseertion failled this boot. However I
   have usually a lot of
   bcm43xx: ASSERTION FAILED (radio_attenuation  10) at:
  
 drivers/net/wireless/bcm43xx/bcm43xx_phy.c:1496:bcm43xx_find_lopair()
 
  Those are well known and do not affect this problem.
 
   Moreover after the first oops I have a second oops (Surelly a
   consequence of the first).
 
  I think that is right.
 
  Unfortunately, I cannot test for this problem on my system as it
  doesn't suspend at all.
 
  Does this oops happen every time, or is it intermittent? I'm looking
  at the code to find places to
  insert debugging statements. At present, I don't understand how it
  gets to the shutdown code while
  resuming!
  Perhaps because syslog log it after resume...
  I will investigate this evening
 
 Her the crash scenario:
 o suspend to disk (s2disk)
 o down the wifi card
 o oopps all the time
 Therefore it llok like a bad reinitialisation...

Does it help to down the wifi card before the s2disk?

Larry
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Re: Bcm43xx oops after suspend to disk

2007-01-26 Thread Larry Finger 
roucaries bastien wrote:
 On 1/26/07, Larry Finger [EMAIL PROTECTED] wrote:

 Does it help to down the wifi card before the s2disk?
 
 Yes no oops but I can't associate to the network after suspend. But at
 least no oops.

Did you use an ifup after resuming?

Please send me the log information that comes from the ifdown, s2disk, resume, 
ifup sequence.

Thanks,

Larry

___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev