[tim-janik/beast] Remove Rapicorn requirement from README.md (#71)

2018-08-28 Thread Nil Geisweiller via beast

You can view, comment on, or merge this pull request online at:

  https://github.com/tim-janik/beast/pull/71

-- Commit Summary --

  * Remove Rapicorn requirement from README.md

-- File Changes --

M README.md (9)

-- Patch Links --

https://github.com/tim-janik/beast/pull/71.patch
https://github.com/tim-janik/beast/pull/71.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tim-janik/beast/pull/71
___
beast mailing list
beast@gnome.org
https://mail.gnome.org/mailman/listinfo/beast


[tim-janik/beast] a metronome would be very helpful (#70)

2018-08-28 Thread Reaper10 via beast
you could use
http://das.nasophon.de/gtklick/
http://das.nasophon.de/klick/
https://github.com/dsacre/gtklick
https://github.com/dsacre/klick

or
http://quitte.de/dsp/caps.html#Click


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tim-janik/beast/issues/70___
beast mailing list
beast@gnome.org
https://mail.gnome.org/mailman/listinfo/beast


Re: [tim-janik/beast] Port Song::loop_right, Song::tick_pointer (#68)

2018-08-28 Thread Tim Janik via beast
Merged #68 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tim-janik/beast/pull/68#event-1812662311___
beast mailing list
beast@gnome.org
https://mail.gnome.org/mailman/listinfo/beast


Re: [tim-janik/beast] Port Song::loop_right, Song::tick_pointer (#68)

2018-08-28 Thread Tim Janik via beast
tim-janik commented on this pull request.

Thanks a lot, minor comments inline.

> +
+void
+SongImpl::tick_pointer (int tick)
+{
+  BseSong *self = as();
+
+  if (uint (tick) != self->tick_SL)
+{
+  // this property has no undo
+
+  BSE_SEQUENCER_LOCK ();
+  self->tick_SL = tick;
+  for (SfiRing *ring = self->tracks_SL; ring; ring = sfi_ring_walk (ring, 
self->tracks_SL))
+{
+  BseTrack *track = (BseTrack*) ring->data;
+  track->track_done_SL = FALSE;/* let sequencer recheck if 
playing */

While you're at it, the C macros TRUE and FALSE should be converted to C++'s 
true and false.

> @@ -565,7 +565,8 @@ pointer_move (BstTrackRollController *self,
   drag->type != GXK_DRAG_DONE) /* skip release events */
 {
   guint tick = bst_track_roll_controller_quantize (self, 
drag->current_tick);
-  bse_proxy_set (self->song, "tick-pointer", tick, NULL);
+  Bse::SongH song = Bse::SongH::down_cast (bse_server.from_proxy 
(self->song));

It might (soon) be time to convert self->song into a scoped handle. Please keep 
an eye on when it's easier or not too much effort to use a Bse::SongS in the 
track controller and go for it, so we can avoid all those from_proxy down casts.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tim-janik/beast/pull/68#pullrequestreview-150049358___
beast mailing list
beast@gnome.org
https://mail.gnome.org/mailman/listinfo/beast


Re: [tim-janik/beast] Native SpectMorph Support in Beast (#12)

2018-08-28 Thread Stefan Westerfeld via beast
An updated pull request is available: https://github.com/tim-janik/beast/pull/30

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tim-janik/beast/issues/12#issuecomment-416506416___
beast mailing list
beast@gnome.org
https://mail.gnome.org/mailman/listinfo/beast