Re: [Beignet] [PATCH] Fix getting bitwidth of PointerType of LLVM.

[Yang, Rong R]

LGTM, pushed, thanks.

> -Original Message-
> From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
> yan.w...@linux.intel.com
> Sent: Friday, November 18, 2016 15:44
> To: beignet@lists.freedesktop.org
> Cc: Yan Wang 
> Subject: [Beignet] [PATCH] Fix getting bitwidth of PointerType of LLVM.
> 
> From: Yan Wang 
> 
> PointerType could not be forced to IntegerTyoe for getting bitwidth.
> With Rong's comments, use getTypeBitSize() instead of
> Type::getIntegerBitWidth().
> ---
>  backend/src/llvm/llvm_gen_backend.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/backend/src/llvm/llvm_gen_backend.cpp
> b/backend/src/llvm/llvm_gen_backend.cpp
> index 397c721..d6b0665 100644
> --- a/backend/src/llvm/llvm_gen_backend.cpp
> +++ b/backend/src/llvm/llvm_gen_backend.cpp
> @@ -1366,7 +1366,7 @@ namespace gbe
>}
>Builder.SetInsertPoint(cast(theUser));
> 
> -  Type *ptyTy = IntegerType::get(ptr->getContext(), ptr->getType()-
> >getIntegerBitWidth());
> +  Type *ptyTy = IntegerType::get(ptr->getContext(),
> + getTypeBitSize(unit, ptr->getType()));
>Value *v1 = Builder.CreatePtrToInt(pointerOp, ptyTy);
> 
>Value *v2 = 
> Builder.CreatePtrToInt(getSinglePointerOrigin(pointerOp),
> ptyTy);
> --
> 2.7.4
> 
> ___
> Beignet mailing list
> Beignet@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/beignet
___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet

[Beignet] [PATCH] Fix getting bitwidth of PointerType of LLVM.

[yan . wang]

From: Yan Wang 

PointerType could not be forced to IntegerTyoe for getting bitwidth.
With Rong's comments, use getTypeBitSize() instead of
Type::getIntegerBitWidth().
---
 backend/src/llvm/llvm_gen_backend.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/backend/src/llvm/llvm_gen_backend.cpp 
b/backend/src/llvm/llvm_gen_backend.cpp
index 397c721..d6b0665 100644
--- a/backend/src/llvm/llvm_gen_backend.cpp
+++ b/backend/src/llvm/llvm_gen_backend.cpp
@@ -1366,7 +1366,7 @@ namespace gbe
   }
   Builder.SetInsertPoint(cast(theUser));
 
-  Type *ptyTy = IntegerType::get(ptr->getContext(), 
ptr->getType()->getIntegerBitWidth());
+  Type *ptyTy = IntegerType::get(ptr->getContext(), 
getTypeBitSize(unit, ptr->getType()));
   Value *v1 = Builder.CreatePtrToInt(pointerOp, ptyTy);
 
   Value *v2 = 
Builder.CreatePtrToInt(getSinglePointerOrigin(pointerOp), ptyTy);
-- 
2.7.4

___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet